Home GnuPG

const-time: always avoid comparison operator for byte comparison
5e9ba851948fUnpublished

Unpublished Commit · Learn More

Not On Permanent Ref: This commit is not an ancestor of any permanent ref.

Description

const-time: always avoid comparison operator for byte comparison

* configure.ac: Remove POSSIBLE_CONDITIONAL_BRANCH_IN_BYTE_COMPARISON
macro.
* src/const-time.h (ct_not_equal_byte): Remove
POSSIBLE_CONDITIONAL_BRANCH_IN_BYTE_COMPARISON ifdef.

Cherry-pick master commit of:
137e35ad47ee8734d0f3ffb6af1d1669c4621e0b

Performance impact of avoiding comparison is negligible, so
remove the option for using comparison to make this easier
maintain (tested on every arch).

  • Signed-off-by: Jussi Kivilinna <jussi.kivilinna@iki.fi>

Details

Provenance
jukiviliAuthored on Oct 30 2023, 7:17 PM
gniibeCommitted on Nov 6 2023, 2:29 AM
Parents
rC892bc25ff74b: Use single constant-time memory comparison implementation
Branches
Unknown
Tags
Unknown

Event Timeline