Diffusion GnuPG 01fa318be0f8

scd: Fix how scdaemon pipe server finishes.
Audited01fa318be0f8
Actions

Tags

None

Subscribers

Description

scd: Fix how scdaemon pipe server finishes.

* scd/scdaemon.h (scd_command_handler): Fix the return type.
* scd/command.c (scd_command_handler): Not return a value.
* scd/scdaemon.c (pipe_server): Make it auto variable in main.
(main): Use auto PIPE_SERVER variable.
(start_connection_thread): When it's a pipe connection and it
finishes, let the service shutdown.

GnuPG-bug-id: T7151
Signed-off-by: NIIBE Yutaka <gniibe@fsij.org>

Details

Auditors

Provenance

Authored on Mon, Jun 17, 4:44 AM

Parents

rGc4e6b6aba2c9: m4: Update m4 files.

Branches

Unknown

Tags

Unknown

Tasks

T7151: graceful shutdown: DEVINFO should be a gpg-agent command: also watching input close

Event Timeline

• gniibe committed rG01fa318be0f8: scd: Fix how scdaemon pipe server finishes. (authored by • gniibe).Mon, Jun 17, 4:44 AM

• gniibe added a task: T7151: graceful shutdown: DEVINFO should be a gpg-agent command: also watching input close.Mon, Jun 17, 4:54 AM

• werner raised a concern with this commit.Mon, Jun 17, 8:53 AM

• werner added a subscriber: • werner.

• werner added inline comments.

/scd/scdaemon.c
1219–1224	Seems that the command handler invocation was accidentally removed.

This commit now has outstanding concerns.Mon, Jun 17, 8:53 AM

• gniibe marked an inline comment as done.Mon, Jun 17, 10:11 AM

• gniibe added inline comments.

/scd/scdaemon.c
1219–1224	Indeed. I'll fix it soon.

• werner accepted this commit.Mon, Jun 24, 9:03 AM

All concerns with this commit have now been addressed.Mon, Jun 24, 9:03 AM

Changes (3)

Path

Size

scd/

rG01fa318be0f8

scd/command.c

Loading...

scd/scdaemon.c

Loading...

scd/scdaemon.h

Loading...