Diffusion GnuPG 5c557a51cdf3

Issue 1447: Pass proper Host header and SNI when SRV is used with curl.
5c557a51cdf3Unpublished
Actions

Tags

None

Subscribers

None

Unpublished Commit · Learn More

Not On Permanent Ref: This commit is not an ancestor of any permanent ref.

Description

Issue 1447: Pass proper Host header and SNI when SRV is used with curl.

* configure.ac: Check for inet_ntop.
* m4/libcurl.m4: Provide a #define for the version of the curl
  library.
* keyserver/gpgkeys_hkp.c (main, srv_replace): Call getaddrinfo() on
  each target.  Once we find one that resolves to an address (whether
  IPv4 or IPv6), pass it into libcurl via CURLOPT_RESOLVE using the
  SRV name as the "host".  Force the HTTP Host header to be the same.

Backported from 6b1f71055ebab36989e2089cfde319d2ba40ada7

keyserver/gpgkeys_hkp.c (main): Only default try-dns-srv to on if we have SRV support in the first place.

Backported from 732f3d1d4786239db5f31f82cc04ec79326cc13c

Details

Provenance

Authored on Dec 19 2012, 7:54 PM

Parents

rG6c3a76cca064: Part of issue 1447: Pass proper Host header when SRV is used.

Branches

Unknown

Tags

Unknown

Event Timeline

David Shaw <dshaw@jabberwocky.com> committed rG5c557a51cdf3: Issue 1447: Pass proper Host header and SNI when SRV is used with curl. (authored by David Shaw <dshaw@jabberwocky.com>).Dec 19 2012, 7:54 PM

• werner mentioned this in Unknown Object (Maniphest Task).Mar 27 2017, 5:06 PM

• werner mentioned this in Unknown Object (Maniphest Task).Mar 27 2017, 5:29 PM

• werner mentioned this in T1447: TLS hostname selection uses insecure SRV data.Mar 30 2017, 7:14 PM

Changes (3)

Path

Size

keyserver/

m4/

rG5c557a51cdf3

configure.ac

Loading...

keyserver/gpgkeys_hkp.c

Loading...

m4/libcurl.m4

Loading...