Home GnuPG
Diffusion GnuPG 70c49ce02401

gpg: Fix modifying signature data by pk_verify for Ed25519.
70c49ce02401Unpublished
Actions

Unpublished Commit · Learn More

Not On Permanent Ref: This commit is not an ancestor of any permanent ref.

Description

gpg: Fix modifying signature data by pk_verify for Ed25519.

* g10/pkglue.c (pk_verify): When fixing R and S, make sure those are
copies.

Fixing-commit: 0a5a854510fda6e6990938a3fca424df868fe676

  • GnuPG-bug-id: T7426
  • Signed-off-by: NIIBE Yutaka <gniibe@fsij.org>

Details

Provenance
• gniibeAuthored on Nov 25 2024, 6:39 AM
Parents
rGbb6b38c24010: gpg: Fix comparing ed448 vs ed25519 with --assert-pubkey-algo.
Branches
Unknown
Tags
Unknown
References
gniibe/t7426

Event Timeline

• gniibe mentioned this in T7426: Retain binary representation of key for import->export (in particular, Ed25519 signature).Nov 25 2024, 7:08 AM
• werner added a subscriber: • werner.Nov 25 2024, 9:15 AM
• werner added inline comments.
/g10/pkglue.c
339

Nipicking: If only one copy fails we won't free the already allocated other one. ERRNO might also not be the correct one if r = ... failed.

360

The R copied about leaks. Same for S a few lines down.

Changes (1)

PathSize
g10/

rG70c49ce02401

View Options

g10/pkglue.c

Loading...