dirmngr: Fix the regression of use of proxy for TLS connection.
848546b05ab0
Actions

Description

dirmngr: Fix the regression of use of proxy for TLS connection.

* dirmngr/http.c (run_proxy_connect): Don't set keep_alive, since it
causes resource leak of FP_WRITE.
Don't try to read response body to fix the hang.

GnuPG-bug-id: T6997
Signed-off-by: NIIBE Yutaka <gniibe@fsij.org>

Details

Provenance

• gniibe

Authored on Feb 16 2024, 3:31 AM

Parents

rG037067853609: speedo: Add config variable for the timestamp service.

Branches

Unknown

Tags

Unknown

Tasks

T6997: gnupg-2.4.4 breaks dirmngr fetching keys via hkps:// from behind a proxy

Event Timeline

• gniibe committed rG848546b05ab0: dirmngr: Fix the regression of use of proxy for TLS connection. (authored by • gniibe).Feb 16 2024, 3:38 AM

• gniibe added a task: T6997: gnupg-2.4.4 breaks dirmngr fetching keys via hkps:// from behind a proxy.

• gniibe mentioned this in T6997: gnupg-2.4.4 breaks dirmngr fetching keys via hkps:// from behind a proxy.Feb 16 2024, 3:40 AM

• werner added a subscriber: • werner.Feb 16 2024, 10:11 AM

• werner added inline comments.

/dirmngr/http.c
2611	Hi! I am wondering why I added this code. It could be just debug code.

• gniibe marked an inline comment as done.Feb 17 2024, 4:05 AM

• gniibe added inline comments.

/dirmngr/http.c
2611	There is a little possibility that this is (actually) needed with an implementation of proxy. Please test with a proxy in question on Windows.

• werner added inline comments.Feb 21 2024, 3:00 PM

/dirmngr/http.c
2611	Alright. I also looked again into it and it really seems to be debug code. In particular the setting of the up_to_empty_line wouldn't be correct otherwise.

Changes (1)

Path

Size

dirmngr/

http.c

rG848546b05ab0

View Options