core: Do not modify args for ignored failures
7706fa2c922f
Actions

Description

core: Do not modify args for ignored failures

* src/op-support.c (_gpgme_parse_failure): Ignore gpg-exit failures
before modifying args.

For op_decrypt_verify the status handler for both decrypt and
verify would parse the failure when the first parser ignored
the failure. This resulted in an ERR_INV_ENGINE as the first
call to parse_failure modified the args.

GnuPG-Bug-Id: T3919

Details

Provenance

aheinecke

Authored on Apr 20 2018, 2:30 PM

Parents

rM302ec1f9aa39: Post release updates

Branches

Unknown

Tags

Unknown

Tasks

T3919: GPGOL: Could not decrypt the data: Invalid crypto engine

Event Timeline

aheinecke added a task: T3919: GPGOL: Could not decrypt the data: Invalid crypto engine.Apr 20 2018, 2:35 PM

aheinecke committed rM7706fa2c922f: core: Do not modify args for ignored failures (authored by aheinecke).Apr 20 2018, 2:30 PM

The chained status handlers are a problem in general. I will think about a more robust solution for 1.12

BenM mentioned this in T3919: GPGOL: Could not decrypt the data: Invalid crypto engine.May 2 2018, 9:43 PM

Changes (1)

Path

Size

src/

op-support.c

rM7706fa2c922f

View Options