Home GnuPG
Diffusion GpgOL 81c048b716ec

Improve handling for disallowed filenames
81c048b716ec
Actions

Description

Improve handling for disallowed filenames

* src/common.cpp (get_tmp_outfile): Use a generic name after
50 tries.

If we could not create the file after 50 tries, maybe
the filename is invalid. In that case we now use a
generic "attachment" name. That name is visible in
the "Save As" dialog, but in the OOM the name
is set according to the original filename.

Details

Provenance
aheineckeAuthored on Jul 14 2020, 2:48 PM
Parents
rO4db95f1b3934: Put BodyFormat before setting the body
Branches
Unknown
Tags
Unknown
Tasks
T4835: attachement not displayed when pipe in filename of attachement

Event Timeline

aheinecke committed rO81c048b716ec: Improve handling for disallowed filenames (authored by aheinecke).Jul 14 2020, 2:59 PM
aheinecke added a task: T4835: attachement not displayed when pipe in filename of attachement.
timon-michel added a subscriber: timon-michel.Apr 14 2022, 4:32 PM

I've just had an issue probably related to this.
Outlook was showing an error message like the following: "Empty messages cannot be encrypted" (I am translating, so the exact message may differ)

After looking at the logs, GpgOl tried 100 temporary files, failed (because they all existed, no idea why), and showed this message.

After deleting the files it worked, but the error message was misleading.

Maybe you can make use of this information :)

Changes (1)

PathSize
src/

rO81c048b716ec

View Options

src/common.cpp

Loading...