Home GnuPG

Respect SYSROOT variable when looking for assuan
Concern Raised8d73d2a55a00Unpublished

Unpublished Commit · Learn More

Not On Permanent Ref: This commit is not an ancestor of any permanent ref.

Description

Respect SYSROOT variable when looking for assuan

* m4/libassuan.m4: Respect SYSROOT Variable.

This change makes the libassuan lookup work similar
to the libgpg-error lookup simplifying cross-compiling
a bit.

Details

Auditors
jharvell
werner
Provenance
aheineckeAuthored on Aug 18 2015, 7:47 PM
Parents
rP78afb80e5742: Fix pinentry for Windows
Branches
Unknown
Tags
Unknown

Event Timeline

jharvell raised a concern with this commit.EditedApr 27 2018, 7:02 PM
jharvell added a subscriber: jharvell.

Why are you looking in ${SYSROOT}/bin and not ${SYSROOT}/usr/bin? I am not sure libassuan-config is installed in different directories for different OS distros. But on my distro it is installed in /usr/bin. Has it moved from /bin to /usr/bin? When cross-compiling for ARM, the check on line 30 does not find it in sysroot and the result is it uses the host libassuan-config. See https://bugs.gentoo.org/653938

I filed a bug report for pinentry: https://dev.gnupg.org/T3949

This commit now has outstanding concerns.Apr 27 2018, 7:02 PM
werner added a subscriber: werner.

Please don't apply this, SYSROOT is not a well defined feature and it needs to be implemented everywhere in the same way.

@jharvell: The difference between /usr/bin and /bin on common Unices are hard to handes. That is why a SYSROOT shall have only one set of sub-directories (bin/, lib/, include/ etc). And yes, the foo-config scripts are platform specific.

@werner I'm afraid you are too late. Looks like this was merged into master about three years ago. I probably should not have commented on a commit that was merged so long ago :)

As to your comment below...

That is why a SYSROOT shall have only one set of sub-directories (bin/, lib/, include/ etc).

Since you use the term "shall", is there a standard somewhere that distros are moving to that requires only one set of subdirs?