Differential D440

gtk: Disable tooltips in keyboard-grabbing mode.
AbandonedPublic
Actions

Authored by • werner on Jul 24 2017, 5:40 PM.

Tags

None

Subscribers

None

Details

Reviewers

Commits

rKLEOPATRA5e9d402be380: Yet another place with deprecated API

Summary

gtk+-2/pinentry-gtk-2.c (show_hide_button_toggled): Do not show the

tooltip if we attempt to grab the keyboard.

(create_window): Likewise.

For unclear reasons, those tooltips may interfere with grabbing
under some tiling window managers.

GnuPG-bug-id: 3297
Signed-off-by: Damien Goutte-Gattat <dgouttegattat@incenp.org>

Test Plan

Run pinentry-gtk-2 under a tiling window manager (e.g. Awesome) and issue a 'GETPIN' command. Check that tooltips do not appear and that pinentry can grab the keyboard without having to try more than 4000 times.
Redo with --no-global-grab. Check that tooltips do appear.

Diff Detail

Repository

Branch

priv/gtk-grabbing-issue

Lint

No Linters Available

Unit

No Unit Test Coverage

Event Timeline

gouttegd created this revision.Jul 24 2017, 5:40 PM

• werner accepted this revision.Jul 25 2017, 6:40 PM

This revision is now accepted and ready to land.Jul 25 2017, 6:40 PM

Leave the tooltips in place but show them only if do not have to grab the keyboard. As suggested in the discussion in T3279.

Feel free to push it to the main repo at git.gnupg.org (similar to scrute). I granted you the required rights.

• werner commandeered this revision.Dec 7 2017, 6:28 PM

• werner edited reviewers, added: gouttegd; removed: • werner.

This revision now requires review to proceed.Dec 7 2017, 6:28 PM

• werner abandoned this revision.Dec 7 2017, 6:28 PM

• Fred23 added a commit: rKLEOPATRA5e9d402be380: Yet another place with deprecated API.Jun 20 2021, 6:09 PM

Revision Contents
Changeset List

Path

Size

gtk+-2/

pinentry-gtk-2.c

13 lines

Diff 1293

gtk+-2/pinentry-gtk-2.c

Loading...