Add ctx flag for auto-key-locate
ClosedPublic
Actions

Authored by • aheinecke on Jul 3 2018, 6:02 PM.

Details

Reviewers

• werner

Maniphest Tasks

Commits

rM7bc5d3c7e41c: Add ctx flag for auto-key-locate

Summary

(gpg_set_engine_flags, build_argv): Handle auto_key_locate.

(gpgme_get_ctx_flag, gpgme_set_ctx_flag): Handle auto-key-locate.

This enables users of GPGME to control more fine grained what
auto-key-locate does. Especially for WKD lookups / refreshes
can this be useful.

GnuPG-Bug-Id: T2917

Test Plan

Tested with the run tool

Repository

rM GPGME

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

I find this better then a new "KEYLIST_MODE_WKD" as it is more flexible and this flexibility with context flags is currently our thing anyway.

Use cases are:

Updating a key from WKD
Checking for an existing key if it is also available from WKD
Showing which keys are in the WKD for a users mail address (e.g. in case a new one is generated).

So I think that I need this.

• werner added inline comments.

src/engine-gpg.c
672	if you really want the check for a gpg version, I would use 2.1.18 instead. Instead of allocating a 100 byte array it is easier to free (gpg->auto_key_locate); gpg->auto_key_locate = _gpgme_strconcat ("--auto-key-locate=", ctx->auto_key_locate); and release that in gpg_release. Adding the option to the command line will also be easier.