Page MenuHome GnuPG
Differential D512

Adds Microsoft Edge (Chromium) browser support
AbandonedPublic
Actions

Authored by • aheinecke on Dec 1 2020, 10:45 PM.

Details

Reviewers
pedrolamas
Commits
rKLEOPATRA5e9d402be380: Yet another place with deprecated API
Summary

The inst-gpgme-browser.nsi is only targeting Google Chrome and Mozilla Firefox, this adds support for Microsoft Edge (Chromium).

It's a copy of the Google Chrome settings, but with the extension id changed to match the Mailvelope extension in Microsoft Store: https://microsoftedge.microsoft.com/addons/detail/mailvelope/dgcbddhdhjppfdfjpciagmmibadmoapc

Test Plan
  • Install Mailvelope extension on Microsoft Edge using the link above (or search on Microsoft Store)
  • Observe that extension now works

Diff Detail

Repository
rW Gpg4win
Lint
Lint Skipped
Unit
Unit Tests Skipped

Event Timeline

pedrolamas created this revision.Dec 1 2020, 10:45 PM
• werner added a reviewer: • aheinecke.Dec 2 2020, 9:07 AM
• aheinecke mentioned this in rWcd260e73e667: Add edge support for gpgme-browser.Dec 2 2020, 11:41 AM
• aheinecke accepted this revision.Dec 2 2020, 11:45 AM

Oh! Very Nice! Thanks for this. I've commited it with adding the uninstall parts.

I sent a short mail to the mailvelope developers to confirm with them that the Addon ID really is the official one.

This revision is now accepted and ready to land.Dec 2 2020, 11:45 AM
• aheinecke added a comment.Dec 3 2020, 8:47 AM

For the record, Thomas from mailvelope confirmed by signed mail that this is the correct id.

• aheinecke commandeered this revision.Jan 26 2021, 11:53 AM
• aheinecke edited reviewers, added: pedrolamas; removed: • aheinecke.
This revision now requires review to proceed.Jan 26 2021, 11:53 AM
• aheinecke abandoned this revision.Jan 26 2021, 11:53 AM

This has been added and released with Gpg4win-3.1.15

• Fred23 added a commit: rKLEOPATRA5e9d402be380: Yet another place with deprecated API.Jun 20 2021, 6:09 PM
• canti59 added a commit: rG8046fcac63db: po: Update Czech translation..Oct 14 2022, 2:11 AM
• gniibe removed a commit: rG8046fcac63db: po: Update Czech translation..Oct 14 2022, 2:50 AM

Revision Contents
Changeset List

PathSize
src/
16 lines

Diff 1444

View Options

src/inst-gpgme-browser.nsi

Loading...