Differential D618

Allow passing flags to DeleteJob
Needs ReviewPublic
Actions

Authored by • TobiasFella on Thu, Nov 13, 12:52 PM.

Details

Reviewers

• ikloecker

Summary

for T7538

requires https://dev.gnupg.org/D617

Test Plan

test with corresponding kleopatra and gpgmepp patches

Diff Detail

Repository

rGPGMEQT Gpgme for Qt

Lint

Lint Skipped

Unit

Unit Tests Skipped

Event Timeline

@ikloecker would there be any ABI problems with adding the new virtual function here?

• TobiasFella edited the summary of this revision. (Show Details)Thu, Nov 13, 12:53 PM

In D618#6745, @TobiasFella wrote:

@ikloecker would there be any ABI problems with adding the new virtual function here?

Instead of adding new virtuals I have added non-virtual functions that call virtual private functions (NVI pattern). Job has a proper d-pointer since QGpgME 2.0 so this is the way you should go, i.e. add a DeleteJobPrivate. There are plenty of *JobPrivate classes to c&p from.

In D618#6752, @ikloecker wrote:

In D618#6745, @TobiasFella wrote:

@ikloecker would there be any ABI problems with adding the new virtual function here?

Instead of adding new virtuals I have added non-virtual functions that call virtual private functions (NVI pattern). Job has a proper d-pointer since QGpgME 2.0 so this is the way you should go, i.e. add a DeleteJobPrivate. There are plenty of *JobPrivate classes to c&p from.

aah, thanks for the pointer!

I think you are using an outdated working copy of gpgmeqt. I have killed the old jobPrivate stuff with rGPGMEQT056567525fb9: Add d-pointer to Job class. We are using Qt macros now.