Maniphest T4369

Segfault caused by incorrect _gpgme_strconcat() usage
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	egorpugin
	Feb 19 2019, 9:50 AM

Tags

Subscribers

Description

See
https://dev.gnupg.org/source/gpgme/browse/master/src/w32-util.c;f8312d7c333193582dcb5816198219b9564023f0$604

There must be last NULL argument in _gpgme_strconcat() call.

Revisions and Commits

rM GPGME
	rM4c49417cc0db core,w32: Fix missing sentinel in dir name builder.

Related Objects
Search...

		Status	Assigned	Task
		Resolved	aheinecke	T4331 Stack Buffer overflow in ``` parse_array (cJSON * item, const char value, const char *ep)``` if we send a prepared JSON file
		Resolved	• werner	T4376 Release gpgme 1.13.0
		Resolved	• werner	T4369 Segfault caused by incorrect _gpgme_strconcat() usage
		Resolved	aheinecke	T4264 Gpg4win 3.1.6
		Resolved	• werner	T4289 GnuPG 2.1.12 release

Event Timeline

egorpugin created this task.Feb 19 2019, 9:50 AM

egorpugin created this object in space S1 Public.

Aiiih, what happend to the sentinel attribute? I need to check.

• werner claimed this task.Feb 19 2019, 11:42 AM

Ah okay, that was Windows were we have a couple of warnings anyway. Must have missed that one.

• werner added a commit: rM4c49417cc0db: core,w32: Fix missing sentinel in dir name builder..Feb 19 2019, 12:15 PM

Fixed. Needs to go into the next gpg4win release.

yikes. Sorry for that one,..

aheinecke added a subtask: T4264: Gpg4win 3.1.6.Feb 21 2019, 11:37 AM

Thank you!

Should I mark the issue as resolved? Or will you do it?

Will be released with 1.12.1

• werner mentioned this in T4376: Release gpgme 1.13.0.Mar 26 2019, 5:28 PM

aheinecke closed subtask T4264: Gpg4win 3.1.6 as Resolved.Mar 27 2019, 1:54 PM