Maniphest T5535

Kleopatra: Check that accessibility is also supported for VS-NfD
Closed, ResolvedPublic
Actions

Assigned To
• aheinecke
Authored By
• aheinecke
Jul 29 2021, 11:09 AM
Tags
Subscribers
• aheinecke
• ikloecker
• werner

Description

Back in 2014 we had a project to ensure that accessibility is supported in our software. Mostly it worked the goal was that NVDA https://www.nvaccess.org/ which is seemingly the most important software for that could read the pinentry fields etc. For that we had to ship a Qt plugin and set some "Buddy" rules. The Buddy rules are mostly that a line edit is directly associated with a label.

We now have to check that:

  1. We still ship the plugins and it works
  2. That our "This is VS-NfD compliant is correctly associated with the button

At least for the second point I do not think that we have done this.

Revisions and Commits

rLIBKLEO Libkleo
rLIBKLEOe8fb46f9a46e Add workaround for broken tab order of dialog buttons
rLIBKLEO1792abbe0ce4 Make the Close button the default button of the dialog
rLIBKLEO8ab5857cc518 Set tooltip of push button and line edit
rKLEOPATRA Kleopatra
rKLEOPATRA69aa9861643c Improve accessibility of decryption result overview and details
rKLEOPATRA2ac361b46f13 Allow setting the color of the rendered link
rKLEOPATRA3464ec148c3e Ensure correct focus order of the result item widgets
rKLEOPATRAfb35f8a7d4b0 Ensure that the link is readable even on the blue "success" background
rKLEOPATRA49cd0070652f Create scroll area together with the other child widgets
rKLEOPATRAcbbcbbfb6861 Show information about recipients also if decryption didn't succeed
rKLEOPATRAd0d25f717d5c Exit early if decryption failed or was canceled
rKLEOPATRAcefdbaaeee23 Improve accessibility if no or multiple certificates match
rKLEOPATRA6c3c904a9b40 Show more decryption details if decryption was successful
rKLEOPATRAd031959ef156 Move "No MDC" hint before information on recipients
rKLEOPATRAeaae2c4754fd Improve accessibility of Diagnostics/Show Audit Log label
rKLEOPATRA785049dc0827 Disable the hidden Close button to prevent problem with screen reader
rKLEOPATRAd6582a49c422 Do not show "opaque signature" warning if just one file is to be signed
rKLEOPATRA4aacd973a86c Set VS-NfD compliance hint also as tooltip of the commit button
rKLEOPATRAc7755bcbdafc Ensure correct tab order in VS-NfD compliant mode
rKLEOPATRAb2e7699ac08c Update the commit button only if the corresponding wizard page is shown
rKLEOPATRAe54ed5081272 Modernize code
rKLEOPATRA2c00747e99e4 Disable sign option and encrypt options if needed keys are not available
rKLEOPATRA4479581deb12 Do not crash if there are no keys in the keyring
rKLEOPATRAf45b63d331b7 Simplify code checking for OpenPGP and/or S/MIME encryption
rKLEOPATRA93d3c3789f1a Sort the enum values in the desired GUI order
rKLEOPATRA9f0ec8e0b3bc Add wrapper widget for a FileNameRequester with icon
rKLEOPATRAa89f74471d70 Move output files/folders before "Encrypt/Sign ... separately" option
rKLEOPATRA300719d3ec9a Move focus to next (or previous) recipient field when removing one
rKLEOPATRAa8bedd58865c Add/improve/fix context of a few translated strings
rKLEOPATRA1d1c4df33d62 Ensure correct tab order of the recipient widgets
rKLEOPATRAb9a9ae106b6c Do not add recipient field unconditionally when editing another started
rKLEOPATRAb2817adf528c Ensure correct setup of UI for default protocol
rKLEOPATRAa85ea08abb5f Simplify layout handling of recipient widgets
rKLEOPATRA1ee45a58d278 Minor cleanup
rKLEOPATRA06b03e9b0524 Take the scroll area out of the tab order

Related Objects
Search...

Event Timeline

• aheinecke triaged this task as High priority.Jul 29 2021, 11:09 AM
• aheinecke created this task.
• aheinecke assigned this task to • ikloecker.EditedAug 4 2021, 3:16 PM
• aheinecke added subtasks: T5545: Kleopatra: Select symmetric encryption by default if keyring is empty, T5544: Kleopatra: Ensure that file encryption dialogs has shortcuts on all actions, T5543: pinentry-qt: Accessibility switch to repeat on enter.

Ingo, I have tested this on Windows with NV Access and was able to symmetrically encrypt and decrypt a file with closed eyes. I went through the windows explorer context menu to select sign & encrypt on selected files.
Can you also do some more tests on Linux ( I do not know how to properly enable a screenreader there ) and if you find anything ugly fix it.

The main goal is symmetric encryption and decryption but I think our personal goal should be that Kleo has good accessibility overall.

• ikloecker changed the status of subtask T5543: pinentry-qt: Accessibility switch to repeat on enter from Open to Testing.Aug 16 2021, 10:58 AM
• ikloecker changed the status of subtask T5545: Kleopatra: Select symmetric encryption by default if keyring is empty from Open to Testing.Aug 16 2021, 3:52 PM
• ikloecker moved this task from Restricted Project Column to Restricted Project Column on the Restricted Project board.Aug 18 2021, 4:52 PM
• ikloecker added a commit: rLIBKLEO8ab5857cc518: Set tooltip of push button and line edit.Aug 19 2021, 1:03 PM
• ikloecker added a commit: rKLEOPATRA1ee45a58d278: Minor cleanup.
• ikloecker added a commit: rKLEOPATRAb2817adf528c: Ensure correct setup of UI for default protocol.
• ikloecker added a commit: rKLEOPATRA06b03e9b0524: Take the scroll area out of the tab order.
• ikloecker added a commit: rKLEOPATRAa85ea08abb5f: Simplify layout handling of recipient widgets.
• ikloecker added a commit: rKLEOPATRA1d1c4df33d62: Ensure correct tab order of the recipient widgets.
• ikloecker added a commit: rKLEOPATRAb9a9ae106b6c: Do not add recipient field unconditionally when editing another started.
• ikloecker added a commit: rKLEOPATRAa8bedd58865c: Add/improve/fix context of a few translated strings.
• ikloecker added a commit: rKLEOPATRA300719d3ec9a: Move focus to next (or previous) recipient field when removing one.
• ikloecker added a commit: rKLEOPATRAa89f74471d70: Move output files/folders before "Encrypt/Sign ... separately" option.
• ikloecker added a commit: rKLEOPATRAf45b63d331b7: Simplify code checking for OpenPGP and/or S/MIME encryption.
• ikloecker added a commit: rKLEOPATRA93d3c3789f1a: Sort the enum values in the desired GUI order.
• ikloecker added a commit: rKLEOPATRA9f0ec8e0b3bc: Add wrapper widget for a FileNameRequester with icon.
• ikloecker changed the status of subtask T5544: Kleopatra: Ensure that file encryption dialogs has shortcuts on all actions from Open to Testing.Aug 19 2021, 4:05 PM
• ikloecker added a commit: rKLEOPATRA4479581deb12: Do not crash if there are no keys in the keyring.Aug 19 2021, 5:38 PM
• ikloecker added a commit: rKLEOPATRA2c00747e99e4: Disable sign option and encrypt options if needed keys are not available.Aug 23 2021, 11:24 AM
• ikloecker added a commit: rKLEOPATRA4aacd973a86c: Set VS-NfD compliance hint also as tooltip of the commit button.Aug 23 2021, 5:08 PM
• ikloecker added a commit: rKLEOPATRAc7755bcbdafc: Ensure correct tab order in VS-NfD compliant mode.
• ikloecker added a commit: rKLEOPATRAb2e7699ac08c: Update the commit button only if the corresponding wizard page is shown.
• ikloecker added a commit: rKLEOPATRAe54ed5081272: Modernize code.
• ikloecker added a commit: rKLEOPATRAd6582a49c422: Do not show "opaque signature" warning if just one file is to be signed.
• ikloecker added a commit: rKLEOPATRA785049dc0827: Disable the hidden Close button to prevent problem with screen reader.Aug 25 2021, 12:27 PM
• ikloecker added a commit: rLIBKLEOe8fb46f9a46e: Add workaround for broken tab order of dialog buttons.Aug 26 2021, 4:49 PM
• ikloecker added a commit: rLIBKLEO1792abbe0ce4: Make the Close button the default button of the dialog.
• ikloecker added a commit: rKLEOPATRAeaae2c4754fd: Improve accessibility of Diagnostics/Show Audit Log label.Sep 2 2021, 12:11 AM
• ikloecker added a commit: rKLEOPATRA6c3c904a9b40: Show more decryption details if decryption was successful.Sep 3 2021, 4:39 PM
• ikloecker added a commit: rKLEOPATRAcefdbaaeee23: Improve accessibility if no or multiple certificates match.
• ikloecker added a commit: rKLEOPATRAd031959ef156: Move "No MDC" hint before information on recipients.
• ikloecker added a commit: rKLEOPATRAd0d25f717d5c: Exit early if decryption failed or was canceled.
• ikloecker added a commit: rKLEOPATRAcbbcbbfb6861: Show information about recipients also if decryption didn't succeed.
• ikloecker added a commit: rKLEOPATRA49cd0070652f: Create scroll area together with the other child widgets.
• ikloecker added a commit: rKLEOPATRA3464ec148c3e: Ensure correct focus order of the result item widgets.
• ikloecker added a commit: rKLEOPATRA2ac361b46f13: Allow setting the color of the rendered link.
• ikloecker added a commit: rKLEOPATRAfb35f8a7d4b0: Ensure that the link is readable even on the blue "success" background.
• ikloecker added a commit: rKLEOPATRA69aa9861643c: Improve accessibility of decryption result overview and details.Sep 6 2021, 6:56 PM
• ikloecker changed the task status from Open to Testing.Sep 8 2021, 10:52 AM
• ikloecker reassigned this task from • ikloecker to • aheinecke.
• ikloecker moved this task from Restricted Project Column to Restricted Project Column on the Restricted Project board.

Finishing development for now.

• ikloecker closed subtask T5545: Kleopatra: Select symmetric encryption by default if keyring is empty as Resolved.Oct 20 2021, 4:34 PM
• ikloecker moved this task from Restricted Project Column to Restricted Project Column on the Restricted Project board.Oct 25 2021, 11:43 AM
• werner closed this task as Resolved.Nov 6 2021, 4:40 PM
• werner added a subscriber: • werner.

I think we can close this. In January we will have an external audit (BITV) which hopefully will confirm our tests. They auditor will also provide a list of things to improve (if any).

• werner closed subtask T5544: Kleopatra: Ensure that file encryption dialogs has shortcuts on all actions as Resolved.Nov 6 2021, 4:42 PM
• aheinecke mentioned this in T5824: Kleopatra: Full accessibility support.Feb 10 2022, 1:58 PM
• ebo closed subtask T5543: pinentry-qt: Accessibility switch to repeat on enter as Resolved.Mar 21 2023, 3:01 PM
• ebo moved this task from Restricted Project Column to Restricted Project Column on the Restricted Project board.Apr 5 2023, 2:07 PM