Page MenuHome GnuPG
Create Task
Maniphest T6155

Kleopatra: Certify expired userids offered but leads to General Error
Closed, ResolvedPublic
Actions

Description

When selecting certify on an expired key I then get an error. Kleopatra should not even offer this action.

Revisions and Commits

rKLEOPATRA Kleopatra
rKLEOPATRA4e596c03813b Require a valid key for the Certify command
rKLEOPATRAa0f79d1f10ad Add possibility to require valid keys for a command
rKLEOPATRA6c387232bdfc Don't ask user to certify an imported expired or revoked OpenPGP key
rKLEOPATRAc72081d7f427 Disable Certify action if key cannot be certified
rKLEOPATRA1545acf09493 Add helper to check if a key can be certified
rKLEOPATRA82d513813124 Short-circuit check for revoked or expired user ID
rKLEOPATRA7ceef3e16d64 Do not offer expired user ID for certification
rKLEOPATRA39d9c325c50f Refuse to certify revoked or expired keys
rM GPGME
rMeedaaf70167f cpp: Reject signing expired keys

Related Objects

Event Timeline

aheinecke triaged this task as Normal priority.Aug 24 2022, 11:36 AM
aheinecke created this task.
ikloecker added a commit: rKLEOPATRA39d9c325c50f: Refuse to certify revoked or expired keys.Sep 14 2022, 12:40 PM
ikloecker added a commit: rKLEOPATRA7ceef3e16d64: Do not offer expired user ID for certification.
ikloecker added a commit: rMeedaaf70167f: cpp: Reject signing expired keys.Sep 14 2022, 12:48 PM
ikloecker moved this task from Restricted Project Column to Restricted Project Column on the Restricted Project board.Sep 15 2022, 9:40 AM
ikloecker added a commit: rKLEOPATRA82d513813124: Short-circuit check for revoked or expired user ID.Sep 15 2022, 10:52 AM
ikloecker added a commit: rKLEOPATRA1545acf09493: Add helper to check if a key can be certified.
ikloecker added a commit: rKLEOPATRA6c387232bdfc: Don't ask user to certify an imported expired or revoked OpenPGP key.
ikloecker added a commit: rKLEOPATRAc72081d7f427: Disable Certify action if key cannot be certified.
ikloecker claimed this task.Sep 15 2022, 10:53 AM
ikloecker added a commit: rKLEOPATRA4e596c03813b: Require a valid key for the Certify command.Sep 15 2022, 11:19 AM
ikloecker added a commit: rKLEOPATRAa0f79d1f10ad: Add possibility to require valid keys for a command.
ikloecker added a comment.Sep 15 2022, 11:21 AM

The Certify action is now disabled everywhere for revoked and expired keys, i.e. in the main menu and the certificate list context menu, in the Certficate Details dialog, and in the Certifications dialog. Moreover, after importing a revoked or expired public OpenPGP key, the user isn't asked anymore whether they want to certify it.

ikloecker changed the task status from Open to Testing.Sep 15 2022, 11:22 AM
ikloecker removed ikloecker as the assignee of this task.
ikloecker moved this task from Restricted Project Column to Restricted Project Column on the Restricted Project board.
ikloecker added a project: Restricted Project.
ikloecker added a subscriber: ikloecker.
• werner removed a project: Restricted Project.Sep 22 2022, 10:46 AM
• canti59 added a commit: rG8046fcac63db: po: Update Czech translation..Oct 14 2022, 2:10 AM
• gniibe removed a commit: rG8046fcac63db: po: Update Czech translation..Oct 14 2022, 2:50 AM
ikloecker mentioned this in T6305: Kleopatra: General error when trying to certify key and key is expired or password prompt is canceled.Dec 8 2022, 1:22 PM
• ebo closed this task as Resolved.Dec 13 2022, 2:49 PM
• ebo claimed this task.
• ebo added a subscriber: • ebo.

works

• werner mentioned this in T6341: Release GPGME 1.19.0.Mar 17 2023, 12:23 PM
• ebo moved this task from Restricted Project Column to Restricted Project Column on the Restricted Project board.Apr 5 2023, 2:51 PM