Page MenuHome GnuPG
Create Task
Maniphest T6493

Kleopatra: Add feedback in search window
Testing, HighPublic
Actions

Description

The "Lookup on server" window needs some improvements.

I suggest some progress indication (sometimes the search takes so long that you think Kleopatra maybe hangs) and information where it searches/found or not found something. At the moment if no key was found the user wonders if a search took place at all.

For searching I'd suggest something like "searching for/on WKD..." / "searching on $keyserver..."
In case not found: "No key matching the search criteria was found via WKD and keyserver $keyserver"

In case keys were found I'd like to see the the origin of the keys if I have the column "origin" displayed. It would help to choose if multiple candidates were found.
(The above was split off to T7067)

Additionally I'd like some hint for the uninitiated what "x certificates without name and mail address where ignored" means resp. where information regarding this message can be found. Maybe a tooltip?

Revisions and Commits

rKLEOPATRA Kleopatra
rKLEOPATRAc65a3a03dd77 Show "No certificates found" overlay if nothing was found
rKLEOPATRA4b7a5ab88b27 Add widget for showing a text overlay on top of another widget
rKLEOPATRAf31846d8085d Factor the generic overlay handling out of ProgressOverlay
rKLEOPATRAfbad2f3f8521 Cancel lookup when user cancels progress dialog
rKLEOPATRAcdf162baa1ee Remove message about ignored certificates without user IDs
rKLEOPATRA4fb528c76d55 Show a simple progress dialog while searching for certificates
rKLEOPATRA16f6e0c22b67 Don't show an error message if nothing is found on OpenPGP key server

Related Objects
Search...

Event Timeline

• ebo created this task.May 17 2023, 11:57 AM
aheinecke triaged this task as Wishlist priority.Jun 1 2023, 11:18 AM
aheinecke added a subscriber: aheinecke.

I agree, but can't give this priority because it is more work then it sounds since we need to start from the bottom with dirmngr feedback and then pass this all the way through our layers to kleo.

• ebo added a subscriber: ikloecker.Sep 25 2023, 11:31 AM
• ebo mentioned this in T6708: Allow to inhibit the use of a default PGP keyserver.Sep 25 2023, 1:18 PM
• ebo mentioned this in T6202: Kleopatra: Suppress errors of WKD lookups.Sep 29 2023, 1:54 PM
• ebo mentioned this in T5903: Kleopatra: Add refresh button in certificatedetails .Sep 29 2023, 2:20 PM
• ebo mentioned this in T6761: Kleopatra: Handle special keyserver value "none".Oct 16 2023, 3:02 PM
ikloecker changed the status of subtask T6868: Kleopatra: Allow search of WKD in case of keyserver none from Open to Testing.Dec 8 2023, 11:21 AM
• ebo merged a task: T6664: Kleopatra: Add feedback on search results.Jan 3 2024, 3:03 PM
• ebo renamed this task from Kleopatra: Improvements on search window to Kleopatra: Add feedback in search window.Jan 3 2024, 3:05 PM
• ebo added a parent task: T6935: Kleopatra: Key search related improvements.Jan 12 2024, 12:18 PM
• ebo raised the priority of this task from Wishlist to High.Feb 15 2024, 9:10 AM
• ebo added a project: vsd33.
• ebo mentioned this in T6868: Kleopatra: Allow search of WKD in case of keyserver none.Mar 8 2024, 4:26 PM
ikloecker claimed this task.Mar 19 2024, 11:38 AM
ikloecker moved this task from Restricted Project Column to Restricted Project Column on the Restricted Project board.
ikloecker added a commit: rKLEOPATRA16f6e0c22b67: Don't show an error message if nothing is found on OpenPGP key server.Mar 19 2024, 11:55 AM
ikloecker added a commit: rKLEOPATRA4fb528c76d55: Show a simple progress dialog while searching for certificates.
ikloecker added a comment.Mar 19 2024, 12:10 PM

Changes so far:

  • I have removed the error message that was shown when nothing was found on the OpenPGP key server. We don't show an error for S/MIME or WKD lookup. And I think the error message was just annoying. The user sees whether something was found.
  • Kleopatra now shows a simple progress dialog with the text "Searching for matching certificates ..." and with up to 3 steps (for the up to three lookups). I don't think anybody (except testers) are interested in details where something is looked up.

Open:

  • I'm not convinced that a message like "No certificates were found." is really useful. Now that we have progress the users will see when the lookup is complete. And if no certificates are listed then it should be obvious that nothing was found.
  • I propose to remove the information text "x certificates without name and mail address where ignored". It's confusing and there's nothing the users can do to fix this.
  • I have to check if it's possible to set the origin. gpg sets the origin on import.
ikloecker added a commit: rKLEOPATRAcdf162baa1ee: Remove message about ignored certificates without user IDs.Thu, Mar 21, 9:38 AM
ikloecker added a commit: rKLEOPATRAfbad2f3f8521: Cancel lookup when user cancels progress dialog.
ikloecker added a commit: rKLEOPATRAf31846d8085d: Factor the generic overlay handling out of ProgressOverlay.
ikloecker added a commit: rKLEOPATRA4b7a5ab88b27: Add widget for showing a text overlay on top of another widget.
ikloecker added a commit: rKLEOPATRAc65a3a03dd77: Show "No certificates found" overlay if nothing was found.
ikloecker changed the task status from Open to Testing.Thu, Mar 21, 9:51 AM

More changes:

  • If no certificates are found then an overlay "No certificates found" is shown on top of the certificate list.
  • I have removed the confusing and unhelpful message "x certificates without name and mail address were ignored".

Open:

  • Showing the origin of a search results. I suggest to create a separate ticket for this.
• ebo closed subtask T6868: Kleopatra: Allow search of WKD in case of keyserver none as Resolved.Wed, Mar 27, 2:39 PM
• ebo mentioned this in T7067: Kleopatra: Add origin information in search results.Thu, Mar 28, 2:09 PM
• ebo added a comment.Thu, Mar 28, 2:22 PM

Following your suggestion I have created T7067: Kleopatra: Add origin information in search results for the last open point

• ebo updated the task description. (Show Details)Thu, Mar 28, 2:24 PM