Page MenuHome GnuPG

Pinentry-qt: Add support for external password manager with libsecret
Open, WishlistPublic

Description

From the Mailing list:

  • qt/main.cpp: Pass pinentry info to PinEntryDialog constructor. Set save passphrase checkbox text from pinentry_t->default_pwmngr.
  • qt/pinentrydialog.cpp, qt/pinentrydialog.h: Dialog now accepts pinentry info in the constructor and removed unneeded setter for pinentry info. Add save passphrase checkbox.

This patch adds functionality to save key passphrases with pinentry-qt
that already exists in pinentry-gtk-2.

A "save passphrase" checkbox is shown when libsecret is available,
the external password cache is enabled, and there is valid data in
pinentry_t->keyinfo. When checked, the pinentry info is updated to allow
the underlying implementation in pinentry/pinentry.c and
pinentry/password-cache.c to cache the password using libsecret.

Event Timeline

aheinecke triaged this task as Wishlist priority.Nov 8 2023, 11:18 AM
aheinecke created this task.

I'm not familiar with phabricator software so perhaps there is a better way to attach a diff to this ticket. Here is the diff I created: https://dev.gnupg.org/differential/diff/1543/

Thanks for the reviews. And your beautiful work, by which I also mean the response to the feedback and how you managed to work with phabricator. I will commit the patch on your behalf then later.