Page MenuHome GnuPG

Kleopatra: Improvements to columns in the search window
Closed, ResolvedPublic

Description

This is how the search window looks after first start, the column names are cut of when there are longish names:

And after a search (I added the origin column manually here, because I'm on an older test version without T7155):

You see that the width is still the same.

Edit 2025-01-07:
Resize on very first show (if restoreColumnLayout() returns false). This fixes the initially cut column titles.
And then resize to content when the search results are shown, but also only the very first time (i.e. we'd need to remember the first show).

I'm not sure what is the best approach, one might do something similar to T7227 or T7082.

Edit 2024-08-19 strike through of obsolete suggestions:
And for columns 3 (User-ID/Status) and 5 (Valid until) the tooltip says that those values can not be validated at this point. Therefore I propose to remove those columns from the default columns of the search window.

If both items are not addressed together, please split the ticket.

Details

Version
Gpg4win-4.3.2-beta41

Event Timeline

If this is easy to solve and backport, I would like to have this in the next release, as we did a lot of column related changes in other tables already for that release.

werner triaged this task as Normal priority.Aug 16 2024, 3:03 PM
werner added a project: vsd33.
  • The status column is already removed in the gpg4win branch but not yet in the test version
  • afaik "Valid Until" is actually available for keys coming from WKD
  • For the column widths, we could hide the table until the initial search results come in and then resize to content, or just always resize to content when results come in

afaik "Valid Until" is actually available for keys coming from WKD

you're right. So no columns to remove, as "Status" is gone already.

I would prefer hiding the table until there are results, but that's no strong opinion and only based on visual reasons

I wouldn't hide the table. We don't hide any tables (e.g. also in smart card view) if they are empty. I would resize ones on very first show (if restoreColumnLayout() returns false). This fixes the initially cut column titles. And then I'd resize to content when the search results are shown, but also only the very first time (i.e. we'd need to remember the first show).

TobiasFella moved this task from Restricted Project Column to Restricted Project Column on the Restricted Project board.Aug 20 2024, 10:01 AM
TobiasFella changed the task status from Open to Testing.Aug 26 2024, 11:56 AM

Backported for VSD 3.3

ebo moved this task from Restricted Project Column to Restricted Project Column on the Restricted Project board.Oct 1 2024, 3:55 PM
ebo moved this task from Restricted Project Column to Restricted Project Column on the Restricted Project board.
ebo reopened this task as Open.EditedTue, Jan 7, 10:53 AM
ebo moved this task from Restricted Project Column to Restricted Project Column on the Restricted Project board.

Seems I did not test this sufficiently. This is how the very first Search on a new installation looked with VS-Desktop-3.2.94.474-Beta:

I guess I only looked if the column width is sufficient for the headings, which are ok now.

Should I close this ticket again and make a new one for the width of the result?

Then explicitly for the 2nd part of this ticket mentioned in https://dev.gnupg.org/T7252#190230:

And then I'd resize to content when the search results are shown, but also only the very first time (i.e. we'd need to remember the first show).

ebo moved this task from WiP to Backlog on the vsd33 board.

As discussed offline we continue in this ticket.
Please resize to content when the search results are shown, for the first time only.
Additionally name and emails should have the default column with of the certificate list.

Ok, turns out when testing for the VSD version I first used a search term without result, then closed the window and when I opened it again the columns where not resized any more. Which is basically what was wanted with this ticket that the columns are only resized once. Therefore setting this to resolved again.

ebo edited projects, added vsd33 (vsd-3.3.0); removed vsd33.
ebo moved this task from Restricted Project Column to Restricted Project Column on the Restricted Project board.Mon, Jan 13, 9:24 AM