Page MenuHome GnuPG

Kleopatra: Change filters "All certificates" etc. so that they do not include disabled ones
Testing, NormalPublic

Description

Edited on 2024-09-25 to reflect the result of the discussion

Reasoning:
Extrapolating from some issues and questions, users tend to want to delete old keys if they create a new one. And others requested a feature to disable certificates because they don't want them to clutter up their keyring.
We want to be able to tell users that they should keep their old keys (to decrypt old data) but don't have to see them if they mark them "disabled".

Therefore we need the following changes:

  • The filter "All Certificates" should show all certificates/keys except the disabled ones.
  • All other filters where this applies should be changed accordingly (should be all except the X509 ones)
  • All tool tips of these filters should get the addition " (except disabled ones)" (and work on T7300 at the same time)
  • Add a new filter "Disabled Certificates"

Event Timeline

werner triaged this task as Normal priority.Sep 23 2024, 1:11 PM

ok, discussed this with Werner and Alexander, result was:

The new filter should be the default and the name of the default filter stay "All certificates". But the tool tip for that should then show "All certificates except the disabled ones".

We then need another filter "Disabled certificates" which should only show those.

I'll change the ticket description accordingly if there are no objections today.

What about all other filters? For example "Not Certified", "Not Fully Certified", "My Own", "OpenPGP"? Should the disabled certificates also be excluded for those filters?

ok. For the tooltip I would now favor the same addition to all current tool tips where it applies:
"(w/o disabled ones)", e.g. "All certificates (except disabled ones)".

Incidentally I noticed that we currently use title case for all the tool tips for the filters, see T7300

ebo renamed this task from Draft: Kleopatra: Add filter "All enabled certificates" to Kleopatra: Change filters "All certificates" etc. so that they do not include disabled ones.Sep 25 2024, 11:04 AM
ebo updated the task description. (Show Details)
ebo added a project: vsd33.
ebo added a subscriber: TobiasFella.
TobiasFella set External Link to https://invent.kde.org/pim/libkleo/-/merge_requests/143.Sep 25 2024, 3:46 PM
TobiasFella moved this task from Restricted Project Column to Restricted Project Column on the Restricted Project board.
TobiasFella changed the task status from Open to Testing.Sep 26 2024, 11:16 AM

Backported for VSD 3.3 together with changes made for T6666.

ebo moved this task from Restricted Project Column to Restricted Project Column on the Restricted Project board.Oct 17 2024, 9:28 AM

Gpg4win-Beta-70:
Looks ok.

But the tooltip for disable/enable does not fit any more with these filters, as they are no longer listed in the regular certificate list:
src:/src/view/keylistcontroller.cpp:619
"Disabled certificates are not offered when selecting a certificate to sign with or to encrypt for.\nThey are still listed in the certificate list."

This probably does not really belong to this ticket…

ebo changed the task status from Testing to Open.Fri, Nov 8, 10:27 AM

setting this to open for the small fix in the tooltip.
I suggest as new text:
"Disabled certificates are not offered when selecting a certificate to sign with or to encrypt for.\nThey are not shown in the certificate list with most filters."
And I think there should be an additional newline somewhere, as I was shown a much too long tool tip. The German text is not that much longer…

We shouldn't have to add explicit line breaks. Explicit line breaks will lead to bad formatting (German: Flattersatz) for people who use huge font sizes (a11y!) and Qt will wrap long tool tips so that they won't become wider than the screen. Alternatively, we wrap the tool tips (in the code that sets the tool tips) into <html> tags. Then (for whatever reason) Qt will make the tool tips much narrower. (Some people think too narrow, but we have to die one death.)

Hm, probably I would be for the html-tags, then. Is there an example where one could see how narrow tool tips really get with that option?

Changed in https://invent.kde.org/pim/kleopatra/-/merge_requests/316

The merge request has a screenshot for how it looks with html tags

ebo moved this task from Restricted Project Column to Restricted Project Column on the Restricted Project board.Fri, Nov 8, 1:21 PM

I like it better than the very long tool tip.

ebo changed the task status from Open to Testing.Fri, Nov 8, 1:22 PM
ebo moved this task from WiP to Backlog on the vsd33 board.

Latest changes backported for VSD 3.3