Page MenuHome GnuPG
Create Task
Maniphest T7296

Kleopatra: Change filters "All certificates" etc. so that they do not include disabled ones
Testing, NormalPublic
Actions

Description

Edited on 2024-09-25 to reflect the result of the discussion

Reasoning:
Extrapolating from some issues and questions, users tend to want to delete old keys if they create a new one. And others requested a feature to disable certificates because they don't want them to clutter up their keyring.
We want to be able to tell users that they should keep their old keys (to decrypt old data) but don't have to see them if they mark them "disabled".

Therefore we need the following changes:

  • The filter "All Certificates" should show all certificates/keys except the disabled ones.
  • All other filters where this applies should be changed accordingly (should be all except the X509 ones)
  • All tool tips of these filters should get the addition " (except disabled ones)" (and work on T7300 at the same time)
  • Add a new filter "Disabled Certificates"

Details

External Link
https://invent.kde.org/pim/libkleo/-/merge_requests/143

Revisions and Commits

rLIBKLEO Libkleo
rLIBKLEOd5fd4cb1410c Filter disabled keys out of normal filters and allow filtering with the…
rLIBKLEO15cd22fba76d Filter disabled keys out of normal filters and allow filtering with the…
rLIBKLEO08f325087419 Filter disabled keys out of normal filters and allow filtering with the…

Related Objects
Search...

Event Timeline

• ebo created this task.Fri, Sep 20, 1:18 PM
• werner triaged this task as Normal priority.Mon, Sep 23, 1:11 PM
• ebo added a comment.Tue, Sep 24, 9:53 AM

ok, discussed this with Werner and Alexander, result was:

The new filter should be the default and the name of the default filter stay "All certificates". But the tool tip for that should then show "All certificates except the disabled ones".

We then need another filter "Disabled certificates" which should only show those.

I'll change the ticket description accordingly if there are no objections today.

• ikloecker added a comment.Tue, Sep 24, 12:16 PM

What about all other filters? For example "Not Certified", "Not Fully Certified", "My Own", "OpenPGP"? Should the disabled certificates also be excluded for those filters?

• werner added a comment.Tue, Sep 24, 2:19 PM

I would exclude them.

• ebo added a subtask: T7300: Kleopatra: change filter tool tips to sentence case.EditedWed, Sep 25, 10:48 AM

ok. For the tooltip I would now favor the same addition to all current tool tips where it applies:
"(w/o disabled ones)", e.g. "All certificates (except disabled ones)".

Incidentally I noticed that we currently use title case for all the tool tips for the filters, see T7300

• ebo renamed this task from Draft: Kleopatra: Add filter "All enabled certificates" to Kleopatra: Change filters "All certificates" etc. so that they do not include disabled ones.Wed, Sep 25, 11:04 AM
• ebo updated the task description. (Show Details)
• ebo added a project: vsd33.
• ebo added a subscriber: • TobiasFella.
• ebo updated the task description. (Show Details)Wed, Sep 25, 11:47 AM
• TobiasFella claimed this task.Wed, Sep 25, 11:47 AM
• TobiasFella added a commit: rLIBKLEO08f325087419: Filter disabled keys out of normal filters and allow filtering with the….Wed, Sep 25, 3:42 PM
• TobiasFella set External Link to https://invent.kde.org/pim/libkleo/-/merge_requests/143.Wed, Sep 25, 3:46 PM
• TobiasFella moved this task from Restricted Project Column to Restricted Project Column on the Restricted Project board.
• TobiasFella added a commit: rLIBKLEO15cd22fba76d: Filter disabled keys out of normal filters and allow filtering with the….Thu, Sep 26, 10:35 AM
• TobiasFella added a commit: rLIBKLEOd5fd4cb1410c: Filter disabled keys out of normal filters and allow filtering with the….
• TobiasFella changed the task status from Open to Testing.Thu, Sep 26, 11:16 AM
• ebo closed subtask T7300: Kleopatra: change filter tool tips to sentence case as Invalid.Fri, Sep 27, 11:46 AM