The show/hide button for the password needs to be accessible via keyboard.
Otherwise it is not possible to have a screen reader repeat the password.
Description
Description
Details
Details
- Version
- pinentry 1.3.1
Revisions and Commits
Revisions and Commits
| rP Pinentry | |||
| rPae5f83e76f77 qt: Make Show/Hide Password functionality accessible | |||
| rP07723a8e05f3 qt5: Make Show/Hide Password functionality accessible | |||
| Status | Assigned | Task | ||
|---|---|---|---|---|
| Unknown Object (Maniphest Task) | ||||
| Unknown Object (Maniphest Task) | ||||
| Open | None | T5824 Kleopatra: Full accessibility support | ||
| Testing | • ikloecker | T7736 Pinentry: Show/hide button not accessible by keyboard |
Event Timeline
Comment Actions
The fix should be available in gpg4win-5.0.0-beta350.
To make it available in VSD 3.3.3 and VSD 3.4 pinentry needs to be updated to version 1.3.2 in the corresponding branches.
Comment Actions
Looks good to me on gpg4win-5.0.0-beta357 @ win10:
Is there a reason, why the Show/Hide button needs to have the second tab order? If not, keyboard users would be very happy not to have to press tab twice for the repeat input field.
Still needs to be tested:
- VSD 3.3.3
- VSD 3.4
Comment Actions
The gold rule of tab order is that tab order follows the usual reading direction, i.e. line by line from left to right. If you press Enter after entering the password in the first input field then the focus should jump to the second input field.