Page MenuHome GnuPG
Feed Advanced Search

Nov 13 2024

gniibe renamed T7323: scdaemon hangs up (when output from scdaemon is not consumed by gpg-agent) from scdaemon hangs up (when output from scdaemon is not consumed any more) to scdaemon hangs up (when output from scdaemon is not consumed gpg-agent).
Nov 13 2024, 5:31 AM · Windows, Bug Report, scd
gniibe renamed T7323: scdaemon hangs up (when output from scdaemon is not consumed by gpg-agent) from scdaemon hangs up to scdaemon hangs up (when output from scdaemon is not consumed any more).
Nov 13 2024, 3:49 AM · Windows, Bug Report, scd

Nov 12 2024

gniibe added a comment to T7378: Kleopatra: loading X.509 certificate from Signature card hangs.

For the record, I add the info here too (was: just in xmpp).

Nov 12 2024, 10:59 AM · Restricted Project, kleopatra
gniibe closed T7287: libgpg-error:w32: Support setting an environment block encoded as UTF-8 as Resolved.

Fixed in 1.51, by introducing gpgrt_spawn_actions_set_env_rev, which assumes utf-8 encoding.

Nov 12 2024, 7:47 AM · Bug Report, gpgrt
gniibe closed T7307: Add new function to spawn API which has 'modifying' environment semantics, a subtask of T7169: libgpg-error 1.50 build issue (spawn-posix.c:345:5: error: use of undeclared identifier 'environ'), as Resolved.
Nov 12 2024, 7:42 AM · gpgrt, MacOS, Bug Report
gniibe closed T7307: Add new function to spawn API which has 'modifying' environment semantics as Resolved.

Fixed in 1.51.

Nov 12 2024, 7:42 AM · gpgrt, Bug Report
gniibe closed T7344: libgpg-error: nullptr as Resolved.

Fixed in 1.51.

Nov 12 2024, 7:42 AM · gpgrt, Bug Report
gniibe committed rGd994ffc56a02: scd: Clean up app_send_active_apps and app_send_card_list. (authored by gniibe).
scd: Clean up app_send_active_apps and app_send_card_list.
Nov 12 2024, 7:41 AM
gniibe closed T7293: spawn API glitch as Resolved.
Nov 12 2024, 7:34 AM · gnupg22 (gnupg-2.2.45), gnupg24, gpgrt, Bug Report
gniibe changed the status of T7386: npth:w32: npth_cond_broadcast only wakes up the first waiter from Open to Testing.
Nov 12 2024, 6:18 AM · Windows, npth, Bug Report
gniibe committed rPTHe369dd721762: w32: Fix npth_cond_signal and npth_cond_broadcast. (authored by gniibe).
w32: Fix npth_cond_signal and npth_cond_broadcast.
Nov 12 2024, 6:11 AM
gniibe added a project to T7386: npth:w32: npth_cond_broadcast only wakes up the first waiter: Windows.
Nov 12 2024, 5:34 AM · Windows, npth, Bug Report
gniibe committed rPTHa86421fc08f4: tests: Add a test with condition variable. (authored by gniibe).
tests: Add a test with condition variable.
Nov 12 2024, 3:16 AM

Nov 11 2024

gniibe committed rPTH91b5684b4194: w32: Fix confusion about INVALID_HANDLE_VALUE. Fix leak. (authored by gniibe).
w32: Fix confusion about INVALID_HANDLE_VALUE. Fix leak.
Nov 11 2024, 5:27 PM
gniibe committed rPTH3ac046be9214: w32: Fix value type mismatch for thread impl. (authored by gniibe).
w32: Fix value type mismatch for thread impl.
Nov 11 2024, 5:27 PM
gniibe claimed T7386: npth:w32: npth_cond_broadcast only wakes up the first waiter.
Nov 11 2024, 12:38 PM · Windows, npth, Bug Report
gniibe created T7386: npth:w32: npth_cond_broadcast only wakes up the first waiter.
Nov 11 2024, 12:37 PM · Windows, npth, Bug Report
gniibe triaged T7378: Kleopatra: loading X.509 certificate from Signature card hangs as High priority.
Nov 11 2024, 6:49 AM · Restricted Project, kleopatra
gniibe committed rG2f6b479919f9: scd: Fix a memory leak. (authored by gniibe).
scd: Fix a memory leak.
Nov 11 2024, 5:50 AM
gniibe added a comment to T7378: Kleopatra: loading X.509 certificate from Signature card hangs.

@ebo @ikloecker Let me explain my thoughts. If you have time, please help me doing some tests in your environment.

Nov 11 2024, 2:49 AM · Restricted Project, kleopatra
gniibe committed rGb1f2695d24a8: scd: Fix resource leaks on error paths. (authored by gniibe).
scd: Fix resource leaks on error paths.
Nov 11 2024, 1:55 AM

Nov 9 2024

gniibe added a comment to T7378: Kleopatra: loading X.509 certificate from Signature card hangs.

This shell script running gpg-connect-agent should run successfully:

Nov 9 2024, 1:19 PM · Restricted Project, kleopatra

Nov 8 2024

gniibe claimed T7378: Kleopatra: loading X.509 certificate from Signature card hangs.
Nov 8 2024, 6:43 AM · Restricted Project, kleopatra
gniibe added inline comments to rG8359f2e49895: scd: Fix getinfo active_apps..
Nov 8 2024, 1:52 AM

Nov 7 2024

gniibe added a comment to T7379: Kleopatra: Learning certificates of Signature v2.0 card fails if a Yubikey is plugged in as well.

SCD SERIALNO serialno can move the first card in the list in scdaemon.

Nov 7 2024, 9:06 AM · gpd5x, kleopatra
gniibe added a comment to T7379: Kleopatra: Learning certificates of Signature v2.0 card fails if a Yubikey is plugged in as well.

@ikloecker Using scdaemon with multiple cards, it is a connection which holds the card.

Nov 7 2024, 8:46 AM · gpd5x, kleopatra
gniibe added a comment to T7378: Kleopatra: loading X.509 certificate from Signature card hangs.

@ikloecker Thank you sharing the problem. I don't know much aboug NKS card.

Nov 7 2024, 3:05 AM · Restricted Project, kleopatra
gniibe committed rG8359f2e49895: scd: Fix getinfo active_apps. (authored by gniibe).
scd: Fix getinfo active_apps.
Nov 7 2024, 1:06 AM

Nov 6 2024

gniibe committed rG25a140542a91: scd: Serialize CARD access for send_card_and_app_list. (authored by gniibe).
scd: Serialize CARD access for send_card_and_app_list.
Nov 6 2024, 3:39 AM
gniibe added a comment to T7323: scdaemon hangs up (when output from scdaemon is not consumed by gpg-agent).

I found a problem of possible duplicate registration of another APP, due to no serialization for CARD access.

Nov 6 2024, 3:38 AM · Windows, Bug Report, scd
gniibe added a comment to T7323: scdaemon hangs up (when output from scdaemon is not consumed by gpg-agent).

The resource leak was fixed in: rG40707c8bff49: agent: Fix resource leak for PRIMARY_CTX.

Nov 6 2024, 3:25 AM · Windows, Bug Report, scd

Nov 1 2024

gniibe added a comment to T7332: Kleopatra: Initial keylisting sometimes fails or hangs for some seconds.

@ebo Thank you for your continuous testing.

Nov 1 2024, 1:59 AM · gnupg24, gnupg22, gpd5x, kleopatra, Bug Report

Oct 31 2024

gniibe claimed T7363: gpgme testsuite error against gnupg 2.2.45.

@ikloecker : Thanks for investigating. Please note that gpg-agent is incompatible wrt LISTTRUSTED (2.2 vs 2.4). So, No data callback in IPC maybe expected with gpg-agent 2.4.

Oct 31 2024, 3:54 AM · gnupg22 (gnupg-2.2.46), Bug Report
gniibe committed rG2ca38bee7a63: agent: Fix status output for LISTTRUSTED. (authored by gniibe).
agent: Fix status output for LISTTRUSTED.
Oct 31 2024, 3:53 AM

Oct 25 2024

gniibe committed rC7eaa43bf0931: config: Include Kyber in GCRYPT_PUBKEY_CIPHERS. (authored by gniibe).
config: Include Kyber in GCRYPT_PUBKEY_CIPHERS.
Oct 25 2024, 2:59 AM

Oct 24 2024

gniibe added a comment to T7340: Introduced a context with thread local storage.

I created a branch: https://dev.gnupg.org/source/libgcrypt/history/gniibe%252Ft7340/

Oct 24 2024, 3:27 AM · libgcrypt, FIPS, Feature Request

Oct 23 2024

gniibe committed rEd14c69a7f256: Avoid use of 'nullptr' for an identifier. (authored by gniibe).
Avoid use of 'nullptr' for an identifier.
Oct 23 2024, 2:11 AM
gniibe changed the status of T7344: libgpg-error: nullptr from Open to Testing.

Thanks. Fixed in: rEd14c69a7f256: Avoid use of 'nullptr' for an identifier.

Oct 23 2024, 1:50 AM · gpgrt, Bug Report

Oct 22 2024

gniibe committed rG40707c8bff49: agent: Fix resource leak for PRIMARY_CTX. (authored by gniibe).
agent: Fix resource leak for PRIMARY_CTX.
Oct 22 2024, 6:26 AM

Oct 21 2024

gniibe added a comment to T7323: scdaemon hangs up (when output from scdaemon is not consumed by gpg-agent).

I found fd resource leak in gpg-agent.

  • gpg-connect-agent "scd killscd" /bye seems not release a file descriptor somewhere
Oct 21 2024, 7:35 AM · Windows, Bug Report, scd

Oct 18 2024

gniibe added a comment to T7339: Kleopatra: Cannot decrypt packets with hybrid cipher without using symmetric passphrase.

For the second case, I think that gcry_kdf_defive should not be called with pw="". The result of FAILURE gpg-exit 33554433 comes from the log_error after failure of gcry_kdf_derive.

Oct 18 2024, 8:41 AM · gpd5x, kleopatra, Bug Report

Oct 16 2024

gniibe added a comment to T7340: Introduced a context with thread local storage.

Autoconf archive has AX_TLS: https://www.gnu.org/software/autoconf-archive/ax_tls.html
Also, AX_GCC_VAR_ATTRIBUTE(tls_model) could be used: https://www.gnu.org/software/autoconf-archive/ax_gcc_var_attribute.html

Oct 16 2024, 7:31 AM · libgcrypt, FIPS, Feature Request
gniibe updated the task description for T7340: Introduced a context with thread local storage.
Oct 16 2024, 7:28 AM · libgcrypt, FIPS, Feature Request
gniibe updated the task description for T7340: Introduced a context with thread local storage.
Oct 16 2024, 7:22 AM · libgcrypt, FIPS, Feature Request
gniibe triaged T7340: Introduced a context with thread local storage as Normal priority.
Oct 16 2024, 7:21 AM · libgcrypt, FIPS, Feature Request
gniibe committed rE1bca948594d9: spawn: Shorter identifier gpgrt_spawn_actions_set_env_rev. (authored by gniibe).
spawn: Shorter identifier gpgrt_spawn_actions_set_env_rev.
Oct 16 2024, 7:12 AM
gniibe committed rG347ab07c6245: build: Don't remove --disable-endian-check. (authored by gniibe).
build: Don't remove --disable-endian-check.
Oct 16 2024, 4:46 AM
gniibe added a comment to T7332: Kleopatra: Initial keylisting sometimes fails or hangs for some seconds.

Good catch, @ikloecker !
I located the bug in GnuPG, and the fix is: rG71840b57f486: common: Fix a race condition in creating socketdir.

Oct 16 2024, 3:08 AM · gnupg24, gnupg22, gpd5x, kleopatra, Bug Report
gniibe committed rG71840b57f486: common: Fix a race condition in creating socketdir. (authored by gniibe).
common: Fix a race condition in creating socketdir.
Oct 16 2024, 3:06 AM

Oct 15 2024

gniibe claimed T7338: Revamp the FIPS service indicator.
Oct 15 2024, 11:25 AM · libgcrypt, FIPS, Feature Request

Oct 11 2024

gniibe committed rE1860f6407f83: spawn: Add new function to modify environment. (authored by gniibe).
spawn: Add new function to modify environment.
Oct 11 2024, 9:32 AM
gniibe added a comment to T7307: Add new function to spawn API which has 'modifying' environment semantics.

With the change, T7169 is fixed (by side-effect).

Oct 11 2024, 9:31 AM · gpgrt, Bug Report
gniibe changed the status of T7307: Add new function to spawn API which has 'modifying' environment semantics from Open to Testing.

Pushed the change: rE1860f6407f83: spawn: Add new function to modify environment.

Oct 11 2024, 9:31 AM · gpgrt, Bug Report
gniibe changed the status of T7307: Add new function to spawn API which has 'modifying' environment semantics, a subtask of T7169: libgpg-error 1.50 build issue (spawn-posix.c:345:5: error: use of undeclared identifier 'environ'), from Open to Testing.
Oct 11 2024, 9:31 AM · gpgrt, MacOS, Bug Report
gniibe committed rGf8bf5e01f766: build: Use AC_C_BIGENDIAN for detecting endian. (authored by gniibe).
build: Use AC_C_BIGENDIAN for detecting endian.
Oct 11 2024, 3:24 AM

Oct 10 2024

gniibe committed rE68600fe17c5f: w32: Fix releasing memory for UTF-8 text. (authored by gniibe).
w32: Fix releasing memory for UTF-8 text.
Oct 10 2024, 4:36 AM

Oct 9 2024

gniibe added a comment to T7307: Add new function to spawn API which has 'modifying' environment semantics.

Replacing gpgrt_spawn_actions_set_environ by gpgrt_spawn_actions_set_envchange is not good, as it's exported and already used.

Oct 9 2024, 8:51 AM · gpgrt, Bug Report
gniibe updated the task description for T7323: scdaemon hangs up (when output from scdaemon is not consumed by gpg-agent).
Oct 9 2024, 4:06 AM · Windows, Bug Report, scd
gniibe renamed T7323: scdaemon hangs up (when output from scdaemon is not consumed by gpg-agent) from scdaemon hang to scdaemon hangs up.
Oct 9 2024, 4:06 AM · Windows, Bug Report, scd
gniibe created T7323: scdaemon hangs up (when output from scdaemon is not consumed by gpg-agent).
Oct 9 2024, 4:04 AM · Windows, Bug Report, scd

Oct 8 2024

gniibe changed the status of T7316: Curve25519/v5 key cannot be exported, a subtask of T7315: Allow exporting of PQC keys., from Open to Testing.
Oct 8 2024, 8:38 AM · gnupg26, OpenPGP, PQC, gnupg
gniibe changed the status of T7316: Curve25519/v5 key cannot be exported from Open to Testing.
Oct 8 2024, 8:38 AM · gnupg26, OpenPGP, PQC, gnupg
gniibe added a comment to T7316: Curve25519/v5 key cannot be exported.

Pushed the fix for exporting OpenPGP v5 key: rG57dce1ee62c2: common,gpg,scd,sm: Fix for Curve25519 OID supporting new and old.

Oct 8 2024, 8:38 AM · gnupg26, OpenPGP, PQC, gnupg
gniibe committed rG57dce1ee62c2: common,gpg,scd,sm: Fix for Curve25519 OID supporting new and old. (authored by gniibe).
common,gpg,scd,sm: Fix for Curve25519 OID supporting new and old.
Oct 8 2024, 8:35 AM
gniibe committed rGf5703994d469: common,gpg,scd,sm: Use openpgp_oid_or_name_to_curve to get curve. (authored by gniibe).
common,gpg,scd,sm: Use openpgp_oid_or_name_to_curve to get curve.
Oct 8 2024, 8:00 AM

Oct 3 2024

gniibe added a comment to T7316: Curve25519/v5 key cannot be exported.

The OID is used for fingerprint computation, which complicates things.

Oct 3 2024, 7:37 AM · gnupg26, OpenPGP, PQC, gnupg
gniibe claimed T7316: Curve25519/v5 key cannot be exported.
Oct 3 2024, 2:43 AM · gnupg26, OpenPGP, PQC, gnupg

Oct 2 2024

gniibe triaged T7316: Curve25519/v5 key cannot be exported as Normal priority.
Oct 2 2024, 7:20 AM · gnupg26, OpenPGP, PQC, gnupg

Oct 1 2024

gniibe changed the status of T7309: gpg should not proceed with the key import from the smartcard if no valid SCD READKEY information is received from Open to Testing.

Fixed in master: rGe7891225788a: gpg: Robust error handling for SCD READKEY.

Oct 1 2024, 3:58 AM · Info Needed, scd, gpgagent, Bug Report
gniibe committed rGe7891225788a: gpg: Robust error handling for SCD READKEY. (authored by gniibe).
gpg: Robust error handling for SCD READKEY.
Oct 1 2024, 3:58 AM

Sep 30 2024

gniibe claimed T7309: gpg should not proceed with the key import from the smartcard if no valid SCD READKEY information is received.
Sep 30 2024, 3:49 AM · Info Needed, scd, gpgagent, Bug Report

Sep 27 2024

gniibe added a comment to T7307: Add new function to spawn API which has 'modifying' environment semantics.

Here is my attempt:

Sep 27 2024, 10:12 AM · gpgrt, Bug Report
gniibe triaged T7307: Add new function to spawn API which has 'modifying' environment semantics as Normal priority.
Sep 27 2024, 10:11 AM · gpgrt, Bug Report
gniibe added a comment to T6375: gpg-agent race-condition with parallel clients.

It is reproducible bug even with master branch.

Sep 27 2024, 4:22 AM · gnupg24, gpgagent, Bug Report

Sep 26 2024

gniibe added a comment to T6375: gpg-agent race-condition with parallel clients.

I have a look at the log file of gpg-agent.log. I can see that six PKDECRYPT requests are handled simultaneously. I think that it's out of secure memory to decrypt the private key which results pinentry request.

Sep 26 2024, 10:35 AM · gnupg24, gpgagent, Bug Report

Sep 25 2024

gniibe closed T7186: Fix tpm2d key import after recent changes as Resolved.
Sep 25 2024, 7:29 AM · gnupg, Bug Report
gniibe closed T7195: gpgme regression (t-json) with GnuPG 2.5.0 as Resolved.
Sep 25 2024, 7:28 AM · gnupg, Bug Report
gniibe committed rG79ad6a8b430e: po: Update Japanese Translation. (authored by gniibe).
po: Update Japanese Translation.
Sep 25 2024, 7:27 AM
gniibe committed rG26d171d36d2c: po: Update Japanese Translation. (authored by gniibe).
po: Update Japanese Translation.
Sep 25 2024, 7:15 AM
gniibe closed T6641: pinentry-tty & pinentry-curses breaks tty when timeout occurs or CTRL-C is pressed as Resolved.

Fixed in pinentry 1.3, when using GnuPG 2.4 or later.

Sep 25 2024, 4:56 AM · gnupg, pinentry
gniibe committed rGa269a27c4ce5: common: Fix gnupg_exec_tool_stream for INEXTRA==NULL. (authored by gniibe).
common: Fix gnupg_exec_tool_stream for INEXTRA==NULL.
Sep 25 2024, 4:20 AM

Sep 24 2024

gniibe closed T5924: libassuan: uses of socklen_t in assuan.h are inconsistent as Resolved.

Fixed in libassuan 3.0.0.

Sep 24 2024, 7:39 AM · libassuan
gniibe closed T6734: gnupg: Use gpgrt_b64* API as Resolved.

Done in GnuPG 2.5.0.

Sep 24 2024, 7:35 AM · gnupg26

Sep 20 2024

gniibe added a comment to T7291: scdaemon randomly hangs when trying to access a token.

The change of spawn functions (basically, it was factored out to libgpg-error) results more possibilities to have blocked scdaemon, since the implementation in libgpg-error introduced context switch points when it spawns a child process.

Sep 20 2024, 4:02 AM · scd
gniibe added a comment to T7151: graceful shutdown: DEVINFO should be a gpg-agent command: also watching input close.

Found another thinko; When there is no clients with DEVINFO --watch, the pipe to be notified is not consumed at all (no read). It eventually results blocked by write(2), when the pipe is filled.

Sep 20 2024, 3:51 AM · gpgagent, scd, gnupg24, Bug Report
gniibe committed rG0a94582af5b1: scd: Fix DEVINFO, allowing no clients which watch the change. (authored by gniibe).
scd: Fix DEVINFO, allowing no clients which watch the change.
Sep 20 2024, 3:48 AM

Sep 19 2024

gniibe added a comment to T7291: scdaemon randomly hangs when trying to access a token.

Do you have scd-event script in your GNUPGHOME?

Sep 19 2024, 9:13 AM · scd
gniibe committed rEbcab96484d48: posix: Fix forgotten _gpgrt_post_syscall on error path. (authored by gniibe).
posix: Fix forgotten _gpgrt_post_syscall on error path.
Sep 19 2024, 8:56 AM
gniibe committed rE4a0c942151da: posix: Fix memory leak for spawn. (authored by gniibe).
posix: Fix memory leak for spawn.
Sep 19 2024, 8:55 AM
gniibe added a comment to T7294: keyboxd: Possible race conditions (and clean up).

I applied rGb804378f183f: kbx: Fix a race condition on DATABASE_HD. in master. Let us see how behavior changes.

Sep 19 2024, 6:53 AM · keyboxd, Bug Report, kleopatra, Restricted Project
gniibe committed rGb804378f183f: kbx: Fix a race condition on DATABASE_HD. (authored by gniibe).
kbx: Fix a race condition on DATABASE_HD.
Sep 19 2024, 6:47 AM
gniibe added a comment to T7294: keyboxd: Possible race conditions (and clean up).

I found one problem. This problem may result lock-up on Windows, I suppose.

Sep 19 2024, 6:40 AM · keyboxd, Bug Report, kleopatra, Restricted Project
gniibe triaged T7294: keyboxd: Possible race conditions (and clean up) as High priority.
Sep 19 2024, 6:32 AM · keyboxd, Bug Report, kleopatra, Restricted Project
gniibe added a comment to T7151: graceful shutdown: DEVINFO should be a gpg-agent command: also watching input close.

I mean: two gpg-agent requests simultaneously running DEVINFO --watch.
Single scdaemon, two threads handling DEVINFO --watch simultaneously, by pselect + read.
Two threads waken up, but it was only one thread which can read(2), another was blocked (before the fix).

Sep 19 2024, 1:43 AM · gpgagent, scd, gnupg24, Bug Report

Sep 18 2024

gniibe lowered the priority of T7291: scdaemon randomly hangs when trying to access a token from Unbreak Now! to High.

For POSIX, I found an issue of T7151.
If you are using multiple clients which invoke SCD DEVINFO --watch, the problem should be fixed.
If it's not the case, let us locate a bug (or two).

Sep 18 2024, 6:55 AM · scd
gniibe added a comment to T7151: graceful shutdown: DEVINFO should be a gpg-agent command: also watching input close.

Fixed in rGfc30f7059650: scd: Fix DEVINFO to allow multiple clients.

Sep 18 2024, 6:52 AM · gpgagent, scd, gnupg24, Bug Report
gniibe committed rGfc30f7059650: scd: Fix DEVINFO to allow multiple clients. (authored by gniibe).
scd: Fix DEVINFO to allow multiple clients.
Sep 18 2024, 6:47 AM
gniibe added a comment to T7151: graceful shutdown: DEVINFO should be a gpg-agent command: also watching input close.

I realized that I put a bug on POSIX; When multiple clients do DEVINFO --watch, it is possible for scdaemon to hang (waiting pselect and read, read by one, read by another is blocked).

Sep 18 2024, 4:57 AM · gpgagent, scd, gnupg24, Bug Report

Sep 17 2024

gniibe committed rC4876a1a45c25: tests:kyber: Add genkey and encap KAT tests. (authored by gniibe).
tests:kyber: Add genkey and encap KAT tests.
Sep 17 2024, 10:39 AM
gniibe committed rC38742196c04c: cipher:kyber: Add gcry_kem_genkey to support deterministic op. (authored by gniibe).
cipher:kyber: Add gcry_kem_genkey to support deterministic op.
Sep 17 2024, 10:39 AM