JW (JW)
User

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Wednesday

  • Clear sailing ahead.

User Details

User Since
Mar 27 2017, 4:48 PM (125 w, 2 h)
Availability
Available

Recent Activity

May 14 2019

JW added a comment to T4491: Compile error in nPth's t-fork.c on Solaris 11.3 i86pc.

In case of gcc 4.8 on Solaris, could you please try this patch (instead of configure patch) to see if it works?

May 14 2019, 7:35 AM · npth, Bug Report
JW added a comment to T4494: UBsan finding "armor.c:1159:11: runtime error: member access within null pointer...".

rG5b22d2c4008 tested good under Asan.

May 14 2019, 4:53 AM · gnupg
JW added a comment to T4499: Asan finding in libgcrypt.

I was talking to Thomas Dickey, who maintains Ncurses. Ncurses had a leak and he offered a config option to remove it. Ncurses config responds to --disable-leaks.

May 14 2019, 1:45 AM · libgcrypt

May 13 2019

JW added a comment to T4499: Asan finding in libgcrypt.
Dynamic loading of Libgcrypt is anyway not supported; those who do that are on their own.
May 13 2019, 10:17 PM · libgcrypt
JW added a comment to T4504: Asan findings in iconv configure test causing config failure.

I'm going to bring newest m4/iconv.m4 from original (gettext), which apparently fixed file descriptor leaks.

May 13 2019, 8:08 AM · gpgrt, gnupg
JW added a comment to T4504: Asan findings in iconv configure test causing config failure.

An FYI... Once we cleared the earlier findings GnuPG tested OK under Asan. GnuPG itself had no findings, and it did not cause any dependent libraries to generate findings.

May 13 2019, 7:20 AM · gpgrt, gnupg

May 12 2019

JW added a comment to T4504: Asan findings in iconv configure test causing config failure.

This patch tested OK.

May 12 2019, 11:44 AM · gpgrt, gnupg
JW created T4504: Asan findings in iconv configure test causing config failure in the S1 Public space.
May 12 2019, 10:26 AM · gpgrt, gnupg
JW added a comment to T4499: Asan finding in libgcrypt.

The second and third arguments passed to xgcry_control seem to be lost when calling gcry_control.

May 12 2019, 7:16 AM · libgcrypt
JW added a comment to T4499: Asan finding in libgcrypt.

Here are the next two failures I am seeing while testing libgrcypt. It appears to be related to GCRYCTL_INIT_SECMEM.

May 12 2019, 12:44 AM · libgcrypt

May 11 2019

JW added a comment to T4499: Asan finding in libgcrypt.

I'm still seeing a few odd outputs from make check, but I have not investigated them yet.

May 11 2019, 10:50 PM · libgcrypt
JW added a comment to T4499: Asan finding in libgcrypt.

Maybe cleaner option for mpi/mpiutil.c would be to statically allocate the constants

May 11 2019, 9:14 PM · libgcrypt
JW added a comment to T4499: Asan finding in libgcrypt.

Here's a couple of awful hacks that get me through make check. Feel free to restate how awful they are; I know it is a bad thing to do.

May 11 2019, 7:24 AM · libgcrypt

May 10 2019

JW updated the task description for T4499: Asan finding in libgcrypt.
May 10 2019, 11:44 PM · libgcrypt
JW created T4499: Asan finding in libgcrypt in the S1 Public space.
May 10 2019, 11:43 PM · libgcrypt
JW created T4498: Asan findings in tests/t-logging.c in the S1 Public space.
May 10 2019, 11:34 PM · gpgrt
JW added a comment to T4495: UBsan finding "certdump.c:695:3: runtime error: null pointer passed as argument 2".

It looks like this patch clears this finding:

May 10 2019, 9:26 PM · gnupg
JW created T4495: UBsan finding "certdump.c:695:3: runtime error: null pointer passed as argument 2" in the S1 Public space.
May 10 2019, 9:24 PM · gnupg
JW added a comment to T4494: UBsan finding "armor.c:1159:11: runtime error: member access within null pointer...".

It looks like this patch clears this finding:

May 10 2019, 9:07 PM · gnupg
JW created T4494: UBsan finding "armor.c:1159:11: runtime error: member access within null pointer..." in the S1 Public space.
May 10 2019, 8:31 PM · gnupg
JW added a comment to T4491: Compile error in nPth's t-fork.c on Solaris 11.3 i86pc.

It looks like Solaris only needs CFLAGS+=-std=c99. It was added for all programs and libraries listed at https://www.gnupg.org/download/index.html.

May 10 2019, 9:06 AM · npth, Bug Report
JW updated the task description for T4492: Gawk 5.0 and warning: regexp escape sequence `\#' is not a known regexp operator.
May 10 2019, 8:48 AM · Duplicate, gnupg
JW created T4492: Gawk 5.0 and warning: regexp escape sequence `\#' is not a known regexp operator in the S1 Public space.
May 10 2019, 8:46 AM · Duplicate, gnupg
JW created T4491: Compile error in nPth's t-fork.c on Solaris 11.3 i86pc.
May 10 2019, 8:01 AM · npth, Bug Report

Mar 8 2019

JW added a comment to T4397: GPG Error - version >= 1.25... no.

Similar issue with ntbtls:

Mar 8 2019, 10:33 AM · gpgrt, Bug Report

Mar 7 2019

JW added a comment to T4397: GPG Error - version >= 1.25... no.

Libassuan 2.5.3 has a similar problem:

Mar 7 2019, 9:01 PM · gpgrt, Bug Report
JW updated the task description for T4397: GPG Error - version >= 1.25... no.
Mar 7 2019, 8:51 PM · gpgrt, Bug Report
JW updated the task description for T4397: GPG Error - version >= 1.25... no.
Mar 7 2019, 8:51 PM · gpgrt, Bug Report
JW updated the task description for T4397: GPG Error - version >= 1.25... no.
Mar 7 2019, 8:32 PM · gpgrt, Bug Report
JW updated the task description for T4397: GPG Error - version >= 1.25... no.
Mar 7 2019, 8:30 PM · gpgrt, Bug Report
JW updated the task description for T4397: GPG Error - version >= 1.25... no.
Mar 7 2019, 8:30 PM · gpgrt, Bug Report
JW updated the task description for T4397: GPG Error - version >= 1.25... no.
Mar 7 2019, 8:29 PM · gpgrt, Bug Report
JW created T4397: GPG Error - version >= 1.25... no.
Mar 7 2019, 8:28 PM · gpgrt, Bug Report

Dec 30 2018

JW created T4306: nPth fails to compile in the S1 Public space.
Dec 30 2018, 1:12 AM · npth, Bug Report
JW added a project to T4305: NtbTLS fails to compile: Bug Report.
Dec 30 2018, 1:06 AM · Bug Report, ntbtls
JW added a project to T4304: gcry_control (GCRYCTL_INIT_SECMEM, 16384, 0) failed: General error: libgcrypt.
Dec 30 2018, 1:05 AM · libgcrypt, Bug Report
JW created T4305: NtbTLS fails to compile in the S1 Public space.
Dec 30 2018, 1:05 AM · Bug Report, ntbtls

Dec 29 2018

JW updated the task description for T4304: gcry_control (GCRYCTL_INIT_SECMEM, 16384, 0) failed: General error.
Dec 29 2018, 11:47 PM · libgcrypt, Bug Report
JW created T4304: gcry_control (GCRYCTL_INIT_SECMEM, 16384, 0) failed: General error.
Dec 29 2018, 11:39 PM · libgcrypt, Bug Report
JW added a comment to T4303: scheme.c:875:33: error: expected ‘;’ before ‘abort’.

Here's the patch:

Dec 29 2018, 10:24 PM · Bug Report
JW updated the task description for T4303: scheme.c:875:33: error: expected ‘;’ before ‘abort’.
Dec 29 2018, 9:50 PM · Bug Report
JW created T4303: scheme.c:875:33: error: expected ‘;’ before ‘abort’.
Dec 29 2018, 9:50 PM · Bug Report

Jul 21 2015

JW added a comment to T1878: wipememory relies upon volatile qualifier.

Werner Koch <wk@gnupg.org> added the comment:

Please show me the disassembly of an example along with the commands and program
versions you used to create an object file with removed wipememory code.

Jul 21 2015, 3:50 PM · Info Needed, Bug Report

Jul 16 2015

JW updated subscribers of T2046: Disable optimizations on one function (was: 'pragma optimize' ...).
Jul 16 2015, 11:45 AM · Mistaken, Duplicate, Bug Report

Jul 6 2015

JW added a comment to T1878: wipememory relies upon volatile qualifier.

volatile is used to make sure the writes actually hit the
memory. gcc is not allowed to remove that for the simple reason, it
can't know whether this plain RAM or a device mapped into the address
space. That is the whole point of using volatile and it has been
introduced back in the 80ies for just this reason (back than to write
to video memory).

Jul 6 2015, 9:36 AM · Info Needed, Bug Report

Jun 17 2015

JW added a comment to T1878: wipememory relies upon volatile qualifier.

One relatively unimportant misunderstanding is due to the fact that
the standard only talks about accesses to volatile objects. It does
not talk about accesses via volatile qualified pointers. Some
programmers believe that using a pointer-to-volatile should be
handled as though it pointed to a volatile object. That is not
guaranteed by the standard and is therefore not portable. However,
this is relatively unimportant because gcc does in fact treat a
pointer-to-volatile as though it pointed to a volatile object.

It says that it's not guaranteed and it's not portable by the C
language itself.

So, you are right that volatile qualifier to a pointer should be
avoided (from viewpoint of portability).

I think that I am also right that it works with GCC implementation
(in 2008, at least).

I'm actually more concerned that the optimizer will remove the code
because it surmises its a dead store. That's the issue I am trying to
articulate.

Jun 17 2015, 4:02 PM · Info Needed, Bug Report
JW added a comment to T1878: wipememory relies upon volatile qualifier.

You shouldn't use volatile for that when compiling with GCC.

Any references which support this opinion of yours, please?

Jun 17 2015, 11:13 AM · Info Needed, Bug Report
JW added a comment to T1878: wipememory relies upon volatile qualifier.

On Tue, Jun 16, 2015 at 4:31 AM, NIIBE Yutaka via BTS
<gnupg@bugs.g10code.com> wrote:

NIIBE Yutaka <gniibe@fsij.org> added the comment:

I think that JW had some confusion. I believe that his argument is irrelevant
for libgcrypt's implementation of wipememory.

Jun 17 2015, 9:15 AM · Info Needed, Bug Report

Mar 6 2015

JW added a comment to T1915: Building static GnuPG 2.1.2 fails due to multiply defined symbols..

Changed status to 'unread'. I'm not chatting.

Mar 6 2015, 11:36 AM · Bug Report, gnupg
JW added a comment to T1915: Building static GnuPG 2.1.2 fails due to multiply defined symbols..

I was able to duplicate Bug 1862: Building static GnuPG 2.1.2 fails due to
multiply defined symbols.


/home/jwalton/Desktop/gcrypt-2.0-analyze/libgpg-error-1.18/src/visibility.c:46:
multiple definition of `gpg_err_code_from_errno'
t-support.o:/home/jwalton/Desktop/gcrypt-2.0-analyze/gnupg-2.1.2/common/t-support.c:137:
first defined here
/home/jwalton/gpg-analyze/lib/libgpg-error.a(libgpg_error_la-visibility.o): In
function `gpg_err_code_from_syserror':
/home/jwalton/Desktop/gcrypt-2.0-analyze/libgpg-error-1.18/src/visibility.c:58:
multiple definition of `gpg_err_code_from_syserror'
t-support.o:/home/jwalton/Desktop/gcrypt-2.0-analyze/gnupg-2.1.2/common/t-support.c:151:
first defined here
collect2: error: ld returned 1 exit status
make[3]: * [t-stringhelp] Error 1
make[3]: Leaving directory
`/home/jwalton/Desktop/gcrypt-2.0-analyze/gnupg-2.1.2/common'
make[2]:
* [all] Error 2
make[2]: Leaving directory
`/home/jwalton/Desktop/gcrypt-2.0-analyze/gnupg-2.1.2/common'
make[1]: * [all-recursive] Error 1
make[1]: Leaving directory `/home/jwalton/Desktop/gcrypt-2.0-analyze/gnupg-2.1.2'
make:
* [all] Error 2


LIBRARY=gnupg
VERSION=2.1.2
FILE="$LIBRARY-$VERSION"

export PREFIX=/usr/local

cd "$FILE"
./configure --enable-static --disable-shared
--with-libgpg-error-prefix="$PREFIX" --with-libassuan-prefix="$PREFIX"
--with-ksba-prefix="$PREFIX" --with-npth-prefix="$PREFIX"
--with-libgcrypt-prefix="$PREFIX" --prefix="$PREFIX"

make

Mar 6 2015, 11:35 AM · Bug Report, gnupg
JW set Version to 1.6.3 on T1916: fipsdrv.c: potential race condition due to the use of access(1).
Mar 6 2015, 10:13 AM · Bug Report, libgcrypt
JW added projects to T1916: fipsdrv.c: potential race condition due to the use of access(1): libgcrypt, Bug Report.
Mar 6 2015, 10:13 AM · Bug Report, libgcrypt
JW added a comment to T1881: Undefined behavior when running `make check` under Clang sanitizers.

Changed status to 'unread'. I am not chatting.

Mar 6 2015, 10:06 AM · Bug Report, libgcrypt
JW added a comment to T1881: Undefined behavior when running `make check` under Clang sanitizers.

Also see "Is a misaligned load due to a cast undefined behavior?"
(http://stackoverflow.com/q/28893303) on Stack Overflow.

I wanted to verify it was in fact undefined behavior.

Mar 6 2015, 10:06 AM · Bug Report, libgcrypt
JW set Version to 2.1.2 on T1915: Building static GnuPG 2.1.2 fails due to multiply defined symbols..
Mar 6 2015, 9:54 AM · Bug Report, gnupg
JW added projects to T1915: Building static GnuPG 2.1.2 fails due to multiply defined symbols.: gnupg, Bug Report.
Mar 6 2015, 9:54 AM · Bug Report, gnupg
JW set Version to 2.1.2 on T1914: http.c: potential buffer overflow.
Mar 6 2015, 9:38 AM · Not A Bug, Bug Report, gnupg
JW added projects to T1914: http.c: potential buffer overflow: gnupg, Bug Report.
Mar 6 2015, 9:38 AM · Not A Bug, Bug Report, gnupg
JW added projects to T1913: signal.c: ignoring write failures in signal handler, continuing as if everything is OK.: gnupg, Bug Report.
Mar 6 2015, 9:34 AM · Bug Report, gnupg
JW set Version to 2.1.2 on T1913: signal.c: ignoring write failures in signal handler, continuing as if everything is OK..
Mar 6 2015, 9:34 AM · Bug Report, gnupg
JW set Version to 2.1.2 on T1912: iobuf.c: potential buffer overflows.
Mar 6 2015, 9:25 AM · Not A Bug, Bug Report, gnupg
JW added projects to T1912: iobuf.c: potential buffer overflows: gnupg, Bug Report.
Mar 6 2015, 9:25 AM · Not A Bug, Bug Report, gnupg
JW set Version to 2.1.2 on T1911: dotlock.c: ignoring return value of ‘link’, declared with attribute warn_unused_result.
Mar 6 2015, 9:22 AM · Bug Report, gnupg
JW added projects to T1911: dotlock.c: ignoring return value of ‘link’, declared with attribute warn_unused_result: gnupg, Bug Report.
Mar 6 2015, 9:22 AM · Bug Report, gnupg
JW set Version to 1.6.3 on T1910: fipsdrv.c: dereference of null pointer.
Mar 6 2015, 9:19 AM · Mistaken, Bug Report, libgcrypt
JW added projects to T1910: fipsdrv.c: dereference of null pointer: libgcrypt, Bug Report.
Mar 6 2015, 9:19 AM · Mistaken, Bug Report, libgcrypt
JW set Version to 1.6.3 on T1909: bench-slope.c: potential buffer overflows.
Mar 6 2015, 9:16 AM · Mistaken, Bug Report, libgcrypt
JW added projects to T1909: bench-slope.c: potential buffer overflows: libgcrypt, Bug Report.
Mar 6 2015, 9:16 AM · Mistaken, Bug Report, libgcrypt
JW added projects to T1908: t-ed25519.c: dereference of null pointer: libgcrypt, Bug Report.
Mar 6 2015, 9:14 AM · Mistaken, Bug Report, libgcrypt
JW set Version to 1.6.3 on T1908: t-ed25519.c: dereference of null pointer.
Mar 6 2015, 9:14 AM · Mistaken, Bug Report, libgcrypt
JW added projects to T1907: basic.c: function call argument is an uninitialized value: libgcrypt, Bug Report.
Mar 6 2015, 9:12 AM · Mistaken, Bug Report, libgcrypt
JW set Version to 1.6.3 on T1907: basic.c: function call argument is an uninitialized value.
Mar 6 2015, 9:12 AM · Mistaken, Bug Report, libgcrypt
JW added projects to T1906: tsexp.c: null pointer passed as an argument to a 'nonnull' parameter: libgcrypt, Bug Report.
Mar 6 2015, 9:10 AM · Mistaken, Bug Report, libgcrypt
JW set Version to 1.6.3 on T1906: tsexp.c: null pointer passed as an argument to a 'nonnull' parameter.
Mar 6 2015, 9:10 AM · Mistaken, Bug Report, libgcrypt
JW set Version to 1.6.3 on T1905: hmac256.c: use of memory after it is freed (redux).
Mar 6 2015, 9:09 AM · Mistaken, Bug Report, libgcrypt
JW added projects to T1905: hmac256.c: use of memory after it is freed (redux): libgcrypt, Bug Report.
Mar 6 2015, 9:09 AM · Mistaken, Bug Report, libgcrypt
JW added projects to T1904: hmac256.c: use of memory after it is freed: libgcrypt, Bug Report.
Mar 6 2015, 9:04 AM · Mistaken, Bug Report, libgcrypt
JW set Version to 1.6.3 on T1904: hmac256.c: use of memory after it is freed.
Mar 6 2015, 9:04 AM · Mistaken, Bug Report, libgcrypt
JW added projects to T1903: ecc-eddsa.c: function call argument is an uninitialized value: libgcrypt, Bug Report.
Mar 6 2015, 9:03 AM · Mistaken, Bug Report, libgcrypt
JW set Version to 1.6.3 on T1903: ecc-eddsa.c: function call argument is an uninitialized value.
Mar 6 2015, 9:03 AM · Mistaken, Bug Report, libgcrypt
JW added projects to T1902: ecc-curves.c: dereference of null pointer: gpgrt, Bug Report.
Mar 6 2015, 9:02 AM · Mistaken, Bug Report, gpgrt
JW set Version to 1.6.3 on T1902: ecc-curves.c: dereference of null pointer.
Mar 6 2015, 9:02 AM · Mistaken, Bug Report, gpgrt
JW added a project to T1901: seed.c: the right operand of '^' is a garbage value: libgcrypt.
Mar 6 2015, 9:00 AM · Won't Fix, libgcrypt
JW set Version to 1.6.3 on T1901: seed.c: the right operand of '^' is a garbage value.
Mar 6 2015, 9:00 AM · Won't Fix, libgcrypt
JW set Version to 1.6.3 on T1900: des.c: the right operand of '^' is a garbage value.
Mar 6 2015, 8:58 AM · Mistaken, libgcrypt
JW added a project to T1900: des.c: the right operand of '^' is a garbage value: libgcrypt.
Mar 6 2015, 8:58 AM · Mistaken, libgcrypt
JW set Version to 1.6.3 on T1899: primegen.c: uses is_locked, which appears to suffer a race.
Mar 6 2015, 8:54 AM · Not A Bug, libgcrypt
JW added a project to T1899: primegen.c: uses is_locked, which appears to suffer a race: libgcrypt.
Mar 6 2015, 8:54 AM · Not A Bug, libgcrypt
JW set Version to 1.6.3 on T1898: md.c: null pointer passed as an argument to a 'nonnull' parameter.
Mar 6 2015, 8:50 AM · Mistaken, Bug Report, libgcrypt
JW added projects to T1898: md.c: null pointer passed as an argument to a 'nonnull' parameter: libgcrypt, Bug Report.
Mar 6 2015, 8:50 AM · Mistaken, Bug Report, libgcrypt
JW added projects to T1897: cipher.c: null pointer passed as an argument to a 'nonnull' parameter: libgcrypt, Bug Report.
Mar 6 2015, 8:48 AM · Mistaken, Bug Report, libgcrypt
JW set Version to 1.6.3 on T1897: cipher.c: null pointer passed as an argument to a 'nonnull' parameter.
Mar 6 2015, 8:48 AM · Mistaken, Bug Report, libgcrypt
JW set Version to 1.6.3 on T1896: mpiutil.c: potential null pointer dereferences.
Mar 6 2015, 8:47 AM · Mistaken, Bug Report, libgcrypt
JW added projects to T1896: mpiutil.c: potential null pointer dereferences: libgcrypt, Bug Report.
Mar 6 2015, 8:47 AM · Mistaken, Bug Report, libgcrypt
JW added projects to T1895: mpicoder.c: null pointer dereference: libgcrypt, Bug Report.
Mar 6 2015, 8:43 AM · Mistaken, Bug Report, libgcrypt
JW set Version to 1.6.3 on T1895: mpicoder.c: null pointer dereference.
Mar 6 2015, 8:43 AM · Mistaken, Bug Report, libgcrypt
JW renamed T1885: yat2m.c: null pointer passed as an argument to a 'nonnull' parameter from Null pointer passed as an argument to a 'nonnull' parameter to yat2m.c: null pointer passed as an argument to a 'nonnull' parameter.
Mar 6 2015, 8:37 AM · Bug Report, gpgrt
JW renamed T1886: yat2m.c: null pointer passed as an argument to a 'nonnull' parameter from Null pointer passed as an argument to a 'nonnull' parameter to yat2m.c: null pointer passed as an argument to a 'nonnull' parameter.
Mar 6 2015, 8:36 AM · Mistaken, Bug Report, gpgrt
JW renamed T1887: assuan-buffer.c: dereference of null pointer from Dereference of null pointer to assuan-buffer.c: dereference of null pointer.
Mar 6 2015, 8:36 AM · Mistaken, Bug Report, libassuan
JW renamed T1888: der-encoder.c: dereference of null pointer from Dereference of a null pointer to der-encoder.c: dereference of null pointer.
Mar 6 2015, 8:36 AM · Mistaken, Bug Report, libksba