Setting to resolved, as I think it should be

https://invent.kde.org/pim/kleopatra/-/merge_requests/428

for clarity: the current "password based encryption only" and "public key encryption only" are not about defaults, but completely disable the respective functionality. should they really be under "Sign/Encrypt defaults"?

I can't reproduce your problems. Can you get me the exact test files you used?

yes, it seems to be caused by one of the patches. I'm trying to figure out which one...

I can reproduce on windows. It's not that the Button itself needs to be pressed twice, *something* in the dialog needs to be pressed before the button reacts. So this looks like it's something about focus

Done now, sorry for the confusion around the contructor

as far as i can tell (and remember), I haven't implemented Ingo's suggestions. I'm putting the ticket back in the backlog and on my TODO list

In D618#6752, @ikloecker wrote:

In D618#6745, @TobiasFella wrote:

@ikloecker would there be any ABI problems with adding the new virtual function here?

Instead of adding new virtuals I have added non-virtual functions that call virtual private functions (NVI pattern). Job has a proper d-pointer since QGpgME 2.0 so this is the way you should go, i.e. add a DeleteJobPrivate. There are plenty of *JobPrivate classes to c&p from.

@ikloecker would there be any ABI problems with adding the new virtual function here?