Page MenuHome GnuPG

gpgrtProject
ActivePublic

Members

  • This project does not have any members.
  • View All

Watchers

  • This project does not have any watchers.
  • View All

Recent Activity

Tue, Apr 20

gniibe closed T5293: gpg-error.m4 should search gpg-error.pc under the paths of gpgrt-config as Resolved.
Tue, Apr 20, 2:36 AM · gpgrt

Fri, Apr 16

werner added a comment to T5048: Error handling in libassuan.

(sorry, about my former comment, I only now realized that you did just that already in your original patch)

Fri, Apr 16, 10:03 AM · gpgrt, libassuan
gniibe added a comment to T5048: Error handling in libassuan.

Updated:

diff --git a/configure.ac b/configure.ac
index 53a343b..f496729 100644
--- a/configure.ac
+++ b/configure.ac
@@ -82,6 +82,7 @@ AC_PROG_AWK
 AC_CHECK_TOOL(AR, ar, :)
 AC_USE_SYSTEM_EXTENSIONS
Fri, Apr 16, 8:50 AM · gpgrt, libassuan
werner added a comment to T5048: Error handling in libassuan.

I guess the strcasecmp (nl_langinfo (CODESET), "UTF-8") results in some overhead, so if we do that what about kicking in only if a truncation is really to happen.

Fri, Apr 16, 8:26 AM · gpgrt, libassuan
gniibe added a project to T5048: Error handling in libassuan: gpgrt.
Fri, Apr 16, 3:56 AM · gpgrt, libassuan

Thu, Apr 15

gniibe closed T5296: libgpg-error: build failure without threads as Resolved.
Thu, Apr 15, 4:18 AM · gpgrt, Bug Report

Apr 12 2021

gniibe changed the status of T5365: --with-libgpg-error-prefix doesn't affect gpgrt-config path detection from Open to Testing.
Apr 12 2021, 6:13 AM · Testing, MacOS, gpgrt, Cross-Compiler, libgcrypt
gniibe closed T5381: libgpg-error coverity static analysis reports as Resolved.

Thank you for your publishing your key of CB6BE1D0D7D1594A.
I applied and pushed your changes.

Apr 12 2021, 6:08 AM · gpgrt, Bug Report

Apr 9 2021

gniibe added a comment to T5381: libgpg-error coverity static analysis reports.

Thanks. Note, that the same code is in gnupg2 in common/exechelp-posix.c:736

Apr 9 2021, 1:45 AM · gpgrt, Bug Report

Apr 8 2021

Jakuje added a comment to T5381: libgpg-error coverity static analysis reports.

For gpgrt_wait_processes, I modified it to skip invalid PID.
The change is: rE956c40f106ea: core: Fix gpgrt_wait_processes, by skipping invalid PID.

Apr 8 2021, 9:33 AM · gpgrt, Bug Report
gniibe added a comment to T5381: libgpg-error coverity static analysis reports.

For gpgrt_wait_processes, I modified it to skip invalid PID.
The change is: rE956c40f106ea: core: Fix gpgrt_wait_processes, by skipping invalid PID.

Apr 8 2021, 4:26 AM · gpgrt, Bug Report

Apr 7 2021

Jakuje added a comment to T5381: libgpg-error coverity static analysis reports.

Thanks. I understand that this is no big issue in the test code, but half of the code paths have proper cleaning already so fixing it once should save anyone in the future going through the same issues over and over again during our releases or anyone else who would run your code through static analyzer.

Apr 7 2021, 11:56 AM · gpgrt, Bug Report
gniibe added a comment to T5381: libgpg-error coverity static analysis reports.

Thank you.
For get_attr_l, I pushed a fix as rE89a353f418f5: build: Fix gpgrt-config for handling 'Requires' field.

Apr 7 2021, 10:25 AM · gpgrt, Bug Report

Apr 6 2021

werner added a project to T5381: libgpg-error coverity static analysis reports: gpgrt.

Actually I don't care about releasing resources for regression test failures.
The other missing free is for code which is commented out (#if 0) but should eventually be fixed.

Apr 6 2021, 11:29 PM · gpgrt, Bug Report

Apr 1 2021

gniibe closed T5289: gen-lock-obj.sh uses echo -n from /bin/sh, which echos "-n" as Resolved.

Fixed in 1.42.

Apr 1 2021, 5:58 AM · MacOS, gpgrt, Bug Report

Mar 31 2021

gniibe added a comment to T5365: --with-libgpg-error-prefix doesn't affect gpgrt-config path detection.

I was wrong in my last comment. Escaping by another \ is needed.

Mar 31 2021, 4:09 AM · Testing, MacOS, gpgrt, Cross-Compiler, libgcrypt

Mar 30 2021

werner added a comment to T5365: --with-libgpg-error-prefix doesn't affect gpgrt-config path detection.

A PATH with spaces is too Windowish (or macOS). IIRC, we had once checks that the used directories have proper names; we can expect this for build environment. Spaces in file names are horrible from a security POV it is just to easy to get things wrong (hello ssh).

Mar 30 2021, 5:15 PM · Testing, MacOS, gpgrt, Cross-Compiler, libgcrypt
saurik added a comment to T5365: --with-libgpg-error-prefix doesn't affect gpgrt-config path detection.

@gniibe Note that you also need to at least add the semicolons, as BSD sed is trying to parse "gp}" as substitution flags (which, honestly, makes more forward-compatible sense than GNU sed's behavior...).

Mar 30 2021, 10:35 AM · Testing, MacOS, gpgrt, Cross-Compiler, libgcrypt
gniibe added a comment to T5365: --with-libgpg-error-prefix doesn't affect gpgrt-config path detection.

Or, if we keep the code of newline (so that it will eventually support path with a space in future):

Mar 30 2021, 9:55 AM · Testing, MacOS, gpgrt, Cross-Compiler, libgcrypt
gniibe added a comment to T5365: --with-libgpg-error-prefix doesn't affect gpgrt-config path detection.

Thank you. Sorry for the use of GNU sed extension. It could be just a whitespace, if it's OK not to support path having a space.
sed -n -e "/^libraries/{s/libraries: =//;s/:/ /gp}") should work.

Mar 30 2021, 9:42 AM · Testing, MacOS, gpgrt, Cross-Compiler, libgcrypt
saurik added a comment to T5365: --with-libgpg-error-prefix doesn't affect gpgrt-config path detection.

@gniibe OK, so... "worst case": I guess this worked? ;P

Mar 30 2021, 8:23 AM · Testing, MacOS, gpgrt, Cross-Compiler, libgcrypt
saurik added a comment to T5365: --with-libgpg-error-prefix doesn't affect gpgrt-config path detection.

@gniibe Actually, I just realized that neither of the commands I provided work, as I failed to notice you were trying to also replace :'s with newlines (as I guess libraries from clang can return multiple paths). I'd momentarily edited my comment to just try to add back your colon replacement, before remembering you can't do that either: \n is a GNU sed extension. Hilariously, I'm always in contexts where I can assume I'm using bash (which isn't ok for configure), so I've never bothered to learn a technique that doesn't involve $'\n'... do you have a strategy for doing this replacement? :(

Mar 30 2021, 8:19 AM · Testing, MacOS, gpgrt, Cross-Compiler, libgcrypt
saurik updated the task description for T5365: --with-libgpg-error-prefix doesn't affect gpgrt-config path detection.
Mar 30 2021, 8:14 AM · Testing, MacOS, gpgrt, Cross-Compiler, libgcrypt
saurik added a comment to T5365: --with-libgpg-error-prefix doesn't affect gpgrt-config path detection.

@gniibe Ah yeah, that was the commit I meant to reference when I said "--maybe caused by --", but then forgot to go back and fill in the commit hash ;P.

Mar 30 2021, 8:10 AM · Testing, MacOS, gpgrt, Cross-Compiler, libgcrypt
gniibe added a comment to T5365: --with-libgpg-error-prefix doesn't affect gpgrt-config path detection.

I wonder if this works in your use case:

diff --git a/m4/gpg-error.m4 b/m4/gpg-error.m4
index d910754e..aeedaf10 100644
--- a/m4/gpg-error.m4
+++ b/m4/gpg-error.m4
@@ -65,7 +65,7 @@ AC_DEFUN([AM_PATH_GPG_ERROR],
   min_gpg_error_version=ifelse([$1], ,1.33,$1)
   ok=no
Mar 30 2021, 7:36 AM · Testing, MacOS, gpgrt, Cross-Compiler, libgcrypt
gniibe added a comment to T5365: --with-libgpg-error-prefix doesn't affect gpgrt-config path detection.

If it is new, it may be the change of this commit rC8e3cd4c4677c: build: Update gpg-error.m4.

Mar 30 2021, 7:22 AM · Testing, MacOS, gpgrt, Cross-Compiler, libgcrypt
saurik added a comment to T5365: --with-libgpg-error-prefix doesn't affect gpgrt-config path detection.

(To be clear, I also know enough about autoconf to not have been like, blocked from upgrading by this: overriding ac_cv_path_GPGRT_CONFIG worked, but I can't believe that's the intended way for someone to ensure they get the correct path for gpgrt-config ;P.)

Mar 30 2021, 6:53 AM · Testing, MacOS, gpgrt, Cross-Compiler, libgcrypt
saurik added a comment to T5365: --with-libgpg-error-prefix doesn't affect gpgrt-config path detection.

@gniibe The problem is that the check seems to just find gpgrt-config from the path; like, I'm already passing --prefix and --host, but it is deciding to just arbitrarily pick up my system-wide copy of /usr/local/bin/gpgrt-config. Here's my entire configure invocation from that earlier failed build: note that the --prefix is the same as --with-gpg-error-prefix.

Mar 30 2021, 6:43 AM · Testing, MacOS, gpgrt, Cross-Compiler, libgcrypt
gniibe triaged T5365: --with-libgpg-error-prefix doesn't affect gpgrt-config path detection as Normal priority.

We are in transition from old gpg-error-config to new gpgrt-config. <-- This is the cause, while I tried to cover most use cases.

Mar 30 2021, 4:19 AM · Testing, MacOS, gpgrt, Cross-Compiler, libgcrypt

Mar 26 2021

werner assigned T5365: --with-libgpg-error-prefix doesn't affect gpgrt-config path detection to gniibe.
Mar 26 2021, 10:47 AM · Testing, MacOS, gpgrt, Cross-Compiler, libgcrypt

Mar 22 2021

werner closed T5194: Release libgpg-error 1.42 as Resolved.
Mar 22 2021, 1:39 PM · gpgrt, Release Info
werner triaged T5352: Release libgpg-error 1.43 as Low priority.
Mar 22 2021, 11:52 AM · Release Info, gpgrt

Feb 18 2021

gniibe changed the status of T5296: libgpg-error: build failure without threads from Open to Testing.

Pushed the change. Please test.

Feb 18 2021, 2:24 AM · gpgrt, Bug Report
gniibe added a comment to T5296: libgpg-error: build failure without threads.

See the comment in rE13918d05a333: Allow building with --disable-threads. for ABI incompatibility.

Feb 18 2021, 2:24 AM · gpgrt, Bug Report

Feb 17 2021

gniibe added a comment to T5296: libgpg-error: build failure without threads.

When building with no threads support, I think that generating same lock-obj-pub-$host.h is just possible by this change.

Feb 17 2021, 4:33 AM · gpgrt, Bug Report

Feb 16 2021

gniibe added a comment to T5296: libgpg-error: build failure without threads.

Tell us the architecture(s) which doesn't support POSIX threads by uClibc.
Adding support for such an architecture would be the best.

Feb 16 2021, 5:09 AM · gpgrt, Bug Report
gniibe added a comment to T5296: libgpg-error: build failure without threads.

Sorry, I was assuming uClibc were not supporting POSIX threads.

Feb 16 2021, 4:49 AM · gpgrt, Bug Report

Feb 15 2021

gniibe added a comment to T5296: libgpg-error: build failure without threads.

Thank you for more information.

Feb 15 2021, 11:24 PM · gpgrt, Bug Report
ffontaine added a comment to T5296: libgpg-error: build failure without threads.

I was not the author of the host "hacking" which has been committed to buildroot in 2016 by https://git.buildroot.net/buildroot/commit/package/?id=2f89476ad98b82ea9f914337b0050c4808082c82 so I can't really comment on it.
You can find more information here: https://patchwork.ozlabs.org/project/buildroot/patch/1451762923-15985-1-git-send-email-joerg.krause@embedded.rocks/
Especially, it seems that Jörg Krause started a discussion about this issue and proposed a patch to fix the architecture depends but it was never applied. Unfortunately, I wasn't able to find more information as it seems that links on comments.gmane.org are broken ...

Feb 15 2021, 9:03 AM · gpgrt, Bug Report
gniibe added a comment to T5296: libgpg-error: build failure without threads.

Please note that the result with --host="arm-unknown-linux-gnueabi" for linux-uclibcgnueabih machine is different to the one of correctly generated version by gen-posix-lock-obj.c with USE_POSIX_THREADS undefined on the host.

Feb 15 2021, 8:42 AM · gpgrt, Bug Report
gniibe added a comment to T5293: gpg-error.m4 should search gpg-error.pc under the paths of gpgrt-config.

I found that the use of $CC -print-file-name=crt1.o won't work with some cross compiler.
For example, on my system of Debian bullseye for cross compiler ppc64el, while it's for multiarch configuration, crt1.o is under GNU cross style directory: /usr/powerpc64le-linux-gnu/lib

Feb 15 2021, 8:38 AM · gpgrt
gniibe added a comment to T5296: libgpg-error: build failure without threads.

I would understand your workaorund of using artifical --host intentionally.

Feb 15 2021, 8:26 AM · gpgrt, Bug Report
ffontaine added a comment to T5296: libgpg-error: build failure without threads.

This won't work in the context of buildroot as we're passing --host="arm-unknown-linux-gnueabi" to avoid the following build failure:

Feb 15 2021, 8:12 AM · gpgrt, Bug Report
gniibe added a comment to T5293: gpg-error.m4 should search gpg-error.pc under the paths of gpgrt-config.

We also need to support the use case of GNU cross style, like when we build with MinGW toolchain.

Feb 15 2021, 7:22 AM · gpgrt
gniibe added a comment to T5293: gpg-error.m4 should search gpg-error.pc under the paths of gpgrt-config.

For other libraries, like libgcrypt, it is mostly OK with old gpg-error.m4, because those libraries don't depend on new libgpg-error features.

Feb 15 2021, 2:44 AM · gpgrt
gniibe added a comment to T5293: gpg-error.m4 should search gpg-error.pc under the paths of gpgrt-config.

Fixed GnuPG in rGe1e3f1db4660: build: Update gpg-error.m4. and rG985e85dc0e6c: build: Update gpg-error.m4..

Feb 15 2021, 2:40 AM · gpgrt
gniibe added a comment to T5293: gpg-error.m4 should search gpg-error.pc under the paths of gpgrt-config.

Fixed more in rEd7fd25bbfb83: build: Fix the previous change..

Feb 15 2021, 2:39 AM · gpgrt
gniibe added a comment to T5296: libgpg-error: build failure without threads.

Thank you for the report. I had expected *-*-linux* matches only to GNU/Linux (Linux kernel with GNU C library).

Feb 15 2021, 2:36 AM · gpgrt, Bug Report
gniibe claimed T5296: libgpg-error: build failure without threads.
Feb 15 2021, 2:14 AM · gpgrt, Bug Report

Feb 13 2021

werner added a comment to T5296: libgpg-error: build failure without threads.

They are mandatory for gnupg but not for Libgcrypt and Libgpg-error. I guess we can fix that.

Feb 13 2021, 6:03 PM · gpgrt, Bug Report