Page MenuHome GnuPG

gpgrtProject
ActivePublic

Members

  • This project does not have any members.
  • View All

Watchers

  • This project does not have any watchers.
  • View All

Recent Activity

Wed, Sep 22

aconchillo added a comment to T5610: Update libtool.

Oh, you are right, it's not upstream. It's actually applied to Homebrew (https://brew.sh/) libtool formula which is where I originally got libtool.m4, see:

Wed, Sep 22, 9:06 PM · MacOS, ntbtls, npth, libksba, libassuan, libgcrypt, gpgrt
gniibe added a comment to T5610: Update libtool.

I see your point. I'd like to locate/identify where the change comes from.
I think that what you refer by "new libtool.m4" is actually macOS local change (I mean, not from libtool upstream, AFAIK).
Could you please point out the source of the change?

Wed, Sep 22, 2:01 AM · MacOS, ntbtls, npth, libksba, libassuan, libgcrypt, gpgrt

Tue, Sep 21

aconchillo added a comment to T5610: Update libtool.

That would work, however we might hit this issue with a new macOS release. Would it make more sense to update to what the new libtool.m4 is doing? Linker flags are the same, it only changes the way they detect macOS versions:

Tue, Sep 21, 8:33 PM · MacOS, ntbtls, npth, libksba, libassuan, libgcrypt, gpgrt
werner added a comment to T5610: Update libtool.

That does indeed not look like something which could introduce a regression.

Tue, Sep 21, 11:43 AM · MacOS, ntbtls, npth, libksba, libassuan, libgcrypt, gpgrt
gniibe added a comment to T5610: Update libtool.

I misunderstood as if we need to update libtool from upstream.

Tue, Sep 21, 9:16 AM · MacOS, ntbtls, npth, libksba, libassuan, libgcrypt, gpgrt
werner triaged T5610: Update libtool as Low priority.

macOS has low priority for us and I do not want to risk any regression.

Tue, Sep 21, 8:42 AM · MacOS, ntbtls, npth, libksba, libassuan, libgcrypt, gpgrt
gniibe added a comment to T5610: Update libtool.

About merging our local changes.

Tue, Sep 21, 8:11 AM · MacOS, ntbtls, npth, libksba, libassuan, libgcrypt, gpgrt
gniibe added a comment to T5610: Update libtool.

We have our own changes for ltmain.sh and libtool.m4.

Tue, Sep 21, 7:19 AM · MacOS, ntbtls, npth, libksba, libassuan, libgcrypt, gpgrt
gniibe added a comment to T5610: Update libtool.

And update from automake 1.16:

Tue, Sep 21, 7:02 AM · MacOS, ntbtls, npth, libksba, libassuan, libgcrypt, gpgrt
gniibe added a comment to T5610: Update libtool.

It's better to update the set of files from libtool:

build-aux/ltmain.sh
m4/libtool.m4
m4/ltoptions.m4
m4/ltsugar.m4
m4/ltversion.m4
m4/lt~obsolete.m4
Tue, Sep 21, 6:58 AM · MacOS, ntbtls, npth, libksba, libassuan, libgcrypt, gpgrt
gniibe added a comment to T5610: Update libtool.

Our libtool was 2.4.2 + Debian patches + our local changes.
Debian patches are:
https://salsa.debian.org/mckinstry/libtool/-/blob/debian/master/debian/patches/link_all_deplibs.patch
https://salsa.debian.org/mckinstry/libtool/-/blob/debian/master/debian/patches/netbsdelf.patch

Tue, Sep 21, 6:57 AM · MacOS, ntbtls, npth, libksba, libassuan, libgcrypt, gpgrt
gniibe created T5610: Update libtool.
Tue, Sep 21, 6:33 AM · MacOS, ntbtls, npth, libksba, libassuan, libgcrypt, gpgrt

Fri, Sep 10

ikloecker added a comment to T5595: gpgrt-config doesn't work well with PKG_CONFIG_LIBDIR="" and setting PKG_CONFIG_PATH.

The fix works for me (using bash on openSUSE Tumbleweed).

Fri, Sep 10, 12:26 PM · Testing, gpgrt
gniibe changed the status of T5595: gpgrt-config doesn't work well with PKG_CONFIG_LIBDIR="" and setting PKG_CONFIG_PATH from Open to Testing.
Fri, Sep 10, 3:00 AM · Testing, gpgrt

Thu, Sep 9

gniibe added a comment to T5595: gpgrt-config doesn't work well with PKG_CONFIG_LIBDIR="" and setting PKG_CONFIG_PATH.

Here is a possible fix:

Thu, Sep 9, 12:36 PM · Testing, gpgrt
gniibe triaged T5595: gpgrt-config doesn't work well with PKG_CONFIG_LIBDIR="" and setting PKG_CONFIG_PATH as High priority.
Thu, Sep 9, 12:33 PM · Testing, gpgrt

Mon, Aug 30

gniibe closed T5365: --with-libgpg-error-prefix doesn't affect gpgrt-config path detection as Resolved.
Mon, Aug 30, 7:05 AM · MacOS, gpgrt, Cross-Compiler, libgcrypt

Aug 26 2021

gniibe closed T5547: Single thread support with newer GNU C library (2.34 or later) as Resolved.

Added a test, and tested with glibc 2.32 by manual editing config.h for USE_POSIX_THREADS_FROM_LIBC.
Works correctly.

Aug 26 2021, 6:37 AM · gpgrt

Aug 23 2021

pert added a comment to T5135: Provide more practical thread-safe strerror, perhaps with strerror_l.

Actually, I think there's a way to make gpg_strerror_r more usable on its own. I previously said

I find it quite difficult to use strerror_r and gpg_strerror_r. With having to guess and retry to get an appropriate buffer length, a wrapper which dynamically allocates the string seems to be needed.

Aug 23 2021, 7:47 PM · gpgrt, Feature Request

Aug 13 2021

werner changed the edit policy for gpgrt.
Aug 13 2021, 11:04 PM
werner changed the edit policy for T5352: Release libgpg-error 1.43.
Aug 13 2021, 11:57 AM · gpgrt, Release Info
werner updated subscribers of T5352: Release libgpg-error 1.43.
Aug 13 2021, 11:57 AM · gpgrt, Release Info
werner placed T5352: Release libgpg-error 1.43 up for grabs.
Aug 13 2021, 11:57 AM · gpgrt, Release Info

Aug 6 2021

gniibe renamed T5547: Single thread support with newer GNU C library (2.34 or later) from Single thread support with newer GNU C library (2.32 or later) to Single thread support with newer GNU C library (2.34 or later).
Aug 6 2021, 9:19 AM · gpgrt
gniibe claimed T5547: Single thread support with newer GNU C library (2.34 or later).
Aug 6 2021, 9:19 AM · gpgrt
gniibe added a comment to T5547: Single thread support with newer GNU C library (2.34 or later).

Here is the documentation of the new way of single-threaded execution:
https://www.gnu.org/software/libc/manual/html_node/Single_002dThreaded.html

Aug 6 2021, 4:17 AM · gpgrt

Aug 5 2021

gniibe added a comment to T5547: Single thread support with newer GNU C library (2.34 or later).

We also need to update m4/threadlib.m4.
Now, it's maintained in gnulib.
See the changes in:
https://git.savannah.gnu.org/gitweb/?p=gnulib.git;a=commitdiff;h=12b5b00f93c6433c3df8176fc9674d7600f8b268

Aug 5 2021, 8:53 AM · gpgrt
gniibe edited projects for T5547: Single thread support with newer GNU C library (2.34 or later), added: gpgrt; removed libgcrypt.
Aug 5 2021, 8:34 AM · gpgrt

Jun 8 2021

gniibe closed T5048: Error handling in libassuan as Resolved.

Applied and pushed.

Jun 8 2021, 8:11 AM · gpgrt, libassuan

Apr 20 2021

gniibe closed T5293: gpg-error.m4 should search gpg-error.pc under the paths of gpgrt-config as Resolved.
Apr 20 2021, 2:36 AM · gpgrt

Apr 16 2021

werner added a comment to T5048: Error handling in libassuan.

(sorry, about my former comment, I only now realized that you did just that already in your original patch)

Apr 16 2021, 10:03 AM · gpgrt, libassuan
gniibe added a comment to T5048: Error handling in libassuan.

Updated:

diff --git a/configure.ac b/configure.ac
index 53a343b..f496729 100644
--- a/configure.ac
+++ b/configure.ac
@@ -82,6 +82,7 @@ AC_PROG_AWK
 AC_CHECK_TOOL(AR, ar, :)
 AC_USE_SYSTEM_EXTENSIONS
Apr 16 2021, 8:50 AM · gpgrt, libassuan
werner added a comment to T5048: Error handling in libassuan.

I guess the strcasecmp (nl_langinfo (CODESET), "UTF-8") results in some overhead, so if we do that what about kicking in only if a truncation is really to happen.

Apr 16 2021, 8:26 AM · gpgrt, libassuan
gniibe added a project to T5048: Error handling in libassuan: gpgrt.
Apr 16 2021, 3:56 AM · gpgrt, libassuan

Apr 15 2021

gniibe closed T5296: libgpg-error: build failure without threads as Resolved.
Apr 15 2021, 4:18 AM · gpgrt, Bug Report

Apr 12 2021

gniibe changed the status of T5365: --with-libgpg-error-prefix doesn't affect gpgrt-config path detection from Open to Testing.
Apr 12 2021, 6:13 AM · MacOS, gpgrt, Cross-Compiler, libgcrypt
gniibe closed T5381: libgpg-error coverity static analysis reports as Resolved.

Thank you for your publishing your key of CB6BE1D0D7D1594A.
I applied and pushed your changes.

Apr 12 2021, 6:08 AM · gpgrt, Bug Report

Apr 9 2021

gniibe added a comment to T5381: libgpg-error coverity static analysis reports.

Thanks. Note, that the same code is in gnupg2 in common/exechelp-posix.c:736

Apr 9 2021, 1:45 AM · gpgrt, Bug Report

Apr 8 2021

Jakuje added a comment to T5381: libgpg-error coverity static analysis reports.

For gpgrt_wait_processes, I modified it to skip invalid PID.
The change is: rE956c40f106ea: core: Fix gpgrt_wait_processes, by skipping invalid PID.

Apr 8 2021, 9:33 AM · gpgrt, Bug Report
gniibe added a comment to T5381: libgpg-error coverity static analysis reports.

For gpgrt_wait_processes, I modified it to skip invalid PID.
The change is: rE956c40f106ea: core: Fix gpgrt_wait_processes, by skipping invalid PID.

Apr 8 2021, 4:26 AM · gpgrt, Bug Report

Apr 7 2021

Jakuje added a comment to T5381: libgpg-error coverity static analysis reports.

Thanks. I understand that this is no big issue in the test code, but half of the code paths have proper cleaning already so fixing it once should save anyone in the future going through the same issues over and over again during our releases or anyone else who would run your code through static analyzer.

Apr 7 2021, 11:56 AM · gpgrt, Bug Report
gniibe added a comment to T5381: libgpg-error coverity static analysis reports.

Thank you.
For get_attr_l, I pushed a fix as rE89a353f418f5: build: Fix gpgrt-config for handling 'Requires' field.

Apr 7 2021, 10:25 AM · gpgrt, Bug Report

Apr 6 2021

werner added a project to T5381: libgpg-error coverity static analysis reports: gpgrt.

Actually I don't care about releasing resources for regression test failures.
The other missing free is for code which is commented out (#if 0) but should eventually be fixed.

Apr 6 2021, 11:29 PM · gpgrt, Bug Report

Apr 1 2021

gniibe closed T5289: gen-lock-obj.sh uses echo -n from /bin/sh, which echos "-n" as Resolved.

Fixed in 1.42.

Apr 1 2021, 5:58 AM · MacOS, gpgrt, Bug Report

Mar 31 2021

gniibe added a comment to T5365: --with-libgpg-error-prefix doesn't affect gpgrt-config path detection.

I was wrong in my last comment. Escaping by another \ is needed.

Mar 31 2021, 4:09 AM · MacOS, gpgrt, Cross-Compiler, libgcrypt

Mar 30 2021

werner added a comment to T5365: --with-libgpg-error-prefix doesn't affect gpgrt-config path detection.

A PATH with spaces is too Windowish (or macOS). IIRC, we had once checks that the used directories have proper names; we can expect this for build environment. Spaces in file names are horrible from a security POV it is just to easy to get things wrong (hello ssh).

Mar 30 2021, 5:15 PM · MacOS, gpgrt, Cross-Compiler, libgcrypt
saurik added a comment to T5365: --with-libgpg-error-prefix doesn't affect gpgrt-config path detection.

@gniibe Note that you also need to at least add the semicolons, as BSD sed is trying to parse "gp}" as substitution flags (which, honestly, makes more forward-compatible sense than GNU sed's behavior...).

Mar 30 2021, 10:35 AM · MacOS, gpgrt, Cross-Compiler, libgcrypt
gniibe added a comment to T5365: --with-libgpg-error-prefix doesn't affect gpgrt-config path detection.

Or, if we keep the code of newline (so that it will eventually support path with a space in future):

Mar 30 2021, 9:55 AM · MacOS, gpgrt, Cross-Compiler, libgcrypt
gniibe added a comment to T5365: --with-libgpg-error-prefix doesn't affect gpgrt-config path detection.

Thank you. Sorry for the use of GNU sed extension. It could be just a whitespace, if it's OK not to support path having a space.
sed -n -e "/^libraries/{s/libraries: =//;s/:/ /gp}") should work.

Mar 30 2021, 9:42 AM · MacOS, gpgrt, Cross-Compiler, libgcrypt
saurik added a comment to T5365: --with-libgpg-error-prefix doesn't affect gpgrt-config path detection.

@gniibe OK, so... "worst case": I guess this worked? ;P

Mar 30 2021, 8:23 AM · MacOS, gpgrt, Cross-Compiler, libgcrypt