ecc: Improve new ECDH API.
a658c9ccc2c7
Actions

Description

ecc: Improve new ECDH API.

* cipher/ecc-ecdh.c (_gcry_ecc_get_algo_keylen): New.
(_gcry_ecc_mul_point): Fill into the RESULT buffer, instead of
allocating new buffer.
* src/gcrypt-int.h: Change the API.
* src/gcrypt.h.in: Likewise.
* src/libgcrypt.def (gcry_ecc_get_algo_keylen): New.
* src/libgcrypt.vers (gcry_ecc_get_algo_keylen): New.
* src/visibility.c (gcry_ecc_get_algo_keylen): New.
* src/visibility.h (gcry_ecc_get_algo_keylen): New.
* tests/t-cv25519.c: Fix the use case.

Signed-off-by: NIIBE Yutaka <gniibe@fsij.org>

Details

Provenance

• gniibe

Authored on Jun 21 2019, 4:47 AM

Parents

rC6d77c2054ea0: ecc: X25519 API change to allow NULL for POINT.

Branches

Unknown

Tags

Unknown

Event Timeline

• gniibe committed rCa658c9ccc2c7: ecc: Improve new ECDH API. (authored by • gniibe).Jun 21 2019, 4:47 AM

jukivili added a subscriber: jukivili.Jun 21 2019, 10:09 AM

jukivili added inline comments.

/cipher/ecc-ecdh.c
58	Should we check if "algo == GCRY_ECC_CURVE448" here and if not, return zero?
88	Should we check if "algo == GCRY_ECC_CURVE448"? Then return invalid algorithm error code if it isn't.