Page MenuHome GnuPG
Differential D488

gpg: add the --delete-secret-key-stubs command
AbandonedPublic
Actions

Authored by matheusmoreira on May 8 2019, 11:53 PM.

Details

Reviewers
None
Maniphest Tasks
T4544: More prompts before key deletion
T4457: Improve deletion of secret subkeys (don't delete primary key when subkey deletion is requested)
Commits
rKLEOPATRA5e9d402be380: Yet another place with deprecated API
Summary
  • g10/gpg.c (cmd_and_opt_values): Add delete-secret-key-stubs command.

(opts): Add delete-secret-key-stubs argparse option.
(main): Parse and invoke the delete-secret-key-stubs command.

  • g10/main.h (delete_keys): Add the stubs_only parameter.
  • g10/delkey.c (delete_keys): Likewise.

(do_delete_key): Likewise.
(gpg_agent_delete_secret_key): Likewise.

  • g10/call-agent.h (agent_delete_key): Likewise.
  • g10/call-agent.c (agent_delete_key): Pass --stub-only to gpg agent.
  • po/pt.po: Translate delete-secret-key-stubs command description.
  • doc/gpg.texi: Document the delete-secret-key-stubs command.

The new --delete-secret-key-stubs command provides access to
the --stub-only option of the gpg agent's DELETE_KEY command.

Signed-off-by: Matheus Afonso Martins Moreira <matheus.a.m.moreira@gmail.com>

Test Plan

The --delete-secret-key-stubs command should delete key stubs and fail when invoked on any normal key.

Diff Detail

Repository
rG GnuPG
Lint
Lint Skipped
Unit
Unit Tests Skipped

Event Timeline

matheusmoreira created this revision.May 8 2019, 11:53 PM
matheusmoreira added a parent revision: D487: gpg: don't delete any keys if --dry-run is passed.
matheusmoreira added a child revision: D489: po: add portuguese translation for the new command.May 8 2019, 11:56 PM
matheusmoreira added a task: T4457: Improve deletion of secret subkeys (don't delete primary key when subkey deletion is requested).May 8 2019, 11:59 PM
matheusmoreira updated this revision to Diff 1383.May 22 2019, 2:27 AM

Rebased on top of master: 4c7d63cd5b02

matheusmoreira edited parent revisions, added: D485: gpg: add the --delete-secret-subkeys command; removed: D487: gpg: don't delete any keys if --dry-run is passed.May 22 2019, 2:39 AM
matheusmoreira added a task: T4544: More prompts before key deletion.May 28 2019, 5:39 PM
matheusmoreira mentioned this in D489: po: add portuguese translation for the new command.May 28 2019, 5:41 PM
matheusmoreira updated this revision to Diff 1396.May 28 2019, 5:52 PM
matheusmoreira edited the summary of this revision. (Show Details)
matheusmoreira edited child revisions, added: D481: gpg: confirm deletion of each key individually; removed: D489: po: add portuguese translation for the new command.May 28 2019, 5:58 PM
matheusmoreira updated this revision to Diff 1400.May 29 2019, 10:05 AM
matheusmoreira edited the summary of this revision. (Show Details)

Add documentation.

matheusmoreira abandoned this revision.Jun 6 2019, 3:23 AM

New commands can't be introduced.

• Fred23 added a commit: rKLEOPATRA5e9d402be380: Yet another place with deprecated API.Jun 20 2021, 6:09 PM

Revision Contents
Changeset List

PathSize
g10/
2 lines
9 lines
31 lines
13 lines
5 lines

Diff 1383

View Options

g10/call-agent.h

Loading...
View Options

g10/call-agent.c

Loading...
View Options

g10/delkey.c

Loading...
View Options

g10/gpg.c

Loading...
View Options

g10/main.h

Loading...