Page MenuHome GnuPG
Create Task
Maniphest T5681

GpgOL: Handle GPO settings for readAsPlain
Closed, ResolvedPublic
Actions

Description

To check if we should use the plaintext body modification API in Outlook or not we use:

HKEY_CURRENT_USER\Software\Microsoft\Office\16.0\Outlook\Options\Mail "ReadAsPlain"

This is incomplete and might cause users not to be able to view the mail content as our modifications to the HTML Body are rejected even though we should handle this and fall back to plaintext in case of error. This part needs to be checked again if the error handling somehow regressed in recent versions.

Additionally we need to at least check:
HKEY_CURRENT_USER\software\policies\microsoft\office\16.0\outlook\options\mail "readasplain"

I am also pretty sure that we should additionally check HKLM in case the HKCU value is not set.

Details

Version
master

Revisions and Commits

rO GpgOL
rOd245f6513fd4 Improve ReadAsPlain detection
rO76b43345cdd3 Do not abort if updating HTML Body fails
rO23e3fd7da386 Fix fallback logic in set_body

Event Timeline

aheinecke triaged this task as High priority.Nov 11 2021, 9:59 AM
aheinecke created this task.
aheinecke set Version to master.
aheinecke added a project: Restricted Project.
aheinecke changed the task status from Open to Testing.Nov 11 2021, 2:09 PM

Tested both with the policies key and with the normal key and with HKLM fallback. Works as expected. There was also an issue where the error handling in case setting the HTML body failed did no longer work, probably since the verification preview changes. This was fixed with 76b43345cdd3e932dae7b677e5c021ca52191f8e

aheinecke added a commit: rO23e3fd7da386: Fix fallback logic in set_body.Nov 11 2021, 6:05 PM
aheinecke added a commit: rO76b43345cdd3: Do not abort if updating HTML Body fails.
aheinecke added a commit: rOd245f6513fd4: Improve ReadAsPlain detection.
aheinecke closed this task as Resolved.Aug 22 2022, 2:30 PM
• ebo moved this task from Restricted Project Column to Restricted Project Column on the Restricted Project board.Jul 24 2023, 2:12 PM