Maniphest T6534

gpg's progress_filter needs to use uint64_t
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	• werner
	Jun 12 2023, 4:23 PM

Tags

Subscribers

Description

To let the progress indicator work properly on Windows the progress filter of gpg needs to use 64 bit types and not just unsigned long. As we all known Windows uses 32 bit for long even on64 bit windows.

Revisions and Commits

rG GnuPG
	rGce0d3238f07e gpgsm: Print PROGRESS status lines.
	rGbd545346b50a gpgsm: New option --input-size-hint.
	rG1b60aab2c489 gpg: Make progress work for large files on Windows.
	rGe9c337c0b94b gpgsm: New option --input-size-hint.
	rG808494b48577 gpg: Make progress work for large files on Windows.
	rGc58067415fe9 gpgsm: Print PROGRESS status lines.
rM GPGME
	rM5811d069d3b3 qt, cpp: Support larger size-hint on 32 bit builds
	rM91bbb1e482da core: Send a input-size-hint for gpgsm.
	rM8796456d235d tests: Add option --cancel to run-encrypt.
	rMeb68948c4388 core: Use 64 bit instead of gpgme_off_t for some internal functions.

Related Objects

Mentioned In: T7189: Release GnuPG 2.5.0
T6307: Release GnuPG 2.2.42
T6363: Add progress status output to gpgtar
T6585: Release GPGME 1.21.0
T6509: Release GnuPG 2.4.3

Event Timeline

• werner triaged this task as High priority.Jun 12 2023, 4:23 PM

• werner created this task.

• werner created this object with edit policy "Contributor (Project)".

• werner added a project: Feature Request.

• werner claimed this task.Jun 13 2023, 10:07 AM

• werner moved this task from Backlog to WiP on the gnupg24 board.

We also need PROGRESS lines in gpgsm.

And of course we also need to adjust GPGME

• werner added a commit: rMeb68948c4388: core: Use 64 bit instead of gpgme_off_t for some internal functions..Jun 15 2023, 11:03 AM

• werner added a commit: rM8796456d235d: tests: Add option --cancel to run-encrypt..

• werner added a commit: rGc58067415fe9: gpgsm: Print PROGRESS status lines..Jun 15 2023, 11:17 AM

• werner added a commit: rG808494b48577: gpg: Make progress work for large files on Windows..

• werner moved this task from WiP to QA on the gnupg24 board.Jun 15 2023, 11:21 AM

• werner added a commit: rM91bbb1e482da: core: Send a input-size-hint for gpgsm..Jun 15 2023, 1:00 PM

• werner added a commit: rGe9c337c0b94b: gpgsm: New option --input-size-hint..Jun 15 2023, 2:00 PM

• aheinecke added a commit: rM5811d069d3b3: qt, cpp: Support larger size-hint on 32 bit builds.Jun 16 2023, 2:38 PM

I tested this with OpenPGP and 2.4.3-beta19 on Windows. Worked nicely.

• aheinecke closed this task as Resolved.Jul 3 2023, 2:48 PM

• werner moved this task from QA to gnupg-2.4.3 on the gnupg24 board.Jul 4 2023, 2:44 PM

• werner edited projects, added gnupg24 (gnupg-2.4.3); removed gnupg24.

• werner mentioned this in T6509: Release GnuPG 2.4.3.Jul 4 2023, 4:57 PM

• werner moved this task from Backlog to WiP on the gnupg22 board.Jul 5 2023, 11:16 AM

• werner added a commit: rG1b60aab2c489: gpg: Make progress work for large files on Windows..Jul 5 2023, 11:31 AM

• werner reopened this task as Testing.Jul 5 2023, 11:56 AM

• werner moved this task from WiP to QA on the gnupg22 board.

• werner added a commit: rGce0d3238f07e: gpgsm: Print PROGRESS status lines..Jul 5 2023, 2:30 PM

• werner added a commit: rGbd545346b50a: gpgsm: New option --input-size-hint..

• werner mentioned this in T6585: Release GPGME 1.21.0.Jul 7 2023, 2:13 PM

Was already with gpgme 1.21.0. Note that I used the done column but in future a milestone would be more useful than that catch all "done".

Still in testing mode because we need to test with gnupg 2.2.

Tested in VS-Desktop-3.2.0.0-beta214 by encrypting a large file with Kleopatra. The progress bar shows percentage finished, progress looks all right

• ebo moved this task from QA to gnupg-2.2.42 on the gnupg22 board.Sep 21 2023, 4:14 PM

• ebo edited projects, added gnupg22 (gnupg-2.2.42); removed gnupg22.

• aheinecke mentioned this in T6363: Add progress status output to gpgtar.Oct 19 2023, 1:39 PM

• werner moved this task from done to gpgme 1.23.x on the gpgme board.Oct 25 2023, 10:39 AM

• werner edited projects, added gpgme (gpgme 1.23.x); removed gpgme.

• werner mentioned this in T6307: Release GnuPG 2.2.42.Nov 28 2023, 4:59 PM

• werner mentioned this in T7189: Release GnuPG 2.5.0.Jul 5 2024, 2:42 PM