Page MenuHome GnuPG
Create Task
Maniphest T7050

Kleopatra: Exit on windows if elevated and dont ask
Testing, HighPublic
Actions

Description

If the user is elevated the two quit / close functions should behave the same.

Revisions and Commits

rKLEOPATRA Kleopatra
rKLEOPATRAca31d694351a Accept close event of main window if Kleo is run with elevated permissions
rKLEOPATRAd812c442424e Do not quit Kleopatra when user chooses to just close the main window
rKLEOPATRAb2c858895a47 Quit Kleopatra when last windows is closed for elevated users on Windows
rKLEOPATRA1c4bf2f41a54 Do not block application shutdown with a QEventLoopLocker
rKLEOPATRA57359f6296ec Do not quit Kleopatra when user chooses to just close the main window
rKLEOPATRAbff1b01a2e45 Accept close event of main window if Kleo is run with elevated permissions
rKLEOPATRAbfed041ea1b1 Do not block application shutdown with a QEventLoopLocker
rKLEOPATRA662bdc315e7a Quit Kleopatra when last windows is closed for elevated users on Windows
rKLEOPATRA51d9756abe0a Always quit on Quit for users with elevated permissions on Windows
rKLEOPATRAf7efd7d6e6b5 Always quit on Quit for users with elevated permissions on Windows

Related Objects

Event Timeline

aheinecke created this task.Mar 21 2024, 12:17 PM
aheinecke merged a task: T7049: Kleopatra: Prevent issues caused by inacessible sockets on windows.
aheinecke added subscribers: • ebo, ikloecker.
ikloecker added commits: rKLEOPATRAf7efd7d6e6b5: Always quit on Quit for users with elevated permissions on Windows, rKLEOPATRA51d9756abe0a: Always quit on Quit for users with elevated permissions on Windows.Mar 21 2024, 1:06 PM
ikloecker claimed this task.Mar 21 2024, 7:01 PM
ikloecker added projects: Restricted Project, kleopatra, vsd32.
ikloecker moved this task from Restricted Project Column to Restricted Project Column on the Restricted Project board.
aheinecke triaged this task as High priority.Mar 22 2024, 7:02 AM

Just to triage this

ikloecker added a commit: rKLEOPATRAbfed041ea1b1: Do not block application shutdown with a QEventLoopLocker.Mar 22 2024, 10:10 AM
ikloecker added a commit: rKLEOPATRA662bdc315e7a: Quit Kleopatra when last windows is closed for elevated users on Windows.
ikloecker added a commit: rKLEOPATRAbff1b01a2e45: Accept close event of main window if Kleo is run with elevated permissions.
ikloecker added a commit: rKLEOPATRA57359f6296ec: Do not quit Kleopatra when user chooses to just close the main window.
ikloecker added a commit: rKLEOPATRA1c4bf2f41a54: Do not block application shutdown with a QEventLoopLocker.Mar 22 2024, 10:18 AM
ikloecker added a commit: rKLEOPATRAca31d694351a: Accept close event of main window if Kleo is run with elevated permissions.
ikloecker added a commit: rKLEOPATRAb2c858895a47: Quit Kleopatra when last windows is closed for elevated users on Windows.
ikloecker added a commit: rKLEOPATRAd812c442424e: Do not quit Kleopatra when user chooses to just close the main window.
ikloecker changed the task status from Open to Testing.Mar 22 2024, 10:22 AM
ikloecker moved this task from Backlog to WiP on the vsd32 board.

Done and backported for 3.2.

• werner added a subscriber: • werner.Mar 26 2024, 12:51 PM

Works for me using the latest vsd beta (3.1.92.39)

• ebo moved this task from WiP to QA on the vsd32 board.Mar 27 2024, 2:36 PM
• ebo added a comment.Mar 28 2024, 2:46 PM

Yes, the kleopatra.exe process ist shut down for me with that version, too.
But I wonder if the remaining gpg-agent and scdaemon processes which remain may cause issues later on. The are still running with elevated rights according to the process explorer after restarting as normal user. It does not cause any immediately obvious issues, though.

• ebo mentioned this in T7051: Kleopatra: Defunct processes when Kleopatra is running with elevated privileges.Mar 28 2024, 4:13 PM
• werner added a comment.Fri, Apr 5, 4:05 PM

I don't see a problem here. Of course Kleopatra could run a gpgconf -K all when it really exits but I doubt that we need to do that in this special elevated case

• ebo moved this task from QA to vsd-3.2.0 on the vsd32 board.Fri, Apr 5, 4:19 PM
• ebo edited projects, added vsd32 (vsd-3.2.0); removed vsd32.