Page MenuHome GnuPG
Feed Advanced Search

Feb 28 2020

gniibe committed rG19f70b5072b2: scd: Fix the previous commit. (authored by gniibe).
scd: Fix the previous commit.
Feb 28 2020, 8:26 AM
gniibe committed rG3ba7c9bcf7f1: scd: Improve setattr for KDF. (authored by gniibe).
scd: Improve setattr for KDF.
Feb 28 2020, 8:04 AM
gniibe committed rG11da44101622: scd: Fix pinpad handling when KDF enabled. (authored by gniibe).
scd: Fix pinpad handling when KDF enabled.
Feb 28 2020, 8:04 AM

Feb 27 2020

gniibe committed rTc77450d9cbf0: build: Change NTBTLS_CONFIG_LIBS. (authored by gniibe).
build: Change NTBTLS_CONFIG_LIBS.
Feb 27 2020, 7:51 AM

Feb 25 2020

gniibe committed rA034e5450cdd5: build: Use Requires.private and Libs.private. (authored by gniibe).
build: Use Requires.private and Libs.private.
Feb 25 2020, 12:07 PM
gniibe committed rC9b8ac13761f0: build: More accurate dependency to -lgpg-error. (authored by gniibe).
build: More accurate dependency to -lgpg-error.
Feb 25 2020, 8:18 AM
gniibe committed rCc21e5d72e24e: build: Fix linking -ldl. (authored by gniibe).
build: Fix linking -ldl.
Feb 25 2020, 7:54 AM
gniibe committed rE732ac9c681a0: w32: Fix exporting gpgrt_argparser. (authored by gniibe).
w32: Fix exporting gpgrt_argparser.
Feb 25 2020, 7:08 AM

Feb 19 2020

gniibe changed the status of T4850: GnuPG fails to find default key to sign when using a smart card, but recovers once card is removed from Open to Testing.
Feb 19 2020, 3:07 AM · Restricted Project, gnupg (gpg22)
gniibe committed rG41913d76f7db: gpg: Fix default-key selection when card is available. (authored by gniibe).
gpg: Fix default-key selection when card is available.
Feb 19 2020, 3:06 AM
gniibe committed rG1cdd9e57f701: gpg: Fix default-key selection when card is available. (authored by gniibe).
gpg: Fix default-key selection when card is available.
Feb 19 2020, 3:04 AM
gniibe claimed T4850: GnuPG fails to find default key to sign when using a smart card, but recovers once card is removed.

Thanks for your info.

Feb 19 2020, 2:43 AM · Restricted Project, gnupg (gpg22)
gniibe added a comment to T4850: GnuPG fails to find default key to sign when using a smart card, but recovers once card is removed.

Or your card has the key to certify and its fingerprint is: CB522FE0379DDF40A93400D7E4BC91FACDA9A65B

Feb 19 2020, 2:06 AM · Restricted Project, gnupg (gpg22)
gniibe added a comment to T4850: GnuPG fails to find default key to sign when using a smart card, but recovers once card is removed.

Simply, we need the output of gpg --card-status to identify which key is on your card.

Feb 19 2020, 2:02 AM · Restricted Project, gnupg (gpg22)
gniibe added a comment to T4850: GnuPG fails to find default key to sign when using a smart card, but recovers once card is removed.

Please show us your card information. Does it have unrelated signing key?

Feb 19 2020, 1:48 AM · Restricted Project, gnupg (gpg22)

Feb 18 2020

gniibe committed rEa6ab8e3a710b: w32: Support static link with -lws2_32. (authored by gniibe).
w32: Support static link with -lws2_32.
Feb 18 2020, 8:28 AM
gniibe changed the status of T4624: libassuan-config and libassuan.pc both put -lws2_32 before -lgpg-error, which fails during static linking from Open to Testing.

With the fix of T4623, this bug is now fixed.

Feb 18 2020, 8:17 AM · Restricted Project, Windows, libassuan, Bug Report
gniibe changed the status of T4623: pkg-config for mingw needs to emit -lws2_32 from Open to Testing.

Fixed in master, using Libs.private support.

Feb 18 2020, 8:05 AM · Restricted Project, Windows, gpgrt, Bug Report

Feb 17 2020

gniibe committed rG95c7498b7623: scd: Disable pinpad if it's impossible by KDF DO. (authored by gniibe).
scd: Disable pinpad if it's impossible by KDF DO.
Feb 17 2020, 9:50 AM
gniibe changed the status of T4832: card: when KDF is enabled, use of pinpad input should be disabled from Open to Testing.

Fixed in master.

Feb 17 2020, 9:48 AM · Restricted Project, gnupg (gpg22), scd, Bug Report

Feb 14 2020

gniibe committed rG17216e6dc9f3: regexp: Add comment of changes. (authored by gniibe).
regexp: Add comment of changes.
Feb 14 2020, 6:26 AM
gniibe added a comment to T4843: REGEXP support for all systems.

Documentation for the regular expression of Jim Tcl: http://jim.tcl.tk/fossil/doc/trunk/Tcl_shipped.html#_jim_built_in_regular_expressions

Feb 14 2020, 6:15 AM · Restricted Project, gnupg

Feb 13 2020

gniibe committed rGf1998d04daef: regexp: Add rules to generate _unicode_mapping.c. (authored by gniibe).
regexp: Add rules to generate _unicode_mapping.c.
Feb 13 2020, 4:08 AM
gniibe committed rGda735afdcc9e: regexp: Tweak generation of _unicode_mapping.c. (authored by gniibe).
regexp: Tweak generation of _unicode_mapping.c.
Feb 13 2020, 4:08 AM
gniibe committed rG5c8c9f5e3123: regexp: More removal from unused utf8 functions. (authored by gniibe).
regexp: More removal from unused utf8 functions.
Feb 13 2020, 4:08 AM
gniibe committed rG53dd03292aea: regexp: Don't need width calc for regexp. (authored by gniibe).
regexp: Don't need width calc for regexp.
Feb 13 2020, 4:08 AM
gniibe committed rG96d873a08ceb: regexp: Also don't need title map. (authored by gniibe).
regexp: Also don't need title map.
Feb 13 2020, 4:08 AM

Feb 12 2020

gniibe triaged T4843: REGEXP support for all systems as Normal priority.
Feb 12 2020, 4:52 AM · Restricted Project, gnupg
gniibe added a comment to T4843: REGEXP support for all systems.

Created gniibe/regexp branch.

Feb 12 2020, 4:52 AM · Restricted Project, gnupg
gniibe committed rG29eb843fa522: regexp: Check if ->pmatch != NULL. (authored by gniibe).
regexp: Check if ->pmatch != NULL.
Feb 12 2020, 4:52 AM
gniibe committed rGece1764c12b7: regexp: Fix use of regexp in g10/trustdb.c. (authored by gniibe).
regexp: Fix use of regexp in g10/trustdb.c.
Feb 12 2020, 4:52 AM
gniibe committed rGcf894cbdec3f: regexp: Use regexp/libregexp.a by gpg frontend. (authored by gniibe).
regexp: Use regexp/libregexp.a by gpg frontend.
Feb 12 2020, 4:52 AM
gniibe committed rG1c3107f1962a: regexp: Add regexp/Makefile.am. (authored by gniibe).
regexp: Add regexp/Makefile.am.
Feb 12 2020, 4:52 AM
gniibe committed rGdb38b551ba61: regexp: A little fix for jimregexp.c. (authored by gniibe).
regexp: A little fix for jimregexp.c.
Feb 12 2020, 4:52 AM
gniibe committed rGac46aedb77dd: regexp: Add UTF-8 support. (authored by gniibe).
regexp: Add UTF-8 support.
Feb 12 2020, 4:52 AM
gniibe committed rGefe993f4a669: regexp: Remove including Jim Tcl headers. (authored by gniibe).
regexp: Remove including Jim Tcl headers.
Feb 12 2020, 4:52 AM
gniibe committed rGc2d1511f0bc6: regexp: Add regexp module from Jim Tcl. (authored by gniibe).
regexp: Add regexp module from Jim Tcl.
Feb 12 2020, 4:52 AM
gniibe added a comment to T4843: REGEXP support for all systems.

RFC4880 (and older version of RFC2440) referes Henry Spenser's REGEXP. There are three implementations: https://garyhouston.github.io/regex/

Feb 12 2020, 3:00 AM · Restricted Project, gnupg
gniibe created T4843: REGEXP support for all systems.
Feb 12 2020, 2:27 AM · Restricted Project, gnupg

Jan 30 2020

gniibe claimed T4832: card: when KDF is enabled, use of pinpad input should be disabled.
Jan 30 2020, 5:19 PM · Restricted Project, gnupg (gpg22), scd, Bug Report
gniibe created T4832: card: when KDF is enabled, use of pinpad input should be disabled.
Jan 30 2020, 5:19 PM · Restricted Project, gnupg (gpg22), scd, Bug Report

Jan 28 2020

gniibe added a comment to T3891: kdf-setup does not set admin and user PIN codes.

Or, #5 would be:

Jan 28 2020, 1:59 AM · Restricted Project, scd, Bug Report

Jan 27 2020

gniibe added a comment to T3891: kdf-setup does not set admin and user PIN codes.

@Amaud, I read your code in Python. IIUC, it asks users PW1, Reset Code, and PW3 to setup, just before registering KDF DO (as you describe in https://dev.gnupg.org/T3891#114950).

Jan 27 2020, 5:30 AM · Restricted Project, scd, Bug Report

Jan 24 2020

gniibe added a comment to T4818: libgcrypt build failures on several platforms.

For Cygwin, I can't find how its libgcrypt package is built.
I found this for MSYS2: https://github.com/msys2/MSYS2-packages/tree/master/libgcrypt
This for Mingw-w64: https://github.com/msys2/MINGW-packages/tree/master/mingw-w64-libgcrypt

Jan 24 2020, 2:53 AM · Solaris, libgcrypt, Bug Report
gniibe created T4822: mlock requires privilege.
Jan 24 2020, 2:21 AM · FAQ, Solaris, libgcrypt
gniibe added a comment to T4818: libgcrypt build failures on several platforms.

I tested on FreeBSD. Same errors (t-secmen and t-sexp) are reproducible when we set:

Jan 24 2020, 2:05 AM · Solaris, libgcrypt, Bug Report
gniibe added a comment to T3891: kdf-setup does not set admin and user PIN codes.

Thanks for concrete cases. Sorry, not responding earlier. It was an experimental feature, firstly only available in Gnuk Token.

Jan 24 2020, 12:19 AM · Restricted Project, scd, Bug Report

Jan 23 2020

gniibe committed rEd1e4b4b001b3: po: Update Japanese Translation. (authored by gniibe).
po: Update Japanese Translation.
Jan 23 2020, 6:13 AM
gniibe added a comment to T4818: libgcrypt build failures on several platforms.

On Solaris, the test errors are because of:

USAGE
       Because of the impact on system resources, the use of mlock() and
       munlock() is restricted to users with the {PRIV_PROC_LOCK_MEMORY}
       privilege.
Jan 23 2020, 3:45 AM · Solaris, libgcrypt, Bug Report
gniibe committed rC03e6d6597198: random: Fix include of config.h. (authored by gniibe).
random: Fix include of config.h.
Jan 23 2020, 2:31 AM
gniibe committed rCe0898d062878: random: Fix include of config.h. (authored by gniibe).
random: Fix include of config.h.
Jan 23 2020, 2:30 AM
gniibe added a comment to T4818: libgcrypt build failures on several platforms.

OK, I identified the problem on OpenIndiana. The inclusion of <unistd.h> causes inclusion of <sys/types.h> before config.h. I'm going to fix this.

Jan 23 2020, 2:24 AM · Solaris, libgcrypt, Bug Report

Jan 21 2020

gniibe committed rCaa9c78afa1d8: tests: Add basic test cases for sm2 (authored by Tianjia Zhang <tianjia.zhang@linux.alibaba.com>).
tests: Add basic test cases for sm2
Jan 21 2020, 6:19 AM
gniibe committed rC6b55246c7708: Add elliptic curve SM2 implementation. (authored by Tianjia Zhang <tianjia.zhang@linux.alibaba.com>).
Add elliptic curve SM2 implementation.
Jan 21 2020, 6:19 AM
gniibe committed rC8d9958910e54: ecc: Simplify signature code (authored by Tianjia Zhang <tianjia.zhang@linux.alibaba.com>).
ecc: Simplify signature code
Jan 21 2020, 5:38 AM
gniibe committed rC95e9cee80241: tests: Fix check_pubkey. (authored by gniibe).
tests: Fix check_pubkey.
Jan 21 2020, 5:19 AM
gniibe committed rC4997139b3e83: Avoid use of ulong in internal code. (authored by gniibe).
Avoid use of ulong in internal code.
Jan 21 2020, 4:09 AM
gniibe added a comment to T4818: libgcrypt build failures on several platforms.

For GNU/Linux or GNU/kFreeBSD system, libgcrypt 1.8 with libgpg-error 1.36 has no problem in Debian build:
https://buildd.debian.org/status/package.php?p=libgcrypt20

Jan 21 2020, 1:48 AM · Solaris, libgcrypt, Bug Report
gniibe added a comment to T4818: libgcrypt build failures on several platforms.

In solaris11openindiana-log2, we have two errors: one for ulong, and another for ushort.
I fixed the former. It is because of our mistake of using ulong before it is handled by libgcrypt/src/types.h. In the first place, it is implemented by "unsigned long", so, there is no need to use ulong here.

Jan 21 2020, 1:41 AM · Solaris, libgcrypt, Bug Report
gniibe committed rCa29e058ff114: Fix declaration of internal function _gcry_mpi_get_ui. (authored by gniibe).
Fix declaration of internal function _gcry_mpi_get_ui.
Jan 21 2020, 1:02 AM

Jan 20 2020

gniibe claimed T4818: libgcrypt build failures on several platforms.

Thanks. I see the situation for Solaris 11 Openindiana. In master (will be 1.9.0), it has no problem.
We need to fix in 1.8. I will.

Jan 20 2020, 11:02 AM · Solaris, libgcrypt, Bug Report
gniibe added a comment to T4818: libgcrypt build failures on several platforms.

Please give us log for Solaris 11 Openindiana.

Jan 20 2020, 5:24 AM · Solaris, libgcrypt, Bug Report
gniibe added a comment to T1983: gpg2 prefers missing secret key to available key on card.

I think that this ticket and https://bugs.debian.org/346241 handle different things, although both do key selection.

Jan 20 2020, 3:32 AM · Bug Report, gnupg

Jan 17 2020

gniibe committed rG8748c50bfaa8: gpg: Prefer card key on use in multiple subkeys situation. (authored by gniibe).
gpg: Prefer card key on use in multiple subkeys situation.
Jan 17 2020, 8:12 AM
gniibe committed rG853d5b7677ea: gpg: Prepare enhancement of agent_probe_secret_key. (authored by gniibe).
gpg: Prepare enhancement of agent_probe_secret_key.
Jan 17 2020, 8:12 AM
gniibe changed the status of T3416: gpg should select available signing key on card (even with -u option), a subtask of T2291: Smartcard interaction improvement (was: Shadowed private key design (for smartcard)), from Open to Testing.
Jan 17 2020, 8:12 AM · Restricted Project, Feature Request, gnupg
gniibe changed the status of T3416: gpg should select available signing key on card (even with -u option) from Open to Testing.

Implemented in master.

Jan 17 2020, 8:12 AM · Restricted Project, Feature Request, gnupg
gniibe updated subscribers of D497: Set vZZ.16b register to zero before use in armv8 gcm implementation.

It looks good.

Jan 17 2020, 12:27 AM · libgcrypt

Jan 16 2020

lopter awarded T2291: Smartcard interaction improvement (was: Shadowed private key design (for smartcard)) a 100 token.
Jan 16 2020, 6:48 PM · Restricted Project, Feature Request, gnupg
gniibe committed rCd154c1e9e110: Add new curve named sm2p256v1. (authored by Tianjia Zhang <tianjia.zhang@linux.alibaba.com>).
Add new curve named sm2p256v1.
Jan 16 2020, 9:16 AM
gniibe committed rCf34de41b9db5: Register DCO for Tianjia Zhang. (authored by gniibe).
Register DCO for Tianjia Zhang.
Jan 16 2020, 9:16 AM
gniibe raised the priority of T3416: gpg should select available signing key on card (even with -u option) from Normal to High.
Jan 16 2020, 5:43 AM · Restricted Project, Feature Request, gnupg
gniibe added a comment to T3416: gpg should select available signing key on card (even with -u option).

With new "KEYINFO" command of scdaemon, finally, we can move on to support better selection of signing key.
(Note: having a private key on multiple cards had already been solved in T4301: Handling multiple subkeys on two SmartCards.)

Jan 16 2020, 5:40 AM · Restricted Project, Feature Request, gnupg
gniibe added a project to T2291: Smartcard interaction improvement (was: Shadowed private key design (for smartcard)): Restricted Project.
Jan 16 2020, 5:29 AM · Restricted Project, Feature Request, gnupg
gniibe changed the status of T2291: Smartcard interaction improvement (was: Shadowed private key design (for smartcard)) from Open to Testing.

In master, it has been implemented.

Jan 16 2020, 5:29 AM · Restricted Project, Feature Request, gnupg
gniibe changed the status of T4695: Remove SERIALNO as an identifier to select keys, a subtask of T2291: Smartcard interaction improvement (was: Shadowed private key design (for smartcard)), from Open to Testing.
Jan 16 2020, 5:25 AM · Restricted Project, Feature Request, gnupg
gniibe changed the status of T4695: Remove SERIALNO as an identifier to select keys from Open to Testing.
Jan 16 2020, 5:25 AM · Restricted Project, Feature Request, gnupg
gniibe added a comment to T4695: Remove SERIALNO as an identifier to select keys.

The first "SCD SERIALNO" command let scdaemon re-scan smartcards/tokens.

Jan 16 2020, 5:24 AM · Restricted Project, Feature Request, gnupg
gniibe added a comment to T4695: Remove SERIALNO as an identifier to select keys.

With new "KEYINFO" command in scdaemon, a list of card keys can be retrieved by:

Jan 16 2020, 5:22 AM · Restricted Project, Feature Request, gnupg
gniibe closed T4784: Remove referring a key by $AUTHKEYID, $ENCRKEYID, and $SIGNKEYID as Resolved.
Jan 16 2020, 5:17 AM · scd, Feature Request, gnupg
gniibe closed T4784: Remove referring a key by $AUTHKEYID, $ENCRKEYID, and $SIGNKEYID, a subtask of T4695: Remove SERIALNO as an identifier to select keys, as Resolved.
Jan 16 2020, 5:17 AM · Restricted Project, Feature Request, gnupg
gniibe added a comment to T4784: Remove referring a key by $AUTHKEYID, $ENCRKEYID, and $SIGNKEYID.

There is no use cases for $SIGNKEYID.

Jan 16 2020, 5:16 AM · scd, Feature Request, gnupg
gniibe added a comment to T4784: Remove referring a key by $AUTHKEYID, $ENCRKEYID, and $SIGNKEYID.

$ENCRKEYID use case have been removed.

Jan 16 2020, 5:14 AM · scd, Feature Request, gnupg
gniibe committed rG8edd4b8b8cdc: gpg: Use "SCD KEYINFO" to get available card keys. (authored by gniibe).
gpg: Use "SCD KEYINFO" to get available card keys.
Jan 16 2020, 5:10 AM
gniibe committed rG8240a70c31a8: gpg: Add agent_scd_keyinfo to retrieve available card keys. (authored by gniibe).
gpg: Add agent_scd_keyinfo to retrieve available card keys.
Jan 16 2020, 5:10 AM
gniibe added a comment to T4810: A key with only "C" capability cannot be selected as default key..

Fixed and backported.

Jan 16 2020, 5:04 AM · Restricted Project, gnupg (gpg22)
gniibe committed rGa7840777e427: gpg: default-key: Simply don't limit by capability. (authored by gniibe).
gpg: default-key: Simply don't limit by capability.
Jan 16 2020, 2:32 AM
gniibe committed rG1aa2a0a46dc1: gpg: default-key: Simply don't limit by capability. (authored by gniibe).
gpg: default-key: Simply don't limit by capability.
Jan 16 2020, 2:31 AM

Jan 15 2020

gniibe committed rG6e4f7fe26ea9: po: Update Japanese Translation. (authored by gniibe).
po: Update Japanese Translation.
Jan 15 2020, 7:52 AM
gniibe added a comment to T4810: A key with only "C" capability cannot be selected as default key..

Err.. Just removing the check may be the correct fix; It doesn't make sense to limit capability here.

Jan 15 2020, 7:41 AM · Restricted Project, gnupg (gpg22)
gniibe committed rG9287f9e87b21: gpg: Cert only key should be usable with --default-key. (authored by gniibe).
gpg: Cert only key should be usable with --default-key.
Jan 15 2020, 6:33 AM

Jan 14 2020

gniibe added a comment to T4810: A key with only "C" capability cannot be selected as default key..

I think rGe573e6188dad: gpg: Fix --default-key checks. should be fixed as:

diff --git a/g10/getkey.c b/g10/getkey.c
index ad5dd8e01..cc908964e 100644
--- a/g10/getkey.c
+++ b/g10/getkey.c
@@ -1860,7 +1860,8 @@ parse_def_secret_key (ctrl_t ctrl)
           PKT_public_key *pk = node->pkt->pkt.public_key;
Jan 14 2020, 8:28 AM · Restricted Project, gnupg (gpg22)
gniibe added a comment to T4810: A key with only "C" capability cannot be selected as default key..
$ export GNUPGHOME=<somewhere>
# Create a key with "C"-only capability
$ gpg --quick-gen-key "test-user <chuji@gniibe.org>" ed25519 cert
# Create another key (or get/import it)
$ gpg --quick-gen-key "2020-user <chuji2020@gniibe.org>" ed25519
# Sign with the first key to the second key with --default-key
$ gpg --default-key 7694AB44DED1154CEB981059B0B36418AF85C918 --lsign 72FF31542DB059A507BAF81BE05523DEB4B018E6

(where 7694AB...85C918 is the first key and 72FF31..B018E6 is the second key)

Jan 14 2020, 8:03 AM · Restricted Project, gnupg (gpg22)
gniibe added a comment to T4810: A key with only "C" capability cannot be selected as default key..

rGe573e6188dad: gpg: Fix --default-key checks. is suspicious.

Jan 14 2020, 7:39 AM · Restricted Project, gnupg (gpg22)
gniibe created T4810: A key with only "C" capability cannot be selected as default key..
Jan 14 2020, 7:38 AM · Restricted Project, gnupg (gpg22)

Jan 13 2020

gniibe committed rGc31266716dd6: agent: Extend agent_card_getattr with KEYGRIP. (authored by gniibe).
agent: Extend agent_card_getattr with KEYGRIP.
Jan 13 2020, 9:09 AM
gniibe committed rG15028627a165: agent: handle SSH operation by KEYGRIP. (authored by gniibe).
agent: handle SSH operation by KEYGRIP.
Jan 13 2020, 9:09 AM
gniibe added a comment to T4784: Remove referring a key by $AUTHKEYID, $ENCRKEYID, and $SIGNKEYID.

$AUTHKEYID use cases have been removed.

Jan 13 2020, 8:53 AM · scd, Feature Request, gnupg

Jan 10 2020

gniibe committed rG0cfded4bb148: scd: Implement direct access by KEYGRIP for GETATTR and READKEY. (authored by gniibe).
scd: Implement direct access by KEYGRIP for GETATTR and READKEY.
Jan 10 2020, 8:02 AM

Jan 9 2020

gniibe committed rG57b8ed61ab93: agent: SSH: SCD KEYINFO to list available keys. (authored by gniibe).
agent: SSH: SCD KEYINFO to list available keys.
Jan 9 2020, 4:01 AM