So, the change against libgcrypt 1.9.1 will be:
- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
Advanced Search
Feb 2 2021
I got hit of search by "$ld$weak$os10.11$_getentropy".
So, I guess that it's 10.11 which has _getentropy as weak symbol, and 10.12 or later has implementation.
Feb 1 2021
Here is a patch adding those checks:
diff --git a/cipher/ecc-ecdsa.c b/cipher/ecc-ecdsa.c index d540578e..30103f14 100644 --- a/cipher/ecc-ecdsa.c +++ b/cipher/ecc-ecdsa.c @@ -172,6 +172,9 @@ _gcry_ecc_ecdsa_verify (gcry_mpi_t input, mpi_ec_t ec, mpi_point_struct Q, Q1, Q2; unsigned int nbits;
In T5268#142612, @ballapete wrote:Wouldn't it be better to move these failures as a single one into the configure script that it definitely can tell "This Mac has getentropy()"?
Jan 29 2021
I linked all related tasks for the release of 1.9.1, so that making release notes can be easier and recording information here.
Jan 28 2021
Jan 27 2021
Thank you for your testing.
Am I allowed to publish the patches for MacPorts?
Push the change.
For older versions of MacOS X, I'll handle it later.
https://developer.apple.com/library/archive/documentation/System/Conceptual/ManPages_iPhoneOS/man2/posix_spawn.2.html dated August 9, 2007.
So, I guess that posix_spawn became available in MacOS X Leopard (10.5).
I wrote:
I don't know when the symbol of getentropy was available on macOS.
@ballapete Thank you for testing.
Also support older MacOS X, which has no posix_spawn.
Jan 26 2021
@ballapete when you have time, could you also test https://dev.gnupg.org/T5268#142155 on Tiger?
To support old macOS (< 10.12), I think that code should be something like this:
I created T5268, please continue discussion there.
Just for the information, this library of Rust checks if the symbol definition is available (not NULL), and use getentropy in that case.
fall back to /dev/u?random
https://www.unix.com/man-page/mojave/2/getentropy/ says getentropy is available in 10.12 or later.
I realized that it's a bit difficult for macOS to use getentropy.
Please note that we also have a commit rC477355047e5c: mpi/longlong: make use of compiler provided __builtin_ctz/__builtin_clz.