Feed Advanced Search

Sat, Feb 1

jukivili added a comment to T4833: libgcrypt: bug in _gcry_poly1305_armv7_neon_init_ext.

I prepared slightly different patch, which 'and r2,r2,r2' instruction removed as it is no longer needed.

Sat, Feb 1, 6:39 PM · libgcrypt, Bug Report
jukivili added a comment to T4833: libgcrypt: bug in _gcry_poly1305_armv7_neon_init_ext.

Thanks for reporting this this. Your patch is correct.

Sat, Feb 1, 4:54 PM · libgcrypt, Bug Report

Fri, Jan 31

werner triaged T4833: libgcrypt: bug in _gcry_poly1305_armv7_neon_init_ext as High priority.
Fri, Jan 31, 11:39 AM · libgcrypt, Bug Report

Fri, Jan 24

bhaible added a comment to T4818: libgcrypt build failures on several platforms.

Regarding Cygwin: The sources are a bit hard to find.
https://cygwin.com/packages.html
-> https://cygwin.com/packaging/repos.html
-> https://cygwin.com/git-cygwin-packages/
-> https://cygwin.com/git-cygwin-packages/?p=git/cygwin-packages/libgcrypt.git;a=summary

Fri, Jan 24, 11:33 AM · Solaris, libgcrypt, Bug Report
bhaible added a comment to T4818: libgcrypt build failures on several platforms.

Regarding GNU/kFreeBSD, my machine is using the FreeBSD 9.0 kernel, which does not yet have the security.bsd.unprivileged_mlock oid. Like what was mentioned here: https://lists.debian.org/debian-bsd/2014/08/msg00092.html

Fri, Jan 24, 11:15 AM · Solaris, libgcrypt, Bug Report
gniibe added a comment to T4818: libgcrypt build failures on several platforms.

For Cygwin, I can't find how its libgcrypt package is built.
I found this for MSYS2: https://github.com/msys2/MSYS2-packages/tree/master/libgcrypt
This for Mingw-w64: https://github.com/msys2/MINGW-packages/tree/master/mingw-w64-libgcrypt

Fri, Jan 24, 2:53 AM · Solaris, libgcrypt, Bug Report
gniibe created T4822: mlock requires privilege.
Fri, Jan 24, 2:21 AM · Solaris, libgcrypt, Bug Report
gniibe added a comment to T4818: libgcrypt build failures on several platforms.

I tested on FreeBSD. Same errors (t-secmen and t-sexp) are reproducible when we set:

Fri, Jan 24, 2:05 AM · Solaris, libgcrypt, Bug Report

Thu, Jan 23

gniibe added a comment to T4818: libgcrypt build failures on several platforms.

On Solaris, the test errors are because of:

USAGE
       Because of the impact on system resources, the use of mlock() and
       munlock() is restricted to users with the {PRIV_PROC_LOCK_MEMORY}
       privilege.
Thu, Jan 23, 3:45 AM · Solaris, libgcrypt, Bug Report
gniibe added a commit to T4818: libgcrypt build failures on several platforms: rCe0898d062878: random: Fix include of config.h..
Thu, Jan 23, 2:30 AM · Solaris, libgcrypt, Bug Report
gniibe added a comment to T4818: libgcrypt build failures on several platforms.

OK, I identified the problem on OpenIndiana. The inclusion of <unistd.h> causes inclusion of <sys/types.h> before config.h. I'm going to fix this.

Thu, Jan 23, 2:24 AM · Solaris, libgcrypt, Bug Report

Wed, Jan 22

jukivili added a comment to D497: Set vZZ.16b register to zero before use in armv8 gcm implementation.

Patch have been applied to master, https://git.gnupg.org/cgi-bin/gitweb.cgi?p=libgcrypt.git;a=commit;h=79ed620ec46adbb08f5cea6a4865a95a436e4109

Wed, Jan 22, 10:55 PM · libgcrypt

Jan 21 2020

slandden added a comment to T4630: libgcrypt: POWER GHASH Vector Acceleration.

Yes, I need to optimize it.

Jan 21 2020, 9:31 PM · Feature Request, libgcrypt
larma added a comment to D497: Set vZZ.16b register to zero before use in armv8 gcm implementation.

@jukivili thanks for looking into this. If you want, you can go with "Marvin W. <git at larma.de>" or just keep as is.

Jan 21 2020, 9:27 PM · libgcrypt
johnmar added a comment to T4630: libgcrypt: POWER GHASH Vector Acceleration.

Hi @slandden. Have you made any progress since the last time I asked?

Jan 21 2020, 9:16 PM · Feature Request, libgcrypt
gniibe added a comment to T4818: libgcrypt build failures on several platforms.

For GNU/Linux or GNU/kFreeBSD system, libgcrypt 1.8 with libgpg-error 1.36 has no problem in Debian build:
https://buildd.debian.org/status/package.php?p=libgcrypt20

Jan 21 2020, 1:48 AM · Solaris, libgcrypt, Bug Report
gniibe added a comment to T4818: libgcrypt build failures on several platforms.

In solaris11openindiana-log2, we have two errors: one for ulong, and another for ushort.
I fixed the former. It is because of our mistake of using ulong before it is handled by libgcrypt/src/types.h. In the first place, it is implemented by "unsigned long", so, there is no need to use ulong here.

Jan 21 2020, 1:41 AM · Solaris, libgcrypt, Bug Report

Jan 20 2020

werner triaged T4818: libgcrypt build failures on several platforms as Normal priority.
Jan 20 2020, 3:37 PM · Solaris, libgcrypt, Bug Report

Jan 19 2020

jukivili added a comment to D497: Set vZZ.16b register to zero before use in armv8 gcm implementation.

Thanks for bug fix. I've prepared patch and send it to mailing list https://lists.gnupg.org/pipermail/gcrypt-devel/2020-January/004885.html. Let me know if Reported-by is ok/enough. I would have liked to put you as author of commit, but this Differential interface of quite horrible and does not give all the needed information (mainly "name <email>" format for git).

Jan 19 2020, 9:50 AM · libgcrypt

Jan 17 2020

larma added a reviewer for D497: Set vZZ.16b register to zero before use in armv8 gcm implementation: jukivili.
Jan 17 2020, 12:28 AM · libgcrypt
gniibe updated subscribers of D497: Set vZZ.16b register to zero before use in armv8 gcm implementation.

It looks good.

Jan 17 2020, 12:27 AM · libgcrypt

Jan 16 2020

larma updated subscribers of D497: Set vZZ.16b register to zero before use in armv8 gcm implementation.
Jan 16 2020, 9:44 PM · libgcrypt
larma changed the edit policy for D497: Set vZZ.16b register to zero before use in armv8 gcm implementation.
Jan 16 2020, 9:36 PM · libgcrypt
larma changed the visibility for D497: Set vZZ.16b register to zero before use in armv8 gcm implementation.
Jan 16 2020, 9:27 PM · libgcrypt

Dec 9 2019

johnmar added a comment to T4630: libgcrypt: POWER GHASH Vector Acceleration.

Oh, no worries! Just wanted to confirm, that's all.

Dec 9 2019, 5:54 PM · Feature Request, libgcrypt
slandden added a comment to T4630: libgcrypt: POWER GHASH Vector Acceleration.

I am about half way. Sorry for the slowness.

Dec 9 2019, 5:51 PM · Feature Request, libgcrypt
jukivili added a comment to T4630: libgcrypt: POWER GHASH Vector Acceleration.

I've been wondering this also. I can start working on this.

Dec 9 2019, 5:50 PM · Feature Request, libgcrypt
johnmar added a comment to T4630: libgcrypt: POWER GHASH Vector Acceleration.

Hello,
Is anyone working on this? Just want to confirm.

Dec 9 2019, 5:46 PM · Feature Request, libgcrypt

Dec 6 2019

gniibe added a subtask for T4293: Add dedicated X25519 function to Libcgrypt : T4294: Release Libgcrypt 1.9.0.
Dec 6 2019, 5:22 AM · Testing, libgcrypt
gniibe added a parent task for T4294: Release Libgcrypt 1.9.0: T4293: Add dedicated X25519 function to Libcgrypt .
Dec 6 2019, 5:22 AM · Release Info, libgcrypt
gniibe removed a parent task for T4293: Add dedicated X25519 function to Libcgrypt : T4294: Release Libgcrypt 1.9.0.
Dec 6 2019, 5:21 AM · Testing, libgcrypt
gniibe removed a subtask for T4294: Release Libgcrypt 1.9.0: T4293: Add dedicated X25519 function to Libcgrypt .
Dec 6 2019, 5:21 AM · Release Info, libgcrypt
gniibe added a subtask for T4293: Add dedicated X25519 function to Libcgrypt : T4702: Release GnuPG 2.3.0.
Dec 6 2019, 5:20 AM · Testing, libgcrypt
gniibe added a project to T4293: Add dedicated X25519 function to Libcgrypt : Testing.
Dec 6 2019, 5:20 AM · Testing, libgcrypt
gniibe closed T4663: libgcrypt: fix build without threads by adding an option to disable tests as Resolved.
Dec 6 2019, 3:07 AM · libgcrypt, Bug Report

Nov 28 2019

jukivili closed T4425: libgcrypt relocation error on aarch64 as Resolved.
Nov 28 2019, 4:15 PM · asm, libgcrypt, Bug Report

Nov 8 2019

slandden added a comment to T4630: libgcrypt: POWER GHASH Vector Acceleration.

El vie., 8 nov. 2019 8:19, johnmar (John Martinez) <noreply@dev.gnupg.org>
escribió:

Nov 8 2019, 5:29 PM · Feature Request, libgcrypt
johnmar added a comment to T4630: libgcrypt: POWER GHASH Vector Acceleration.

Allow me to clarify. For bounty purposes, as long as the intrinsic implementation matches or beats OpenSSL performance, it is acceptable. There have been cases where the use of certain intrinsics may yield better performing, but sub optimal results.

Nov 8 2019, 5:18 PM · Feature Request, libgcrypt
jukivili added a comment to T4630: libgcrypt: POWER GHASH Vector Acceleration.

Please note that C-based intrinsic implementation is the way to go now as that is the path chosen for PowerPC implementations in libgcrypt.

Nov 8 2019, 9:23 AM · Feature Request, libgcrypt
slandden added a comment to T4630: libgcrypt: POWER GHASH Vector Acceleration.
C-based intrinsic implementations are discouraged.
Nov 8 2019, 12:16 AM · Feature Request, libgcrypt

Nov 7 2019

johnmar updated the task description for T4630: libgcrypt: POWER GHASH Vector Acceleration.
Nov 7 2019, 11:14 PM · Feature Request, libgcrypt

Oct 4 2019

werner added a comment to T4683: Release Libgcrypt 1.8.5.

See https://minerva.crocs.fi.muni.cz/ for a description of the timing attack.

Oct 4 2019, 8:57 AM · CVE, Release Info, libgcrypt

Oct 2 2019

gniibe added a project to T4712: Keygrip broken in master for cv25519: Testing.

I modified _gcry_ecc_fill_in_curve so that g_y has new value in eid4730.

Oct 2 2019, 8:29 AM · Testing, Bug Report, libgcrypt
gniibe added a commit to T4712: Keygrip broken in master for cv25519: rC1cfe2329b91c: ecc: Fix regression in keygrip computation for cv25519 (2)..
Oct 2 2019, 5:07 AM · Testing, Bug Report, libgcrypt

Oct 1 2019

gniibe claimed T4712: Keygrip broken in master for cv25519.

That's my badness. I think that I haven't seen this problem, because I mainly use tokens (where keygrip difference doesn't matter, after --card-status).

Oct 1 2019, 7:17 AM · Testing, Bug Report, libgcrypt

Sep 28 2019

werner added a commit to T4712: Keygrip broken in master for cv25519: rCf67b6492e0b0: ecc: Fix regression in keygrip computation for cv25519..
Sep 28 2019, 11:12 AM · Testing, Bug Report, libgcrypt
werner lowered the priority of T4712: Keygrip broken in master for cv25519 from Unbreak Now! to Normal.
Sep 28 2019, 11:08 AM · Testing, Bug Report, libgcrypt

Sep 26 2019

jukivili updated the task description for T4460: libgcrypt performance TODOs.
Sep 26 2019, 9:09 PM · libgcrypt
jukivili added a commit to T4460: libgcrypt performance TODOs: rC4bebafb7bae8: Add stitched ChaCha20-Poly1305 ARMv8/AArch64 implementation.
Sep 26 2019, 9:08 PM · libgcrypt

Sep 15 2019

jukivili added a commit to T4460: libgcrypt performance TODOs: rC0486b85bd1fb: Add PowerPC vpmsum implementation of CRC.
Sep 15 2019, 10:31 PM · libgcrypt
jukivili added a commit to T4460: libgcrypt performance TODOs: rC557702f0d53a: Add PowerPC vector implementation of ChaCha20.
Sep 15 2019, 10:31 PM · libgcrypt
jukivili added a commit to T4460: libgcrypt performance TODOs: rC0564757b934d: poly1305: add fast addition macro for ppc64.
Sep 15 2019, 10:31 PM · libgcrypt
jukivili updated the task description for T4460: libgcrypt performance TODOs.
Sep 15 2019, 10:13 PM · libgcrypt
jukivili claimed T4460: libgcrypt performance TODOs.
Sep 15 2019, 10:13 PM · libgcrypt

Sep 6 2019

jukivili added a comment to T4460: libgcrypt performance TODOs.

Poly1305 addition helper for ppc64 posted on mailing list: https://lists.gnupg.org/pipermail/gcrypt-devel/2019-September/004804.html

Sep 6 2019, 9:50 PM · libgcrypt
jukivili updated the task description for T4460: libgcrypt performance TODOs.
Sep 6 2019, 9:49 PM · libgcrypt

Sep 3 2019

jukivili updated the task description for T4460: libgcrypt performance TODOs.
Sep 3 2019, 9:57 PM · libgcrypt
jukivili updated the task description for T4460: libgcrypt performance TODOs.
Sep 3 2019, 9:57 PM · libgcrypt
jukivili updated the task description for T4460: libgcrypt performance TODOs.
Sep 3 2019, 9:56 PM · libgcrypt
jukivili added a parent task for T4630: libgcrypt: POWER GHASH Vector Acceleration: T4531: PowerPC performance improvements.
Sep 3 2019, 9:49 PM · Feature Request, libgcrypt
jukivili closed T4530: libgcrypt: POWER SHA-2 Vector Acceleration as Resolved.

PowerPC SHA-256 and SHA-512 implementations with little bit more tuning committed. Most notably, SHA-512 on POWER8 now gives similar performance to OpenSSL:

Sep 3 2019, 9:39 PM · libgcrypt, Feature Request
jukivili added a commit to T4530: libgcrypt: POWER SHA-2 Vector Acceleration: rC93632f1adf57: Add SHA-512 implementations for POWER8 and POWER9.
Sep 3 2019, 9:34 PM · libgcrypt, Feature Request
jukivili added a commit to T4530: libgcrypt: POWER SHA-2 Vector Acceleration: rCe19dc973bc8e: Add SHA-256 implementations for POWER8 and POWER9.
Sep 3 2019, 9:34 PM · libgcrypt, Feature Request

Sep 1 2019

olf added a comment to T4541: C implementation of AES is vulnerable to side-channel attacks.

... https://lists.gnupg.org/pipermail/gcrypt-devel/2019-July/004760.html

Sep 1 2019, 11:33 PM · side-channel, libgcrypt, Bug Report

Aug 31 2019

jukivili reassigned T4630: libgcrypt: POWER GHASH Vector Acceleration from jukivili to slandden.
Aug 31 2019, 11:13 AM · Feature Request, libgcrypt
jukivili added a comment to T4530: libgcrypt: POWER SHA-2 Vector Acceleration.

Patches send to mailing list:
https://lists.gnupg.org/pipermail/gcrypt-devel/2019-August/004800.html
https://lists.gnupg.org/pipermail/gcrypt-devel/2019-August/004799.html

Aug 31 2019, 2:07 AM · libgcrypt, Feature Request
jukivili closed T4529: libgcrypt: POWER AES Vector Acceleration as Resolved.
Aug 31 2019, 1:38 AM · libgcrypt, Feature Request

Aug 29 2019

werner set External Link to https://lists.gnupg.org/pipermail/gnupg-announce/2019q3/000440.html on T4683: Release Libgcrypt 1.8.5.
Aug 29 2019, 5:39 PM · CVE, Release Info, libgcrypt
werner closed T4683: Release Libgcrypt 1.8.5 as Resolved.
Aug 29 2019, 3:24 PM · CVE, Release Info, libgcrypt

Aug 26 2019

jukivili added a commit to T4529: libgcrypt: POWER AES Vector Acceleration: rCbd1367bb6078: rijndael-ppc: add bulk mode for ocb_auth.
Aug 26 2019, 7:04 PM · libgcrypt, Feature Request
jukivili added a commit to T4529: libgcrypt: POWER AES Vector Acceleration: rC821602c60c7d: rijndael-ppc: enable PowerPC AES-OCB implemention.
Aug 26 2019, 7:04 PM · libgcrypt, Feature Request
jukivili added a commit to T4529: libgcrypt: POWER AES Vector Acceleration: rC81d555d34730: rijndael-ppc: add bulk modes for CBC, CFB, CTR and XTS.
Aug 26 2019, 7:04 PM · libgcrypt, Feature Request
jukivili added a commit to T4529: libgcrypt: POWER AES Vector Acceleration: rC9dca65ef71b4: rijndael-ppc: add key setup and enable single block PowerPC AES.
Aug 26 2019, 7:04 PM · libgcrypt, Feature Request
jukivili added a commit to T4529: libgcrypt: POWER AES Vector Acceleration: rC92f38a619b1c: rijndael/ppc: implement single-block mode, and implement OCB block cipher.
Aug 26 2019, 7:04 PM · libgcrypt, Feature Request
jukivili added a commit to T4529: libgcrypt: POWER AES Vector Acceleration: rCb4a3c76fabfa: hwf: add detection of PowerPC hardware features.
Aug 26 2019, 7:04 PM · libgcrypt, Feature Request

Aug 25 2019

jukivili claimed T4630: libgcrypt: POWER GHASH Vector Acceleration.

I'll start working on PowerPC GHASH implementation in September after SHA2 is done.

Aug 25 2019, 6:12 PM · Feature Request, libgcrypt
jukivili claimed T4530: libgcrypt: POWER SHA-2 Vector Acceleration.

I'll start working on new PowerPC SHA2 implementations for libgcrypt in coming weeks.

Aug 25 2019, 6:11 PM · libgcrypt, Feature Request
jukivili claimed T4529: libgcrypt: POWER AES Vector Acceleration.

Patches for PowerPC AES acceleration sent to mailing-list, based partly on initial work by Shawn Landden (@slandden): https://lists.gnupg.org/pipermail/gcrypt-devel/2019-August/004788.html

Aug 25 2019, 6:10 PM · libgcrypt, Feature Request

Aug 23 2019

werner added a parent task for T4683: Release Libgcrypt 1.8.5: T4684: Release GnuPG 2.2.18.
Aug 23 2019, 11:31 AM · CVE, Release Info, libgcrypt
werner created T4683: Release Libgcrypt 1.8.5.
Aug 23 2019, 11:28 AM · CVE, Release Info, libgcrypt

Aug 16 2019

gniibe added a commit to T4663: libgcrypt: fix build without threads by adding an option to disable tests: rC900647d96cb7: build: Fix build with !HAVE_PTHREAD.
Aug 16 2019, 2:12 AM · libgcrypt, Bug Report

Aug 13 2019

ffontaine added a comment to T4663: libgcrypt: fix build without threads by adding an option to disable tests.

Fixing t-lock is indeed a better solution however having an option to disable tests could be used in another context than fixing this issue.
For example, in the context of buildroot (which goal is to build a custom embedded linux system), this option could be used to save time during compilation as well as to save space on the embedded system.

Aug 13 2019, 9:17 AM · libgcrypt, Bug Report
gniibe claimed T4663: libgcrypt: fix build without threads by adding an option to disable tests.

Thanks for your report.
I think that adding an option for disabling tests is too much.
If it were AC_SUBST, we could use HAVE_PTHREAD in tests/Makefile.am.
In the current situation, just modifining t-lock is easier.

Aug 13 2019, 7:13 AM · libgcrypt, Bug Report

Aug 2 2019

werner triaged T4663: libgcrypt: fix build without threads by adding an option to disable tests as Normal priority.
Aug 2 2019, 11:33 AM · libgcrypt, Bug Report

Jul 18 2019

slandden updated subscribers of T4630: libgcrypt: POWER GHASH Vector Acceleration.

@werner I would be willing to share 20% to the reviewer of my patches. (or 25% in this case, as @jwilk went through the effort to even write a test to point out a bug in my code). However, so far that has been entirely @jwilk who has been reviewing my patches.

Jul 18 2019, 5:59 PM · Feature Request, libgcrypt

Jul 17 2019

werner triaged T4630: libgcrypt: POWER GHASH Vector Acceleration as Low priority.
Jul 17 2019, 12:07 PM · Feature Request, libgcrypt
werner added a comment to T4630: libgcrypt: POWER GHASH Vector Acceleration.

Please STOP adding such bug reports or feature requests. They are not helpful and such discussion are better done at the mailing list. In case you want to spend money to speed up things you may contact gnupg.com for a quote.

Jul 17 2019, 12:07 PM · Feature Request, libgcrypt

Jul 16 2019

johnmar created T4630: libgcrypt: POWER GHASH Vector Acceleration in the S1 Public space.
Jul 16 2019, 6:32 PM · Feature Request, libgcrypt
werner triaged T4529: libgcrypt: POWER AES Vector Acceleration as Normal priority.

Please do not change the priority back. That is a maintainer's task. I consider this along with adding replicas of issues to a bit rude.

Jul 16 2019, 8:33 AM · libgcrypt, Feature Request
werner triaged T4530: libgcrypt: POWER SHA-2 Vector Acceleration as Normal priority.

Please do not change the priority back without discussing this with the maintainer first. Thanks.

Jul 16 2019, 8:31 AM · libgcrypt, Feature Request
werner closed T4629: POWER AES Vector Acceleration as Spite.
Jul 16 2019, 8:27 AM · libgcrypt, Feature Request

Jul 15 2019

johnmar raised the priority of T4530: libgcrypt: POWER SHA-2 Vector Acceleration from Normal to Needs Triage.
Jul 15 2019, 9:09 PM · libgcrypt, Feature Request
johnmar raised the priority of T4529: libgcrypt: POWER AES Vector Acceleration from Normal to Needs Triage.
Jul 15 2019, 9:09 PM · libgcrypt, Feature Request
johnmar updated the task description for T4629: POWER AES Vector Acceleration.
Jul 15 2019, 8:45 PM · libgcrypt, Feature Request
johnmar created T4629: POWER AES Vector Acceleration.
Jul 15 2019, 8:38 PM · libgcrypt, Feature Request
johnmar added a watcher for libgcrypt: johnmar.
Jul 15 2019, 6:22 PM

Jul 10 2019

werner added a comment to T4541: C implementation of AES is vulnerable to side-channel attacks.

Check out the mailing list gcrypt-devel@

Jul 10 2019, 7:23 PM · side-channel, libgcrypt, Bug Report
ware added a comment to T4541: C implementation of AES is vulnerable to side-channel attacks.

Folks, I was just wondering if I could get an update on where we are with this bug. It seems we aren't sure if it's a real issue or not. What's the latest thought?

Jul 10 2019, 7:17 PM · side-channel, libgcrypt, Bug Report

Jul 8 2019

jukivili added a revision to T4530: libgcrypt: POWER SHA-2 Vector Acceleration: D490: PowerPC optimized routines for AES and SHA2 using PowerISA 2.07 instructions..
Jul 8 2019, 2:57 PM · libgcrypt, Feature Request
jukivili added a revision to T4529: libgcrypt: POWER AES Vector Acceleration: D490: PowerPC optimized routines for AES and SHA2 using PowerISA 2.07 instructions..
Jul 8 2019, 2:57 PM · libgcrypt, Feature Request