Page MenuHome GnuPG
Feed All Stories

Jun 22 2022

gniibe updated the task description for T6039: FIPS: Allow salt=NULL (or shorter salt) for HKDF.
Jun 22 2022, 3:47 AM · backport, libgcrypt, FIPS
gniibe added a comment to T6039: FIPS: Allow salt=NULL (or shorter salt) for HKDF.

In rC76aad97dd312: fips: Reject shorter key for HMAC in FIPS mode., I added rejection, but it would be good to move the check to src/visibility.c to allow internal use.

Jun 22 2022, 3:46 AM · backport, libgcrypt, FIPS
gniibe triaged T6039: FIPS: Allow salt=NULL (or shorter salt) for HKDF as Normal priority.
Jun 22 2022, 3:41 AM · backport, libgcrypt, FIPS

Jun 21 2022

cklassen committed rW0db3170a0b36: grammar (authored by cklassen).
grammar
Jun 21 2022, 8:05 PM
cklassen committed rWfebe250cecf8: wording (authored by cklassen).
wording
Jun 21 2022, 8:05 PM
cklassen committed rW16ed62b0454b: typo (authored by cklassen).
typo
Jun 21 2022, 8:05 PM
cklassen committed rW4fc775d7f393: grammar (authored by cklassen).
grammar
Jun 21 2022, 8:05 PM
cklassen committed rW3d23c9b5abe8: typo + phrasing (authored by cklassen).
typo + phrasing
Jun 21 2022, 8:05 PM
cklassen committed rW0cf89e517dd1: added missing sentence (authored by cklassen).
added missing sentence
Jun 21 2022, 7:52 PM
cklassen committed rW1c4a4fb49dc2: grammar (authored by cklassen).
grammar
Jun 21 2022, 7:48 PM
cklassen committed rW4ec80a146656: typo (authored by cklassen).
typo
Jun 21 2022, 7:45 PM
cklassen committed rW7ce83dbeee21: edited part of description (authored by cklassen).
edited part of description
Jun 21 2022, 7:09 PM
cklassen committed rWe9b3239299c8: removed string that doesnt belong there (authored by cklassen).
removed string that doesnt belong there
Jun 21 2022, 6:46 PM
werner committed rG4c14bbf56fb5: sm: Update pkcs#12 module from master (authored by werner).
sm: Update pkcs#12 module from master
Jun 21 2022, 6:29 PM
werner committed rGd21ced1e3596: common: Add an easy to use DER builder. (authored by werner).
common: Add an easy to use DER builder.
Jun 21 2022, 6:29 PM
gniibe added a comment to T6035: Portability issue: ftruncate.

Looking illumos-gate, Solaris variants have no issues.

Jun 21 2022, 12:46 PM · backport, gpgagent, gnupg
gniibe added a comment to T6035: Portability issue: ftruncate.

Wine 5.0.3 (on Debian bullseye) fails.
Wine 6.0.3 Debian testing does no failure.

Jun 21 2022, 10:35 AM · backport, gpgagent, gnupg
ikloecker added a comment to T6038: gpg-wks-client excludes uid with URL in comment.

This problem does not seem to exist in GnuPG 2.3.6.

Jun 21 2022, 9:49 AM · gnupg (gpg22), wkd, Bug Report
gniibe committed rC07722d89bac1: kdf,fips: Modify HKDF test for FIPS mode. (authored by gniibe).
kdf,fips: Modify HKDF test for FIPS mode.
Jun 21 2022, 8:40 AM
gniibe added a comment to T6033: Regression in GnuPG 2.2.34 with some ECC keys.

My intention to refer rG7b1db7192 was to specify the HEAD of STABLE-BRANCH-2-2, meaning "the head of STABLE-BRANCH-2-2 today". The commit itself has no meaning.

Jun 21 2022, 7:32 AM · Bug Report, gnupg (gpg22)
gniibe committed rCe0f0c788dc0f: kdf: Add input check for hkdf. (authored by gniibe).
kdf: Add input check for hkdf.
Jun 21 2022, 7:21 AM
l0s created T6038: gpg-wks-client excludes uid with URL in comment.
Jun 21 2022, 7:03 AM · gnupg (gpg22), wkd, Bug Report
gniibe added a comment to T6035: Portability issue: ftruncate.

I created minimized test:

Jun 21 2022, 4:38 AM · backport, gpgagent, gnupg

Jun 20 2022

werner removed a reviewer for D556: Disallow compressed signatures and certificates: werner.
Jun 20 2022, 8:29 PM
DemiMarie abandoned D555: g10: Disallow compressed signatures and certificates.

Closing in favor of D556.

Jun 20 2022, 6:41 PM · gnupg
DemiMarie updated the diff for D556: Disallow compressed signatures and certificates.

When failing due to a bad packet in a detached signature, log the
packet's type.

Jun 20 2022, 6:40 PM
DemiMarie requested review of D556: Disallow compressed signatures and certificates.
Jun 20 2022, 6:32 PM
DemiMarie added a revision to T5993: gpg should reject compressed packets outside of messages: D556: Disallow compressed signatures and certificates.
Jun 20 2022, 6:32 PM · Feature Request, gnupg
werner committed rG52f9e13c0cb3: sm: Improve pkcs#12 debug output. (authored by werner).
sm: Improve pkcs#12 debug output.
Jun 20 2022, 5:34 PM
werner committed rGa4e04375e84e: sm: Rework the PKCS#12 parser to support DFN issued keys. (authored by werner).
sm: Rework the PKCS#12 parser to support DFN issued keys.
Jun 20 2022, 5:34 PM
werner triaged T6037: Allow import of nwer DFN generated P12 files as Normal priority.
Jun 20 2022, 4:43 PM · gnupg (gpg22), S/MIME
ikloecker committed rKLEOPATRAf3e3435bb115: Remove workaround for missing focus indicator for text labels (authored by ikloecker).
Remove workaround for missing focus indicator for text labels
Jun 20 2022, 3:46 PM
ikloecker committed rKLEOPATRA052383e08c62: Add a focus frame to labels that receive keyboard focus (authored by ikloecker).
Add a focus frame to labels that receive keyboard focus
Jun 20 2022, 3:26 PM
ikloecker moved T6036: Kleopatra: Show focus indicator for (text) labels that got focus from Restricted Project Column to Restricted Project Column on the Restricted Project board.
Jun 20 2022, 3:19 PM · kleopatra, Restricted Project
ikloecker triaged T6036: Kleopatra: Show focus indicator for (text) labels that got focus as Normal priority.
Jun 20 2022, 3:19 PM · kleopatra, Restricted Project
werner triaged T6035: Portability issue: ftruncate as Normal priority.
Jun 20 2022, 1:08 PM · backport, gpgagent, gnupg
werner added a comment to T6033: Regression in GnuPG 2.2.34 with some ECC keys.

I fixed the title, because it is not a Windows only issue.

Jun 20 2022, 1:07 PM · Bug Report, gnupg (gpg22)
werner renamed T6033: Regression in GnuPG 2.2.34 with some ECC keys from Regression in GnuPG 2.2.34 on Windows to Regression in GnuPG 2.2.34 with some ECC keys.
Jun 20 2022, 1:06 PM · Bug Report, gnupg (gpg22)
werner added a comment to T6033: Regression in GnuPG 2.2.34 with some ECC keys.

The mentioned "g10: Fix garbled status messages in NOTATION_DATA" has nothing to do with the problem. So it can'r be the actual cause. Anway, I hope to get a 2.2.36 out this week.

Jun 20 2022, 1:05 PM · Bug Report, gnupg (gpg22)
werner added a comment to T6035: Portability issue: ftruncate.

iirc, we use ftruncate for ages now. The problem with the name ftruncate is that it looks to similar to the stdio functions. But sure, things should be flushed first.

Jun 20 2022, 12:59 PM · backport, gpgagent, gnupg
gniibe added projects to T6035: Portability issue: ftruncate: gnupg, gpgagent.
Jun 20 2022, 10:33 AM · backport, gpgagent, gnupg
gniibe created T6035: Portability issue: ftruncate.
Jun 20 2022, 10:33 AM · backport, gpgagent, gnupg
ikloecker moved T6034: Kleopatra: Make links in label text accessible from Restricted Project Column to Restricted Project Column on the Restricted Project board.
Jun 20 2022, 9:40 AM · kleopatra, Restricted Project
gniibe added a comment to T6033: Regression in GnuPG 2.2.34 with some ECC keys.

I can replicate the error by 2.2.35, but I cannot replicate it with rG7b1db7192.
I tested:

  • GNU/Linux
    • i686
    • x86_64
  • Windows
    • i686
Jun 20 2022, 8:33 AM · Bug Report, gnupg (gpg22)
werner removed a reviewer for D555: g10: Disallow compressed signatures and certificates: gniibe.
Jun 20 2022, 8:05 AM · gnupg
gniibe committed rA97516d6c24b9: Don't access NULL by wipememory. (authored by gniibe).
Don't access NULL by wipememory.
Jun 20 2022, 4:51 AM
gniibe committed rA5277f24ab4b0: Fix the previous commit. (authored by gniibe).
Fix the previous commit.
Jun 20 2022, 4:51 AM

Jun 18 2022

DemiMarie edited reviewers for D555: g10: Disallow compressed signatures and certificates, added: gniibe; removed: sergei, gp_ast.
Jun 18 2022, 1:38 AM · gnupg
DemiMarie added reviewers for D555: g10: Disallow compressed signatures and certificates: sergei, gp_ast.
Jun 18 2022, 1:35 AM · gnupg
DemiMarie removed a reviewer for D555: g10: Disallow compressed signatures and certificates: werner.
Jun 18 2022, 1:34 AM · gnupg

Jun 17 2022

DemiMarie updated the summary of D555: g10: Disallow compressed signatures and certificates.
Jun 17 2022, 8:37 PM · gnupg
DemiMarie added a comment to D555: g10: Disallow compressed signatures and certificates.

Compressed packets in detached signatures and/or certificates have never been permitted by any version of the standard.

Jun 17 2022, 8:36 PM · gnupg
DemiMarie updated subscribers of D555: g10: Disallow compressed signatures and certificates.
In D555#5569, @werner wrote:

Sorry, there is no padding packet in OpenPGP. Please do no try to push ideas from that crypto-refresh-06 thing into GnuPG. We continue to follow the last draft with consesus, which is rfc4880bis-10.

Jun 17 2022, 8:26 PM · gnupg
DemiMarie updated the diff for D555: g10: Disallow compressed signatures and certificates.
Jun 17 2022, 8:21 PM · gnupg
Purkkapallo updated Purkkapallo.
Jun 17 2022, 4:25 PM
ikloecker committed rKLEOPATRAa04592573c74: Use our HtmlLabel for the Welcome message (authored by ikloecker).
Use our HtmlLabel for the Welcome message
Jun 17 2022, 3:38 PM
ikloecker committed rKLEOPATRA0ddc9744ebbf: Make links in label text accessible (authored by ikloecker).
Make links in label text accessible
Jun 17 2022, 3:38 PM
ikloecker committed rKLEOPATRAa4b6783f5374: Make "select label text on focus" workaround customizable (authored by ikloecker).
Make "select label text on focus" workaround customizable
Jun 17 2022, 3:38 PM
ikloecker committed rKLEOPATRA9ffe17d3bcd8: Implement the action interface for AccessibleLink (authored by ikloecker).
Implement the action interface for AccessibleLink
Jun 17 2022, 3:38 PM
ikloecker triaged T6034: Kleopatra: Make links in label text accessible as Normal priority.
Jun 17 2022, 2:37 PM · kleopatra, Restricted Project
werner assigned T6033: Regression in GnuPG 2.2.34 with some ECC keys to gniibe.

The likely cause is that the secret key is not protected. Problem seems to be in gpg-agent.

Jun 17 2022, 12:39 PM · Bug Report, gnupg (gpg22)
werner triaged T6033: Regression in GnuPG 2.2.34 with some ECC keys as High priority.

Looking again at your report, I don't think it is an IPC problem (bad magic cooky was my assumption). I can replicate this with the current 2.2 but not with 2.3. Both un Unix.

Jun 17 2022, 12:36 PM · Bug Report, gnupg (gpg22)
werner committed rGbe5d06dae239: agent: Improve "Insert the card" message. (authored by werner).
agent: Improve "Insert the card" message.
Jun 17 2022, 12:24 PM
werner triaged T6030: Missing support for the Brave Web Browser on Windows as Normal priority.
Jun 17 2022, 7:48 AM · gpgme, Feature Request, gpg4win

Jun 16 2022

DemiMarie added a comment to T6031: Creating an overlong notation hits a fatal error..

{please add comments instead of adding the description - a changed description makes it hard to understand follow up comments. I will change the title, though for clarity.]

Jun 16 2022, 7:19 PM · Bug Report, gnupg
werner removed a member for Contributor: DemiMarie.
Jun 16 2022, 7:03 PM
werner closed T6021: GPG misparses `--list-options=show-sig-subpackets="100"a` as Wontfix.

Please don't play ping pong now,

Jun 16 2022, 7:02 PM · g10, Bug Report
werner closed T6032: Assertion failure in gpg as Invalid.

Please report such bugs to RedHat - they use a modified Libgcrypt and thus it's there bug.

Jun 16 2022, 7:00 PM · RHEL, g10, Bug Report
werner resigned from D555: g10: Disallow compressed signatures and certificates.
Jun 16 2022, 6:58 PM · gnupg
werner requested changes to D555: g10: Disallow compressed signatures and certificates.

Sorry, there is no padding packet in OpenPGP. Please do no try to push ideas from that crypto-refresh-06 thing into GnuPG. We continue to follow the last draft with consesus, which is rfc4880bis-10.

Jun 16 2022, 6:56 PM · gnupg
werner renamed T6031: Creating an overlong notation hits a fatal error. from Creating an overlong notation crashes gpg to Creating an overlong notation hits a fatal error..
Jun 16 2022, 6:54 PM · Bug Report, gnupg
werner triaged T6031: Creating an overlong notation hits a fatal error. as Wishlist priority.

The length limit of the signature sub packets are not reasy to pre-compute. Better to have a fatal error than a corrupt message. I am not sure whether we want to change this to a regualar error message - at that point we anyway need to stop.

Jun 16 2022, 6:54 PM · Bug Report, gnupg
DemiMarie edited projects for D555: g10: Disallow compressed signatures and certificates, added: gnupg; removed g10.
Jun 16 2022, 6:53 PM · gnupg
DemiMarie added a task to D555: g10: Disallow compressed signatures and certificates: T5993: gpg should reject compressed packets outside of messages.
Jun 16 2022, 6:53 PM · gnupg
DemiMarie added a revision to T5993: gpg should reject compressed packets outside of messages: D555: g10: Disallow compressed signatures and certificates.
Jun 16 2022, 6:53 PM · Feature Request, gnupg
DemiMarie retitled D555: g10: Disallow compressed signatures and certificates from Disallow compressed signatures and certificates to g10: Disallow compressed signatures and certificates.
Jun 16 2022, 6:53 PM · gnupg
DemiMarie raised the priority of T6021: GPG misparses `--list-options=show-sig-subpackets="100"a` from Low to Needs Triage.
Jun 16 2022, 6:52 PM · g10, Bug Report
werner edited projects for T6033: Regression in GnuPG 2.2.34 with some ECC keys, added: Not A Bug, Windows, gnupg (gpg22); removed Bug Report.

You deleted the socket file but you did not restart the agent. Thus gpg can't contact the agent anymore. On Windows we use a socket emulation which requires the socket's file only for a new connection (to get the port and magic cookie).

Jun 16 2022, 6:48 PM · Bug Report, gnupg (gpg22)
DemiMarie added a comment to T6032: Assertion failure in gpg.

I will try, but it will likely be a while. In any case I believe you will need a Red Hat-family distro to trigger the bug; it happens when gpg trys to encrypt with a key that uses a public key algorithm libgcrypt does not support.

Jun 16 2022, 6:42 PM · RHEL, g10, Bug Report
werner added a comment to T6032: Assertion failure in gpg.

Please provide a test case.

Jun 16 2022, 6:39 PM · RHEL, g10, Bug Report
werner triaged T6029: ntbtls: Require TLS 1.2 or later + AEAD by default as Normal priority.
Jun 16 2022, 6:37 PM · Not A Bug, ntbtls
cklassen committed rWb49317beab84: spelling (authored by cklassen).
spelling
Jun 16 2022, 5:06 PM
cklassen committed rW3cbc2d8c7a79: wrote text less cumbersome (authored by cklassen).
wrote text less cumbersome
Jun 16 2022, 4:33 PM
justus created T6033: Regression in GnuPG 2.2.34 with some ECC keys.
Jun 16 2022, 3:35 PM · Bug Report, gnupg (gpg22)
DemiMarie reopened T6021: GPG misparses `--list-options=show-sig-subpackets="100"a` as "Open".

Reopening as it appears this issue was closed based on an incorrect understanding of what it is.

Jun 16 2022, 3:20 PM · g10, Bug Report
DemiMarie reopened T6032: Assertion failure in gpg as "Open".

Reopening as gpg’s handling of the situation is very much suboptimal.

Jun 16 2022, 3:19 PM · RHEL, g10, Bug Report
ikloecker committed rLIBKLEO6541fa3dd6b6: GIT_SILENT Unify include of local headers (authored by ikloecker).
GIT_SILENT Unify include of local headers
Jun 16 2022, 2:50 PM
ikloecker committed rLIBKLEOf641eca34cb1: GIT_SILENT Remove duplicate includes (authored by ikloecker).
GIT_SILENT Remove duplicate includes
Jun 16 2022, 2:50 PM
ikloecker committed rLIBKLEO74e15b5b629c: GIT_SILENT Unify include of local headers in header files (authored by ikloecker).
GIT_SILENT Unify include of local headers in header files
Jun 16 2022, 2:50 PM
ikloecker committed rLIBKLEOebbb92b99438: GIT_SILENT Include config-libkleo.h in all source files (authored by ikloecker).
GIT_SILENT Include config-libkleo.h in all source files
Jun 16 2022, 2:50 PM
ikloecker committed rLIBKLEOecf00334f881: GIT_SILENT Unify include of debug headers (authored by ikloecker).
GIT_SILENT Unify include of debug headers
Jun 16 2022, 2:50 PM
ikloecker committed rLIBKLEO642fdd93bc58: GIT_SILENT Move tests subdirectory to top-level (authored by ikloecker).
GIT_SILENT Move tests subdirectory to top-level
Jun 16 2022, 2:50 PM
ikloecker committed rKLEOPATRA3f8e20aa6af4: Avoid deprecation warning (authored by ikloecker).
Avoid deprecation warning
Jun 16 2022, 2:25 PM
ikloecker committed rKLEOPATRA30294906a26f: Avoid deprecation warning (authored by ikloecker).
Avoid deprecation warning
Jun 16 2022, 2:25 PM
ikloecker committed rKLEOPATRA4e9fd9677586: Make lambdas used in std::accumulate compatible with C++20 (authored by ikloecker).
Make lambdas used in std::accumulate compatible with C++20
Jun 16 2022, 2:25 PM
ikloecker committed rKLEOPATRA5a2eb383220b: Require C++20 (authored by ikloecker).
Require C++20
Jun 16 2022, 2:25 PM
ikloecker committed rKLEOPATRA2e520331fb87: Fix raising main window (authored by Nicolas Fella <nicolas.fella@gmx.de>).
Fix raising main window
Jun 16 2022, 2:19 PM
gniibe added a comment to T5964: gnupg should use the KDFs implemented in libgcrypt.

I pushed the change needed for GnuPG to t5964 branch.
See: https://dev.gnupg.org/rGc281bd94349e4f7997a89927aaa2c2f45004b902

Jun 16 2022, 8:47 AM · gnupg26, FIPS, Feature Request
gniibe added a comment to T5964: gnupg should use the KDFs implemented in libgcrypt.

Added HKDF implementation to master.

Jun 16 2022, 8:18 AM · gnupg26, FIPS, Feature Request
gniibe committed rCfbddfb964f0b: kdf: Add HKDF of RFC5869. (authored by gniibe).
kdf: Add HKDF of RFC5869.
Jun 16 2022, 8:04 AM