Maniphest T5863

pinentry-qt: Further improve the accessibility
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	ikloecker
	Mar 1 2022, 9:58 AM

Tags

Subscribers

Description

In particular, it should be possible to navigate to individual text labels with the keyboard to allow people using accessibility tools to read them.

Revisions and Commits

rP Pinentry
		rPf9e9cdae9b14 qt: Remove focus indication by text selection
		rPedc17d497d67 qt: Use same focus indication for labels as Kleopatra
		rP0f8e361f4331 qt: Do not set accessible description of text labels
		rP1b60a7e5a39e qt: Do not set accessible name and description of dialog
		rPb2208048be77 qt: Do not set accessible description of buttons
		rP42af54bece51 qt: Make text label in pinentry message box focusable
		rPb6370f87d247 qt: Extract function for selecting the text of a QLabel
		rP4435e9fa206f qt: Fix reaction to Escape key and close button of window
		rPe7bcc0894e3a qt: Modernize code
		rP50ad2196d3f6 qt: Make text labels focusable if accessibility is active
		rPc75350edce1b qt: Allow text of all labels to be selected with the mouse
		rPe19dc862774e qt: Do not set an empty tool tip
	D549	rPdd9f76525823 qt: Create all widgets in tab order
		rP09f92e7123c2 qt: Ensure visual feedback when a text label gets focus

Related Objects
Search...

		Status	Assigned	Task
		Open	None	T5824 Kleopatra: Full accessibility support
		Resolved	aheinecke	T5842 Gpg4win LTS 3.1.22
		Resolved	• ebo	T5845 Kleopatra: Accessibility for file encryption
		Resolved	• ebo	T5863 pinentry-qt: Further improve the accessibility

Event Timeline

ikloecker triaged this task as Normal priority.Mar 1 2022, 9:58 AM

ikloecker created this task.

ikloecker moved this task from Restricted Project Column to Restricted Project Column on the Restricted Project board.

ikloecker added a commit: rPdd9f76525823: qt: Create all widgets in tab order.Mar 1 2022, 4:48 PM

ikloecker added a commit: rP09f92e7123c2: qt: Ensure visual feedback when a text label gets focus.

ikloecker added a commit: rPe19dc862774e: qt: Do not set an empty tool tip.

ikloecker added a commit: rP50ad2196d3f6: qt: Make text labels focusable if accessibility is active.

ikloecker added a commit: rPc75350edce1b: qt: Allow text of all labels to be selected with the mouse.

ikloecker added a commit: rP4435e9fa206f: qt: Fix reaction to Escape key and close button of window.Mar 2 2022, 6:14 PM

ikloecker added a commit: rPe7bcc0894e3a: qt: Modernize code.

ikloecker added a commit: rPb6370f87d247: qt: Extract function for selecting the text of a QLabel.

ikloecker added a commit: rP42af54bece51: qt: Make text label in pinentry message box focusable.

Ready for testing

ikloecker removed ikloecker as the assignee of this task.Mar 3 2022, 2:40 PM

Fix issues found while testing with NVDA.

ikloecker added a commit: rPb2208048be77: qt: Do not set accessible description of buttons.Aug 24 2022, 3:26 PM

ikloecker added a commit: rP0f8e361f4331: qt: Do not set accessible description of text labels.

ikloecker added a commit: rP1b60a7e5a39e: qt: Do not set accessible name and description of dialog.

This is now ready for testing.

ikloecker added a commit: rPedc17d497d67: qt: Use same focus indication for labels as Kleopatra.Oct 28 2022, 11:05 AM

ikloecker added a commit: rPf9e9cdae9b14: qt: Remove focus indication by text selection.

closing with reference to external testing

• ebo moved this task from Restricted Project Column to Restricted Project Column on the Restricted Project board.Apr 5 2023, 2:49 PM

• werner mentioned this in T7046: Release Pinentry 1.3.x.Mar 18 2024, 12:16 PM

• werner mentioned this in T5566: Release Pinentry 1.2.x.Mar 18 2024, 12:20 PM