Maniphest T5845

Kleopatra: Accessibility for file encryption
Closed, ResolvedPublic
Actions

Assigned To
• ebo
Authored By
• aheinecke
Feb 18 2022, 8:57 AM
Tags
Subscribers
• aheinecke
• ebo
• ikloecker
wk

Revisions and Commits

rLIBKLEO Libkleo
rLIBKLEO23fe13c5ecdc Use the same text for display and accessibility tools
rLIBKLEO6de644bf4648 Make the model used for the key selection combo a single-column model
rLIBKLEO99aa5efa6abe Allow setting the accessible name of the underlying line edit
rLIBKLEO9d68d7e32fb8 Improve accessibility of "Open file dialog" button
rKLEOPATRA Kleopatra
rKLEOPATRA89467cf4a0a3 Insert all selected certificates/groups back-to-back
rKLEOPATRA5bad3a6b47e6 Do not remove recipient widgets when they become empty
rKLEOPATRAc6fa286c9dd7 Fix passing focus to next recipient widget if removed had focus
rKLEOPATRA60536ecf8545 Refactor: Use a single flag for keeping track of editing
rKLEOPATRA0a86e01d19f6 Prefix error messages with "Error: "
rKLEOPATRAf246c9803028 Make error state and message of certificate input field more accessible
rKLEOPATRA60e3ae56ec2c Make the error concerning a recipient input field more prominent
rKLEOPATRAbd4a5291d81a Disable the Encrypt button if required information is missing
rKLEOPATRAe650628e9b38 Use locateKeysJob instead of keyForMailboxJob for locating key
rKLEOPATRAba966cc7798f Perform key lookup only if there is no matching key or group
rKLEOPATRAbc34c70d8983 Treat whitespace-only text as empty
rKLEOPATRA0d2cb43c681c Focus first unresolved recipient if validation fails
rKLEOPATRAcbc7d23be891 Filter certificate list with name/email of current key/group
rKLEOPATRAe92e31289efc Fix setting accessible name of recipient key input field
rKLEOPATRA62ec8eee5ebf Simplify the action of the recipient key input field
rKLEOPATRA0f2c2caabce8 Make showing details of matching certificate/group accessible
rKLEOPATRAfb0a38c07c5a Filter certificate list with current text of input field
rKLEOPATRA73e8c9b24c7c Make "Show certificate list" action accessible
rKLEOPATRA720e8f9e14bd Pimpl CertificateLineEdit
rKLEOPATRAf416737ac9f3 Set accessible name for recipient key input field
rKLEOPATRAc588a624db26 Set key/group summary if we have a key/group on editing finished
rKLEOPATRA8994f1ce7dff Ensure update of line action on text changed after editing finished
rKLEOPATRA4d3c5b420f8d Make the model used for auto completion a single-column model
rKLEOPATRA91db9838aeaf Improve accessibility of the filename requesters

Related Objects
Search...

Event Timeline

• aheinecke triaged this task as Normal priority.Feb 18 2022, 8:57 AM
• aheinecke created this task.
• aheinecke added a parent task: T5842: Gpg4win LTS 3.1.22.Feb 18 2022, 9:09 AM
• aheinecke removed a subtask: T5846: Kleopatra: File operation resultlistwidget accessibility (contrast).
• aheinecke mentioned this in T5824: Kleopatra: Full accessibility support.Feb 18 2022, 9:14 AM
• ikloecker claimed this task.Feb 23 2022, 1:35 PM
• ikloecker moved this task from Restricted Project Column to Restricted Project Column on the Restricted Project board.
• ikloecker added a commit: rLIBKLEO9d68d7e32fb8: Improve accessibility of "Open file dialog" button.Feb 23 2022, 4:19 PM
• ikloecker added a commit: rLIBKLEO99aa5efa6abe: Allow setting the accessible name of the underlying line edit.
• ikloecker added a commit: rKLEOPATRA91db9838aeaf: Improve accessibility of the filename requesters.Feb 23 2022, 4:34 PM
• ikloecker changed the task status from Open to Testing.Mar 3 2022, 2:40 PM
• ikloecker removed • ikloecker as the assignee of this task.
• ikloecker changed the status of subtask T5863: pinentry-qt: Further improve the accessibility from Open to Testing.
• ikloecker moved this task from Restricted Project Column to Restricted Project Column on the Restricted Project board.

Ready for testing

• ikloecker changed the task status from Testing to Open.Mar 3 2022, 2:46 PM
• ikloecker claimed this task.
• ikloecker moved this task from Restricted Project Column to Restricted Project Column on the Restricted Project board.

From the parent task "I think having the [...] keyselection when encrypting improved is the best way to help current users of the software who might already have received help from a collegue to import and have a list of certified certificates available."

-> Checking accessibility of key selection.

• ikloecker added a commit: rLIBKLEO6de644bf4648: Make the model used for the key selection combo a single-column model.Mar 3 2022, 5:16 PM
• ikloecker added a commit: rKLEOPATRA8994f1ce7dff: Ensure update of line action on text changed after editing finished.Mar 8 2022, 6:18 PM
• ikloecker added a commit: rKLEOPATRA4d3c5b420f8d: Make the model used for auto completion a single-column model.
• ikloecker added a commit: rKLEOPATRAc588a624db26: Set key/group summary if we have a key/group on editing finished.
• ikloecker added a commit: rKLEOPATRAf416737ac9f3: Set accessible name for recipient key input field.Mar 9 2022, 4:18 PM
• ikloecker added a commit: rKLEOPATRA720e8f9e14bd: Pimpl CertificateLineEdit.
• ikloecker added a commit: rKLEOPATRA73e8c9b24c7c: Make "Show certificate list" action accessible.
• ikloecker added a commit: rKLEOPATRAfb0a38c07c5a: Filter certificate list with current text of input field.
• ikloecker added a commit: rKLEOPATRA0f2c2caabce8: Make showing details of matching certificate/group accessible.
• ikloecker added a commit: rKLEOPATRA62ec8eee5ebf: Simplify the action of the recipient key input field.
• ikloecker added a commit: rKLEOPATRAe92e31289efc: Fix setting accessible name of recipient key input field.Mar 10 2022, 2:13 PM
• ikloecker added a commit: rKLEOPATRAcbc7d23be891: Filter certificate list with name/email of current key/group.Mar 10 2022, 3:22 PM
• ikloecker added a commit: rKLEOPATRA0d2cb43c681c: Focus first unresolved recipient if validation fails.Mar 10 2022, 3:50 PM
• ikloecker added a commit: rKLEOPATRAe650628e9b38: Use locateKeysJob instead of keyForMailboxJob for locating key.Mar 16 2022, 4:47 PM
• ikloecker added a commit: rKLEOPATRAba966cc7798f: Perform key lookup only if there is no matching key or group.
• ikloecker added a commit: rKLEOPATRAbc34c70d8983: Treat whitespace-only text as empty.
• ikloecker added a commit: rKLEOPATRA60e3ae56ec2c: Make the error concerning a recipient input field more prominent.
• ikloecker added a commit: rKLEOPATRAbd4a5291d81a: Disable the Encrypt button if required information is missing.
• ikloecker added a commit: rKLEOPATRAf246c9803028: Make error state and message of certificate input field more accessible.
• ikloecker added a commit: rKLEOPATRA0a86e01d19f6: Prefix error messages with "Error: ".
• ikloecker added a commit: rKLEOPATRAc6fa286c9dd7: Fix passing focus to next recipient widget if removed had focus.
• ikloecker added a commit: rKLEOPATRA60536ecf8545: Refactor: Use a single flag for keeping track of editing.
• ikloecker added a commit: rKLEOPATRA5bad3a6b47e6: Do not remove recipient widgets when they become empty.
• ikloecker added a commit: rKLEOPATRA89467cf4a0a3: Insert all selected certificates/groups back-to-back.Mar 28 2022, 12:22 PM
• ikloecker moved this task from Restricted Project Column to Restricted Project Column on the Restricted Project board.Mar 28 2022, 1:40 PM
• ikloecker changed the status of subtask T5863: pinentry-qt: Further improve the accessibility from Testing to Open.Aug 23 2022, 5:53 PM
• ikloecker added a commit: rLIBKLEO23fe13c5ecdc: Use the same text for display and accessibility tools.Aug 30 2022, 10:01 AM
• ikloecker changed the status of subtask T5863: pinentry-qt: Further improve the accessibility from Open to Testing.Oct 28 2022, 10:49 AM
• ikloecker changed the task status from Open to Testing.Dec 19 2022, 5:19 PM
• ikloecker removed • ikloecker as the assignee of this task.
• ikloecker moved this task from Restricted Project Column to Restricted Project Column on the Restricted Project board.

Finished for now. Not sure if there's much we can/should test ourselves. Maybe we should simply close it and open new tasks for the findings in the report of the next accessibility test.

• ebo closed this task as Resolved.Mar 20 2023, 11:42 AM
• ebo claimed this task.
• ebo added a subscriber: • ebo.

closing and opening new tasks is the best option

• ebo closed subtask T5863: pinentry-qt: Further improve the accessibility as Resolved.Mar 20 2023, 11:52 AM
• ebo moved this task from Restricted Project Column to Restricted Project Column on the Restricted Project board.Apr 5 2023, 2:49 PM