Page MenuHome GnuPG
Feed Advanced Search

Jun 3 2021

gniibe claimed T5464: Failure to import Curve25519 ECDH secret subkey to the GnupG..
Jun 3 2021, 8:26 AM · Support, gnupg, OpenPGP
gniibe committed rG9668ee097a14: gpg: Support KEYGRIP search with traditional keyring. (authored by gniibe).
gpg: Support KEYGRIP search with traditional keyring.
Jun 3 2021, 6:32 AM
gniibe added a comment to T5469: GnuPG 2.3 regression: keydb_search failed: Invalid argument.

Here, we use keygrip search: https://dev.gnupg.org/source/gnupg/browse/master/g10/skclist.c$429

Jun 3 2021, 4:52 AM · gnupg (gpg23)
gniibe triaged T5469: GnuPG 2.3 regression: keydb_search failed: Invalid argument as High priority.
Jun 3 2021, 4:48 AM · gnupg (gpg23)

Jun 2 2021

gniibe added a comment to T5369: GnuPG build on Apple with Clang.

jitterentropy is also used in Linux kernel, and some people use clang to build it these days. So, I checked the kernel's one. It is simply compiled -O0 by Makefile, and there's no pragma line now (as of v5.13).

Jun 2 2021, 3:16 AM · libgcrypt, MacOS, Bug Report
gniibe added a comment to T5460: Migration for ABI change (newer mingw).

With sqlite3 using -static-libgcc, I confirmed that GnuPG and its friends are built well with newer mingw on bullseye. And I lightly tested GnuPG on Windows.

Jun 2 2021, 3:07 AM · gpg4win, Windows

Jun 1 2021

gniibe added a comment to T5460: Migration for ABI change (newer mingw).

Ah, I realized that the build for sqlite3 in Speedo has a patch using -static-libgcc.

Jun 1 2021, 10:05 AM · gpg4win, Windows
gniibe updated the task description for T5460: Migration for ABI change (newer mingw).
Jun 1 2021, 6:14 AM · gpg4win, Windows
gniibe created T5460: Migration for ABI change (newer mingw).
Jun 1 2021, 6:12 AM · gpg4win, Windows
gniibe committed rCf6a4e22d86d2: random: Silence a warning for building rndjent by Clang. (authored by gniibe).
random: Silence a warning for building rndjent by Clang.
Jun 1 2021, 4:36 AM
gniibe closed T5369: GnuPG build on Apple with Clang as Resolved.

That warning could be silenced by surrounding pragma with #ifdef __OPTIMIZE__ (with should be supported by GCC and Clang).

Jun 1 2021, 4:09 AM · libgcrypt, MacOS, Bug Report
gniibe added a comment to T5457: libgcrypt unable to be compiled with clang.

Thanks for your report.

Jun 1 2021, 4:03 AM · libgcrypt, Bug Report

May 31 2021

gniibe committed rPTH5020c2b9c939: build: Add -Wpointer-arith if available. (authored by gniibe).
build: Add -Wpointer-arith if available.
May 31 2021, 4:41 AM
gniibe committed rPTH1b4ca92e720c: tests: Minor fixes for test programs. (authored by gniibe).
tests: Minor fixes for test programs.
May 31 2021, 4:36 AM

May 28 2021

gniibe edited projects for T5436: gpg-agent 2.3.1: PIN caching not working for decrypt operations, added: yubikey; removed MacOS.
May 28 2021, 7:19 AM · gnupg24, yubikey, Bug Report
gniibe triaged T5436: gpg-agent 2.3.1: PIN caching not working for decrypt operations as High priority.
May 28 2021, 7:18 AM · gnupg24, yubikey, Bug Report
gniibe claimed T5436: gpg-agent 2.3.1: PIN caching not working for decrypt operations.

Thanks. I push the fix of yours.

May 28 2021, 7:17 AM · gnupg24, yubikey, Bug Report
gniibe committed rG36f50b259cae: agent: Fix calling handle_pincache_put. (authored by gniibe).
agent: Fix calling handle_pincache_put.
May 28 2021, 6:48 AM
gniibe committed rG5b1806454c03: scd: Fix zero-byte handling in ECC. (authored by gniibe).
scd: Fix zero-byte handling in ECC.
May 28 2021, 4:36 AM
gniibe merged T5451: disable-ccid breaks gpg-agent caching on MacOS (gpg 2.3.1) into T5436: gpg-agent 2.3.1: PIN caching not working for decrypt operations.
May 28 2021, 3:23 AM · gnupg24, yubikey, Bug Report
gniibe merged task T5451: disable-ccid breaks gpg-agent caching on MacOS (gpg 2.3.1) into T5436: gpg-agent 2.3.1: PIN caching not working for decrypt operations.
May 28 2021, 3:23 AM · scd, gnupg (gpg23), MacOS, Bug Report

May 27 2021

gniibe committed rG2b50f942672d: gpg: Ed448 and X448 are only for v5 for --full-gen-key. (authored by gniibe).
gpg: Ed448 and X448 are only for v5 for --full-gen-key.
May 27 2021, 10:07 AM
gniibe committed rT01464c04267a: build: _DARWIN_C_SOURCE should be 1. (authored by gniibe).
build: _DARWIN_C_SOURCE should be 1.
May 27 2021, 9:21 AM
gniibe committed rA335030e3d204: build: _DARWIN_C_SOURCE should be 1. (authored by gniibe).
build: _DARWIN_C_SOURCE should be 1.
May 27 2021, 7:16 AM
gniibe committed rM792a7e7f04ea: build: Update gpg-error.m4 (authored by gniibe).
build: Update gpg-error.m4
May 27 2021, 7:00 AM
gniibe committed rM367b9e748860: build: _DARWIN_C_SOURCE should be 1. (authored by gniibe).
build: _DARWIN_C_SOURCE should be 1.
May 27 2021, 7:00 AM
gniibe committed rKa375a3d20e83: build: _DARWIN_C_SOURCE should be 1. (authored by gniibe).
build: _DARWIN_C_SOURCE should be 1.
May 27 2021, 6:48 AM
gniibe changed the status of T5440: _DARWIN_C_SOURCE kind of "must" be 1, not "900000L" from Open to Testing.
May 27 2021, 6:41 AM · MacOS, libgcrypt, Bug Report
gniibe added a comment to T5440: _DARWIN_C_SOURCE kind of "must" be 1, not "900000L".

Done for all (libgcrypt (master, 1.9, and 1.8), libassuan, ntbtls, libksba, gpgme, gnupg (2.2 and 2.3).

May 27 2021, 6:40 AM · MacOS, libgcrypt, Bug Report
gniibe committed rG40b2890b4349: build: _DARWIN_C_SOURCE should be 1. (authored by gniibe).
build: _DARWIN_C_SOURCE should be 1.
May 27 2021, 6:34 AM
gniibe committed rGbe81941e1aca: build: _DARWIN_C_SOURCE should be 1. (authored by gniibe).
build: _DARWIN_C_SOURCE should be 1.
May 27 2021, 6:32 AM
gniibe committed rCb9a14725ec13: build: _DARWIN_C_SOURCE should be 1. (authored by gniibe).
build: _DARWIN_C_SOURCE should be 1.
May 27 2021, 6:21 AM
gniibe added a comment to T5443: Debian ppc64el failure of 'make check with_valgrind=1'.

I test on ppc64 machine (POWER9, big endian).

May 27 2021, 4:38 AM · gnupg

May 26 2021

gniibe committed rC632d80ef30e1: cipher: Fix ElGamal encryption for other implementations. (authored by gniibe).
cipher: Fix ElGamal encryption for other implementations.
May 26 2021, 8:56 AM

May 25 2021

gniibe added a comment to T5328: On the (in)security of Elgamal in OpenPGP.

CVE-2021-33560

May 25 2021, 2:46 AM · side-channel, CVE, libgcrypt

May 21 2021

gniibe committed rEf9b50dafc5d3: build: _DARWIN_C_SOURCE should be 1. (authored by gniibe).
build: _DARWIN_C_SOURCE should be 1.
May 21 2021, 7:10 AM
gniibe claimed T5440: _DARWIN_C_SOURCE kind of "must" be 1, not "900000L".

Thank you for your report.

May 21 2021, 7:04 AM · MacOS, libgcrypt, Bug Report
gniibe added a comment to T5328: On the (in)security of Elgamal in OpenPGP.

Let me rephrase from a viewpoint of mine (an implementer).

May 21 2021, 3:59 AM · side-channel, CVE, libgcrypt
gniibe committed rG5be0d075b1ad: scd: Release memory for RDRNAME. (authored by gniibe).
scd: Release memory for RDRNAME.
May 21 2021, 3:15 AM
gniibe committed rG44c8232b97e9: po: Update Japanese Translation. (authored by gniibe).
po: Update Japanese Translation.
May 21 2021, 3:15 AM

May 20 2021

gniibe added a comment to T5328: On the (in)security of Elgamal in OpenPGP.

The paper describes another problem: interoperability (or interpretation) of "ElGamal encryption", and its impact.

May 20 2021, 8:51 AM · side-channel, CVE, libgcrypt
gniibe updated the task description for T5443: Debian ppc64el failure of 'make check with_valgrind=1'.
May 20 2021, 6:17 AM · gnupg
gniibe added a comment to T5443: Debian ppc64el failure of 'make check with_valgrind=1'.

This is another test case for GNU C library's strncmp:

May 20 2021, 6:05 AM · gnupg
gniibe added a comment to T5443: Debian ppc64el failure of 'make check with_valgrind=1'.

This is the minimized test case.

May 20 2021, 6:02 AM · gnupg
gniibe updated the task description for T5443: Debian ppc64el failure of 'make check with_valgrind=1'.
May 20 2021, 5:45 AM · gnupg
gniibe triaged T5443: Debian ppc64el failure of 'make check with_valgrind=1' as Low priority.
May 20 2021, 5:44 AM · gnupg

May 18 2021

gniibe added a comment to T5439: Bug of t-keydb.c.

Possibly, it keeps running at calibrate_s2k_count, for some reason.

May 18 2021, 4:00 AM · gnupg (gpg23)
gniibe added a comment to T5439: Bug of t-keydb.c.

I was wrong.

May 18 2021, 3:18 AM · gnupg (gpg23)

May 17 2021

gniibe triaged T5439: Bug of t-keydb.c as Normal priority.
May 17 2021, 10:43 AM · gnupg (gpg23)

May 14 2021

gniibe committed rG58b330e935b9: scd: Remove wrong assertion and add protection to PCSC.COUNT. (authored by gniibe).
scd: Remove wrong assertion and add protection to PCSC.COUNT.
May 14 2021, 6:07 AM
gniibe committed rPTH6629a4b8015c: build: Fix detecting pthread library. (authored by gniibe).
build: Fix detecting pthread library.
May 14 2021, 3:58 AM

May 13 2021

gniibe added a comment to T5437: PC/SC change: monitoring card status changes (possibly also for new reader).

I am testing with rGccfb5e0a7dc6: scd: Use SCardStatus for pcsc_get_status. on GNU/Linux.

May 13 2021, 6:19 AM · scd
gniibe renamed T5437: PC/SC change: monitoring card status changes (possibly also for new reader) from PC/SC change monitoring card status changes (possibly also for new reader) to PC/SC change: monitoring card status changes (possibly also for new reader).
May 13 2021, 6:15 AM · scd
gniibe triaged T5437: PC/SC change: monitoring card status changes (possibly also for new reader) as Wishlist priority.
May 13 2021, 6:15 AM · scd

May 11 2021

gniibe changed the status of T5430: "free(): invalid pointer" from --clearsign from Open to Testing.
May 11 2021, 8:43 AM · gnupg (gpg23)
gniibe added a comment to T5430: "free(): invalid pointer" from --clearsign.

Sorry, it's my fault.
Fixed in rGac731dbbbd21: gpg: Fix allocation for EXTRAHASH..

May 11 2021, 7:50 AM · gnupg (gpg23)
gniibe committed rGac731dbbbd21: gpg: Fix allocation for EXTRAHASH. (authored by gniibe).
gpg: Fix allocation for EXTRAHASH.
May 11 2021, 7:50 AM
gniibe added a comment to T5428: PC/SC detecting removal of card.

On Windows, smartcard is also used by logon/logout and certificates handling. Those may be related.

May 11 2021, 3:47 AM · Info Needed, Windows, scd, Bug Report
gniibe added a comment to D531: Keep holding READER_LOCK_TABLE and make clear distinction among close/releasing_PCSC_context/nullify_rdrname.

Applied in rG32baa9acfb15: scd: Serialize READER_TABLE access for PC/SC..

May 11 2021, 3:42 AM · gnupg (gpg23), scd
gniibe added a comment to D531: Keep holding READER_LOCK_TABLE and make clear distinction among close/releasing_PCSC_context/nullify_rdrname.

Please note that we don't use lock in apdu_dev_list_start/finish any more.
Use of lock is narrowed, only within apdu_open_reader function.

May 11 2021, 3:41 AM · gnupg (gpg23), scd
gniibe committed rG32baa9acfb15: scd: Serialize READER_TABLE access for PC/SC. (authored by gniibe).
scd: Serialize READER_TABLE access for PC/SC.
May 11 2021, 3:39 AM

May 10 2021

gniibe updated the diff for D531: Keep holding READER_LOCK_TABLE and make clear distinction among close/releasing_PCSC_context/nullify_rdrname.

Make the lock holding narrower, and it allows no exposing reader_table_lock.

May 10 2021, 7:52 AM · gnupg (gpg23), scd
gniibe added inline comments to D531: Keep holding READER_LOCK_TABLE and make clear distinction among close/releasing_PCSC_context/nullify_rdrname.
May 10 2021, 7:51 AM · gnupg (gpg23), scd
gniibe updated the diff for D531: Keep holding READER_LOCK_TABLE and make clear distinction among close/releasing_PCSC_context/nullify_rdrname.

Exposing reader_table_lock would be better.
I found a dead-lock condition when apdu_close_reader is called during apdu_dev_list_start/finish.

May 10 2021, 7:06 AM · gnupg (gpg23), scd
gniibe claimed T5428: PC/SC detecting removal of card.

I wonder if PCSC_SHARE_SHARED is related or not.

May 10 2021, 6:32 AM · Info Needed, Windows, scd, Bug Report
gniibe created T5428: PC/SC detecting removal of card.
May 10 2021, 5:40 AM · Info Needed, Windows, scd, Bug Report
gniibe updated the diff for D531: Keep holding READER_LOCK_TABLE and make clear distinction among close/releasing_PCSC_context/nullify_rdrname.

And if the coding style of hiding mutex_lock/mutex_unlock inside different functions matters, we can expose the mutex to its user.

May 10 2021, 4:32 AM · gnupg (gpg23), scd
gniibe added a comment to D531: Keep holding READER_LOCK_TABLE and make clear distinction among close/releasing_PCSC_context/nullify_rdrname.

Last commit will be:

May 10 2021, 4:29 AM · gnupg (gpg23), scd
gniibe committed rGec5591dc4e1f: scd: Fix close_pcsc_reader. (authored by gniibe).
scd: Fix close_pcsc_reader.
May 10 2021, 3:56 AM
gniibe committed rGcccc9bd5db1f: scd: Make sure releasing PC/SC context. (authored by gniibe).
scd: Make sure releasing PC/SC context.
May 10 2021, 3:56 AM
gniibe added a comment to D531: Keep holding READER_LOCK_TABLE and make clear distinction among close/releasing_PCSC_context/nullify_rdrname.

The second commit is replacing a use case of close_pcsc_reader by clearing pcsc.rdrname and calling release_pcsc_context.
This makes the use of close_pcsc_reader to its original purpose only (== closing PC/SC reader as a method of close_reader).

May 10 2021, 3:48 AM · gnupg (gpg23), scd
gniibe added a comment to D531: Keep holding READER_LOCK_TABLE and make clear distinction among close/releasing_PCSC_context/nullify_rdrname.

OK. As I pointed out a commit having multiple things may make analysis difficult, I should have been careful.
So, let me fix the problem by multiple commits.

May 10 2021, 3:28 AM · gnupg (gpg23), scd

May 7 2021

gniibe added a comment to T5416: [windows] Smartcards are less reliable under 2.3.1 (requires restarting gpg-agent.exe).

The problem is accesses to reader_table by
(1) scanning reader(s) to open new one
(2) closing reader

May 7 2021, 6:59 AM · yubikey, scd, gnupg (gpg23), Bug Report
gniibe added a comment to T5416: [windows] Smartcards are less reliable under 2.3.1 (requires restarting gpg-agent.exe).

I'm testing D531: Keep holding READER_LOCK_TABLE and make clear distinction among close/releasing_PCSC_context/nullify_rdrname, but I'm not sure about the impact on Windows.

May 7 2021, 6:54 AM · yubikey, scd, gnupg (gpg23), Bug Report
gniibe requested review of D531: Keep holding READER_LOCK_TABLE and make clear distinction among close/releasing_PCSC_context/nullify_rdrname.
May 7 2021, 6:51 AM · gnupg (gpg23), scd
gniibe reopened T5416: [windows] Smartcards are less reliable under 2.3.1 (requires restarting gpg-agent.exe) as "Open".

The commit rGbb8e3996e44f: scd: Fix problem with reader list becoming empty. removed READER_TABLE_LOCK holding between apdu_dev_list_start and apdu_dev_list_finish, that opens possible stale resource access for CCID driver: reader_table[slot].ccid.handle

May 7 2021, 6:34 AM · yubikey, scd, gnupg (gpg23), Bug Report
gniibe added projects to T5425: scdaemon.conf reader-port setting broken in 2.3: scd, Restricted Project, gnupg.
May 7 2021, 6:05 AM · gnupg, Restricted Project, scd, Bug Report
gniibe claimed T5425: scdaemon.conf reader-port setting broken in 2.3.

Thank you for your report.

May 7 2021, 6:04 AM · gnupg, Restricted Project, scd, Bug Report
gniibe committed rG0498ea8fbd57: scd: Increment PCSC.COUNT correctly. (authored by gniibe).
scd: Increment PCSC.COUNT correctly.
May 7 2021, 4:27 AM
gniibe committed rG5d1b41310682: scd: Fix memory leak for RDRNAME and serialize access. (authored by gniibe).
scd: Fix memory leak for RDRNAME and serialize access.
May 7 2021, 4:27 AM
gniibe committed rG039aed9d401f: scd: Fix declarations for PC/SC access. (authored by gniibe).
scd: Fix declarations for PC/SC access.
May 7 2021, 12:13 AM

May 6 2021

gniibe committed rG53bdc6288f9b: scd: Recover the partial match for PORTSTR for PC/SC. (authored by gniibe).
scd: Recover the partial match for PORTSTR for PC/SC.
May 6 2021, 12:26 PM
gniibe committed rGd6fe82d3d169: scd: When reader is specified, make sure only open once. (authored by gniibe).
scd: When reader is specified, make sure only open once.
May 6 2021, 12:26 PM
gniibe added a comment to T5423: libgcrypt 1.8 ECDH.

Also fixed in version 1.8: rCbd662c090bd4: ecc: Fix the previous commit.

May 6 2021, 7:16 AM · Debian, libgcrypt
gniibe committed rC5f814e8a4968: ecc: Fix the input length check for Montgomery curve. (authored by gniibe).
ecc: Fix the input length check for Montgomery curve.
May 6 2021, 6:13 AM
gniibe added a comment to T5423: libgcrypt 1.8 ECDH.

Note that the handling e part uses standard MPI in 1.8 (while it is done by opaque MPI in 1.9).

May 6 2021, 5:31 AM · Debian, libgcrypt
gniibe triaged T5423: libgcrypt 1.8 ECDH as High priority.
May 6 2021, 5:23 AM · Debian, libgcrypt
gniibe added a comment to T5415: YubiKey no longer recognized in GnuPG 2.3.1 on macOS 10.15.7.

Or... we could add --disable-ccid-driver as default for macOS.

May 6 2021, 3:56 AM · MacOS, yubikey, Bug Report
gniibe claimed T5415: YubiKey no longer recognized in GnuPG 2.3.1 on macOS 10.15.7.
May 6 2021, 3:55 AM · MacOS, yubikey, Bug Report
gniibe added a comment to T5415: YubiKey no longer recognized in GnuPG 2.3.1 on macOS 10.15.7.

If it is built with LIBUSB enabled, please try adding the following to your scdaemon.conf:

disable-ccid
May 6 2021, 3:54 AM · MacOS, yubikey, Bug Report

May 3 2021

gniibe added a project to T5413: Unblock PIN by Reset Code: Restricted Project.
May 3 2021, 6:33 AM · Restricted Project, gnupg, scd
gniibe added a comment to T5409: scdaemon: 'Operation not supported by device' error under macOS after upgrading to 2.3.1.

@colemickens We don't maintain any ccid udev rules in GnuPG. What do you refer?

May 3 2021, 6:29 AM · MacOS, Support, scd

Apr 28 2021

gniibe added a comment to T5409: scdaemon: 'Operation not supported by device' error under macOS after upgrading to 2.3.1.

Perhaps, if a distro haven't offered setting of USB, it would be better to configure GnuPG build with --disable-ccid-driver and only support scdaemon with PC/SC. GPG for Windows does so.

Apr 28 2021, 4:05 AM · MacOS, Support, scd
gniibe added a comment to T5409: scdaemon: 'Operation not supported by device' error under macOS after upgrading to 2.3.1.
  1. It's a breaking change for system with both of PC/SC and CCID. T4673 due to T3300
    • If you configure with no libusb, users don't need 'disable-ccid' option.
  2. I don't know how "wide".
  3. In Debian, it is maintained here: https://salsa.debian.org/debian/gnupg2/-/blob/debian/main/debian/scdaemon.udev
  4. Yes.
Apr 28 2021, 3:59 AM · MacOS, Support, scd
gniibe added a comment to T5410: pinentry-gnome3 no longer functions in Wayland.

To set DISPLAY, dbus-update-activation-environment is your friend.

Apr 28 2021, 3:43 AM · pinentry
gniibe added a comment to T5410: pinentry-gnome3 no longer functions in Wayland.

FYI, for me, on a machine with Debian GNU/Linux, I use Sway, it works fine with pinentry-gnome3.

Apr 28 2021, 3:34 AM · pinentry
gniibe added a comment to rC060c378c050e: ecc: Check the input length for the point..

Backported in rC3f48e3ea37ad: ecc: Check the input length for the point..

Apr 28 2021, 3:20 AM

Apr 27 2021

gniibe committed rGf209d7d2db0e: scd: Fix unblock PIN by a Reset Code with KDF. (authored by kirelagin).
scd: Fix unblock PIN by a Reset Code with KDF.
Apr 27 2021, 1:49 PM
gniibe triaged T5413: Unblock PIN by Reset Code as Normal priority.
Apr 27 2021, 1:45 PM · Restricted Project, gnupg, scd
gniibe created T5413: Unblock PIN by Reset Code.
Apr 27 2021, 1:44 PM · Restricted Project, gnupg, scd