Page MenuHome GnuPG
Feed All Stories

May 10 2021

ikloecker committed rKLEOPATRA3af53c4fc238: Modernize and clean up a bit (authored by ikloecker).
Modernize and clean up a bit
May 10 2021, 4:31 PM
ikloecker committed rKLEOPATRA2cb7c1e23304: Add info button explaining the "Certify as trusted introducer" option (authored by ikloecker).
Add info button explaining the "Certify as trusted introducer" option
May 10 2021, 4:31 PM
ikloecker committed rKLEOPATRA5bee1e13eaed: Remove typedefs obsoleted by auto (authored by ikloecker).
Remove typedefs obsoleted by auto
May 10 2021, 4:31 PM
ikloecker committed rKLEOPATRAf2e5d1fe98c1: Refactor CertifyWidget and CertifyCertificateDialog (authored by ikloecker).
Refactor CertifyWidget and CertifyCertificateDialog
May 10 2021, 4:31 PM
ikloecker committed rKLEOPATRAf2062056b35d: Remove not implemented member function (authored by ikloecker).
Remove not implemented member function
May 10 2021, 4:31 PM
ikloecker committed rKLEOPATRA4aca43dc2ac0: Use std::unique_ptr for d-pointer and initialize members in-class (authored by ikloecker).
Use std::unique_ptr for d-pointer and initialize members in-class
May 10 2021, 4:31 PM
ikloecker committed rKLEOPATRA4c3d353bcd98: Remove unused setters (authored by ikloecker).
Remove unused setters
May 10 2021, 4:31 PM
Laurent Montel <montel@kde.org> committed rLIBKLEOab707f2a95ad: GIT_SILENT: add more clazy check (authored by Laurent Montel <montel@kde.org>).
GIT_SILENT: add more clazy check
May 10 2021, 1:57 PM
Laurent Montel <montel@kde.org> committed rKLEOPATRA06f289cc7d00: GIT_SILENT: add more clazy check (authored by Laurent Montel <montel@kde.org>).
GIT_SILENT: add more clazy check
May 10 2021, 1:56 PM
gillcovid19 placed T5428: PC/SC detecting removal of card up for grabs.
May 10 2021, 12:42 PM · Info Needed, Windows, scd, Bug Report
gillcovid19 closed T5415: YubiKey no longer recognized in GnuPG 2.3.1 on macOS 10.15.7 as Resolved.
May 10 2021, 12:41 PM · MacOS, yubikey, Bug Report
ikloecker added a project to T4876: Generic smartcard widget for PKCS# 15 and other apps: Restricted Project.
May 10 2021, 10:30 AM · Restricted Project, kleopatra
ikloecker claimed T4876: Generic smartcard widget for PKCS# 15 and other apps.
May 10 2021, 10:30 AM · Restricted Project, kleopatra
ikloecker triaged T5429: Kleopatra: Display information about trust signatures as Normal priority.
May 10 2021, 9:36 AM · kleopatra, Restricted Project
ikloecker moved T5175: Kleopatra: Add support for custom groups from Restricted Project Column to Restricted Project Column on the Restricted Project board.
May 10 2021, 9:30 AM · Restricted Project, kleopatra
ikloecker changed the status of T5175: Kleopatra: Add support for custom groups from Open to Testing.
May 10 2021, 9:30 AM · Restricted Project, kleopatra
ikloecker moved T5283: GpgOL: Add mixed mode for S/MIME and OpenPGP to libkleo newkeyresolver from Restricted Project Column to Restricted Project Column on the Restricted Project board.
May 10 2021, 9:28 AM · kleopatra, Restricted Project, gpgol
ikloecker changed the status of T5283: GpgOL: Add mixed mode for S/MIME and OpenPGP to libkleo newkeyresolver from Open to Testing.
May 10 2021, 9:28 AM · kleopatra, Restricted Project, gpgol
ikloecker closed T5421: gpgme++, qgpgme: Add support for creating trust signatures as Resolved.
May 10 2021, 9:27 AM · kleopatra, Restricted Project
ikloecker closed T5421: gpgme++, qgpgme: Add support for creating trust signatures, a subtask of T5245: Kleopatra: Add support for trust signatures / trusted introducer, as Resolved.
May 10 2021, 9:27 AM · kleopatra, Restricted Project
ikloecker moved T5421: gpgme++, qgpgme: Add support for creating trust signatures from Restricted Project Column to Restricted Project Column on the Restricted Project board.
May 10 2021, 9:27 AM · kleopatra, Restricted Project
ikloecker closed T5426: [Pinentry]: add remeber password checkbox in pinentry-qt. as Wontfix.

GnuPG (more precisely gpg-agent) does cache the password for some time in memory. The default is 10 minutes. Add

default-cache-ttl n

where n is the number of seconds to cache the password, to ~/.gnupg/gpg-agent.conf.

May 10 2021, 9:23 AM · Feature Request
werner triaged T5428: PC/SC detecting removal of card as High priority.
May 10 2021, 8:51 AM · Info Needed, Windows, scd, Bug Report
werner added a comment to T5428: PC/SC detecting removal of card.

I don't think that it is --pcsc-shared related; Andre reported that he noticed such a behaviour before we introduced this.

May 10 2021, 8:49 AM · Info Needed, Windows, scd, Bug Report
werner added a comment to D531: Keep holding READER_LOCK_TABLE and make clear distinction among close/releasing_PCSC_context/nullify_rdrname.

We should add a comment at the caller side, that this takes a lock in apdu.c.

May 10 2021, 8:45 AM · gnupg (gpg23), scd
gniibe updated the diff for D531: Keep holding READER_LOCK_TABLE and make clear distinction among close/releasing_PCSC_context/nullify_rdrname.

Make the lock holding narrower, and it allows no exposing reader_table_lock.

May 10 2021, 7:52 AM · gnupg (gpg23), scd
gniibe added inline comments to D531: Keep holding READER_LOCK_TABLE and make clear distinction among close/releasing_PCSC_context/nullify_rdrname.
May 10 2021, 7:51 AM · gnupg (gpg23), scd
gniibe updated the diff for D531: Keep holding READER_LOCK_TABLE and make clear distinction among close/releasing_PCSC_context/nullify_rdrname.

Exposing reader_table_lock would be better.
I found a dead-lock condition when apdu_close_reader is called during apdu_dev_list_start/finish.

May 10 2021, 7:06 AM · gnupg (gpg23), scd
gniibe claimed T5428: PC/SC detecting removal of card.

I wonder if PCSC_SHARE_SHARED is related or not.

May 10 2021, 6:32 AM · Info Needed, Windows, scd, Bug Report
gniibe created T5428: PC/SC detecting removal of card.
May 10 2021, 5:40 AM · Info Needed, Windows, scd, Bug Report
gniibe updated the diff for D531: Keep holding READER_LOCK_TABLE and make clear distinction among close/releasing_PCSC_context/nullify_rdrname.

And if the coding style of hiding mutex_lock/mutex_unlock inside different functions matters, we can expose the mutex to its user.

May 10 2021, 4:32 AM · gnupg (gpg23), scd
gniibe added a comment to D531: Keep holding READER_LOCK_TABLE and make clear distinction among close/releasing_PCSC_context/nullify_rdrname.

Last commit will be:

May 10 2021, 4:29 AM · gnupg (gpg23), scd
gniibe committed rGec5591dc4e1f: scd: Fix close_pcsc_reader. (authored by gniibe).
scd: Fix close_pcsc_reader.
May 10 2021, 3:56 AM
gniibe committed rGcccc9bd5db1f: scd: Make sure releasing PC/SC context. (authored by gniibe).
scd: Make sure releasing PC/SC context.
May 10 2021, 3:56 AM
gniibe added a comment to D531: Keep holding READER_LOCK_TABLE and make clear distinction among close/releasing_PCSC_context/nullify_rdrname.

The second commit is replacing a use case of close_pcsc_reader by clearing pcsc.rdrname and calling release_pcsc_context.
This makes the use of close_pcsc_reader to its original purpose only (== closing PC/SC reader as a method of close_reader).

May 10 2021, 3:48 AM · gnupg (gpg23), scd
gniibe added a comment to D531: Keep holding READER_LOCK_TABLE and make clear distinction among close/releasing_PCSC_context/nullify_rdrname.

OK. As I pointed out a commit having multiple things may make analysis difficult, I should have been careful.
So, let me fix the problem by multiple commits.

May 10 2021, 3:28 AM · gnupg (gpg23), scd

May 9 2021

Laurent Montel <montel@kde.org> committed rLIBKLEOb7b6a8fa6fea: GIT_SILENT: add build support (authored by Laurent Montel <montel@kde.org>).
GIT_SILENT: add build support
May 9 2021, 5:07 PM
Laurent Montel <montel@kde.org> committed rKLEOPATRAdc8eeb1838bd: GIT_SILENT: add build support (authored by Laurent Montel <montel@kde.org>).
GIT_SILENT: add build support
May 9 2021, 5:05 PM

May 8 2021

Laurent Montel <montel@kde.org> committed rLIBKLEOe307781e2645: GIT_SILENT: time to increase version (authored by Laurent Montel <montel@kde.org>).
GIT_SILENT: time to increase version
May 8 2021, 4:04 PM
Laurent Montel <montel@kde.org> committed rKLEOPATRA4d7dcf54ad10: GIT_SILENT: time to increase version (authored by Laurent Montel <montel@kde.org>).
GIT_SILENT: time to increase version
May 8 2021, 4:01 PM
Denisov23 updated the task description for T5427: Update Italian Version.
May 8 2021, 2:41 PM · i18n, gpg4win
Denisov23 created T5427: Update Italian Version.
May 8 2021, 2:41 PM · i18n, gpg4win
evan0g created T5426: [Pinentry]: add remeber password checkbox in pinentry-qt..
May 8 2021, 11:17 AM · Feature Request

May 7 2021

Heiko Becker <heiko.becker@kde.org> committed rKLEOPATRA736032d86bf1: GIT_SILENT Update Appstream for new release (authored by Heiko Becker <heiko.becker@kde.org>).
GIT_SILENT Update Appstream for new release
May 7 2021, 8:37 PM
Heiko Becker <heiko.becker@kde.org> committed rKLEOPATRA419f8be9b6f0: GIT_SILENT Update Appstream for new release (authored by Heiko Becker <heiko.becker@kde.org>).
GIT_SILENT Update Appstream for new release
May 7 2021, 8:37 PM
aheinecke committed rW7dbe3ed7fb9a: Auto: Update italian l10n formatting (authored by aheinecke).
Auto: Update italian l10n formatting
May 7 2021, 1:32 PM
dain added a comment to T5425: scdaemon.conf reader-port setting broken in 2.3.

Ah, great. Thanks!

May 7 2021, 1:16 PM · gnupg, Restricted Project, scd, Bug Report
ikloecker closed T5422: gnupg 2.3.1 breaks gpgme_op_createkey() as Resolved.

You are welcome.

May 7 2021, 12:43 PM · gpgme, Bug Report
werner committed rG89e20c38c21f: po: auto updates (authored by werner).
po: auto updates
May 7 2021, 9:55 AM
werner committed rG987b81686022: scd,pcsc: Use a single context. (authored by gniibe).
scd,pcsc: Use a single context.
May 7 2021, 9:55 AM
werner committed rG26de9c400ee6: build: Silence a cimpiler warning also in non-maintainer mode. (authored by werner).
build: Silence a cimpiler warning also in non-maintainer mode.
May 7 2021, 9:55 AM
pnirschl added a comment to T5422: gnupg 2.3.1 breaks gpgme_op_createkey().

run-genkey is working fine in my test environment as well.

May 7 2021, 9:41 AM · gpgme, Bug Report
werner requested changes to D531: Keep holding READER_LOCK_TABLE and make clear distinction among close/releasing_PCSC_context/nullify_rdrname.

Keeping the lock over the call to the function does not look very robust to me. This is why I removed it. And since then PC/SC worked on Windows for me. Modulo this:
All these changes don't tackle the real problem that windows gets struck in a removed-card state.

May 7 2021, 8:36 AM · gnupg (gpg23), scd
colemickens added a comment to T5416: [windows] Smartcards are less reliable under 2.3.1 (requires restarting gpg-agent.exe).

Technical commentary on smartcard operation and/or Windows is going to be over my head, so I can't help (just in case you're looking for anything from me). But always happy to drive-test another build. (I've still had no issues, personally, with the build above.) I'll assume you don't need me unless you link another binary build to test or tag me. Thanks again, all.

May 7 2021, 7:22 AM · yubikey, scd, gnupg (gpg23), Bug Report
gniibe added a comment to T5416: [windows] Smartcards are less reliable under 2.3.1 (requires restarting gpg-agent.exe).

The problem is accesses to reader_table by
(1) scanning reader(s) to open new one
(2) closing reader

May 7 2021, 6:59 AM · yubikey, scd, gnupg (gpg23), Bug Report
gniibe added a comment to T5416: [windows] Smartcards are less reliable under 2.3.1 (requires restarting gpg-agent.exe).

I'm testing D531: Keep holding READER_LOCK_TABLE and make clear distinction among close/releasing_PCSC_context/nullify_rdrname, but I'm not sure about the impact on Windows.

May 7 2021, 6:54 AM · yubikey, scd, gnupg (gpg23), Bug Report
gniibe requested review of D531: Keep holding READER_LOCK_TABLE and make clear distinction among close/releasing_PCSC_context/nullify_rdrname.
May 7 2021, 6:51 AM · gnupg (gpg23), scd
gniibe reopened T5416: [windows] Smartcards are less reliable under 2.3.1 (requires restarting gpg-agent.exe) as "Open".

The commit rGbb8e3996e44f: scd: Fix problem with reader list becoming empty. removed READER_TABLE_LOCK holding between apdu_dev_list_start and apdu_dev_list_finish, that opens possible stale resource access for CCID driver: reader_table[slot].ccid.handle

May 7 2021, 6:34 AM · yubikey, scd, gnupg (gpg23), Bug Report
gniibe added projects to T5425: scdaemon.conf reader-port setting broken in 2.3: scd, Restricted Project, gnupg.
May 7 2021, 6:05 AM · gnupg, Restricted Project, scd, Bug Report
gniibe claimed T5425: scdaemon.conf reader-port setting broken in 2.3.

Thank you for your report.

May 7 2021, 6:04 AM · gnupg, Restricted Project, scd, Bug Report
gniibe committed rG0498ea8fbd57: scd: Increment PCSC.COUNT correctly. (authored by gniibe).
scd: Increment PCSC.COUNT correctly.
May 7 2021, 4:27 AM
gniibe committed rG5d1b41310682: scd: Fix memory leak for RDRNAME and serialize access. (authored by gniibe).
scd: Fix memory leak for RDRNAME and serialize access.
May 7 2021, 4:27 AM
gniibe committed rG039aed9d401f: scd: Fix declarations for PC/SC access. (authored by gniibe).
scd: Fix declarations for PC/SC access.
May 7 2021, 12:13 AM

May 6 2021

brianacton added a comment to T5409: scdaemon: 'Operation not supported by device' error under macOS after upgrading to 2.3.1.

I am also a MacOS Big Sur user who recently upgraded to 2.3.1 and had problems after upgrading. In my use case, I use the yubikey as the authentication for pass password manager which uses gpg under the hood.

May 6 2021, 10:15 PM · MacOS, Support, scd
dain created T5425: scdaemon.conf reader-port setting broken in 2.3.
May 6 2021, 8:57 PM · gnupg, Restricted Project, scd, Bug Report
ikloecker closed T5420: gpgme++: Add read-only support for trust signatures as Resolved.
May 6 2021, 3:16 PM · kleopatra, Restricted Project
ikloecker closed T5420: gpgme++: Add read-only support for trust signatures, a subtask of T5245: Kleopatra: Add support for trust signatures / trusted introducer, as Resolved.
May 6 2021, 3:16 PM · kleopatra, Restricted Project
ikloecker moved T5420: gpgme++: Add read-only support for trust signatures from Restricted Project Column to Restricted Project Column on the Restricted Project board.
May 6 2021, 3:16 PM · kleopatra, Restricted Project
ikloecker closed T5419: gpgme: Add support for trust signatures to key list result, a subtask of T5245: Kleopatra: Add support for trust signatures / trusted introducer, as Resolved.
May 6 2021, 3:15 PM · kleopatra, Restricted Project
ikloecker closed T5419: gpgme: Add support for trust signatures to key list result as Resolved.
May 6 2021, 3:15 PM · kleopatra, gpgme, Restricted Project
ikloecker moved T5419: gpgme: Add support for trust signatures to key list result from Restricted Project Column to Restricted Project Column on the Restricted Project board.
May 6 2021, 3:15 PM · kleopatra, gpgme, Restricted Project
ikloecker abandoned D530: gpgme: Add support for trust signatures to key list result.

This revision was committed with rM276187f6b62a: core: Extend gpgme_key_sig_t with trust signature members.

May 6 2021, 3:15 PM · gpgme
ikloecker set the repository for D530: gpgme: Add support for trust signatures to key list result to rM GPGME.
May 6 2021, 3:13 PM · gpgme
ikloecker moved T5421: gpgme++, qgpgme: Add support for creating trust signatures from Restricted Project Column to Restricted Project Column on the Restricted Project board.
May 6 2021, 3:06 PM · kleopatra, Restricted Project
ikloecker moved T5420: gpgme++: Add read-only support for trust signatures from Restricted Project Column to Restricted Project Column on the Restricted Project board.
May 6 2021, 3:06 PM · kleopatra, Restricted Project
ikloecker moved T5419: gpgme: Add support for trust signatures to key list result from Restricted Project Column to Restricted Project Column on the Restricted Project board.
May 6 2021, 3:06 PM · kleopatra, gpgme, Restricted Project
ikloecker committed rMf0858e45b0be: qt: Extend SignKeyJob to create trust signatures (authored by ikloecker).
qt: Extend SignKeyJob to create trust signatures
May 6 2021, 2:28 PM
ikloecker committed rM58a217b108e4: cpp: Do not close stdout/stderr when destroying EditInteractor (authored by ikloecker).
cpp: Do not close stdout/stderr when destroying EditInteractor
May 6 2021, 2:28 PM
ikloecker committed rMa8d7b9d16796: cpp: Add support for trust signatures to sign key edit interactor (authored by ikloecker).
cpp: Add support for trust signatures to sign key edit interactor
May 6 2021, 2:28 PM
ikloecker committed rMdae01f8185e0: qt: Pimpl QGpgMESignKeyJob (authored by ikloecker).
qt: Pimpl QGpgMESignKeyJob
May 6 2021, 2:28 PM
ikloecker committed rM276187f6b62a: core: Extend gpgme_key_sig_t with trust signature members. (authored by ikloecker).
core: Extend gpgme_key_sig_t with trust signature members.
May 6 2021, 2:28 PM
ikloecker committed rMe391a08c6f96: cpp: Add getters for the attributes of a trust signature (authored by ikloecker).
cpp: Add getters for the attributes of a trust signature
May 6 2021, 2:28 PM
gniibe committed rG53bdc6288f9b: scd: Recover the partial match for PORTSTR for PC/SC. (authored by gniibe).
scd: Recover the partial match for PORTSTR for PC/SC.
May 6 2021, 12:26 PM
gniibe committed rGd6fe82d3d169: scd: When reader is specified, make sure only open once. (authored by gniibe).
scd: When reader is specified, make sure only open once.
May 6 2021, 12:26 PM
aheinecke edited projects for T5424: GnuPG w32: Expand environment variables when reading registry paths, added: gnupg; removed gpgagent.
May 6 2021, 12:15 PM · gnupg (gpg22), Restricted Project
aheinecke triaged T5424: GnuPG w32: Expand environment variables when reading registry paths as Normal priority.
May 6 2021, 12:03 PM · gnupg (gpg22), Restricted Project
werner added a comment to D530: gpgme: Add support for trust signatures to key list result.

This is better name. My point was that if we ever use that to create such a field the developer should not assume that arbitrary REs can be used here. We need to have some practical value here and I would prefer to see only the domain name. However, OpenPGP allows for arbitrary REs and thus we may see them here. This is problematic but we can't do much about it.

May 6 2021, 10:01 AM · gpgme
ikloecker added a comment to T5422: gnupg 2.3.1 breaks gpgme_op_createkey().

Well, all I can say is that
./run-genkey --loopback "elektra testkey (gen-gpg-testkey)"
creates a key without any problems and without asking for a passphrase. Even, if I add the GPGME_CREATE_NOEXPIRE flag to the call of gpgme_op_createkey. At least, from a terminal.

May 6 2021, 9:19 AM · gpgme, Bug Report
werner added a comment to T5415: YubiKey no longer recognized in GnuPG 2.3.1 on macOS 10.15.7.

That would required that we also add an option --enable-ccid-driver - better tell the macOS folks to put diable-ccid-driver into /etc/gnupg/scdaemon.conf

May 6 2021, 9:06 AM · MacOS, yubikey, Bug Report
werner added a project to T5423: libgcrypt 1.8 ECDH: Debian.

FWIW, I think that it is a Bad Thing to use unreleased stuff from 1.8 for Debian packages. Only released versions sshould be used or patches we explicitly made to fix a bug. At the very least Andreas should have asked upstream whether this commit should be used for Sid.

May 6 2021, 9:00 AM · Debian, libgcrypt
gniibe added a comment to T5423: libgcrypt 1.8 ECDH.

Also fixed in version 1.8: rCbd662c090bd4: ecc: Fix the previous commit.

May 6 2021, 7:16 AM · Debian, libgcrypt
gniibe committed rC5f814e8a4968: ecc: Fix the input length check for Montgomery curve. (authored by gniibe).
ecc: Fix the input length check for Montgomery curve.
May 6 2021, 6:13 AM
gniibe added a comment to T5423: libgcrypt 1.8 ECDH.

Note that the handling e part uses standard MPI in 1.8 (while it is done by opaque MPI in 1.9).

May 6 2021, 5:31 AM · Debian, libgcrypt
gniibe triaged T5423: libgcrypt 1.8 ECDH as High priority.
May 6 2021, 5:23 AM · Debian, libgcrypt
gniibe added a comment to T5415: YubiKey no longer recognized in GnuPG 2.3.1 on macOS 10.15.7.

Or... we could add --disable-ccid-driver as default for macOS.

May 6 2021, 3:56 AM · MacOS, yubikey, Bug Report
gniibe claimed T5415: YubiKey no longer recognized in GnuPG 2.3.1 on macOS 10.15.7.
May 6 2021, 3:55 AM · MacOS, yubikey, Bug Report
gniibe added a comment to T5415: YubiKey no longer recognized in GnuPG 2.3.1 on macOS 10.15.7.

If it is built with LIBUSB enabled, please try adding the following to your scdaemon.conf:

disable-ccid
May 6 2021, 3:54 AM · MacOS, yubikey, Bug Report

May 5 2021

pnirschl added a comment to T5422: gnupg 2.3.1 breaks gpgme_op_createkey().

Thank you for your response! I tried out all variants of gpgme_pinentry_mode_t and implemented a passphrase callback (using gpgme_set_passphrase_cb as suggested). It turns out that the callback is not invoked at all. However, if I switch back to gnupg 2.2.27, the callback is being invoked and the key is being generated (using the passphrase specified by the callback, as expected).

May 5 2021, 9:17 PM · gpgme, Bug Report
ikloecker added a comment to T5422: gnupg 2.3.1 breaks gpgme_op_createkey().

The problem might be that gpg tries to ask for a passphrase which fails on the CI. Try setting a passphrase callback and setting the pinentry mode to loopback. See https://dev.gnupg.org/source/gpgme/browse/master/tests/run-genkey.c$435.

May 5 2021, 10:01 AM · gpgme, Bug Report
ikloecker committed rKLEOPATRAf9a921135b37: Create shadow key also for the smartcard's encryption key. (authored by werner).
Create shadow key also for the smartcard's encryption key.
May 5 2021, 9:45 AM