gnupgProject
ActivePublic

Milestones

Subprojects

Members

  • This project does not have any members.

Recent Activity

Thu, Jul 30

gniibe changed the status of T4994: Windows: assuan_sock_init or WSAStartup by main/_init_common_subsystem from Open to Testing.

Pushed modified patch to master and 2.2.

Thu, Jul 30, 8:27 AM · Testing, gnupg, Windows
gniibe added a commit to T4994: Windows: assuan_sock_init or WSAStartup by main/_init_common_subsystem: rG8d9ce32c30db: w32: More adding NETLIBS..
Thu, Jul 30, 8:17 AM · Testing, gnupg, Windows
gniibe added a commit to T4994: Windows: assuan_sock_init or WSAStartup by main/_init_common_subsystem: rGf95d923090e1: w32: Add link to $(NETLIB) for -lws2_32..
Thu, Jul 30, 8:17 AM · Testing, gnupg, Windows
gniibe added a commit to T4994: Windows: assuan_sock_init or WSAStartup by main/_init_common_subsystem: rG5fa4427419c8: w32: More adding NETLIBS..
Thu, Jul 30, 8:09 AM · Testing, gnupg, Windows
gniibe added a commit to T4994: Windows: assuan_sock_init or WSAStartup by main/_init_common_subsystem: rGd69f5570ee5e: w32: Add link to $(NETLIB) for -lws2_32..
Thu, Jul 30, 4:41 AM · Testing, gnupg, Windows

Wed, Jul 29

aheinecke added a comment to T4994: Windows: assuan_sock_init or WSAStartup by main/_init_common_subsystem.

That patch fixes the build problem I got into today when trying to build 2.3 for windows. So 👍 from me and please commit the patch as it is already required when assuan and gpgrt config no longer emit ws2_32 in their pgk-config --libs line.

Wed, Jul 29, 1:20 PM · Testing, gnupg, Windows
gniibe added a comment to T4994: Windows: assuan_sock_init or WSAStartup by main/_init_common_subsystem.

Linking $(NETLIB) is required when the executable uses WSAStartup.

Wed, Jul 29, 10:28 AM · Testing, gnupg, Windows

Fri, Jul 17

gniibe triaged T4994: Windows: assuan_sock_init or WSAStartup by main/_init_common_subsystem as Normal priority.

I just learned that WSAStartup can be called multiple times. So, it doesn't cause any erroneous behavior which I had been afraid of.

Fri, Jul 17, 11:33 AM · Testing, gnupg, Windows
werner added a comment to T4994: Windows: assuan_sock_init or WSAStartup by main/_init_common_subsystem.

Thanks for looking into this. However, I do not understand the problem behind it. Is it the need to link against the socket lib? 10 or 15 years ago things were more complicated because two TCP stacks were in use and you could use the modern one only if a certain service pack or Explorer version was installed. That might be the reasons for some of the peculiarities we have in the code.

Fri, Jul 17, 10:44 AM · Testing, gnupg, Windows
gniibe added a comment to T4994: Windows: assuan_sock_init or WSAStartup by main/_init_common_subsystem.

Given the situation we have call of WAStartup in assuan_sock_init (for Windows), the solution would be:

  • Removal of call of WAStartup in _init_common_subsystems
  • Even though it is not needed for POSIX system and it is only needed to call WAStartup on Windows, calling assuan_sock_init from each application (including gpg, gpgsm, dirmngr/dirmngr-client, and tools/* which uses libassuan), would be the solution (not perfect one, though, because it allocates sock_ctx)
Fri, Jul 17, 4:32 AM · Testing, gnupg, Windows
gniibe added a comment to T4994: Windows: assuan_sock_init or WSAStartup by main/_init_common_subsystem.

Sorry, I was confused by assuan_socket_ API and assuan_sock_ API.

Fri, Jul 17, 2:35 AM · Testing, gnupg, Windows

Thu, Jul 16

werner edited projects for T3948: GPGSM: Multiple issues reported to KMail, added: gnupg; removed gpgme.
Thu, Jul 16, 3:23 PM · gnupg, S/MIME
werner edited projects for T3471: gpgme decryptverify indicating wrongly an error., added: gnupg, Not A Bug; removed gpgme.

I don't see any error here. There is a trailing LF on the binary data which gpg rightfully complains about.

Thu, Jul 16, 3:06 PM · Not A Bug, gnupg, Bug Report
werner closed T3348: gpgsm: should default to --disable-crl-checks as Wontfix.
Thu, Jul 16, 2:45 PM · gpgme, gnupg, S/MIME
gniibe added a comment to T4994: Windows: assuan_sock_init or WSAStartup by main/_init_common_subsystem.

Here are the fixes:

diff --git a/common/init.c b/common/init.c
index 073c5cd8a..dbdf40527 100644
--- a/common/init.c
+++ b/common/init.c
@@ -161,17 +161,6 @@ _init_common_subsystems (gpg_err_source_t errsource, int *argcp, char ***argvp)
   /* Try to auto set the character set.  */
   set_native_charset (NULL);
Thu, Jul 16, 6:43 AM · Testing, gnupg, Windows
gniibe added a comment to T4994: Windows: assuan_sock_init or WSAStartup by main/_init_common_subsystem.

Call of WSAStartup in dirmngr/http.c is no problem, as we define HTTP_NO_WSASTARTUP.

Thu, Jul 16, 6:22 AM · Testing, gnupg, Windows
gniibe updated the task description for T4994: Windows: assuan_sock_init or WSAStartup by main/_init_common_subsystem.
Thu, Jul 16, 6:18 AM · Testing, gnupg, Windows
gniibe updated the task description for T4994: Windows: assuan_sock_init or WSAStartup by main/_init_common_subsystem.
Thu, Jul 16, 3:06 AM · Testing, gnupg, Windows
gniibe created T4994: Windows: assuan_sock_init or WSAStartup by main/_init_common_subsystem.
Thu, Jul 16, 3:03 AM · Testing, gnupg, Windows

Wed, Jul 15

gniibe added a commit to T4843: REGEXP support for all systems: rG199309190a0b: gpg: Add regular expression support..
Wed, Jul 15, 7:30 AM · Testing, gnupg

Thu, Jul 9

werner closed T4856: GPG: Key Exchange Put public OpenPGP key into signature as Resolved.
Thu, Jul 9, 1:15 PM · Feature Request, gpgol, Keyserver, gnupg
werner added a parent task for T4702: Release GnuPG 2.3.0: T4989: Gpg4win-4.0.0.
Thu, Jul 9, 12:23 PM · Release Info, gpg4win, gnupg
werner changed Due Date from Dec 20 2019, 12:00 AM to Sep 30 2020, 12:00 AM on T4702: Release GnuPG 2.3.0.
Thu, Jul 9, 12:21 PM · Release Info, gpg4win, gnupg

Jul 5 2020

scy added a comment to T1849: Show revocation certificate details.

Since this issue is what I came across when googling for gpg inspect revocation certificate, I thought I’d add what I found out:

Jul 5 2020, 9:44 PM · gnupg, Feature Request

Jun 18 2020

werner closed T4976: Revocation Date after importing a Rev-Cert as Resolved.
Jun 18 2020, 10:33 AM · gnupg, Not A Bug

Jun 9 2020

aheinecke created T4972: GPG: Add Option to force passphrase constraints for symmetric encryption, too.
Jun 9 2020, 9:58 AM · gnupg
aheinecke created T4971: Pass setrepeat to pinentry for symmetric encryption, too.
Jun 9 2020, 9:51 AM · gnupg (gpg22)

Jun 3 2020

werner closed T4947: Build of documentation from tarball not deterministic as Resolved.

Done.

Jun 3 2020, 5:17 PM · gnupg, Documentation, Bug Report
werner added a commit to T4947: Build of documentation from tarball not deterministic: rG5ade2b68db23: doc: Minor enhancement for reproducibility..
Jun 3 2020, 5:17 PM · gnupg, Documentation, Bug Report
werner added a commit to T4947: Build of documentation from tarball not deterministic: rG074ab108e768: doc: Minor enhancement for reproducibility..
Jun 3 2020, 5:16 PM · gnupg, Documentation, Bug Report
werner added a commit to T4965: GnuPG dependency of libgpg-error and GPG_ERR_WRONG_NAME: rG381c54179c2a: common: Add missing error code GPG_ERR_WRONG_NAME..
Jun 3 2020, 10:33 AM · gnupg, Bug Report
werner closed T4965: GnuPG dependency of libgpg-error and GPG_ERR_WRONG_NAME as Resolved.

I bumped up the requirement to 1.25 because we also use error codes defined there. To be on the safe side with older distros I defined the missing error code instead of requiring 1.27.

Jun 3 2020, 10:33 AM · gnupg, Bug Report

Jun 2 2020

gniibe added a comment to T4956: agent: Disrepancy of handling MPI for the interpretation of signed and unsigned.

Change of gpg-agent for ECC-SOS

Jun 2 2020, 8:05 AM · libgcrypt, gpgagent, gnupg
Angel created T4965: GnuPG dependency of libgpg-error and GPG_ERR_WRONG_NAME.
Jun 2 2020, 3:22 AM · gnupg, Bug Report

May 28 2020

PWRzTOtacorTPq7KNW4oFec8F added a comment to T2291: Smartcard interaction improvement (was: Shadowed private key design (for smartcard)).

Is there a blogpost or similar where the use of several smartcards following this improvement is explained to n00bs like me? :) For now all I find is this thread and some SE answers saying it does not work yet (https://security.stackexchange.com/questions/154702/gpg-encryption-subkey-on-multiple-smart-cards-issue) . If somebody could post a new answer on SE / write a small blog post or similar that would be great. Useful would be to have 1) from which versions and over is that available 2) how this works / how to use.

May 28 2020, 10:18 PM · Testing, Feature Request, gnupg
bernhard created T4958: Document different use of pubring.gpg in newer versions.
May 28 2020, 12:45 PM · gnupg (gpg22), Documentation

May 27 2020

gniibe added a comment to T4954: SOS representation and improvements in GnuPG.

In the SOS branch, rG1c4291c3951d: ecc-sos: Add special leading zero octet removal. should be reverted.
Instead, the S_KEY should be fixed up in read_key_file in findkey.c,
and merge_lists in protect.c.
(Then, no need to be fixed up in extract_private_key.)

May 27 2020, 11:57 AM · OpenPGP, gnupg
gniibe updated the task description for T4956: agent: Disrepancy of handling MPI for the interpretation of signed and unsigned.
May 27 2020, 3:09 AM · libgcrypt, gpgagent, gnupg
gniibe edited projects for T4956: agent: Disrepancy of handling MPI for the interpretation of signed and unsigned, added: gpgagent, libgcrypt; removed OpenPGP.
May 27 2020, 3:08 AM · libgcrypt, gpgagent, gnupg
gniibe added a comment to T4956: agent: Disrepancy of handling MPI for the interpretation of signed and unsigned.

Exactly same problem is there in libgcrypt.
In the definitions of curves, it uses negative constant internally in some specific places, but for other parts, we have same problems.

May 27 2020, 3:08 AM · libgcrypt, gpgagent, gnupg
gniibe updated the task description for T4956: agent: Disrepancy of handling MPI for the interpretation of signed and unsigned.
May 27 2020, 3:03 AM · libgcrypt, gpgagent, gnupg
gniibe created T4956: agent: Disrepancy of handling MPI for the interpretation of signed and unsigned.
May 27 2020, 3:03 AM · libgcrypt, gpgagent, gnupg

May 26 2020

gniibe added a comment to T4954: SOS representation and improvements in GnuPG.

I should concentrate the case of ECC, in particular, ECC with modern curves.
Removing leading zero from RSA/ECC/ELGamal assuming unsigned integer would result more work.

May 26 2020, 8:23 AM · OpenPGP, gnupg
gniibe added a comment to T4954: SOS representation and improvements in GnuPG.

In libgcrypt, we have another problem of GCRYSEXP_FMT_ADVANCED formatting, which is used by gpg-agent of GnuPG 2.3 with name-value list.

May 26 2020, 7:07 AM · OpenPGP, gnupg
gniibe added a comment to T4954: SOS representation and improvements in GnuPG.

Confusingly, in the SSH specification, it is signed MPI.
See RFC4251, for the definition of "mpint": https://tools.ietf.org/html/rfc4251#page-8

May 26 2020, 3:59 AM · OpenPGP, gnupg

May 25 2020

gniibe added a comment to T4954: SOS representation and improvements in GnuPG.

There are more places for clean up in GnuPG.
While "MPI" in OpenPGP specification is based on unsigned integer, the default "MPI" handling of GnuPG/Libgcrypt is signed. This difference matters internally.
Formatting by "%m" with libgcrypt, it may result prefixed by 0x00 (so that it represents unsigned value, even if scanned as signed).
And because of this, existing private keys in private-keys-v1.d may have this leading zero-byte.
But the counting bits don't count this byte.

May 25 2020, 7:27 AM · OpenPGP, gnupg

May 21 2020

gniibe added a comment to T4954: SOS representation and improvements in GnuPG.

Important interoperability issue:
OpenPGP implementations should implement:

  • Recovery of leading zero octets for Ed25519 key handling (secret part) and Ed25519 signature
May 21 2020, 7:01 AM · OpenPGP, gnupg
gniibe added a comment to T4954: SOS representation and improvements in GnuPG.

Better to paste directly:

# SOS representation
#
# Initially, it was intended as "Simply, Octet String", but 
# it is actually "Strange" Octet String.
#
May 21 2020, 6:52 AM · OpenPGP, gnupg
gniibe added a comment to T4954: SOS representation and improvements in GnuPG.

I wrote this:

May 21 2020, 6:51 AM · OpenPGP, gnupg
gniibe created T4954: SOS representation and improvements in GnuPG.
May 21 2020, 6:50 AM · OpenPGP, gnupg