Page MenuHome GnuPG

Kleopatra: Fix issues with high contrast resp. inverted color scheme
Testing, NormalPublic

Event Timeline

ikloecker triaged this task as Normal priority.
ikloecker created this task.
ikloecker moved this task from Restricted Project Column to Restricted Project Column on the Restricted Project board.

Note to self: On Windows, we need to check whether the high-contrast mode is enabled. If yes, then we must not use any custom colors. KColorScheme doesn't help here.

If the high-contrast mode is active (on Windows), then we disable the usage of custom colors in Kleopatra. This avoids problems with too low contrast due to the custom colors.

For testing purposes, high-contrast mode can be forced by setting the environment variable KLEO_HIGH_CONTRAST_MODE to 1.

There may still be problems with low contrast, if the user selects a "high-contrast" color scheme instead of activating the high-contrast mode.

ikloecker changed the task status from Open to Testing.Jul 13 2022, 4:34 PM
ikloecker removed ikloecker as the assignee of this task.
ikloecker moved this task from Restricted Project Column to Restricted Project Column on the Restricted Project board.
ikloecker added a project: Restricted Project.

Ready for testing. See https://dev.gnupg.org/T6073#160145.

Most things look good to me, it was automatically enabled when I switched Windows to high contrast mode. The only thing I noticed is that the fields where we explicitly set the background may not look to readable. Especially the Sign&Encrypt buttons because there we don't set the text color.

Did you restart Kleopatra after enabling the high contrast mode? I have implemented that Kleopatra doesn't change/set any background or foreground colors if high contrast mode is detected. Maybe the detection (in SystemInfo::isHighContrastModeActive) doesn't work.

You can check how it should look like by setting the environment variable KLEO_HIGH_CONTRAST_MODE to 1.

werner removed a project: Restricted Project.Sep 22 2022, 10:52 AM

On windows the main window looks ok with high contrast mode black. But with dark backgrounds some items in other windows are not readable:

With setting "contrast white" everything in that window is readable.

ikloecker changed the task status from Testing to Open.Jul 28 2023, 5:46 PM
ikloecker moved this task from Restricted Project Column to Restricted Project Column on the Restricted Project board.
ikloecker moved this task from Restricted Project Column to Restricted Project Column on the Restricted Project board.
ikloecker changed the task status from Open to Testing.Jun 20 2024, 11:33 AM
ikloecker added a project: vsd33.
In T6073#173463, @ebo wrote:

On windows the main window looks ok with high contrast mode black. But with dark backgrounds some items in other windows are not readable:

This should now be fixed.

Backported for VSD 3.3

Selection with unpatched Qt:

Selection with patched Qt: