Page MenuHome GnuPG
Feed Advanced Search

Apr 10 2017

gniibe committed rG3c1ad96f1ce8: scd: Relax a condition for p15 driver. (authored by gniibe).
scd: Relax a condition for p15 driver.
Apr 10 2017, 6:16 AM
gniibe committed rG34199ef677bb: scd: Remove "special transport" support. (authored by gniibe).
scd: Remove "special transport" support.
Apr 10 2017, 5:30 AM
gniibe added a reviewer for D424: some spelling fixes (libgcrypt): gniibe.
Apr 10 2017, 3:54 AM

Apr 7 2017

gniibe added a comment to D421: padding is needed for 64-bit big endian.

I understand your emulator is s390x. Perhaps, on the emulator, memory layout is different?
I now see that C99 is OK for GnuPG, or at least no problem for gpgscm.

Apr 7 2017, 12:37 PM · gnupg (gpg21)
gniibe added a comment to D421: padding is needed for 64-bit big endian.

I think that there are two archs: s390 and s390x. Latter is 64-bit and supports 32-bit version as well.
Use of machine word size (32-bit for 32-bit machine, 64-bit for 32-bit machine) is good. That will be update of Diff 1255.
But I don't know how it is achieved easily.
(If we can ignore LLP64, we can use unsigned long.)
Please go ahead that way.

Apr 7 2017, 12:12 PM · gnupg (gpg21)
justus awarded D421: padding is needed for 64-bit big endian a Pterodactyl token.
Apr 7 2017, 11:53 AM · gnupg (gpg21)
gniibe committed rG3c93595d701c: scd: Don't keep CCID reader open when card is not available. (authored by gniibe).
scd: Don't keep CCID reader open when card is not available.
Apr 7 2017, 6:32 AM
gniibe committed rGcc420d34880e: scd: Internal CCID reader cleanup. (authored by gniibe).
scd: Internal CCID reader cleanup.
Apr 7 2017, 6:32 AM
gniibe added a comment to D421: padding is needed for 64-bit big endian.

Please decide for _flag access on 64-bit machine, if 32-bit access is better or not.
If 64-bit access is better, update version of {Diff1255} is needed, instead.
unsigned long is not good for LLP64 system. Use unsigned long long for 64-bit system.

Apr 7 2017, 3:05 AM · gnupg (gpg21)
gniibe updated the diff for D421: padding is needed for 64-bit big endian.

Update of the diff, so that we can keep _flag field access to 32-bit on 64-bit machine.

Apr 7 2017, 2:27 AM · gnupg (gpg21)
gniibe added a comment to T3027: gpg-agent crash on macOS Sierra triggerd by ssh.

Applied as ebe12be034f0.

Apr 7 2017, 2:15 AM · Bug Report, gpgagent, gnupg
gniibe committed rGebe12be034f0: agent: Serialize access to passphrase cache. (authored by gniibe).
agent: Serialize access to passphrase cache.
Apr 7 2017, 1:45 AM
gniibe added a comment to T3014: Intermittent crashes in gpgscm on s390x.

I confirmed that it's 64-bit big-endian.
I wrote a patch for testing. D421: padding is needed for 64-bit big endian

Apr 7 2017, 1:08 AM · Debian, Bug Report, gnupg
gniibe created D421: padding is needed for 64-bit big endian.
Apr 7 2017, 1:07 AM · gnupg (gpg21)
gniibe added a comment to T3014: Intermittent crashes in gpgscm on s390x.

If s390x is big-endian, we need padding at the start of the cell structure. So that the _flag can be compatible to the vector element.
I'll see on the porterbox myself, too.

Apr 7 2017, 12:53 AM · Debian, Bug Report, gnupg

Apr 6 2017

gniibe added a comment to T3014: Intermittent crashes in gpgscm on s390x.

IIUC, cells are used for a place for vector elements.
I'm afraid what happens for memory space not used for vector elements.

Apr 6 2017, 3:45 PM · Debian, Bug Report, gnupg
gniibe abandoned D205: 846_gpg14-create_hashtable-fix.diff.

Applied already.

Apr 6 2017, 5:53 AM
gniibe abandoned D291: 599_gpg2-scd-issue-1930-patch.diff.

Applied already.

Apr 6 2017, 5:51 AM
gniibe abandoned D308: 646_scd-change-st-2000-20150619.diff.

Applied already.

Apr 6 2017, 5:50 AM
gniibe abandoned D309: 638_scd-add-zero.diff.

Applied already.

Apr 6 2017, 5:50 AM
gniibe abandoned D314: 653_gpg-agent-no-nls.diff.

Applied already.

Apr 6 2017, 5:49 AM
gniibe abandoned D330: 688_gpg-ssh-agent-20150929.diff.

Applied already.

Apr 6 2017, 5:49 AM
gniibe abandoned D331: 687_gpg-ssh-agent-20150928.diff.

Applied already.

Apr 6 2017, 5:48 AM
gniibe abandoned D347: 767_0001-g10-Make-sure-to-have-the-directory-for-trustdb-v3.patch.

Applied already.

Apr 6 2017, 5:48 AM
gniibe abandoned D348: 766_0001-g10-Make-sure-to-have-the-directory-for-trustdb-v3.patch.

Applied already.

Apr 6 2017, 5:47 AM
gniibe abandoned D350: 764_0001-g10-Make-sure-to-have-the-directory-for-trustdb.patch.
Apr 6 2017, 5:47 AM
gniibe added a comment to D350: 764_0001-g10-Make-sure-to-have-the-directory-for-trustdb.patch.

Applied already.

Apr 6 2017, 5:46 AM
gniibe abandoned D359: 783_mpi-pow-normalize-expo.diff.

Applied already.

Apr 6 2017, 5:45 AM
gniibe abandoned D367: 835_sig-check-correction.diff.
Apr 6 2017, 5:44 AM
gniibe added a comment to D367: 835_sig-check-correction.diff.

Applied already.

Apr 6 2017, 5:43 AM
gniibe abandoned D368: 838_gnupg-master-20160527.diff.

Applied already.

Apr 6 2017, 5:42 AM
gniibe abandoned D372: 847_libgpg-error-20160613.diff.

Included already.

Apr 6 2017, 5:05 AM
gniibe added reviewers for D419: gpg-agent cache handling serialization: wk, justus.
Apr 6 2017, 4:48 AM · gnupg (gpg21)
gniibe created D419: gpg-agent cache handling serialization.
Apr 6 2017, 4:43 AM · gnupg (gpg21)
gniibe added a comment to T3027: gpg-agent crash on macOS Sierra triggerd by ssh.

While I can't reproduce this problem myself, I think I found an issue of gpg-agent passphrase caching.
Double free may happen when multiple threads enter agent_put_cache, for example.

Apr 6 2017, 4:38 AM · Bug Report, gpgagent, gnupg
gniibe added a comment to T2998: link error in tests on NetBSD.

Err... npth repo is not yet added under dev.gnupg.org.
I requested as T3064.

Apr 6 2017, 12:23 AM · In Progress, Bug Report, npth
gniibe created T3064: Please add nPth repository.
Apr 6 2017, 12:22 AM

Apr 5 2017

gniibe abandoned D415: 990_npth-netbsd-20170328.diff.

This patch was committed.

Apr 5 2017, 1:36 PM
gniibe added a comment to T2886: nPth often needs -lpthread but does not detect this.

I found that FreeBSD also requires -lpthread thing. I also commit the change to the repo.
Tested with FreeBSD 11.0.
I think that TrueOS can be considered as FreeBSD variant.

Apr 5 2017, 8:34 AM · In Progress, Bug Report, npth
gniibe added a project to T2886: nPth often needs -lpthread but does not detect this: In Progress.

Fixed in the repo for DragonFlyBSD 4.8 too.

Apr 5 2017, 7:44 AM · In Progress, Bug Report, npth
gniibe added a comment to T2886: nPth often needs -lpthread but does not detect this.

In T2998, NetBSD was fixed.
I'll check for DragonFlyBSD.
IIUC, FreeBSD and OpenBSD has no issue.

Apr 5 2017, 5:21 AM · In Progress, Bug Report, npth
gniibe added a project to T2998: link error in tests on NetBSD: In Progress.

It works for me on NetBSD 7.1. Please test.

Apr 5 2017, 5:02 AM · In Progress, Bug Report, npth
gniibe lowered the priority of T2998: link error in tests on NetBSD from High to Normal.
Apr 5 2017, 4:52 AM · In Progress, Bug Report, npth
gniibe added a comment to T2998: link error in tests on NetBSD.

I tested with NetBSD 7.1 and -lrt is not required.
Nevertheless, it would be required for older NetBSD, so I leave -lrt check for NetBSD.
I'm going to push the change of D415 now.

Apr 5 2017, 4:51 AM · In Progress, Bug Report, npth

Apr 4 2017

gniibe committed rC719468e53133: mpi: Simplify mpi_powm. (authored by gniibe).
mpi: Simplify mpi_powm.
Apr 4 2017, 10:38 AM
gniibe committed rG685438bf6fe7: po: Update Japanese translation. (authored by gniibe).
po: Update Japanese translation.
Apr 4 2017, 3:48 AM
gniibe committed rG5744d2038bd1: agent: Minor fix for get_client_pid. (authored by gniibe).
agent: Minor fix for get_client_pid.
Apr 4 2017, 3:39 AM
gniibe claimed T2886: nPth often needs -lpthread but does not detect this.

Could you please look at https://dev.gnupg.org/T2998 ?

Apr 4 2017, 3:15 AM · In Progress, Bug Report, npth
gniibe claimed T2903: "gpg --card-status" does not add any entries to the private key ring.
Apr 4 2017, 3:13 AM · Info Needed, Bug Report, gnupg
gniibe closed T2153: agent_pksign_do ignores do_encode_raw_pkcs1 do_encode_md return values as Resolved.
Apr 4 2017, 3:01 AM · Bug Report, gnupg
gniibe closed T2154: encrypt_dek ignores gcry_pk_encrypt return value as Resolved.
Apr 4 2017, 3:00 AM · In Progress, Bug Report, gnupg
gniibe removed a project from T2285: decryption fails with "Missing item in object" even though private key is available: OpenPGP.
Apr 4 2017, 2:59 AM · Info Needed, Bug Report, gnupg, scd
gniibe added a project to T2939: Should not be required to manually `killagent` on card removal: gnupg (gpg20).
Apr 4 2017, 2:57 AM · gnupg (gpg20), Bug Report, gnupg
gniibe added a project to T3027: gpg-agent crash on macOS Sierra triggerd by ssh: In Progress.
Apr 4 2017, 2:56 AM · Bug Report, gpgagent, gnupg
gniibe reopened T3027: gpg-agent crash on macOS Sierra triggerd by ssh as "Open".
Apr 4 2017, 2:54 AM · Bug Report, gpgagent, gnupg
gniibe closed T3027: gpg-agent crash on macOS Sierra triggerd by ssh as Resolved.

In 2.1.19, gpg-agent uses getpeerucred for macOS. I changed it (since it seemed not working). In 2.1.20, gpg-agent now uses getsockopt with LOCAL_PEERPID.
It seems for me that the crash occurs by ucred_free. If this is the case, 2.1.20 fixes this issue.

Apr 4 2017, 2:54 AM · Bug Report, gpgagent, gnupg
gniibe closed T2933: gnupg-2.1.18 fails to read a Yubikey Neo that gnupg-2.1.17 reads fine as Resolved.

Fix published in 2.1.19.

Apr 4 2017, 2:28 AM · Bug Report, gnupg
gniibe closed T2981: struct ucred usage needs ucred.h on Solaris as Resolved.

Fix published in 2.1.20.

Apr 4 2017, 2:21 AM · In Progress, Bug Report, gnupg

Apr 3 2017

gniibe added a member for libgcrypt: gniibe.
Apr 3 2017, 11:20 AM
gniibe added a member for Debian: gniibe.
Apr 3 2017, 11:19 AM
gniibe added a member for scd: gniibe.
Apr 3 2017, 11:18 AM

Mar 28 2017

gniibe added a comment to T2998: link error in tests on NetBSD.

I think that NetBSD also defines single thread version of pthread_* functions in
libc.
How about attached patch in configure.ac?
(You need to generate configure)

Mar 28 2017, 7:31 AM · In Progress, Bug Report, npth
gniibe added a comment to T2998: link error in tests on NetBSD.

D415: 990_npth-netbsd-20170328.diff

Mar 28 2017, 7:31 AM · In Progress, Bug Report, npth
gniibe added a comment to T2998: link error in tests on NetBSD.

It seems that -lrt is required on NetBSD.

Mar 28 2017, 6:28 AM · In Progress, Bug Report, npth

Mar 7 2017

gniibe added a comment to T2981: struct ucred usage needs ucred.h on Solaris.

Since this is for command-ssh.c, we can't change the protocol (the client is SSH
process, which doesn't use libassuan).
Here, the purpose of the code is getting PID of peer, so, we can do something
except FreeBSD.

I think that it is fixed in: f7f806afa5083617f4aba02fc3b285b06a7d73d4

Mar 7 2017, 6:25 AM · In Progress, Bug Report, gnupg
gniibe added a project to T2981: struct ucred usage needs ucred.h on Solaris: In Progress.
Mar 7 2017, 6:25 AM · In Progress, Bug Report, gnupg

Mar 6 2017

gniibe claimed T2981: struct ucred usage needs ucred.h on Solaris.
Mar 6 2017, 12:47 PM · In Progress, Bug Report, gnupg
gniibe added a project to T2980: ssh-import.scm fails during "make check" with gnupg 2.1.19: Unreleased.
Mar 6 2017, 2:39 AM · MacOS, Bug Report, gnupg
gniibe closed T2980: ssh-import.scm fails during "make check" with gnupg 2.1.19 as Resolved.
Mar 6 2017, 2:39 AM · MacOS, Bug Report, gnupg
gniibe added a comment to T2980: ssh-import.scm fails during "make check" with gnupg 2.1.19.

Sorry, I couldn't find any possible bug for PC/SC access in scdaemon. It looks
like scdaemon crashes when it tries to access card by PC/SC, and it seems that
it crashes there (I mean, in PC/SC).
I believe that this scdaemon's crash is something which is difficult to avoid in
an application.

Anyway, I fixed the issue itself by handling errors of gpg-agent for scdaemon:
https://git.gnupg.org/cgi-bin/gitweb.cgi?p=gnupg.git;a=commit;h=4ce4f2f683a17be3ddb93729f3f25014a97934ad

Mar 6 2017, 2:39 AM · MacOS, Bug Report, gnupg

Mar 4 2017

gniibe added a comment to T2982: Scdaemon, w32 hang if two assuan connections are made in parallel.

This patch tried to fix the issue:
https://git.gnupg.org/cgi-bin/gitweb.cgi?p=gnupg.git;a=commit;h=f9acc7d18bb90f47dafe7e32ae92f567756d6b12

I was wrong that PIPE can be select(2)-ed on Windows. This patch changes the
code so that it uses kill(2) on UNIX and SetEvent on Windows
to break the loop.

Mar 4 2017, 2:37 AM · Unreleased, gpg4win, Bug Report, gnupg, scd

Mar 3 2017

gniibe claimed T2980: ssh-import.scm fails during "make check" with gnupg 2.1.19.
Mar 3 2017, 8:39 AM · MacOS, Bug Report, gnupg
gniibe added a comment to T2980: ssh-import.scm fails during "make check" with gnupg 2.1.19.

I think that scdaemon in 2.1.18 would also crash in sandbox environment.
In 2.1.19, I modified ssh-agent emulation code to support multiple tokens.
This change assumes scdaemon returns ENODEV return code and behaves badly, if
scdaemon crashes.
In 2.1.18, the code was somewhat robust and scdaemon crash didn't cause failure.
I am currently looking into the reason why scdaemon crashes.

Mar 3 2017, 8:39 AM · MacOS, Bug Report, gnupg
gniibe added a comment to T2982: Scdaemon, w32 hang if two assuan connections are made in parallel.

It seems npth_eselect is for network FDs.

How about this change?

diff --git a/scd/scdaemon.c b/scd/scdaemon.c
index f7e9f83b5..462ff1b3e 100644

  • a/scd/scdaemon.c

+++ b/scd/scdaemon.c
@@ -1291,7 +1291,7 @@ handle_connections (int listen_fd)

while (npth_sigev_get_pending(&signo))
  handle_signal (signo);

#else

  • ret = npth_eselect (nfd+1, &read_fdset, NULL, NULL, t, NULL, NULL);

+ ret = npth_select (nfd+1, &read_fdset, NULL, NULL, t);

saved_errno = errno;

#endif

Mar 3 2017, 6:24 AM · Unreleased, gpg4win, Bug Report, gnupg, scd
gniibe added a comment to T2982: Scdaemon, w32 hang if two assuan connections are made in parallel.

It is selecting FD which is created by gnupg_create_pipe.

Mar 3 2017, 6:15 AM · Unreleased, gpg4win, Bug Report, gnupg, scd
gniibe added a comment to T2982: Scdaemon, w32 hang if two assuan connections are made in parallel.

Version information, please.

I cannot replicate this on GNU/Linux with PC/SC (by disable-ccid).
Anyway, I am looking into this issue:

npth_pselect failed: Input/output error - waiting 1s
Mar 3 2017, 5:55 AM · Unreleased, gpg4win, Bug Report, gnupg, scd

Mar 1 2017

gniibe added a comment to T2939: Should not be required to manually `killagent` on card removal.

FYI: It is fixed in 2.1.
Backporting the change to 2.0 will be a bit large, and I hesitate to do that.

Mar 1 2017, 1:10 AM · gnupg (gpg20), Bug Report, gnupg
gniibe claimed T2953: scdaemon fails to decrypt if unusual key-size is chosen.
Mar 1 2017, 1:05 AM · Bug Report, gnupg, scd
gniibe added a comment to T1621: Support multiple cards (not just readers).

Simple workaround is having multiple readers...

Most card readers only support a single card.
(This is the reason why it is not yet implemented.)
Could you please let us know the reader which supports multiple cards?

Mar 1 2017, 1:00 AM · gnupg, Feature Request

Dec 23 2016

gniibe added a comment to T2889: gnupg/dirmngr 2.1.17 fails on all keyserver operations.

From my network, when I input:

KEYSERVER --clear hkps://oteiza.siccegge.de

It results the error, because the network to the host is unreachable.
It is likely that it is an error of the network or the server.
And --standard-resolver thing is fixed by my commit.

Dec 23 2016, 9:11 AM · Bug Report, gnupg
gniibe added a comment to T2889: gnupg/dirmngr 2.1.17 fails on all keyserver operations.

I think that this bug is related to libdns. Unfortunately, it is not
reproducible for me.

Well, somehow related, I pushed my change:

commit d26c51825e2255fe58305cbc1cd74fa43f80d93e

In my environment, compiling with --disable-libdns or --standard-resolver at
runtime for dirmngr, it works fine. Before the fix, I confirmed that it failed
with --standard-resolver.

Dec 23 2016, 8:21 AM · Bug Report, gnupg

Dec 7 2016

gniibe added a comment to T2860: Yubikey Sucessfully detected by Win7 but gpg --card-status fails.

Which version of GnuPG are you using? Do you have scdaemon?

Dec 7 2016, 9:38 AM · Bug Report, Windows 64, scd, Windows, gnupg, Windows 32
gniibe claimed T2860: Yubikey Sucessfully detected by Win7 but gpg --card-status fails.
Dec 7 2016, 9:38 AM · Bug Report, Windows 64, scd, Windows, gnupg, Windows 32

Nov 30 2016

gniibe removed a project from T2386: scdaemon wants to accept --homedir, but it doesn't: Restricted Project.
Nov 30 2016, 3:16 AM · Bug Report, gnupg
gniibe closed T2386: scdaemon wants to accept --homedir, but it doesn't as Resolved.
Nov 30 2016, 3:16 AM · Bug Report, gnupg
gniibe added a comment to T2386: scdaemon wants to accept --homedir, but it doesn't.

Applied to 2.0, too. Will be in 2.0.31.

Nov 30 2016, 3:16 AM · Bug Report, gnupg
gniibe claimed T2053: scdaemon over pcsclite holds the card even with "--card-timeout 5".
Nov 30 2016, 3:14 AM · Bug Report, gnupg
gniibe claimed T2738: gpg crashes when attempting to write a key to a card.
Nov 30 2016, 3:12 AM · Fedora, Bug Report, gnupg (gpg14)
gniibe added a comment to T2449: Smartcard reinsert fails with gnupg 2.1.15 (gpg-agent/scdaemon).

Fixed in 2.1.16.

Nov 30 2016, 2:46 AM · Bug Report, gnupg
gniibe closed T2449: Smartcard reinsert fails with gnupg 2.1.15 (gpg-agent/scdaemon) as Resolved.
Nov 30 2016, 2:46 AM · Bug Report, gnupg
gniibe removed a project from T2449: Smartcard reinsert fails with gnupg 2.1.15 (gpg-agent/scdaemon): Restricted Project.
Nov 30 2016, 2:46 AM · Bug Report, gnupg
gniibe closed T1686: GPG Smartcard daemons not detecting card change Windows 8.1 as Resolved.
Nov 30 2016, 2:44 AM · gnupg, Windows 32, gnupg (gpg20), Windows, Bug Report
gniibe removed a project from T1686: GPG Smartcard daemons not detecting card change Windows 8.1: Restricted Project.
Nov 30 2016, 2:44 AM · gnupg, Windows 32, gnupg (gpg20), Windows, Bug Report
gniibe added a comment to T1686: GPG Smartcard daemons not detecting card change Windows 8.1.

Fixed in 2.1.11 and 2.0.30.

Nov 30 2016, 2:44 AM · gnupg, Windows 32, gnupg (gpg20), Windows, Bug Report
gniibe removed a project from T2698: Building static GnuPG fails with 2.1.15 (works with 2.1.14): Restricted Project.
Nov 30 2016, 2:42 AM · Bug Report, gnupg
gniibe closed T2698: Building static GnuPG fails with 2.1.15 (works with 2.1.14) as Resolved.
Nov 30 2016, 2:42 AM · Bug Report, gnupg
gniibe added a comment to T2698: Building static GnuPG fails with 2.1.15 (works with 2.1.14).

Fixed in 2.1.16.

Nov 30 2016, 2:42 AM · Bug Report, gnupg
gniibe closed T2651: scdaemon should free the reader after card removal as Resolved.
Nov 30 2016, 2:41 AM · Bug Report, gnupg, scd
gniibe added a comment to T2651: scdaemon should free the reader after card removal.

Fixed in 2.1.16. Will be in 2.0.31 as the fix is in the git repo already.

Nov 30 2016, 2:41 AM · Bug Report, gnupg, scd
gniibe removed a project from T2651: scdaemon should free the reader after card removal: Restricted Project.
Nov 30 2016, 2:41 AM · Bug Report, gnupg, scd