Page MenuHome GnuPG
Feed Advanced Search

Jun 29 2020

jukivili added a comment to T4966: Jitter entropy RNG disable on non-x86?.

Ok. This was just something that I noticed while going through configure.ac. Should I make patch for this or do you want to?

Jun 29 2020, 5:45 PM · libgcrypt, Bug Report

Jun 20 2020

jukivili added a comment to D501: VPMSUMD accelleration for GCM mode on PPC.

Just one question at the moment.

Jun 20 2020, 4:14 PM
jukivili committed rC35a78eb248d6: Add SM4 x86-64/AES-NI/AVX2 implementation (authored by jukivili).
Add SM4 x86-64/AES-NI/AVX2 implementation
Jun 20 2020, 1:53 PM
jukivili committed rCc9a3f1bb91e6: Add SM4 x86-64/AES-NI/AVX implementation (authored by jukivili).
Add SM4 x86-64/AES-NI/AVX implementation
Jun 20 2020, 1:53 PM
jukivili committed rC81fee26bbbae: Optimizations for SM4 cipher (authored by jukivili).
Optimizations for SM4 cipher
Jun 20 2020, 1:53 PM

Jun 18 2020

jukivili added a comment to D501: VPMSUMD accelleration for GCM mode on PPC.

Thanks for the new version. Unfortunately Minicloud seems to be down and therefore cannot test patch at the moment. I'll take look when I regain power64 access.

Jun 18 2020, 2:32 PM

Jun 16 2020

jukivili committed rCc1535d0b8797: tests: Add basic test-vectors for SM4 (authored by Tianjia Zhang <tianjia.zhang@linux.alibaba.com>).
tests: Add basic test-vectors for SM4
Jun 16 2020, 9:01 PM
jukivili committed rC6c571bfda640: doc: add GCRY_MD_SM3, GCRY_MAC_HMAC_SM3 and GCRY_MAC_GOST28147_IMIT (authored by jukivili).
doc: add GCRY_MD_SM3, GCRY_MAC_HMAC_SM3 and GCRY_MAC_GOST28147_IMIT
Jun 16 2020, 9:01 PM
jukivili committed rCddcce166ab8b: Add SM4 symmetric cipher algorithm (authored by Tianjia Zhang <tianjia.zhang@linux.alibaba.com>).
Add SM4 symmetric cipher algorithm
Jun 16 2020, 9:01 PM

Jun 8 2020

jukivili committed rC3060aadec396: Disable all assembly modules with --disable-asm (authored by jukivili).
Disable all assembly modules with --disable-asm
Jun 8 2020, 8:10 PM
jukivili committed rC6cdd7268fe19: rijndael: fix UBSAN warning on left shift by 24 places with type 'int' (authored by jukivili).
rijndael: fix UBSAN warning on left shift by 24 places with type 'int'
Jun 8 2020, 8:10 PM

Jun 3 2020

jukivili created T4966: Jitter entropy RNG disable on non-x86?.
Jun 3 2020, 10:18 PM · libgcrypt, Bug Report

Jun 1 2020

jukivili committed rC8cfaeae42522: cipher-ocb: fix out-of-array stack memory access (authored by jukivili).
cipher-ocb: fix out-of-array stack memory access
Jun 1 2020, 8:46 PM

Apr 27 2020

jukivili added a comment to D501: VPMSUMD accelleration for GCM mode on PPC.
In D501#4558, @slandden wrote:

But I need it to shift H one to the left:
H1 = H << one;

Apr 27 2020, 5:58 PM

Apr 19 2020

jukivili committed rC45f21f871982: gost28147: implement special MAC mode called imitovstavka (IMIT) (authored by lumag).
gost28147: implement special MAC mode called imitovstavka (IMIT)
Apr 19 2020, 9:11 PM
jukivili committed rCd7fa70ed9ddc: mac: add support for gcry_mac_ctl(GCRYCTL_SET_SBOX) (authored by lumag).
mac: add support for gcry_mac_ctl(GCRYCTL_SET_SBOX)
Apr 19 2020, 9:11 PM

Apr 16 2020

jukivili added a comment to D501: VPMSUMD accelleration for GCM mode on PPC.

Generally nice looking patch and great improvement for performance.

Apr 16 2020, 4:19 PM

Apr 14 2020

jukivili edited reviewers for D501: VPMSUMD accelleration for GCM mode on PPC, added: jukivili; removed: jwilk.
Apr 14 2020, 9:49 PM

Apr 6 2020

jukivili committed rC1250a9cd859d: ppc: avoid using vec_vsx_ld/vec_vsx_st for 2x64-bit vectors (authored by jukivili).
ppc: avoid using vec_vsx_ld/vec_vsx_st for 2x64-bit vectors
Apr 6 2020, 5:03 PM
jukivili added a comment to T4906: error: call to 'vec_vsx_ld' is ambiguous.
In T4906#133954, @JW wrote:

@jukivili,

I'd be interested in seeing the results of testing the patch. Can you provide a link to the results?

Apr 6 2020, 4:45 PM · Restricted Project, libgcrypt, Bug Report

Apr 4 2020

jukivili added a comment to T4906: error: call to 'vec_vsx_ld' is ambiguous.

Attached patch should solve the issue for gcc 7.5 and clang 8.

Apr 4 2020, 1:30 PM · Restricted Project, libgcrypt, Bug Report

Apr 2 2020

jukivili committed rC89b3ded8df96: asm-poly1305-aarch64: fix building with clang (authored by jukivili).
asm-poly1305-aarch64: fix building with clang
Apr 2 2020, 6:53 PM

Feb 3 2020

jukivili committed rC761a1a0d30ea: Fix wrong code execution in Poly1305 ARM/NEON implementation (authored by jukivili).
Fix wrong code execution in Poly1305 ARM/NEON implementation
Feb 3 2020, 9:30 PM
jukivili committed rCec7db47e9998: Set vZZ.16b register to zero before use in armv8 gcm implementation (authored by larma).
Set vZZ.16b register to zero before use in armv8 gcm implementation
Feb 3 2020, 9:30 PM

Feb 2 2020

jukivili committed rC114bbc45e971: Add POWER9 little-endian variant of PPC AES implementation (authored by jukivili).
Add POWER9 little-endian variant of PPC AES implementation
Feb 2 2020, 7:15 PM
jukivili committed rCb64b029318e7: crc-ppc: fix bad register used for vector load/store assembly (authored by jukivili).
crc-ppc: fix bad register used for vector load/store assembly
Feb 2 2020, 7:15 PM
jukivili committed rC89776d45c824: rinjdael-aes: use zero offset vector load/store when possible (authored by jukivili).
rinjdael-aes: use zero offset vector load/store when possible
Feb 2 2020, 7:15 PM
jukivili committed rC5beadf201312: Add gcry_cipher_ctl command to allow weak keys in testing use-cases (authored by jukivili).
Add gcry_cipher_ctl command to allow weak keys in testing use-cases
Feb 2 2020, 7:15 PM

Feb 1 2020

jukivili added a comment to T4833: libgcrypt: bug in _gcry_poly1305_armv7_neon_init_ext.

I prepared slightly different patch, with 'and r2,r2,r2' instruction removed as it is no longer needed.

Feb 1 2020, 6:39 PM · libgcrypt, Bug Report
jukivili added a comment to T4833: libgcrypt: bug in _gcry_poly1305_armv7_neon_init_ext.

Thanks for reporting this this. Your patch is correct.

Feb 1 2020, 4:54 PM · libgcrypt, Bug Report

Jan 22 2020

jukivili added a comment to D497: Set vZZ.16b register to zero before use in armv8 gcm implementation.

Patch have been applied to master, https://git.gnupg.org/cgi-bin/gitweb.cgi?p=libgcrypt.git;a=commit;h=79ed620ec46adbb08f5cea6a4865a95a436e4109

Jan 22 2020, 10:55 PM · libgcrypt
jukivili committed rC8b31091da092: sexp: fix cast from 'int' pointer to 'size_t' pointer (authored by jukivili).
sexp: fix cast from 'int' pointer to 'size_t' pointer
Jan 22 2020, 9:51 PM
jukivili committed rC5f098f7e6ceb: mpi/i386: fix DWARF CFI for _gcry_mpih_sub_n and _gcry_mpih_add_n (authored by jukivili).
mpi/i386: fix DWARF CFI for _gcry_mpih_sub_n and _gcry_mpih_add_n
Jan 22 2020, 9:51 PM
jukivili committed rC24b4d5c10a97: mpi: Add .note.gnu.property section for Intel CET (authored by H.J. Lu <hjl.tools@gmail.com>).
mpi: Add .note.gnu.property section for Intel CET
Jan 22 2020, 9:51 PM
jukivili committed rC22e577071790: amd64: Always include <config.h> in cipher assembly codes (authored by H.J. Lu <hjl.tools@gmail.com>).
amd64: Always include <config.h> in cipher assembly codes
Jan 22 2020, 9:51 PM
jukivili committed rCcb9f0a2df822: i386: Add _CET_ENDBR to indirect jump targets (authored by H.J. Lu <hjl.tools@gmail.com>).
i386: Add _CET_ENDBR to indirect jump targets
Jan 22 2020, 9:51 PM
jukivili committed rC4c88c2bd2a41: x86: Add .note.gnu.property section for Intel CET (authored by H.J. Lu <hjl.tools@gmail.com>).
x86: Add .note.gnu.property section for Intel CET
Jan 22 2020, 9:51 PM
jukivili committed rC8ebbd8545a20: Register DCO for H.J. Lu (authored by jukivili).
Register DCO for H.J. Lu
Jan 22 2020, 9:51 PM
jukivili committed rC4aa8ff904262: tests/basic: add vector cluttering to detect implementation bugs (authored by jukivili).
tests/basic: add vector cluttering to detect implementation bugs
Jan 22 2020, 9:51 PM
jukivili committed rC79ed620ec46a: Set vZZ.16b register to zero before use in armv8 gcm implementation (authored by Marvin W <git@larma.de>).
Set vZZ.16b register to zero before use in armv8 gcm implementation
Jan 22 2020, 9:51 PM

Jan 19 2020

jukivili committed rC7e3aac7ba49b: mpi: Fix error that point not uninitialized (authored by Tianjia Zhang <tianjia.zhang@linux.alibaba.com>).
mpi: Fix error that point not uninitialized
Jan 19 2020, 10:16 AM
jukivili committed rC5ebb2f0671c9: gcrypt.texi: fix GCRYCTL_GET_ALGO_NENCR typo (authored by jukivili).
gcrypt.texi: fix GCRYCTL_GET_ALGO_NENCR typo
Jan 19 2020, 10:16 AM
jukivili committed rC176a5f162acd: Update .gitignore (authored by Tianjia Zhang <tianjia.zhang@linux.alibaba.com>).
Update .gitignore
Jan 19 2020, 10:16 AM
jukivili committed rC43cfc1632dd3: ecc: Wrong flag and elements_enc fix. (authored by Tianjia Zhang <tianjia.zhang@linux.alibaba.com>).
ecc: Wrong flag and elements_enc fix.
Jan 19 2020, 10:16 AM
jukivili added a comment to D497: Set vZZ.16b register to zero before use in armv8 gcm implementation.

Thanks for bug fix. I've prepared patch and send it to mailing list https://lists.gnupg.org/pipermail/gcrypt-devel/2020-January/004885.html. Let me know if Reported-by is ok/enough. I would have liked to put you as author of commit, but this Differential interface of quite horrible and does not give all the needed information (mainly "name <email>" format for git).

Jan 19 2020, 9:50 AM · libgcrypt

Dec 25 2019

jukivili committed rC110077505aca: rijndael-ppc: performance improvements (authored by jukivili).
rijndael-ppc: performance improvements
Dec 25 2019, 9:51 PM
jukivili committed rC0837d7e6be3e: rijndael-ppc: fix bad register used for vector load/store assembly (authored by jukivili).
rijndael-ppc: fix bad register used for vector load/store assembly
Dec 25 2019, 9:51 PM
jukivili committed rC5b9ea3df0dc3: cipher: fix typo in error log (authored by jukivili).
cipher: fix typo in error log
Dec 25 2019, 9:51 PM

Dec 9 2019

jukivili added a comment to T4630: libgcrypt: POWER GHASH Vector Acceleration.

I've been wondering this also. I can start working on this.

Dec 9 2019, 5:50 PM · Feature Request, libgcrypt

Nov 28 2019

jukivili closed T4425: libgcrypt relocation error on aarch64 as Resolved.
Nov 28 2019, 4:15 PM · asm, libgcrypt, Bug Report

Nov 21 2019

jukivili committed rCe5c4cf0efb8f: gost28147: inline gost_val function to speed up code (authored by lumag).
gost28147: inline gost_val function to speed up code
Nov 21 2019, 5:45 PM
jukivili committed rCf9894240bed3: gost28147: do not use GOST28147_CONTEXT outside of GOST 28147 calculation (authored by lumag).
gost28147: do not use GOST28147_CONTEXT outside of GOST 28147 calculation
Nov 21 2019, 5:45 PM
jukivili committed rC8f573a67d12e: gostr3411-94: small speedup (authored by lumag).
gostr3411-94: small speedup
Nov 21 2019, 5:45 PM
jukivili committed rCd164a8e7f682: gost28147: simplify internal code (authored by lumag).
gost28147: simplify internal code
Nov 21 2019, 5:45 PM

Nov 8 2019

jukivili added a comment to T4630: libgcrypt: POWER GHASH Vector Acceleration.

Please note that C-based intrinsic implementation is the way to go now as that is the path chosen for PowerPC implementations in libgcrypt.

Nov 8 2019, 9:23 AM · Feature Request, libgcrypt

Nov 5 2019

jukivili committed rCbdbd032d1626: ec: fix left shift overflows on WIN64 build (authored by jukivili).
ec: fix left shift overflows on WIN64 build
Nov 5 2019, 9:11 PM
jukivili committed rC1322c6a5d1e9: mpi/amd64: use SSE2 for shifting instead of MMX (authored by jukivili).
mpi/amd64: use SSE2 for shifting instead of MMX
Nov 5 2019, 9:11 PM
jukivili committed rCb52dde860963: Add i386/SSSE3 implementation of SHA512 (authored by jukivili).
Add i386/SSSE3 implementation of SHA512
Nov 5 2019, 9:11 PM

Oct 16 2019

jukivili committed rC7e1383cfd43f: Fix building t-lock for WIN32 (authored by jukivili).
Fix building t-lock for WIN32
Oct 16 2019, 10:22 PM
jukivili committed rCf9d8b5a0369c: hash-common: avoid integer division to reduce call overhead (authored by jukivili).
hash-common: avoid integer division to reduce call overhead
Oct 16 2019, 10:22 PM

Sep 26 2019

jukivili updated the task description for T4460: libgcrypt performance TODOs.
Sep 26 2019, 9:09 PM · libgcrypt
jukivili committed rC4bebafb7bae8: Add stitched ChaCha20-Poly1305 ARMv8/AArch64 implementation (authored by jukivili).
Add stitched ChaCha20-Poly1305 ARMv8/AArch64 implementation
Sep 26 2019, 8:24 PM
jukivili committed rC96b91e164160: Small tweak for PowerPC Chacha20-Poly1305 round loop (authored by jukivili).
Small tweak for PowerPC Chacha20-Poly1305 round loop
Sep 26 2019, 8:24 PM
jukivili committed rC664370ea02df: Reduce size of x86-64 stitched Chacha20-Poly1305 implementations (authored by jukivili).
Reduce size of x86-64 stitched Chacha20-Poly1305 implementations
Sep 26 2019, 8:23 PM

Sep 16 2019

jukivili committed rC5516072451d4: Add PowerPC extra CFLAGS also for chacha20-ppc and crc-ppc (authored by jukivili).
Add PowerPC extra CFLAGS also for chacha20-ppc and crc-ppc
Sep 16 2019, 7:10 PM

Sep 15 2019

jukivili committed rC0486b85bd1fb: Add PowerPC vpmsum implementation of CRC (authored by jukivili).
Add PowerPC vpmsum implementation of CRC
Sep 15 2019, 10:31 PM
jukivili committed rC557702f0d53a: Add PowerPC vector implementation of ChaCha20 (authored by jukivili).
Add PowerPC vector implementation of ChaCha20
Sep 15 2019, 10:31 PM
jukivili committed rC0564757b934d: poly1305: add fast addition macro for ppc64 (authored by jukivili).
poly1305: add fast addition macro for ppc64
Sep 15 2019, 10:31 PM
jukivili updated the task description for T4460: libgcrypt performance TODOs.
Sep 15 2019, 10:13 PM · libgcrypt
jukivili claimed T4460: libgcrypt performance TODOs.
Sep 15 2019, 10:13 PM · libgcrypt

Sep 6 2019

jukivili added a comment to T4460: libgcrypt performance TODOs.

Poly1305 addition helper for ppc64 posted on mailing list: https://lists.gnupg.org/pipermail/gcrypt-devel/2019-September/004804.html

Sep 6 2019, 9:50 PM · libgcrypt
jukivili updated the task description for T4460: libgcrypt performance TODOs.
Sep 6 2019, 9:49 PM · libgcrypt

Sep 3 2019

jukivili updated the task description for T4460: libgcrypt performance TODOs.
Sep 3 2019, 9:57 PM · libgcrypt
jukivili updated the task description for T4460: libgcrypt performance TODOs.
Sep 3 2019, 9:57 PM · libgcrypt
jukivili updated the task description for T4460: libgcrypt performance TODOs.
Sep 3 2019, 9:56 PM · libgcrypt
jukivili added a subtask for T4531: PowerPC performance improvements: T4630: libgcrypt: POWER GHASH Vector Acceleration.
Sep 3 2019, 9:49 PM
jukivili added a parent task for T4630: libgcrypt: POWER GHASH Vector Acceleration: T4531: PowerPC performance improvements.
Sep 3 2019, 9:49 PM · Feature Request, libgcrypt
jukivili closed T4530: libgcrypt: POWER SHA-2 Vector Acceleration as Resolved.

PowerPC SHA-256 and SHA-512 implementations with little bit more tuning committed. Most notably, SHA-512 on POWER8 now gives similar performance to OpenSSL:

Sep 3 2019, 9:39 PM · libgcrypt, Feature Request
jukivili closed T4530: libgcrypt: POWER SHA-2 Vector Acceleration, a subtask of T4531: PowerPC performance improvements, as Resolved.
Sep 3 2019, 9:39 PM
jukivili committed rCe19dc973bc8e: Add SHA-256 implementations for POWER8 and POWER9 (authored by jukivili).
Add SHA-256 implementations for POWER8 and POWER9
Sep 3 2019, 9:34 PM
jukivili committed rC93632f1adf57: Add SHA-512 implementations for POWER8 and POWER9 (authored by jukivili).
Add SHA-512 implementations for POWER8 and POWER9
Sep 3 2019, 9:34 PM
jukivili committed rC418179593080: hwf-ppc: add detection for PowerISA 3.00 (authored by jukivili).
hwf-ppc: add detection for PowerISA 3.00
Sep 3 2019, 9:34 PM

Aug 31 2019

jukivili reassigned T4630: libgcrypt: POWER GHASH Vector Acceleration from jukivili to slandden.
Aug 31 2019, 11:13 AM · Feature Request, libgcrypt
jukivili added a comment to T4530: libgcrypt: POWER SHA-2 Vector Acceleration.

Patches send to mailing list:
https://lists.gnupg.org/pipermail/gcrypt-devel/2019-August/004800.html
https://lists.gnupg.org/pipermail/gcrypt-devel/2019-August/004799.html

Aug 31 2019, 2:07 AM · libgcrypt, Feature Request
jukivili closed T4529: libgcrypt: POWER AES Vector Acceleration, a subtask of T4531: PowerPC performance improvements, as Resolved.
Aug 31 2019, 1:38 AM
jukivili closed T4529: libgcrypt: POWER AES Vector Acceleration as Resolved.
Aug 31 2019, 1:38 AM · libgcrypt, Feature Request

Aug 26 2019

jukivili committed rC81d555d34730: rijndael-ppc: add bulk modes for CBC, CFB, CTR and XTS (authored by jukivili).
rijndael-ppc: add bulk modes for CBC, CFB, CTR and XTS
Aug 26 2019, 7:04 PM
jukivili committed rC821602c60c7d: rijndael-ppc: enable PowerPC AES-OCB implemention (authored by jukivili).
rijndael-ppc: enable PowerPC AES-OCB implemention
Aug 26 2019, 7:04 PM
jukivili committed rCbd1367bb6078: rijndael-ppc: add bulk mode for ocb_auth (authored by jukivili).
rijndael-ppc: add bulk mode for ocb_auth
Aug 26 2019, 7:04 PM
jukivili committed rC9dca65ef71b4: rijndael-ppc: add key setup and enable single block PowerPC AES (authored by jukivili).
rijndael-ppc: add key setup and enable single block PowerPC AES
Aug 26 2019, 7:04 PM
jukivili committed rC92f38a619b1c: rijndael/ppc: implement single-block mode, and implement OCB block cipher (authored by slandden).
rijndael/ppc: implement single-block mode, and implement OCB block cipher
Aug 26 2019, 7:04 PM
jukivili committed rCb4a3c76fabfa: hwf: add detection of PowerPC hardware features (authored by slandden).
hwf: add detection of PowerPC hardware features
Aug 26 2019, 7:04 PM
jukivili committed rCcc13336f6289: Register DCO for Shawn Landden (authored by jukivili).
Register DCO for Shawn Landden
Aug 26 2019, 7:04 PM

Aug 25 2019

jukivili claimed T4630: libgcrypt: POWER GHASH Vector Acceleration.

I'll start working on PowerPC GHASH implementation in September after SHA2 is done.

Aug 25 2019, 6:12 PM · Feature Request, libgcrypt
jukivili claimed T4530: libgcrypt: POWER SHA-2 Vector Acceleration.

I'll start working on new PowerPC SHA2 implementations for libgcrypt in coming weeks.

Aug 25 2019, 6:11 PM · libgcrypt, Feature Request
jukivili claimed T4529: libgcrypt: POWER AES Vector Acceleration.

Patches for PowerPC AES acceleration sent to mailing-list, based partly on initial work by Shawn Landden (@slandden): https://lists.gnupg.org/pipermail/gcrypt-devel/2019-August/004788.html

Aug 25 2019, 6:10 PM · libgcrypt, Feature Request

Jul 18 2019

jukivili committed rC320ed4796303: Fix use of AVX instruction in SHA1/SSSE3 assembly (authored by jukivili).
Fix use of AVX instruction in SHA1/SSSE3 assembly
Jul 18 2019, 7:57 PM

Jul 8 2019

jukivili added a comment to D494: rijndael/ppc: re-implement single-block mode, and implement OCB block cipher.
In D494#4450, @slandden wrote:

I will leave these in the main file, as they might benefit from "static", and I do not want to rely on LTO for that.

Jul 8 2019, 9:21 PM
jukivili edited reviewers for D494: rijndael/ppc: re-implement single-block mode, and implement OCB block cipher, added: jukivili; removed: jwilk.
Jul 8 2019, 4:02 PM
jukivili added a comment to D494: rijndael/ppc: re-implement single-block mode, and implement OCB block cipher.

Thanks. I really like this Altivec intrinsic approach. I might reimplement rest of the bulk block cipher functions this way later (if I ever get PPC HW access).

Jul 8 2019, 4:02 PM