Page MenuHome GnuPG
Feed Advanced Search

Jul 10 2020

gniibe added a comment to T4975: undefined-shift in block_filter.

While I see that it's not the matter of actual use case (but how gpg can be immune to fuzzing), code clean up would be good here.

Jul 10 2020, 4:34 AM · gnupg (gpg22), Bug Report
gniibe added a comment to D503: fix undefined-shift in block_filter.

Thanks for the patch.
I see your point in T4975: undefined-shift in block_filter.
You are right that we have a problem of possible overflow (which could be kicked by fuzzing) here.
(The actual impact would be small, though).

Jul 10 2020, 4:26 AM
gniibe claimed T4951: Support point compression in Libgcrypt.
Jul 10 2020, 3:41 AM · Feature Request, libgcrypt
gniibe added a comment to T4951: Support point compression in Libgcrypt.

What kind of API should we offer?
(1) offering something like q@comp name for gcry_mpi_ec_get_mpi
But...
If the intended use case will be in create_request function in gpg/sm/certreqgen.c, the 'q' is already generated in the form of SEXP.
It is up to an application (gpgsm), to convert non-compressed point representation to compressed point representation, here.

Jul 10 2020, 3:40 AM · Feature Request, libgcrypt
gniibe changed the status of T4246: GnuPG master does not allow decryption with bad usage flags (regression), a subtask of T4417: Work needed for gnupg 2.3, from Open to Testing.
Jul 10 2020, 3:04 AM · gnupg (gpg23)
gniibe changed the status of T4246: GnuPG master does not allow decryption with bad usage flags (regression) from Open to Testing.
Jul 10 2020, 3:04 AM · Restricted Project, Bug Report, gnupg (gpg23)
gniibe committed rG31ae0718ba10: gpg: For decryption, support use of a key with no 'encrypt' usage. (authored by gniibe).
gpg: For decryption, support use of a key with no 'encrypt' usage.
Jul 10 2020, 3:03 AM

Jul 9 2020

gniibe claimed T4246: GnuPG master does not allow decryption with bad usage flags (regression).
Jul 9 2020, 8:20 AM · Restricted Project, Bug Report, gnupg (gpg23)
gniibe added a comment to T4246: GnuPG master does not allow decryption with bad usage flags (regression).

Or this (don't allow anon keys for different usage):

diff --git a/g10/pubkey-enc.c b/g10/pubkey-enc.c
index 14cbdbb0f..b8d4059cd 100644
--- a/g10/pubkey-enc.c
+++ b/g10/pubkey-enc.c
@@ -91,9 +91,6 @@ get_session_key (ctrl_t ctrl, struct pubkey_enc_list *list, DEK *dek)
       if (err)
         break;
Jul 9 2020, 8:20 AM · Restricted Project, Bug Report, gnupg (gpg23)
gniibe added a comment to T4246: GnuPG master does not allow decryption with bad usage flags (regression).

Do you mean something like this?

Jul 9 2020, 8:11 AM · Restricted Project, Bug Report, gnupg (gpg23)
gniibe changed the status of T4688: `make distcheck` fails trying to make `rst/gpgme-python-howto.rst` from Open to Testing.

Fixed in rM1b840a151ad7: python: Fix how to generate documentation..

Jul 9 2020, 7:23 AM · Restricted Project, gpgme, Bug Report
gniibe changed the status of T4915: Cannot compile on macOS Mojave (utf8.c) from Open to Testing.
Jul 9 2020, 7:07 AM · Restricted Project, gnupg (gpg23), Bug Report
gniibe changed the status of T4973: Cross build problem with v1.38 from Open to Testing.
Jul 9 2020, 7:05 AM · Restricted Project, gpgrt
gniibe added a parent task for T4160: ed488 support: T4417: Work needed for gnupg 2.3.
Jul 9 2020, 7:00 AM · gnupg24, gnupg (gpg23), Feature Request
gniibe added a subtask for T4417: Work needed for gnupg 2.3: T4160: ed488 support.
Jul 9 2020, 7:00 AM · gnupg (gpg23)
gniibe added a parent task for T4246: GnuPG master does not allow decryption with bad usage flags (regression): T4417: Work needed for gnupg 2.3.
Jul 9 2020, 6:55 AM · Restricted Project, Bug Report, gnupg (gpg23)
gniibe added a subtask for T4417: Work needed for gnupg 2.3: T4246: GnuPG master does not allow decryption with bad usage flags (regression).
Jul 9 2020, 6:55 AM · gnupg (gpg23)
gniibe changed the status of T4160: ed488 support from Open to Testing.

It's in master (to be gnupg 2.3).
Enjoy.

Jul 9 2020, 6:53 AM · gnupg24, gnupg (gpg23), Feature Request

Jul 7 2020

gniibe committed rG34c9cfd3d772: po: Update Japanese Translation. (authored by gniibe).
po: Update Japanese Translation.
Jul 7 2020, 2:45 AM

Jul 2 2020

gniibe added a comment to T4981: internationalization (support UNICODE/UTF-8 character set).

It seems that nl_langinfo(CODESET) returns US-ASCII on your system.

Jul 2 2020, 8:16 AM · i18n, FreeBSD, Feature Request
gniibe added a comment to T4982: [PATCH] qt libraries should be linked with -fPIC instead of -fpic.

Yes, it will fix the problem on x32, I suppose.
If it's difficult for dpkg, for some reason for now, workaround for gpgme packaging is disabling pie hardening for x32 until pie will be its compiler default.
For gpgme, it is only test binaries which matter (pie or not), so, the impact (for x32) is minimum.

Jul 2 2020, 2:15 AM · Debian, gpgme

Jul 1 2020

gniibe added a comment to T4982: [PATCH] qt libraries should be linked with -fPIC instead of -fpic.

Some information of Qt5 about -fpic:

Jul 1 2020, 8:49 AM · Debian, gpgme
gniibe added a comment to T4982: [PATCH] qt libraries should be linked with -fPIC instead of -fpic.

Debian's GCC build for PIE default: https://salsa.debian.org/toolchain-team/gcc/-/blob/master/debian/rules.defs#L1400

Jul 1 2020, 5:09 AM · Debian, gpgme
gniibe added a comment to T4982: [PATCH] qt libraries should be linked with -fPIC instead of -fpic.

Here is my understanding. My point is it's not problem of gpgme. To fix it correctly, I think that dpkg should be fixed and it would be needed to fix Qt too.

Jul 1 2020, 4:52 AM · Debian, gpgme

Jun 30 2020

gniibe committed rG45398518fb76: ecc: Support Ed448/X448 key generation. (authored by gniibe).
ecc: Support Ed448/X448 key generation.
Jun 30 2020, 7:22 AM
gniibe added a comment to T4982: [PATCH] qt libraries should be linked with -fPIC instead of -fpic.
Jun 30 2020, 6:44 AM · Debian, gpgme
gniibe added a comment to T4982: [PATCH] qt libraries should be linked with -fPIC instead of -fpic.

I think that it is the problem of dpkg to override the compiler flag by the spec file. When compiler default is -fPIE, it works well. If not (for the case of x32), it fails.
In the past, hurd-i386 had same issue, but compiler default seems to be now -fPIE, thus no problem.

Jun 30 2020, 6:06 AM · Debian, gpgme
gniibe triaged T4982: [PATCH] qt libraries should be linked with -fPIC instead of -fpic as Normal priority.
Jun 30 2020, 4:36 AM · Debian, gpgme
gniibe claimed T4982: [PATCH] qt libraries should be linked with -fPIC instead of -fpic.

Thanks for your report.

Jun 30 2020, 4:34 AM · Debian, gpgme

Jun 26 2020

gniibe added a comment to T4977: dirmngr not working with linux kernel parameter ipv6.disable=1.

When I test it on Debian, disabling by,

Jun 26 2020, 7:25 AM · Restricted Project, gnupg (gpg22), dirmngr, Bug Report
gniibe claimed T4977: dirmngr not working with linux kernel parameter ipv6.disable=1.
Jun 26 2020, 7:06 AM · Restricted Project, gnupg (gpg22), dirmngr, Bug Report
gniibe added a comment to T4977: dirmngr not working with linux kernel parameter ipv6.disable=1.

Please get log of dirmngr, by putting

log-file /run/user/<YOURNUMBER-LIKE-1000>/dirmngr.log
Jun 26 2020, 7:04 AM · Restricted Project, gnupg (gpg22), dirmngr, Bug Report

Jun 24 2020

gniibe added a comment to T4979: enable-ssh-support in windows is broken..

I think the feature is not (yet) supported on Windows.
Please see: T3883: Add Win32-OpenSSH support to gpg-agent's ssh-agent

Jun 24 2020, 4:05 AM · ssh, Duplicate, Bug Report
gniibe added a comment to D505: Ed448 support for GnuPG.

Pushed to master as rGa763bb2580b0: gpg,agent: Support Ed448 signing..

Jun 24 2020, 3:17 AM
gniibe committed rGa763bb2580b0: gpg,agent: Support Ed448 signing. (authored by gniibe).
gpg,agent: Support Ed448 signing.
Jun 24 2020, 3:16 AM

Jun 23 2020

gniibe updated the diff for D505: Ed448 support for GnuPG.

Update to [rGc94eea15d}.
Hash defaults to SHA512.

Jun 23 2020, 3:56 AM
gniibe committed rGc94eea15d684: ecc: Use "cv448" to specify key using X448. (authored by gniibe).
ecc: Use "cv448" to specify key using X448.
Jun 23 2020, 3:21 AM
gniibe committed rC1db1dc7945b1: ecc: Fix length computation. (authored by gniibe).
ecc: Fix length computation.
Jun 23 2020, 3:11 AM

Jun 19 2020

gniibe added a comment to D505: Ed448 support for GnuPG.

(1) Has no (flags eddsa) in key in SEXP.
(2) Has no (flags eddsa) and no (hash-algo shake256) in data to be signed in SEXP.
(3) Has no (flags eddsa) and no (hash-algo shake256) in data to be verified in SEXP.
(4) Uses SHA256 for hashing of OpenPGP data

Jun 19 2020, 8:14 AM
gniibe updated the diff for D505: Ed448 support for GnuPG.

Update to rG4bdade5b0bea: agent: Use get_pk_algo_from_key.

Jun 19 2020, 8:12 AM
gniibe committed rG4bdade5b0bea: agent: Use get_pk_algo_from_key. (authored by gniibe).
agent: Use get_pk_algo_from_key.
Jun 19 2020, 7:47 AM
gniibe committed rGd2e4aa5ee4c5: agent: Clean up for getting info from SEXP. (authored by gniibe).
agent: Clean up for getting info from SEXP.
Jun 19 2020, 7:07 AM
gniibe committed rGabc6a3100a33: agent: A little clean up. (authored by gniibe).
agent: A little clean up.
Jun 19 2020, 7:07 AM

Jun 18 2020

gniibe committed rCf2847d56cce2: ecc: Fix the condition for EdDSA data handling. (authored by gniibe).
ecc: Fix the condition for EdDSA data handling.
Jun 18 2020, 6:52 AM
gniibe committed rCa6177e1bc948: ecc: For Ed448, it's only for EdDSA. (authored by gniibe).
ecc: For Ed448, it's only for EdDSA.
Jun 18 2020, 6:52 AM
gniibe committed rCba78ad8f1967: ecc: Support EdDSA with context and enabling PH(M). (authored by gniibe).
ecc: Support EdDSA with context and enabling PH(M).
Jun 18 2020, 4:50 AM
gniibe committed rC2856ac14ae3e: ecc: Change EdDSA internal API. (authored by gniibe).
ecc: Change EdDSA internal API.
Jun 18 2020, 2:54 AM

Jun 17 2020

gniibe committed rC1cf497546946: ecc: Support "label" for EdDSA context in data. (authored by gniibe).
ecc: Support "label" for EdDSA context in data.
Jun 17 2020, 10:02 AM
gniibe committed rCd51a9c259d49: ecc: Initialize key before handling data. (authored by gniibe).
ecc: Initialize key before handling data.
Jun 17 2020, 10:02 AM
gniibe committed rC9a640eba6dd7: ecc: Add new flag "prehash". (authored by gniibe).
ecc: Add new flag "prehash".
Jun 17 2020, 9:46 AM
gniibe committed rCb1721f9b291a: ecc: No (flags eddsa) required for Ed448. (authored by gniibe).
ecc: No (flags eddsa) required for Ed448.
Jun 17 2020, 5:48 AM
gniibe committed rC5585ee494708: ecc: Support Ed448 by _gcry_ecc_compute_public. (authored by gniibe).
ecc: Support Ed448 by _gcry_ecc_compute_public.
Jun 17 2020, 5:48 AM
gniibe added a comment to D505: Ed448 support for GnuPG.

The changes just follow the existing practice of Ed25519, which does:

Jun 17 2020, 3:21 AM

Jun 16 2020

gniibe created D505: Ed448 support for GnuPG.
Jun 16 2020, 9:30 AM
gniibe committed rCc15cc1a38199: ecc: Fix Ed448 key generation. (authored by gniibe).
ecc: Fix Ed448 key generation.
Jun 16 2020, 9:24 AM
gniibe committed rCc7779e499e90: ecc,test: Add testing Ed448. (authored by gniibe).
ecc,test: Add testing Ed448.
Jun 16 2020, 4:26 AM
gniibe committed rCd1baad35c650: ecc: Support Ed448 for verify. (authored by gniibe).
ecc: Support Ed448 for verify.
Jun 16 2020, 4:26 AM
gniibe committed rCe25446ecc044: ecc: Support Ed448 for key generation. (authored by gniibe).
ecc: Support Ed448 for key generation.
Jun 16 2020, 4:26 AM
gniibe committed rC951b37c50386: ecc: Support Ed448 signing. (authored by gniibe).
ecc: Support Ed448 signing.
Jun 16 2020, 4:26 AM
gniibe committed rCf6815a96e51b: ecc: Support shake128 and shake256 for message digest. (authored by gniibe).
ecc: Support shake128 and shake256 for message digest.
Jun 16 2020, 4:26 AM
gniibe committed rC32d6d73d44d3: ecc: Use SHAKE256 in EdDSA with Ed448. (authored by gniibe).
ecc: Use SHAKE256 in EdDSA with Ed448.
Jun 16 2020, 4:26 AM
gniibe committed rCbd22b029bbf5: ecc: Support Ed448 in decoding point. (authored by gniibe).
ecc: Support Ed448 in decoding point.
Jun 16 2020, 4:26 AM
gniibe committed rC339b03acf097: ecc: Add new curve: Ed448. (authored by gniibe).
ecc: Add new curve: Ed448.
Jun 16 2020, 4:26 AM
gniibe committed rC3386aaf84d4d: ecc: Fix EdDSA encoding for Ed448. (authored by gniibe).
ecc: Fix EdDSA encoding for Ed448.
Jun 16 2020, 4:26 AM
gniibe added a comment to D504: ECC change for Ed448.

Changes pushed to master.

Jun 16 2020, 4:19 AM · libgcrypt

Jun 15 2020

gniibe added a comment to D502: ECC change for SOS.

Pushed the patch to master.

Jun 15 2020, 4:45 AM
gniibe committed rE1a4c1f37a1c9: build: Fix the gpg-error-config test for cross build. (authored by gniibe).
build: Fix the gpg-error-config test for cross build.
Jun 15 2020, 4:41 AM
gniibe added a comment to T4973: Cross build problem with v1.38.

It's me who should say "thank you".

Jun 15 2020, 4:39 AM · Restricted Project, gpgrt
gniibe added a comment to T4973: Cross build problem with v1.38.

Or one liner patch would be enough:

Jun 15 2020, 3:32 AM · Restricted Project, gpgrt
gniibe added a comment to T4973: Cross build problem with v1.38.

IIUC, you build libgpg-error with setting PKG_CONFIG_SYSROOT_DIR.
It results errors, because while old gpg-error-config never supports PKG_CONFIG_SYSROOT_DIR, it compares result from old gpg-error-config and gpgrt-config gpg-error.

Jun 15 2020, 3:27 AM · Restricted Project, gpgrt
gniibe added a comment to T4973: Cross build problem with v1.38.

Please give us full build log here, so that we can investigate what's going on. You can upload log file by the "upload" button in comment edit dialog.

Jun 15 2020, 3:08 AM · Restricted Project, gpgrt

Jun 12 2020

gniibe created D504: ECC change for Ed448.
Jun 12 2020, 7:11 AM · libgcrypt
gniibe committed rCdb7b2c591004: ecc: Fix NBITS in domain_parms. (authored by gniibe).
ecc: Fix NBITS in domain_parms.
Jun 12 2020, 3:18 AM
gniibe added a comment to T4973: Cross build problem with v1.38.

Sorry for repeated mistake of mine.
I fixed it and tested with 'make distcheck' in the environment of cross-build for ppc64el host.

Jun 12 2020, 2:06 AM · Restricted Project, gpgrt
gniibe committed rE159e394920f6: build: Fix command-line to make 'src 'dir. (authored by gniibe).
build: Fix command-line to make 'src 'dir.
Jun 12 2020, 2:01 AM

Jun 11 2020

gniibe committed rEce97528fa3dc: build: On cross build, detect host's objdump. (authored by gniibe).
build: On cross build, detect host's objdump.
Jun 11 2020, 4:35 AM
gniibe triaged T4973: Cross build problem with v1.38 as Normal priority.

Thanks for your report. I think it fails to generate src/lock-obj-pub.native.h.

Jun 11 2020, 3:52 AM · Restricted Project, gpgrt

Jun 9 2020

gniibe committed rGda5e0bc31b4c: gpg: Use bytes for ECDH. (authored by gniibe).
gpg: Use bytes for ECDH.
Jun 9 2020, 8:51 AM
gniibe committed rGe9760eb9e70b: gpg: Add X448 support. (authored by gniibe).
gpg: Add X448 support.
Jun 9 2020, 8:00 AM
gniibe committed rGf5bc94555458: gpg,ecc: Handle external representation as SOS with opaque MPI. (authored by gniibe).
gpg,ecc: Handle external representation as SOS with opaque MPI.
Jun 9 2020, 3:38 AM

Jun 8 2020

gniibe added a comment to D502: ECC change for SOS.

I was wrong. This patch itself doesn't require libgcrypt 1.9. It works with libgcrypt 1.8 well.

Jun 8 2020, 4:43 AM
gniibe added a comment to D502: ECC change for SOS.

I think that the changes for ECC I've done matters:
o rC050e0b4accfa: pubkey: Support a method to get data as an opaque MPI.
o rC05a7d2f262bc: ecc: Support an opaque MPI handling in mpi_from_keyparam.
rC3d5a05767b84: ecc: Fix handling of point representation in EdDSA.
o rC8fce1027c253: ecc: Return an opaque MPI by _gcry_ecc_ec2os.
rC35c1faaea2b0: ecc: String constant fix.
rCad8927f40169: ecc: Simplify _gcry_ecc_compute_public.
o rCc5a7191c1bd1: ecc: Use opaque MPI for _gcry_ecc_mul_point.
rCbbe15758c893: ecc: Fix _gcry_ecc_mont_decodepoint for data by old implementation.
rC27e848666b4a: ecc: ECDH clean up for use of ec->nbits.
rC82441bbb8290: ecc: Fix key generation for ECDH.
rC6d93812aa312: ecc: Fix debug output.
rC6a30a9a2cc48: ecc: Simplify using mpi_ec_t directly.
rC975de3879691: ecc: Fix for NBITS support.
rCe921ad5b3ad0: ecc: Add NAME member to struct mpi_ec_ctx_s.
rC488704be6e04: ecc: Add key generation support to mpi_ec_get_elliptic_curve.
rC5415bc578080: ecc: Consolidate with _gcry_mpi_ec_internal_new.
rCc2aa333dd88b: ecc: Support flags and debug print in _gcry_mpi_ec_internal_new.
rCc7b97ac9bdf9: ecc: Add new function _gcry_mpi_ec_internal_new.
rC10b8cc280a53: ecc: Simplify ecc_encrypt_raw and ecc_decrypt_raw.
rC61a051828253: ecc: More fixes for cofactor with PUBKEY_FLAG_PARAM.
rCa258ae728de6: ecc: Simply use unsigned int for cofactor, not MPI.
rC579d5d6017d6: ecc: Simplify compute_keygrip.
rC95cc9b8f4483: ecc: Clean up key generation code.
o rCff0f1782560e: ecc: Handle ephemeral key as opaque octets.
rC80cf289905ac: ecc: Consolidate encoding a point for Montgomery curve.
rCba0b31f26366: ecc: More clean-up for Ed25519 and Curve25519.
rCd66a4856eb0c: ecc: Fix hard-coded value for 25519 to allow other modern curves.

Jun 8 2020, 4:31 AM
gniibe committed rGe2e573684229: agent: Fix the condition to detect leading 0x00 problem. (authored by gniibe).
agent: Fix the condition to detect leading 0x00 problem.
Jun 8 2020, 4:10 AM

Jun 5 2020

gniibe created D502: ECC change for SOS.
Jun 5 2020, 5:48 AM
gniibe committed rG47c1c329ed82: agent,ecc: Use of opaque MPI for ECC, fixup 'd'. (authored by gniibe).
agent,ecc: Use of opaque MPI for ECC, fixup 'd'.
Jun 5 2020, 3:39 AM
gniibe committed rGa7d46c78e242: agent,ssh: Tighten condition for EdDSA. (authored by gniibe).
agent,ssh: Tighten condition for EdDSA.
Jun 5 2020, 3:39 AM
gniibe committed rG2e988546c59b: agent: Remove duplicated code for EdDSA. (authored by gniibe).
agent: Remove duplicated code for EdDSA.
Jun 5 2020, 3:39 AM
gniibe committed rG2b118516240b: agent: For ECC, use opaque MPI for key representation. (authored by gniibe).
agent: For ECC, use opaque MPI for key representation.
Jun 5 2020, 3:39 AM
gniibe committed rG4c0b12f817f1: agent: Clean up do_encode_md. (authored by gniibe).
agent: Clean up do_encode_md.
Jun 5 2020, 3:39 AM

Jun 4 2020

gniibe committed rG74a79bed4ba6: ecc-sos,gpg: More fixes for SOS. (authored by gniibe).
ecc-sos,gpg: More fixes for SOS.
Jun 4 2020, 11:53 AM
gniibe committed rG1e537dd29a88: Fix previous commit. (authored by gniibe).
Fix previous commit.
Jun 4 2020, 11:23 AM
gniibe committed rGfb9e39dcc979: ecc-sos,gpg: Use sexp_extract_param_sos to get MPI. (authored by gniibe).
ecc-sos,gpg: Use sexp_extract_param_sos to get MPI.
Jun 4 2020, 11:20 AM
gniibe committed rC78a5a1aa7627: mpi: Fix flags in mpi_copy for opaque MPI. (authored by gniibe).
mpi: Fix flags in mpi_copy for opaque MPI.
Jun 4 2020, 5:52 AM
gniibe committed rGf71dff40ead8: ecc-sos: Apply SOS also to ECDSA. (authored by gniibe).
ecc-sos: Apply SOS also to ECDSA.
Jun 4 2020, 4:57 AM
gniibe committed rGd18fa9fb9a41: ecc-sos: Fix handling cleartext secret key from agent. (authored by gniibe).
ecc-sos: Fix handling cleartext secret key from agent.
Jun 4 2020, 4:48 AM
gniibe committed rGe249f51c6415: ecc-sos, agent: More fixes for fixup of ECC private key. (authored by gniibe).
ecc-sos, agent: More fixes for fixup of ECC private key.
Jun 4 2020, 3:49 AM

Jun 3 2020

gniibe committed rGd1af7b781c74: ecc-sos,agent: Fix sexp parsing of private key. (authored by gniibe).
ecc-sos,agent: Fix sexp parsing of private key.
Jun 3 2020, 1:27 PM
gniibe committed rG5f3fcb579f0b: ecc-sos, agent: Add fixing up private key part for leading zero. (authored by gniibe).
ecc-sos, agent: Add fixing up private key part for leading zero.
Jun 3 2020, 6:05 AM
gniibe committed rG3d3f99d76aa5: Revert "ecc-sos: Add special leading zero octet removal." (authored by gniibe).
Revert "ecc-sos: Add special leading zero octet removal."
Jun 3 2020, 6:05 AM
gniibe added a reverting change for rG1c4291c3951d: ecc-sos: Add special leading zero octet removal.: rG3d3f99d76aa5: Revert "ecc-sos: Add special leading zero octet removal.".
Jun 3 2020, 6:05 AM