Page MenuHome GnuPG
Feed Advanced Search

Nov 5 2020

gniibe committed rG484bafda4dbf: scd: Internal CCID driver: Fix a race condition on close. (authored by gniibe).
scd: Internal CCID driver: Fix a race condition on close.
Nov 5 2020, 8:19 AM
gniibe created T5121: a race condition between intr_cb call back and libusb_free_transfer in do_close_reader.
Nov 5 2020, 12:43 AM · gnupg (gpg22), Restricted Project, scd

Nov 4 2020

gniibe added a comment to T5120: Incompatible Ed25519 secret key (no-encryption).

Applying following SOS-handling, the key can be handled.

diff --git a/g10/parse-packet.c b/g10/parse-packet.c
index 9cb254e24..be7fc6d67 100644
--- a/g10/parse-packet.c
+++ b/g10/parse-packet.c
@@ -188,6 +188,76 @@ mpi_read (iobuf_t inp, unsigned int *ret_nread, int secure)
 }
Nov 4 2020, 3:57 AM · gnupg (gpg22), Bug Report
gniibe added a comment to T5120: Incompatible Ed25519 secret key (no-encryption).

Note that there is no problem for encrypted key, because it is handled by opaque MPI.

Nov 4 2020, 3:21 AM · gnupg (gpg22), Bug Report
gniibe created T5120: Incompatible Ed25519 secret key (no-encryption).
Nov 4 2020, 3:21 AM · gnupg (gpg22), Bug Report
gniibe changed the status of T5116: GnuPG master shows an error when importing Ed25519 keys generated from Open to Testing.
Nov 4 2020, 3:14 AM · Restricted Project, gnupg, Bug Report
gniibe changed the status of T5116: GnuPG master shows an error when importing Ed25519 keys generated, a subtask of T5114: GnuPG fails to import back generated and exported EdDSA secret key., from Open to Testing.
Nov 4 2020, 3:14 AM · gnupg, Restricted Project, gpgagent, Bug Report

Nov 2 2020

gniibe committed rG8211d0bc3ba5: kbx: Don't put zero-byte for ECC. (authored by gniibe).
kbx: Don't put zero-byte for ECC.
Nov 2 2020, 7:35 AM
gniibe committed rG90c3d623ce37: gpg: Fix debug output for key_check_all_keysigs with opaque MPI. (authored by gniibe).
gpg: Fix debug output for key_check_all_keysigs with opaque MPI.
Nov 2 2020, 3:37 AM
gniibe committed rG029ba6dc961c: gpg: Fix check_signature2 for opaque MPI. (authored by gniibe).
gpg: Fix check_signature2 for opaque MPI.
Nov 2 2020, 3:37 AM
gniibe committed rG21d8927f794b: gpg: Change the API for checksum to use const qualifier. (authored by gniibe).
gpg: Change the API for checksum to use const qualifier.
Nov 2 2020, 3:37 AM
gniibe committed rG3151210e455f: gpg: Fix counting buffer size in check_signature2. (authored by gniibe).
gpg: Fix counting buffer size in check_signature2.
Nov 2 2020, 3:37 AM

Oct 30 2020

gniibe committed rG813e24108a13: gpg: Fix SOS handling with libgcrypt version <= 1.8. (authored by gniibe).
gpg: Fix SOS handling with libgcrypt version <= 1.8.
Oct 30 2020, 9:09 AM
gniibe added a comment to T5116: GnuPG master shows an error when importing Ed25519 keys generated.

One bug is fixed in rGdd4fb1c8f668: gpg: Fix first zero-byte case for SOS handling..

Oct 30 2020, 9:03 AM · Restricted Project, gnupg, Bug Report
gniibe committed rGdd4fb1c8f668: gpg: Fix first zero-byte case for SOS handling. (authored by gniibe).
gpg: Fix first zero-byte case for SOS handling.
Oct 30 2020, 7:23 AM
gniibe committed rC361a0588489c: ecc: Handle removed zeros at the beginning for Ed25519. (authored by gniibe).
ecc: Handle removed zeros at the beginning for Ed25519.
Oct 30 2020, 2:28 AM
gniibe changed the status of T5114: GnuPG fails to import back generated and exported EdDSA secret key. from Open to Testing.

Fixed in 2.2 branch.
Also, I found another issue of libgcrypt master, which is fixed in rC361a0588489c: ecc: Handle removed zeros at the beginning for Ed25519..
Further, I found different issue, and created T5116: GnuPG master shows an error when importing Ed25519 keys generated.

Oct 30 2020, 2:23 AM · gnupg, Restricted Project, gpgagent, Bug Report
gniibe committed rGba321b60bc3b: agent: Fix secret key import for Ed25519. (authored by gniibe).
agent: Fix secret key import for Ed25519.
Oct 30 2020, 2:22 AM
gniibe created T5116: GnuPG master shows an error when importing Ed25519 keys generated.
Oct 30 2020, 12:55 AM · Restricted Project, gnupg, Bug Report
gniibe added a comment to T5114: GnuPG fails to import back generated and exported EdDSA secret key..

I think that it may occur with eddsa secret keys generated with 2.2, too. (In the 50% probability)

Oct 30 2020, 12:51 AM · gnupg, Restricted Project, gpgagent, Bug Report

Oct 29 2020

gniibe added a comment to T5114: GnuPG fails to import back generated and exported EdDSA secret key..

IIUC, it is an issue of GnuPG 2.2.
The condition is where the secret 'd' starts by the first bit = 1 (that is, >= 0x80).
I located the bug in agent/cvt-openpgp.c. The function do_unprotect calls convert_secret_key with skey[1] as usual MPI (not opaque),
and gcry_sexp_build with "(d%m)" will put additional 0x00 at the beginning, which results 33-byte secret in R_KEY. Then, when gcry_pk_testkey is called with R_KEY, when it checks, because 32-byte is expected, it returns GPG_ERR_INV_OBJ. Then, do_unprotect returns GPG_ERR_BAD_PASSPHRASE.

Oct 29 2020, 8:58 AM · gnupg, Restricted Project, gpgagent, Bug Report
gniibe edited projects for T5114: GnuPG fails to import back generated and exported EdDSA secret key., added: gnupg (gpg22), gpgagent; removed gnupg (gpg23).
Oct 29 2020, 7:26 AM · gnupg, Restricted Project, gpgagent, Bug Report
gniibe added a comment to T5114: GnuPG fails to import back generated and exported EdDSA secret key..

With Debian's GnuPG 2.2.12, I got an error:

Oct 29 2020, 7:22 AM · gnupg, Restricted Project, gpgagent, Bug Report
gniibe claimed T5114: GnuPG fails to import back generated and exported EdDSA secret key..

With bata1449, I cannot reproduce it.
I can import by gpg --import key-uids-sec.pgp
I tested with Debian's libgcrypt, as well as libgcrypt master (4a50c6b8).

Oct 29 2020, 6:35 AM · gnupg, Restricted Project, gpgagent, Bug Report

Oct 28 2020

gniibe triaged T5100: OpenPGP app overwrites Yubikey serial number as Normal priority.
Oct 28 2020, 2:45 AM · Restricted Project, gnupg, scd, yubikey, kleopatra
gniibe committed rM089164a0c0d6: python: Handle the when case __doc__ is None. (authored by gniibe).
python: Handle the when case __doc__ is None.
Oct 28 2020, 1:12 AM
gniibe closed T5075: [python-gpgme] Traceback when running with python -OO as Resolved.

Pushed the change.

Oct 28 2020, 12:51 AM · gpgme, Python, Bug Report
gniibe claimed T5075: [python-gpgme] Traceback when running with python -OO.
Oct 28 2020, 12:30 AM · gpgme, Python, Bug Report

Oct 27 2020

gniibe added a comment to T5075: [python-gpgme] Traceback when running with python -OO.

IIUC, fix can be like this:

diff --git a/lang/python/src/core.py b/lang/python/src/core.py
index 996c3b0f..646bbc60 100644
--- a/lang/python/src/core.py
+++ b/lang/python/src/core.py
@@ -147,7 +147,12 @@ class GpgmeWrapper(object):
                     gpgme.gpg_raise_callback_exception(slf)
                 return result
Oct 27 2020, 8:31 AM · gpgme, Python, Bug Report
gniibe changed the status of T5100: OpenPGP app overwrites Yubikey serial number from Open to Testing.
Oct 27 2020, 6:43 AM · Restricted Project, gnupg, scd, yubikey, kleopatra
gniibe added a comment to T5100: OpenPGP app overwrites Yubikey serial number.

SCD commands:

  • DEVINFO
    • returns app apecific serialno
  • SERIALNO
    • returns app specific serialno
  • LEARN
    • returns canonical serialno
Oct 27 2020, 6:41 AM · Restricted Project, gnupg, scd, yubikey, kleopatra
gniibe committed rGe59d2b3632d8: scd: Handle canonical serialno and app specific serialno differently. (authored by gniibe).
scd: Handle canonical serialno and app specific serialno differently.
Oct 27 2020, 6:41 AM

Oct 26 2020

gniibe closed T5102: READCERT immediately after WRITECERT fails as Resolved.

Pushed the change.

Oct 26 2020, 6:32 AM · kleopatra, scd
gniibe committed rG8264b10d33e4: scd: Flush the cache when writing cert data object. (authored by gniibe).
scd: Flush the cache when writing cert data object.
Oct 26 2020, 6:32 AM
gniibe committed rGa153d0f76914: gpg: Fix double free on error. (authored by gniibe).
gpg: Fix double free on error.
Oct 26 2020, 6:01 AM
gniibe committed rG157f1de64e43: gpg,tools: Fix detecting OpenPGP card by serialno. (authored by gniibe).
gpg,tools: Fix detecting OpenPGP card by serialno.
Oct 26 2020, 6:01 AM
gniibe committed rG31def32eeed8: scd: Internal CCID driver thing only for SPR532. (authored by gniibe).
scd: Internal CCID driver thing only for SPR532.
Oct 26 2020, 3:42 AM

Oct 24 2020

gniibe committed rG3c6b5dfa2a23: scd: Internal CCID driver limiting only for SPR532. (authored by gniibe).
scd: Internal CCID driver limiting only for SPR532.
Oct 24 2020, 4:02 AM

Oct 23 2020

gniibe committed rG2d4de4b6f06c: scd: Handle Yubikey's multiple apps and serialno. (authored by gniibe).
scd: Handle Yubikey's multiple apps and serialno.
Oct 23 2020, 9:34 AM
gniibe committed rGc8cc35dd2c10: scd: Use app_get_serialno for app_getattr. (authored by gniibe).
scd: Use app_get_serialno for app_getattr.
Oct 23 2020, 8:26 AM
gniibe committed rG65c91e601ae9: scd: Don't overwrite serialno for Yubikey. (authored by gniibe).
scd: Don't overwrite serialno for Yubikey.
Oct 23 2020, 8:21 AM
gniibe committed rG41505f0ae544: scd,openpgp: Use app_get_serialno function to get SERIALNO. (authored by gniibe).
scd,openpgp: Use app_get_serialno function to get SERIALNO.
Oct 23 2020, 8:17 AM
gniibe updated the task description for T5109: Initial socket connection to server.
Oct 23 2020, 4:54 AM · gnupg24, gnupg (gpg23)
gniibe updated the summary of D510: Connection to gpg-agent/dirmngr/etc..
Oct 23 2020, 4:52 AM · gnupg
gniibe updated the diff for D510: Connection to gpg-agent/dirmngr/etc..

Only enabled for UNIX #ifdef/#else/#endif

Oct 23 2020, 4:52 AM · gnupg
gniibe edited projects for T5109: Initial socket connection to server, added: gnupg (gpg22); removed gnupg.
Oct 23 2020, 4:49 AM · gnupg24, gnupg (gpg23)
gniibe added a comment to T5109: Initial socket connection to server.

I had overlooked this fix rG044379772fc5: common: Fix the previous commit., after the commit of rGb1c56cf9e2bb: common: Use gnupg_spawn_process_fd to invoke gpg-agent/dirmngr..

Oct 23 2020, 4:46 AM · gnupg24, gnupg (gpg23)
gniibe updated the task description for T5109: Initial socket connection to server.
Oct 23 2020, 4:33 AM · gnupg24, gnupg (gpg23)
gniibe updated the task description for T5109: Initial socket connection to server.
Oct 23 2020, 4:33 AM · gnupg24, gnupg (gpg23)
gniibe created T5109: Initial socket connection to server.
Oct 23 2020, 4:31 AM · gnupg24, gnupg (gpg23)
gniibe created D510: Connection to gpg-agent/dirmngr/etc..
Oct 23 2020, 4:25 AM · gnupg

Oct 21 2020

gniibe added a comment to T5100: OpenPGP app overwrites Yubikey serial number.

I created this patch D509: Yubikey supports two (or more) apps, serial number problem.

Oct 21 2020, 7:53 AM · Restricted Project, gnupg, scd, yubikey, kleopatra
gniibe created D509: Yubikey supports two (or more) apps, serial number problem.
Oct 21 2020, 7:51 AM · gnupg

Oct 19 2020

gniibe added a comment to T5100: OpenPGP app overwrites Yubikey serial number.

No, the above patch makes OpenPGP app stop working.

Oct 19 2020, 9:34 AM · Restricted Project, gnupg, scd, yubikey, kleopatra
gniibe added a comment to T5100: OpenPGP app overwrites Yubikey serial number.

(I don't know well about Yubikey specific serial number.)

Oct 19 2020, 9:27 AM · Restricted Project, gnupg, scd, yubikey, kleopatra
gniibe claimed T5100: OpenPGP app overwrites Yubikey serial number.
Oct 19 2020, 6:41 AM · Restricted Project, gnupg, scd, yubikey, kleopatra
gniibe claimed T5102: READCERT immediately after WRITECERT fails.
Oct 19 2020, 6:37 AM · kleopatra, scd

Oct 9 2020

gniibe committed rG33cb1655f1b7: agent: Fix SEGV when debuging for cache enabled. (authored by gniibe).
agent: Fix SEGV when debuging for cache enabled.
Oct 9 2020, 6:59 AM
gniibe committed rG228836f79f64: gpg,ecc: Fix SOS handling when receiving from agent. (authored by gniibe).
gpg,ecc: Fix SOS handling when receiving from agent.
Oct 9 2020, 6:59 AM

Oct 8 2020

gniibe added a comment to T5099: Confirmation dialog for remote access (restricted extra socket).

I'm testing:

diff --git a/agent/findkey.c b/agent/findkey.c
index fa9e5b548..eec85ba67 100644
--- a/agent/findkey.c
+++ b/agent/findkey.c
@@ -996,7 +996,10 @@ agent_key_from_file (ctrl_t ctrl, const char *cache_nonce,
   if (r_passphrase)
     *r_passphrase = NULL;
Oct 8 2020, 11:24 AM · Feature Request, gnupg
gniibe created T5099: Confirmation dialog for remote access (restricted extra socket).
Oct 8 2020, 11:23 AM · Feature Request, gnupg

Oct 6 2020

gniibe committed rG25bec16d0bdc: scd: Add a workaround for Yubikey. (authored by gniibe).
scd: Add a workaround for Yubikey.
Oct 6 2020, 10:18 AM
gniibe added a comment to T5063: Use of some "SCD" command through extra socket.

Perhaps, don't allow automatic use of available card keys would be better:

diff --git a/agent/command.c b/agent/command.c
index 160979dae..b6286becf 100644
--- a/agent/command.c
+++ b/agent/command.c
@@ -2292,13 +2292,7 @@ cmd_scd (assuan_context_t ctx, char *line)
       if ((argc == 1 && !strcmp (argv[0], "SERIALNO"))
           || (argc == 2
               && !strcmp (argv[0], "GETINFO")
-              && !strcmp (argv[1], "version"))
-          || (argc == 2
-              && !strcmp (argv[0], "GETATTR")
-              && !strcmp (argv[1], "KEY-FPR"))
-          || (argc == 2
-              && !strcmp (argv[0], "KEYINFO")
-              && !strcmp (argv[1], "--list=encr")))
+              && !strcmp (argv[1], "version")))
         xfree (l);
       else
         {
Oct 6 2020, 7:17 AM · Bug Report
gniibe committed rG0f4c956a7661: scd: Silence compiler warning. (authored by gniibe).
scd: Silence compiler warning.
Oct 6 2020, 5:04 AM
gniibe committed rG7c8823bf82da: scd: Report any error for LEARN command. (authored by gniibe).
scd: Report any error for LEARN command.
Oct 6 2020, 5:04 AM
gniibe committed rG1f1b68eef72b: scd: Internal CCID driver: More fix for SPR532. (authored by gniibe).
scd: Internal CCID driver: More fix for SPR532.
Oct 6 2020, 5:04 AM
gniibe committed rG48565e7a08d6: scd: Internal CCID driver: Call libusb_clear_halt at ccid_setup_intr. (authored by gniibe).
scd: Internal CCID driver: Call libusb_clear_halt at ccid_setup_intr.
Oct 6 2020, 5:04 AM
gniibe committed rG33a2d4bd7ffc: scd: Internal CCID driver fix. (authored by gniibe).
scd: Internal CCID driver fix.
Oct 6 2020, 5:04 AM
gniibe committed rG498cd38019b8: scd: Internal CCID: Handle LIBUSB_ERROR_TIMEOUT at ccid_get_atr. (authored by gniibe).
scd: Internal CCID: Handle LIBUSB_ERROR_TIMEOUT at ccid_get_atr.
Oct 6 2020, 5:04 AM
gniibe committed rG7db836c0e922: scd: Change handling of SPR532 card reader. (authored by gniibe).
scd: Change handling of SPR532 card reader.
Oct 6 2020, 5:04 AM
gniibe committed rG30693dfb6fe9: scd: Internal CCID driver: Fix a failure path. (authored by gniibe).
scd: Internal CCID driver: Fix a failure path.
Oct 6 2020, 5:04 AM
gniibe committed rGdd7cc24d5f92: scd: Fix CCID internal driver for interrupt transfer. (authored by gniibe).
scd: Fix CCID internal driver for interrupt transfer.
Oct 6 2020, 5:04 AM
gniibe committed rG11d8d1e05056: scd: For SPR532, submit the ESCape command at initialization. (authored by gniibe).
scd: For SPR532, submit the ESCape command at initialization.
Oct 6 2020, 5:04 AM
gniibe committed rG186d11896ca2: scd: Better handling of timeout and time extension. (authored by gniibe).
scd: Better handling of timeout and time extension.
Oct 6 2020, 5:04 AM
gniibe committed rG165312dca90a: scd: ccid-driver: Initial getting ATR more robustly. (authored by gniibe).
scd: ccid-driver: Initial getting ATR more robustly.
Oct 6 2020, 5:04 AM
gniibe committed rG60af035c22b9: scd: Fix internal CCID driver, so that -DTEST works. (authored by gniibe).
scd: Fix internal CCID driver, so that -DTEST works.
Oct 6 2020, 5:04 AM
gniibe committed rG1efc01ff987d: scd: Clean up the structure for future fix of PC/SC. (authored by gniibe).
scd: Clean up the structure for future fix of PC/SC.
Oct 6 2020, 5:04 AM
gniibe committed rG5b985b026418: scd: Map some error codes from libusb to ccid-driver error codes. (authored by werner).
scd: Map some error codes from libusb to ccid-driver error codes.
Oct 6 2020, 5:04 AM
gniibe committed rGcccdca61a841: scd: internal driver: Submit SET_INTERFACE control transfer. (authored by gniibe).
scd: internal driver: Submit SET_INTERFACE control transfer.
Oct 6 2020, 5:03 AM
gniibe committed rGe3a12b09dca4: scd: Internal CCID driver: Spelling cleanup. (authored by gniibe).
scd: Internal CCID driver: Spelling cleanup.
Oct 6 2020, 5:03 AM
gniibe committed rG7b531fe5801b: scd: Internal CCID driver: Clean up backport from master. (authored by gniibe).
scd: Internal CCID driver: Clean up backport from master.
Oct 6 2020, 5:03 AM

Oct 5 2020

gniibe closed T5064: Forwarded gpg ssh agent doesn't see smartcard ssh key, only (none) as Resolved.

This is due to access control for "extra" socket.
Fixed in T5062: gpg: error getting version from 'scdaemon': Forbidden.

Oct 5 2020, 7:01 AM · Bug Report
gniibe closed T5064: Forwarded gpg ssh agent doesn't see smartcard ssh key, only (none), a subtask of T5062: gpg: error getting version from 'scdaemon': Forbidden, as Resolved.
Oct 5 2020, 7:01 AM · Bug Report
gniibe added a parent task for T5064: Forwarded gpg ssh agent doesn't see smartcard ssh key, only (none): T5062: gpg: error getting version from 'scdaemon': Forbidden.
Oct 5 2020, 7:00 AM · Bug Report
gniibe added a subtask for T5062: gpg: error getting version from 'scdaemon': Forbidden: T5064: Forwarded gpg ssh agent doesn't see smartcard ssh key, only (none).
Oct 5 2020, 7:00 AM · Bug Report

Oct 1 2020

gniibe committed rMfd904f87f8d4: gpgsm: Fix leaked fd. (authored by gniibe).
gpgsm: Fix leaked fd.
Oct 1 2020, 6:16 AM
gniibe changed the status of T5074: Leaking fd from Open to Testing.
Oct 1 2020, 4:21 AM · Restricted Project, gpgme, Bug Report
gniibe claimed T5074: Leaking fd.

Good catch. Thank you.

Oct 1 2020, 4:18 AM · Restricted Project, gpgme, Bug Report
gniibe accepted D508: Close unused fd.
Oct 1 2020, 4:18 AM · gpgme

Sep 30 2020

gniibe added a comment to T5086: GnuPG fails to generate keys on-card in versions 2.2.22 and 2.2.23.

I think that rG61aea64b3c17: scd: Fix the use case of verify_chv2 by CHECKPIN. fixes this issue.

Sep 30 2020, 4:04 AM · Restricted Project, gnupg, Bug Report
gniibe added a comment to T5065: scdaemon doesn't detect card removal after boot/resume (Identiv SPR332v2).

I observed that the card reader's going erroneous state when I removed a card during its communication.
In this state, it never reports the card removal by the interrupt transfer.
I applied rG920f258eb601: scd: Internal CCID driver: More fix for SPR532. for this problem.

Sep 30 2020, 4:01 AM · Restricted Project, gnupg (gpg22), scd, Bug Report
gniibe committed rG920f258eb601: scd: Internal CCID driver: More fix for SPR532. (authored by gniibe).
scd: Internal CCID driver: More fix for SPR532.
Sep 30 2020, 3:59 AM
gniibe committed rG862d9c6face9: scd: Report any error for LEARN command. (authored by gniibe).
scd: Report any error for LEARN command.
Sep 30 2020, 3:59 AM
gniibe triaged T5086: GnuPG fails to generate keys on-card in versions 2.2.22 and 2.2.23 as High priority.

Thanks for your report.

Sep 30 2020, 1:20 AM · Restricted Project, gnupg, Bug Report
gniibe claimed T5086: GnuPG fails to generate keys on-card in versions 2.2.22 and 2.2.23.
Sep 30 2020, 1:19 AM · Restricted Project, gnupg, Bug Report

Sep 29 2020

gniibe committed rG1444203ca32c: scd: Internal CCID driver fix. (authored by gniibe).
scd: Internal CCID driver fix.
Sep 29 2020, 6:29 AM
gniibe committed rG6af978713e4c: scd: Internal CCID driver: Call libusb_clear_halt at ccid_setup_intr. (authored by gniibe).
scd: Internal CCID driver: Call libusb_clear_halt at ccid_setup_intr.
Sep 29 2020, 6:29 AM

Sep 28 2020

gniibe committed rGb1e8072320c1: scd: Internal CCID: Handle LIBUSB_ERROR_TIMEOUT at ccid_get_atr. (authored by gniibe).
scd: Internal CCID: Handle LIBUSB_ERROR_TIMEOUT at ccid_get_atr.
Sep 28 2020, 8:58 AM
gniibe committed rGd561c936a217: scd: Internal CCID driver: Fix a failure path. (authored by gniibe).
scd: Internal CCID driver: Fix a failure path.
Sep 28 2020, 8:58 AM
gniibe committed rGc5e8ef3ab980: scd: Internal CCID: Clear the handle after use. (authored by gniibe).
scd: Internal CCID: Clear the handle after use.
Sep 28 2020, 6:38 AM