Page MenuHome GnuPG
Feed Advanced Search

Feb 10 2022

jukivili committed rGab177eed514f: g10/mainproc: avoid extra hash contexts when decrypting MDC input (authored by jukivili).
g10/mainproc: avoid extra hash contexts when decrypting MDC input
Feb 10 2022, 7:50 PM
jukivili created T5826: Improve detached signing and verification speed.
Feb 10 2022, 7:15 PM · gnupg

Feb 9 2022

jukivili added inline comments to rC90f41a1898e4: Fix memory allocation when GCRYCTL_ENABLE_M_GUARD..
Feb 9 2022, 8:58 AM

Feb 8 2022

jukivili committed rC59b2504df8f0: kdf: fix unaligned memory access in balloon_xor_block (authored by jukivili).
kdf: fix unaligned memory access in balloon_xor_block
Feb 8 2022, 8:13 AM

Feb 7 2022

jukivili added a comment to T5820: Slow symmetric decryption speed.

Benchmarking blog post that I linked tested GnuPG in symmetric mode, gpg --symmetric. I think symmetric case is important too from performance point of view, there is tools that use gpg --symmetric as bulk encryption/decryption backend (for example duplicity backup tool). Such encrypted files have tag3 (symmetric-key ESK) packet followed tag18 (encrypted and MDC) packet. Could existence of Tag18 packet in input be used as marker for input being rfc4880 and allow disabling those extra hash contexts? As I understand those hashes should not be needed with rfc4880 input (but I don't know all the historical details).

Feb 7 2022, 9:24 PM · gnupg (gpg23), Bug Report
jukivili created T5820: Slow symmetric decryption speed.
Feb 7 2022, 5:05 PM · gnupg (gpg23), Bug Report

Feb 2 2022

jukivili committed rCd480db6e6c80: hwf-arm: add detection of ARMv8 crypto extension by toolchain config (authored by jukivili).
hwf-arm: add detection of ARMv8 crypto extension by toolchain config
Feb 2 2022, 5:57 PM

Jan 30 2022

jukivili committed rC409f69167983: kdf/argon2: use BLAKE2b hash_buffers function instead of _gcry_md_* (authored by jukivili).
kdf/argon2: use BLAKE2b hash_buffers function instead of _gcry_md_*
Jan 30 2022, 11:30 PM
jukivili committed rC54369c66bedd: kdf: handle errors from thread dispatch/wait functions (authored by jukivili).
kdf: handle errors from thread dispatch/wait functions
Jan 30 2022, 11:30 PM
jukivili committed rC03a0eedefe3e: tests/t-kdf: few changes to pthread example and fix win32/win64 builds (authored by jukivili).
tests/t-kdf: few changes to pthread example and fix win32/win64 builds
Jan 30 2022, 11:30 PM
jukivili committed rCc5aead8aebc7: Rename KDF job functions and function types (authored by jukivili).
Rename KDF job functions and function types
Jan 30 2022, 11:30 PM

Jan 26 2022

jukivili added a comment to T5797: New API for modern password hash function.

I planned to reply to your email on mailing-list, but I just have too little time.

Jan 26 2022, 7:45 PM · Feature Request, libgcrypt
jukivili added a comment to T5785: libgcrypt-1.9.4 build failure on ppc64le.

Thanks for report. Those powerpc vector implementations expect that compiler optimizations are enabled and here provided CFLAGS did not have '-Ox' parameter. This could be worked around by introducing -O2 always when building those files (confiugre.ac & cipher/Makefile.am change) or using 'optimize' attributes to required functions (cipher/*-ppc*.c change).

Jan 26 2022, 8:19 AM · Gentoo, Bug Report
jukivili claimed T5785: libgcrypt-1.9.4 build failure on ppc64le.
Jan 26 2022, 8:14 AM · Gentoo, Bug Report

Jan 22 2022

jukivili committed rCa35ac62ee7b5: Fix building GCM when GCM_USE_ARM_NEON defined but GCM_USE_ARM_PMULL not (authored by jukivili).
Fix building GCM when GCM_USE_ARM_NEON defined but GCM_USE_ARM_PMULL not
Jan 22 2022, 6:21 PM
jukivili committed rCe9e723d5e320: tests/t-kdf: fix format string argument type mismatch (authored by jukivili).
tests/t-kdf: fix format string argument type mismatch
Jan 22 2022, 6:21 PM
jukivili claimed T5796: libgcrypt-1.9.4 build failure on ARM without NEON.

Thanks for report. I got similar report earlier this week from gentoo user through email and made following patch for them to test. I'll push it to master soon.

Jan 22 2022, 6:03 PM · arm, libgcrypt, Gentoo, Bug Report

Jan 12 2022

jukivili committed rCdfd53c7eddf0: rijndael-aesni: small optimization for cbc-enc and cfb-enc (authored by jukivili).
rijndael-aesni: small optimization for cbc-enc and cfb-enc
Jan 12 2022, 4:57 PM

Jan 11 2022

jukivili committed rC9bbb6c2c5d03: mpi/config.links: merge i586 targets with rest i*86 targets (authored by jukivili).
mpi/config.links: merge i586 targets with rest i*86 targets
Jan 11 2022, 7:17 PM
jukivili committed rC2800de892585: mpi: remove unused i586 and pentium4 assembly (authored by jukivili).
mpi: remove unused i586 and pentium4 assembly
Jan 11 2022, 7:17 PM
jukivili committed rC0c0f27a89205: mpi/amd64: remove extra 'ret' from assembly functions (authored by jukivili).
mpi/amd64: remove extra 'ret' from assembly functions
Jan 11 2022, 7:17 PM
jukivili committed rC11ade08efbfb: Add straight-line speculation hardening for amd64 and i386 assembly (authored by jukivili).
Add straight-line speculation hardening for amd64 and i386 assembly
Jan 11 2022, 7:17 PM
jukivili committed rC34bcc102158a: Add straight-line speculation hardening for aarch64 assembly (authored by jukivili).
Add straight-line speculation hardening for aarch64 assembly
Jan 11 2022, 7:17 PM
jukivili committed rCff2a647d3667: Optimizations for AES aarch64-ce assembly implementation (authored by jukivili).
Optimizations for AES aarch64-ce assembly implementation
Jan 11 2022, 7:17 PM
jukivili committed rC4e6f1ef5a00e: Add armv8/pmull accelerated POLYVAL for GCM-SIV (authored by jukivili).
Add armv8/pmull accelerated POLYVAL for GCM-SIV
Jan 11 2022, 7:17 PM
jukivili committed rC859b6ac7fbdb: Use 'vmov' and 'movi' for vector register clearing in ARM assembly (authored by jukivili).
Use 'vmov' and 'movi' for vector register clearing in ARM assembly
Jan 11 2022, 7:17 PM
jukivili committed rCf664333a4749: Add SM3 ARM/AArch64 assembly implementation (authored by jukivili).
Add SM3 ARM/AArch64 assembly implementation
Jan 11 2022, 7:17 PM

Dec 21 2021

jukivili committed rC7205c715b3e0: AES-GCM: Bulk implementation of AES-GCM acceleration for ppc64le (authored by dannytsen).
AES-GCM: Bulk implementation of AES-GCM acceleration for ppc64le
Dec 21 2021, 4:42 PM
jukivili committed rCf23634f9141b: Register DCO for Danny Tsen (authored by jukivili).
Register DCO for Danny Tsen
Dec 21 2021, 4:42 PM
jukivili committed rC3b9f746c2fb1: cipher: Fix SM3 avx/bmi2 compilation error (authored by Tianjia Zhang <tianjia.zhang@linux.alibaba.com>).
cipher: Fix SM3 avx/bmi2 compilation error
Dec 21 2021, 4:42 PM
jukivili added a comment to T5700: libgcrypt: bulk AES-GCM acceleration for ppc64le.

Ok, I'll add.

Dec 21 2021, 4:03 PM · patch, ppc, libgcrypt, Feature Request

Dec 14 2021

jukivili added a comment to T5700: libgcrypt: bulk AES-GCM acceleration for ppc64le.

DCO has not appeared on mailing-list. You can this from check list archives, https://lists.gnupg.org/pipermail/gcrypt-devel/2021-December/thread.html

Dec 14 2021, 8:58 PM · patch, ppc, libgcrypt, Feature Request
jukivili added a comment to T5700: libgcrypt: bulk AES-GCM acceleration for ppc64le.

I did some finishing touches on coding style:

Dec 14 2021, 7:39 PM · patch, ppc, libgcrypt, Feature Request
jukivili committed rC0c1d55a84c89: Add SM3 x86-64 AVX/BMI2 assembly implementation (authored by jukivili).
Add SM3 x86-64 AVX/BMI2 assembly implementation
Dec 14 2021, 7:15 PM

Dec 12 2021

jukivili added a comment to T5700: libgcrypt: bulk AES-GCM acceleration for ppc64le.

Few comments on new patch:

Dec 12 2021, 7:18 PM · patch, ppc, libgcrypt, Feature Request

Dec 4 2021

jukivili added a comment to T5700: libgcrypt: bulk AES-GCM acceleration for ppc64le.

Thanks, however I didn't see your email on mailing-list. Maybe the email got stuck on the way.

Dec 4 2021, 12:46 PM · patch, ppc, libgcrypt, Feature Request

Dec 2 2021

jukivili added a comment to T5700: libgcrypt: bulk AES-GCM acceleration for ppc64le.

Please read doc/HACKING carefully on the process of sending DCO the right way.

Dec 2 2021, 5:31 PM · patch, ppc, libgcrypt, Feature Request

Dec 1 2021

jukivili committed rCd5bf106468e6: gcry_mpi_sub_ui: fix subtracting from negative value (authored by jukivili).
gcry_mpi_sub_ui: fix subtracting from negative value
Dec 1 2021, 9:54 PM

Nov 18 2021

jukivili committed rC33f1a7ad3cd1: Do not build 'cipher/' assembly files when --disable-asm used (authored by jukivili).
Do not build 'cipher/' assembly files when --disable-asm used
Nov 18 2021, 6:55 PM
jukivili committed rCf10fa6b9a6ca: Do not build poly1305-s390x.S on foreign architectures (authored by jukivili).
Do not build poly1305-s390x.S on foreign architectures
Nov 18 2021, 6:55 PM
jukivili committed rCa44301f6d205: jitterentropy: use wipememory for jent_memset_secure (authored by jukivili).
jitterentropy: use wipememory for jent_memset_secure
Nov 18 2021, 6:55 PM
jukivili committed rCc38ebc3b6c7d: jitterentropy: fix building on Win32 (authored by jukivili).
jitterentropy: fix building on Win32
Nov 18 2021, 6:55 PM
jukivili added a comment to T5694: poly1305-s390x.S is compiled despite --disable-asm.

Following patch should prevent assembly files being built at all with --disable-asm:

Nov 18 2021, 8:51 AM · libgcrypt, Bug Report
jukivili added a comment to T5694: poly1305-s390x.S is compiled despite --disable-asm.

Thanks for your report.

Nov 18 2021, 8:27 AM · libgcrypt, Bug Report
jukivili claimed T5694: poly1305-s390x.S is compiled despite --disable-asm.
Nov 18 2021, 8:17 AM · libgcrypt, Bug Report

Nov 15 2021

jukivili committed rC5e0187d84fc1: Add intel-pclmul accelerated POLYVAL for GCM-SIV (authored by jukivili).
Add intel-pclmul accelerated POLYVAL for GCM-SIV
Nov 15 2021, 9:49 PM

Oct 27 2021

jukivili committed rCecd4d348ac87: tests/bench-slope: avoid divide by zero (authored by jukivili).
tests/bench-slope: avoid divide by zero
Oct 27 2021, 7:35 PM
jukivili committed rC5881114e0860: md: clear context with wipememory to avoid false warning (authored by jukivili).
md: clear context with wipememory to avoid false warning
Oct 27 2021, 7:35 PM
jukivili committed rCe4ce7ad0ecf6: poly1305: fix building with 'arm-linux-gnueabihf-gcc-11 -O3' (authored by jukivili).
poly1305: fix building with 'arm-linux-gnueabihf-gcc-11 -O3'
Oct 27 2021, 7:35 PM
jukivili committed rC6333cdeee5c1: cipher/sha512: fix 'accessing 64 bytes in a region of size 8' warnings (authored by jukivili).
cipher/sha512: fix 'accessing 64 bytes in a region of size 8' warnings
Oct 27 2021, 7:35 PM

Oct 10 2021

jukivili committed rC95425c6b0b96: cipher/sha256: fix 'accessing 32 bytes in a region of size 4' warnings (authored by jukivili).
cipher/sha256: fix 'accessing 32 bytes in a region of size 4' warnings
Oct 10 2021, 8:38 AM

Oct 6 2021

jukivili committed rC9fc0d145278d: Fix building for Win64 target (authored by jukivili).
Fix building for Win64 target
Oct 6 2021, 6:16 PM

Sep 1 2021

jukivili added a comment to T5581: buf_eq_const() function in cipher/bufhelp.h may get wrong result.

Based on GCC bugzilla, affected released GCC versions are 11.1 and 11.2.

Sep 1 2021, 3:44 PM · toolchain, libgcrypt, Bug Report
jukivili added a comment to T5581: buf_eq_const() function in cipher/bufhelp.h may get wrong result.

(ab | ba) >= 0 is used to make optimization analysis for compiler more difficult. I see that with (ab | ba) == 0, it would be much easier for compiler to conclude than loop could exit early as soon as first a[i] != b[i] is seen.

Sep 1 2021, 3:39 PM · toolchain, libgcrypt, Bug Report

Aug 26 2021

jukivili committed rC47e425e07995: Add ARMv8-CE HW acceleration for GCM-SIV counter mode (authored by jukivili).
Add ARMv8-CE HW acceleration for GCM-SIV counter mode
Aug 26 2021, 8:19 PM
jukivili committed rC9e3b0446653f: mpi/longlong: fix variable shadowing from MIPS umul_ppmm macros (authored by jukivili).
mpi/longlong: fix variable shadowing from MIPS umul_ppmm macros
Aug 26 2021, 8:19 PM
jukivili committed rC33aebb30d210: Add x86 HW acceleration for GCM-SIV counter mode (authored by jukivili).
Add x86 HW acceleration for GCM-SIV counter mode
Aug 26 2021, 8:19 PM
jukivili committed rC1b8994c4ecf2: Add AES-GCM-SIV mode (RFC 8452) (authored by jukivili).
Add AES-GCM-SIV mode (RFC 8452)
Aug 26 2021, 8:19 PM
jukivili committed rC659a208cb065: Add SIV mode (RFC 5297) (authored by jukivili).
Add SIV mode (RFC 5297)
Aug 26 2021, 8:19 PM

Aug 13 2021

jukivili committed rCa5982e35088a: tests/bench-slope: allow non-FIPS ECC benchmarking in non-FIPS mode (authored by jukivili).
tests/bench-slope: allow non-FIPS ECC benchmarking in non-FIPS mode
Aug 13 2021, 2:01 PM

Jul 31 2021

jukivili claimed T4486: Add AEAD mode AES-SIV to libgcrypt (RFC 5297).
Jul 31 2021, 12:36 PM · Feature Request, libgcrypt

Jul 7 2021

jukivili committed rCb98ca3f798ab: tests/basic: use SHA256 instead of RMD160 for SHAKE extract testing (authored by jukivili).
tests/basic: use SHA256 instead of RMD160 for SHAKE extract testing
Jul 7 2021, 5:29 PM
jukivili added a comment to T5520: Fix tests in FIPS mode.

That crcalgo can be any digest algorithm and SHA256 seems best option to me.

Jul 7 2021, 5:29 PM · FIPS, libgcrypt, Bug Report

Jul 6 2021

jukivili committed rC69fdcb543323: ec: add zSeries/s390x accelerated scalar multiplication (authored by jukivili).
ec: add zSeries/s390x accelerated scalar multiplication
Jul 6 2021, 6:07 PM
jukivili committed rC4b76fa6a1f92: rinjdael-s390x: fix UBSAN warning on using index beyond end of array (authored by jukivili).
rinjdael-s390x: fix UBSAN warning on using index beyond end of array
Jul 6 2021, 6:07 PM
jukivili closed T5510: libgcrypt: incorrect computation for secp192r1 as Resolved.
Jul 6 2021, 6:02 PM · libgcrypt, Bug Report

Jul 2 2021

jukivili committed rC3f4a59299134: tests/t-mpi-point: add one more NIST P-256 reduction test-vector (authored by jukivili).
tests/t-mpi-point: add one more NIST P-256 reduction test-vector
Jul 2 2021, 12:49 AM
jukivili added a comment to T5510: libgcrypt: incorrect computation for secp192r1.

Got a new bug with regression range ccfa9f2c1427b40483984198c3df41f8057f69f8:6dfab8cfb94ccb485a15b13df3c499cbb06fddf2

curve=23 secp256r1
point=04555555ffffffffffffffffffffffffffffffffffffffffffffffffffffffffff73a865e2e128733884fb82ce625ade822f7d8a59a4dcc09266966cf1bf082856
bignum=2020ff2020202020202020202020202020202020202020202020202020202020
nettle: 0 045549408909dd3e772d7d669f8fba2248d334b54be3d18833223d944a328948c76198ac3b29712256dcd9ce1a09471f04267684e1edd45910d61d0b7847db2d58
gcrypt: 0 047a6ec0df23082c8ce54c2b536d76b30464f4e1e690bb77665d298f05f0bee6806e7db3377141cc71ee30dcb8ffb7240bc3ecf29132ab5eb4ae03c067cea0d561
Jul 2 2021, 12:43 AM · libgcrypt, Bug Report

Jul 1 2021

jukivili committed rC9911069388e7: bench-slope: add X25519 and X448 scalar multiplication (authored by jukivili).
bench-slope: add X25519 and X448 scalar multiplication
Jul 1 2021, 5:38 PM
jukivili committed rC2fcac487069f: mpi: optimizations for MPI scanning and printing (authored by jukivili).
mpi: optimizations for MPI scanning and printing
Jul 1 2021, 5:38 PM
jukivili committed rCef676b9c14da: mpi/ec: cache converted field_table MPIs (authored by jukivili).
mpi/ec: cache converted field_table MPIs
Jul 1 2021, 5:38 PM
jukivili committed rC38d80fdfddd0: mpi_ec_get_affine: fast path for Z==1 case (authored by jukivili).
mpi_ec_get_affine: fast path for Z==1 case
Jul 1 2021, 5:38 PM
jukivili committed rC165237776389: tests/t-mpi-point: add reduction test-vectors for secp256k1 (authored by jukivili).
tests/t-mpi-point: add reduction test-vectors for secp256k1
Jul 1 2021, 5:38 PM

Jun 30 2021

jukivili committed rCfc92c609dfdb: ec-nist: fix 'mod p' carry adjustment and output masking (authored by jukivili).
ec-nist: fix 'mod p' carry adjustment and output masking
Jun 30 2021, 5:58 PM
jukivili added a comment to T5510: libgcrypt: incorrect computation for secp192r1.

Thanks a lot.

Jun 30 2021, 4:54 PM · libgcrypt, Bug Report

Jun 28 2021

jukivili added a comment to T5510: libgcrypt: incorrect computation for secp192r1.

P192, P224, P256 and P384 are affected.

Jun 28 2021, 10:03 PM · libgcrypt, Bug Report
jukivili added a comment to T5510: libgcrypt: incorrect computation for secp192r1.

Attached patch should fix the issue:

Jun 28 2021, 8:03 PM · libgcrypt, Bug Report
jukivili added a comment to T5510: libgcrypt: incorrect computation for secp192r1.

Thanks for reporting. There is two commits in that commit range, including https://dev.gnupg.org/rC9d909cb67e70fd792926ac1e2ab305b2cc96bc27 which adds fast reduction for NIST curves. So obviously something is wrong there. Is secp192r1 only curve that is giving wrong results?

Jun 28 2021, 5:34 PM · libgcrypt, Bug Report

Jun 24 2021

jukivili committed rC6dfab8cfb94c: mpi/ec: add fast reduction for secp256k1 (authored by jukivili).
mpi/ec: add fast reduction for secp256k1
Jun 24 2021, 8:49 PM
jukivili committed rC9d909cb67e70: mpi/ec: add fast reduction functions for NIST curves (authored by jukivili).
mpi/ec: add fast reduction functions for NIST curves
Jun 24 2021, 8:49 PM

Jun 19 2021

jukivili committed rC9c12226c31d4: mpi/ec: small optimization for ec_mulm_25519 (authored by jukivili).
mpi/ec: small optimization for ec_mulm_25519
Jun 19 2021, 3:33 PM
jukivili committed rC9722da5bfc4a: mpi/longlong.h: fix missing macro parameter parentheses (authored by jukivili).
mpi/longlong.h: fix missing macro parameter parentheses
Jun 19 2021, 3:33 PM
jukivili committed rCccfa9f2c1427: mpi/ec: small optimization for ec_mulm_448 (authored by jukivili).
mpi/ec: small optimization for ec_mulm_448
Jun 19 2021, 3:33 PM
jukivili committed rCa0871a1e817f: tests/t-mpi-point: add NIST curve multiplication test vectors (authored by jukivili).
tests/t-mpi-point: add NIST curve multiplication test vectors
Jun 19 2021, 3:33 PM
jukivili committed rC57cf83834bc0: tests/bench-slope: add ECC benchmarking (authored by jukivili).
tests/bench-slope: add ECC benchmarking
Jun 19 2021, 3:33 PM
jukivili committed rCb53abf7905e0: tests/benchmark: add benchmark for Ed448 (authored by jukivili).
tests/benchmark: add benchmark for Ed448
Jun 19 2021, 3:33 PM

Jun 3 2021

jukivili committed rCec7db47e9998: Set vZZ.16b register to zero before use in armv8 gcm implementation (authored by larma).
Set vZZ.16b register to zero before use in armv8 gcm implementation
Jun 3 2021, 7:08 PM
jukivili committed rC761a1a0d30ea: Fix wrong code execution in Poly1305 ARM/NEON implementation (authored by jukivili).
Fix wrong code execution in Poly1305 ARM/NEON implementation
Jun 3 2021, 7:08 PM

May 17 2021

jukivili committed rC14bb6d4ea0dc: cipher: Fix memory leaks for EdDSA. (authored by Tianjia Zhang <tianjia.zhang@linux.alibaba.com>).
cipher: Fix memory leaks for EdDSA.
May 17 2021, 9:01 PM
jukivili committed rCa1f5d87ed49b: Always include <config.h> in cipher assembly codes (authored by H.J. Lu <hjl.tools@gmail.com>).
Always include <config.h> in cipher assembly codes
May 17 2021, 9:01 PM

Apr 28 2021

jukivili committed rCec87511d9cd2: hwf-x86: fix use of wrong operand type (authored by jukivili).
hwf-x86: fix use of wrong operand type
Apr 28 2021, 8:52 PM

Apr 26 2021

jukivili committed rCeb96baf28473: hash_buffers: add output length param for XOF support (authored by jukivili).
hash_buffers: add output length param for XOF support
Apr 26 2021, 9:47 PM
jukivili committed rCe866c01e645d: keccak: add hash_buffers functions for SHAKE128 & SHAKE256 (authored by jukivili).
keccak: add hash_buffers functions for SHAKE128 & SHAKE256
Apr 26 2021, 9:47 PM
jukivili committed rC580ae61db5fe: md: remove hash_buffer function from algorithms (authored by jukivili).
md: remove hash_buffer function from algorithms
Apr 26 2021, 9:47 PM
jukivili committed rCf53d541d0947: Add XOF output support for internal _gcry_md_hash_buffers (authored by jukivili).
Add XOF output support for internal _gcry_md_hash_buffers
Apr 26 2021, 9:47 PM
jukivili committed rC4770ad72607f: Use memset for constant length wipememory2 (authored by jukivili).
Use memset for constant length wipememory2
Apr 26 2021, 9:47 PM
jukivili closed T5255: libgcrypt: build "error: invalid operand for instruction" when compiling with Clang & LTO as Resolved.
Apr 26 2021, 5:43 PM · asm, libgcrypt, clang, Bug Report

Apr 12 2021

jukivili committed rC9bc3d8de6e2a: mpi: harden add_n_cond, sub_n_cond and abs_cond against EM leakage (authored by jukivili).
mpi: harden add_n_cond, sub_n_cond and abs_cond against EM leakage
Apr 12 2021, 7:40 PM
jukivili committed rCc7c25b6e6e6b: mpi: harden set_cond functions against EM leakage (authored by jukivili).
mpi: harden set_cond functions against EM leakage
Apr 12 2021, 7:40 PM
jukivili committed rC1266f5bb02b7: mpi: harden swap_cond functions against EM leakage (authored by jukivili).
mpi: harden swap_cond functions against EM leakage
Apr 12 2021, 7:40 PM