Page MenuHome GnuPG
Feed Advanced Search

Oct 6 2023

gniibe committed rGd17efdcd6f75: tests:tpm2dtests: Fix tests with TPM2D. (authored by gniibe).
tests:tpm2dtests: Fix tests with TPM2D.
Oct 6 2023, 3:14 AM
gniibe committed rG19caa5c267a5: agent: Initialize FP for the case of error return. (authored by gniibe).
agent: Initialize FP for the case of error return.
Oct 6 2023, 3:14 AM
gniibe committed rG9909f622f69e: agent: fix tpm2d keytotpm handling (authored by gniibe).
agent: fix tpm2d keytotpm handling
Oct 6 2023, 3:14 AM
gniibe added a comment to T6052: gnupg2 tpm2d tests do not work.

Applied to 2.4, too.

Oct 6 2023, 3:14 AM · gnupg24 (gnupg-2.4.4), Tests, TPM, Bug Report
gniibe committed rAa8c38df6e461: doc: Minor style fixes. (authored by gniibe).
doc: Minor style fixes.
Oct 6 2023, 3:03 AM
gniibe committed rCec27ff6666be: sexp: String with \0 is considered "binary". (authored by gniibe).
sexp: String with \0 is considered "binary".
Oct 6 2023, 2:34 AM
gniibe committed rC5e5dff0551fc: sexp: Minor clean-up of sexp output handling. (authored by gniibe).
sexp: Minor clean-up of sexp output handling.
Oct 6 2023, 2:29 AM

Oct 5 2023

gniibe committed rCedddc5738e6b: doc: Minor style fixes. (authored by gniibe).
doc: Minor style fixes.
Oct 5 2023, 9:36 AM
gniibe committed rCddd41eb6ace0: sexp: String with \0 is considered "binary". (authored by gniibe).
sexp: String with \0 is considered "binary".
Oct 5 2023, 9:36 AM
gniibe changed the status of T6747: sexp string including \0 from Open to Testing.
Oct 5 2023, 8:38 AM · libgcrypt, Bug Report
gniibe claimed T6747: sexp string including \0.
Oct 5 2023, 8:30 AM · libgcrypt, Bug Report
gniibe created T6747: sexp string including \0.
Oct 5 2023, 8:30 AM · libgcrypt, Bug Report
gniibe committed rE53d9d77a496f: doc: Minor style fix. (authored by gniibe).
doc: Minor style fix.
Oct 5 2023, 7:41 AM
gniibe claimed T6637: PQC for Libgcrypt.

I'll create a branch for this work. Then, I'll incorporate changes to master.

Oct 5 2023, 7:15 AM · PQC, libgcrypt
gniibe triaged T6746: yat2man: Support -- and --- as Wishlist priority.
Oct 5 2023, 7:03 AM · gpgrt
gniibe committed rG16b6b7753229: Minor style fixes. (authored by gniibe).
Minor style fixes.
Oct 5 2023, 7:01 AM
gniibe changed the status of T6052: gnupg2 tpm2d tests do not work from Open to Testing.

OK. I pushed: rG227b3b14f4be: tests:tpm2dtests: Modify tests with SWTPM and relax the condition.
... which doesn't require swtpm_ioctl and tssstartup any more.

Oct 5 2023, 3:28 AM · gnupg24 (gnupg-2.4.4), Tests, TPM, Bug Report
gniibe committed rG227b3b14f4be: tests:tpm2dtests: Modify tests with SWTPM and relax the condition. (authored by gniibe).
tests:tpm2dtests: Modify tests with SWTPM and relax the condition.
Oct 5 2023, 3:26 AM

Oct 4 2023

gniibe added a comment to T6052: gnupg2 tpm2d tests do not work.

I pushed rG321f9c0a3f28: tests:tpm2dtests: Fix tests with TPM2D. and rG98dd6f7af6aa: tests:tpm2dtests: Fix tests with SWTPM. (and other small changes).
Now, it works with two cases:

  • tpm_server
  • swtpm, swtpm_ioctl, and tssstartup
Oct 4 2023, 11:38 AM · gnupg24 (gnupg-2.4.4), Tests, TPM, Bug Report
gniibe committed rG98dd6f7af6aa: tests:tpm2dtests: Fix tests with SWTPM. (authored by gniibe).
tests:tpm2dtests: Fix tests with SWTPM.
Oct 4 2023, 11:33 AM
gniibe committed rG68b7aff9ce34: agent: Fix agent_update_private_key. (authored by gniibe).
agent: Fix agent_update_private_key.
Oct 4 2023, 3:27 AM
gniibe committed rG08e529fa7cfa: agent: Fix agent_update_private_key. (authored by gniibe).
agent: Fix agent_update_private_key.
Oct 4 2023, 3:27 AM

Oct 3 2023

gniibe committed rGf2ca727978da: build: Simplify detecting a TPM emulator. (authored by gniibe).
build: Simplify detecting a TPM emulator.
Oct 3 2023, 9:59 AM
gniibe committed rG25c84ffd1078: tools: Add TPM2DAEMON_SOCK_NAME for --remove-socketdir. (authored by gniibe).
tools: Add TPM2DAEMON_SOCK_NAME for --remove-socketdir.
Oct 3 2023, 9:59 AM
gniibe committed rG321f9c0a3f28: tests:tpm2dtests: Fix tests with TPM2D. (authored by gniibe).
tests:tpm2dtests: Fix tests with TPM2D.
Oct 3 2023, 4:57 AM
gniibe committed rG4206d89003d1: tests:gpgscm: Fix process select loop. (authored by gniibe).
tests:gpgscm: Fix process select loop.
Oct 3 2023, 4:57 AM

Oct 2 2023

gniibe committed rG78afc209ccb7: tpm2d: Fix call to assuan_control. (authored by gniibe).
tpm2d: Fix call to assuan_control.
Oct 2 2023, 3:44 AM

Sep 29 2023

gniibe committed rM8ad22290df34: gpgme-tool: Support use of Windows HANDLE for INPUT/OUTPUT/MESSAGE. (authored by gniibe).
gpgme-tool: Support use of Windows HANDLE for INPUT/OUTPUT/MESSAGE.
Sep 29 2023, 4:42 AM

Sep 28 2023

gniibe committed rG1da40db03eba: tpm2d: Check SWTPM environment variable for swtpm support. (authored by gniibe).
tpm2d: Check SWTPM environment variable for swtpm support.
Sep 28 2023, 6:27 AM
gniibe committed rGeda3997b439e: agent: fix tpm2d keytotpm handling (authored by gniibe).
agent: fix tpm2d keytotpm handling
Sep 28 2023, 6:12 AM
gniibe committed rSac3890137329: Add DCO entry of Jernej Jakob. (authored by gniibe).
Add DCO entry of Jernej Jakob.
Sep 28 2023, 5:49 AM
gniibe committed rS0176a51095a8: Add support -f --disable-tests. (authored by gniibe).
Add support -f --disable-tests.
Sep 28 2023, 5:49 AM

Sep 27 2023

gniibe committed rE0fc740ffca84: estream: String filter should NOT be called with non-nul string. (authored by gniibe).
estream: String filter should NOT be called with non-nul string.
Sep 27 2023, 5:15 AM
gniibe committed rGa8618fdccdab: agent: Initialize FP for the case of error return. (authored by gniibe).
agent: Initialize FP for the case of error return.
Sep 27 2023, 4:04 AM
gniibe committed rG459bd577fc5f: agent,common,gpg: Use unsigned int for 1-bit field. (authored by gniibe).
agent,common,gpg: Use unsigned int for 1-bit field.
Sep 27 2023, 4:04 AM
gniibe committed rG26939ea2227b: Use gpgrt_b64* API of libgpg-error. (authored by gniibe).
Use gpgrt_b64* API of libgpg-error.
Sep 27 2023, 4:04 AM
gniibe updated the task description for T6737: libgpg-error: String filter should *NOT* be called with non-nul-terminated string.
Sep 27 2023, 3:55 AM · gpgrt, Bug Report
gniibe claimed T6737: libgpg-error: String filter should *NOT* be called with non-nul-terminated string.
Sep 27 2023, 3:54 AM · gpgrt, Bug Report
gniibe created T6737: libgpg-error: String filter should *NOT* be called with non-nul-terminated string.
Sep 27 2023, 3:54 AM · gpgrt, Bug Report

Sep 26 2023

gniibe triaged T6734: gnupg: Use gpgrt_b64* API as Wishlist priority.
Sep 26 2023, 6:25 AM · gnupg26
gniibe committed rG8e3d4f5b63c1: gpg: Keep the integrity of the code for KEYINFO command. (authored by gniibe).
gpg: Keep the integrity of the code for KEYINFO command.
Sep 26 2023, 3:11 AM

Sep 25 2023

gniibe added a comment to T3456: GPG does not import secret subkeys from --export-secret-subkeys output if subkey stubs existed before.

In 2.2, KEYINFO output doesn't support A-flag for the information if card is online or not.
We need to clean up this discrepancy.

Sep 25 2023, 8:23 AM · gnupg22 (gnupg-2.2.42), Restricted Project
gniibe added a comment to T3456: GPG does not import secret subkeys from --export-secret-subkeys output if subkey stubs existed before.

I pushed rGff42ed0d69bb: gpg: Enhance agent_probe_secret_key to return bigger value. to fix this issue.

Sep 25 2023, 8:12 AM · gnupg22 (gnupg-2.2.42), Restricted Project
gniibe committed rGff42ed0d69bb: gpg: Enhance agent_probe_secret_key to return bigger value. (authored by gniibe).
gpg: Enhance agent_probe_secret_key to return bigger value.
Sep 25 2023, 6:40 AM

Sep 6 2023

gniibe added a comment to T3456: GPG does not import secret subkeys from --export-secret-subkeys output if subkey stubs existed before.

Backported to 2.2 branch.

Sep 6 2023, 3:10 AM · gnupg22 (gnupg-2.2.42), Restricted Project
gniibe committed rG07cb3c65e8be: dirmngr: Enable the call of ks_ldap_help_variables when USE_LDAP. (authored by gniibe).
dirmngr: Enable the call of ks_ldap_help_variables when USE_LDAP.
Sep 6 2023, 3:06 AM
gniibe committed rG292caef663b1: build: Fix detection of sigdescr_np for newer glibc. (authored by gniibe).
build: Fix detection of sigdescr_np for newer glibc.
Sep 6 2023, 3:06 AM
gniibe committed rG8a1e123a36e0: gpg: Fix for overridden key import. (authored by gniibe).
gpg: Fix for overridden key import.
Sep 6 2023, 3:06 AM
gniibe committed rG383d524239e3: gpg: Allow overridden key import when stub exists. (authored by gniibe).
gpg: Allow overridden key import when stub exists.
Sep 6 2023, 3:06 AM
gniibe committed rG481782551131: gpg: Prepare enhancement of agent_probe_secret_key. (authored by gniibe).
gpg: Prepare enhancement of agent_probe_secret_key.
Sep 6 2023, 3:06 AM

Sep 4 2023

gniibe committed rGd90f1e5fa4d1: agent: Fix timer round-up check when inserting an entry into cache. (authored by gniibe).
agent: Fix timer round-up check when inserting an entry into cache.
Sep 4 2023, 5:04 AM
gniibe committed rG28364affa64e: agent: Fix sock_inotify_fd handling. (authored by gniibe).
agent: Fix sock_inotify_fd handling.
Sep 4 2023, 5:04 AM

Sep 1 2023

gniibe committed rE19d7ec4bfeda: Fix the previous commit. (authored by gniibe).
Fix the previous commit.
Sep 1 2023, 8:32 AM
gniibe committed rE071effebcf7d: build: Change the default for --with-libtool-modification. (authored by gniibe).
build: Change the default for --with-libtool-modification.
Sep 1 2023, 8:32 AM
gniibe committed rA76816b1350c0: build: Change the default for --with-libtool-modification. (authored by gniibe).
build: Change the default for --with-libtool-modification.
Sep 1 2023, 8:15 AM
gniibe committed rT549fa4258421: build: Change the default for --with-libtool-modification. (authored by gniibe).
build: Change the default for --with-libtool-modification.
Sep 1 2023, 7:50 AM
gniibe committed rK2c4551c0c405: build: Change the default for --with-libtool-modification. (authored by gniibe).
build: Change the default for --with-libtool-modification.
Sep 1 2023, 7:48 AM
gniibe committed rPTHe6b90ae73222: build: Change the default for --with-libtool-modification. (authored by gniibe).
build: Change the default for --with-libtool-modification.
Sep 1 2023, 7:47 AM
gniibe committed rS206530271666: build: Change the default for --with-libtool-modification. (authored by gniibe).
build: Change the default for --with-libtool-modification.
Sep 1 2023, 7:46 AM
gniibe committed rC36d014f919d1: build: Change the default for --with-libtool-modification. (authored by gniibe).
build: Change the default for --with-libtool-modification.
Sep 1 2023, 7:18 AM
gniibe changed the status of T6681: agent: Clean up main loop and better cache handling of expiration (was: Adding agent_timer API for monitoring something and passphrase cache) from Open to Testing.
Sep 1 2023, 7:13 AM · keyboxd, gpgagent, gnupg26
gniibe committed rMb80d52a1f74a: build: Change the default for --with-libtool-modification. (authored by gniibe).
build: Change the default for --with-libtool-modification.
Sep 1 2023, 7:07 AM
gniibe renamed T6681: agent: Clean up main loop and better cache handling of expiration (was: Adding agent_timer API for monitoring something and passphrase cache) from agent: Adding agent_timer API for monitoring something and passphrase cache to agent: Clean up main loop and better cache handling of expiration (was: Adding agent_timer API for monitoring something and passphrase cache).
Sep 1 2023, 4:57 AM · keyboxd, gpgagent, gnupg26
gniibe committed rG5e47d5edd8f8: agent: Fix timer list management. (authored by gniibe).
agent: Fix timer list management.
Sep 1 2023, 4:34 AM
gniibe committed rG57125d3f5a3f: agent: Fix the previous commit. (authored by gniibe).
agent: Fix the previous commit.
Sep 1 2023, 4:02 AM

Aug 31 2023

gniibe added a comment to T6681: agent: Clean up main loop and better cache handling of expiration (was: Adding agent_timer API for monitoring something and passphrase cache).

Firstly, I clean up the code with each individual thread for monitoring something; That's T6692 and T6693.
Then, I pushed rG76a2f180286e: agent: Better interaction between main loop and cache expiration. and rG92de0387f04b: agent: Introduce management of timer to expire cache entries.
No more use of tick, but timers.

Aug 31 2023, 8:08 AM · keyboxd, gpgagent, gnupg26
gniibe committed rG92de0387f04b: agent: Introduce management of timer to expire cache entries. (authored by gniibe).
agent: Introduce management of timer to expire cache entries.
Aug 31 2023, 8:03 AM
gniibe added a comment to T6674: doc: U+2010 HYPHEN vs. U+002D HYPHEN-MINUS for man pages.

Other problems of yat2m transformation:
https://bugs.debian.org/1050886

Aug 31 2023, 1:49 AM · gpgrt

Aug 30 2023

gniibe committed rG76a2f180286e: agent: Better interaction between main loop and cache expiration. (authored by gniibe).
agent: Better interaction between main loop and cache expiration.
Aug 30 2023, 8:46 AM
gniibe updated the task description for T6693: agent: Have a thread monitoring parent PID and homedir.
Aug 30 2023, 7:18 AM · keyboxd, gpgagent, gnupg26
gniibe changed the status of T6682: agent: agent_kick_the_loop function to unblock the select(2), a subtask of T6681: agent: Clean up main loop and better cache handling of expiration (was: Adding agent_timer API for monitoring something and passphrase cache), from Open to Testing.
Aug 30 2023, 7:17 AM · keyboxd, gpgagent, gnupg26
gniibe changed the status of T6682: agent: agent_kick_the_loop function to unblock the select(2), a subtask of T6692: agent: Clean up check_own_socket to monitor socket takeover, from Open to Testing.
Aug 30 2023, 7:17 AM · keyboxd, gnupg26, gpgagent
gniibe changed the status of T6682: agent: agent_kick_the_loop function to unblock the select(2) from Open to Testing.

It's pushed by rG716e59b0b628: agent: Add agent_kick_the_loop function.

Aug 30 2023, 7:17 AM · keyboxd, gpgagent, gnupg26
gniibe changed the status of T6682: agent: agent_kick_the_loop function to unblock the select(2), a subtask of T6693: agent: Have a thread monitoring parent PID and homedir, from Open to Testing.
Aug 30 2023, 7:17 AM · keyboxd, gpgagent, gnupg26
gniibe changed the status of T6693: agent: Have a thread monitoring parent PID and homedir, a subtask of T6681: agent: Clean up main loop and better cache handling of expiration (was: Adding agent_timer API for monitoring something and passphrase cache), from Open to Testing.
Aug 30 2023, 7:17 AM · keyboxd, gpgagent, gnupg26
gniibe changed the status of T6693: agent: Have a thread monitoring parent PID and homedir from Open to Testing.
Aug 30 2023, 7:17 AM · keyboxd, gpgagent, gnupg26
gniibe added a comment to T6693: agent: Have a thread monitoring parent PID and homedir.

Pushed the change by rG7025375e8bec: agent: Have a thread monitoring parent PID and homedir.
It depends on T6682 to wake up the loop.

Aug 30 2023, 7:16 AM · keyboxd, gpgagent, gnupg26
gniibe committed rG7025375e8bec: agent: Have a thread monitoring parent PID and homedir. (authored by gniibe).
agent: Have a thread monitoring parent PID and homedir.
Aug 30 2023, 7:14 AM
gniibe added a parent task for T6682: agent: agent_kick_the_loop function to unblock the select(2): T6693: agent: Have a thread monitoring parent PID and homedir.
Aug 30 2023, 7:07 AM · keyboxd, gpgagent, gnupg26
gniibe added a subtask for T6693: agent: Have a thread monitoring parent PID and homedir: T6682: agent: agent_kick_the_loop function to unblock the select(2).
Aug 30 2023, 7:07 AM · keyboxd, gpgagent, gnupg26
gniibe triaged T6693: agent: Have a thread monitoring parent PID and homedir as Wishlist priority.
Aug 30 2023, 7:07 AM · keyboxd, gpgagent, gnupg26
gniibe added a subtask for T6692: agent: Clean up check_own_socket to monitor socket takeover: T6682: agent: agent_kick_the_loop function to unblock the select(2).
Aug 30 2023, 6:58 AM · keyboxd, gnupg26, gpgagent
gniibe added a parent task for T6682: agent: agent_kick_the_loop function to unblock the select(2): T6692: agent: Clean up check_own_socket to monitor socket takeover.
Aug 30 2023, 6:58 AM · keyboxd, gpgagent, gnupg26
gniibe committed rG76896e2339a4: agent: Recover support CHECK_OWN_SOCKET_INTERVAL == 0. (authored by gniibe).
agent: Recover support CHECK_OWN_SOCKET_INTERVAL == 0.
Aug 30 2023, 6:24 AM
gniibe committed rGb2826924eeca: agent: Fix the handling of socket takeover. (authored by gniibe).
agent: Fix the handling of socket takeover.
Aug 30 2023, 4:28 AM
gniibe committed rG95186ae92f92: agent: Use a thread to monitor socket takeover. (authored by gniibe).
agent: Use a thread to monitor socket takeover.
Aug 30 2023, 4:03 AM
gniibe changed the status of T6692: agent: Clean up check_own_socket to monitor socket takeover, a subtask of T6681: agent: Clean up main loop and better cache handling of expiration (was: Adding agent_timer API for monitoring something and passphrase cache), from Open to Testing.
Aug 30 2023, 4:02 AM · keyboxd, gpgagent, gnupg26
gniibe changed the status of T6692: agent: Clean up check_own_socket to monitor socket takeover from Open to Testing.

Push the code by rG95186ae92f92: agent: Use a thread to monitor socket takeover.

Aug 30 2023, 4:02 AM · keyboxd, gnupg26, gpgagent
gniibe triaged T6692: agent: Clean up check_own_socket to monitor socket takeover as Wishlist priority.
Aug 30 2023, 3:56 AM · keyboxd, gnupg26, gpgagent

Aug 28 2023

gniibe added a comment to T6681: agent: Clean up main loop and better cache handling of expiration (was: Adding agent_timer API for monitoring something and passphrase cache).

I concluded that it's just simpler not to do so. Since expected use cases are only for passphrase cache expiration and some monitoring something, it would be overkill.

Aug 28 2023, 4:41 AM · keyboxd, gpgagent, gnupg26

Aug 24 2023

gniibe committed rG716e59b0b628: agent: Add agent_kick_the_loop function. (authored by gniibe).
agent: Add agent_kick_the_loop function.
Aug 24 2023, 9:53 AM
gniibe added a comment to T6682: agent: agent_kick_the_loop function to unblock the select(2).

I confirmed that the pselect EINTR problem of Linux (at least for x86) has not yet been fixed: https://lkml.org/lkml/2018/3/21/909

Aug 24 2023, 8:08 AM · keyboxd, gpgagent, gnupg26
gniibe triaged T6682: agent: agent_kick_the_loop function to unblock the select(2) as Wishlist priority.
Aug 24 2023, 4:43 AM · keyboxd, gpgagent, gnupg26
gniibe triaged T6681: agent: Clean up main loop and better cache handling of expiration (was: Adding agent_timer API for monitoring something and passphrase cache) as Wishlist priority.
Aug 24 2023, 4:37 AM · keyboxd, gpgagent, gnupg26

Aug 22 2023

gniibe added a comment to T6674: doc: U+2010 HYPHEN vs. U+002D HYPHEN-MINUS for man pages.

I found a troff reference: https://www.quut.com/berlin/ms/troff.html

Aug 22 2023, 8:36 AM · gpgrt
gniibe triaged T6675: doc: Man page for keyboxd as Wishlist priority.
Aug 22 2023, 6:40 AM · gnupg, Documentation
gniibe added a comment to T6674: doc: U+2010 HYPHEN vs. U+002D HYPHEN-MINUS for man pages.

Ideally, we should change the source document to use @minus{} for a minus sign, and keep - only when it means a hyphen. But we cannot do that blindly; We need to handle it with care, in a way of case by case (Texinfo manual suggests no use of @minus{} with @code or @example, but it is needed for groff man pages in many cases).... We would need to consider each occurrence of - in our document. That's too much (if it were me to fix).

Aug 22 2023, 3:49 AM · gpgrt
gniibe triaged T6674: doc: U+2010 HYPHEN vs. U+002D HYPHEN-MINUS for man pages as Wishlist priority.
Aug 22 2023, 3:32 AM · gpgrt

Aug 21 2023

gniibe added a comment to T6641: pinentry-tty & pinentry-curses breaks tty when timeout occurs or CTRL-C is pressed.

Using Ubuntu, it's GnuPG 2.2 (which doesn't have the fix of T4585). Without the fix, killing gpg (by CTRL-C) causes problematic situation where pinentry remains asking.
That's because gpg-agent and pinentry don't know the frontend side has been killed. T4585 introduced a watching thread into gpg-agent, so that it can correctly detect lost of frontend.

Aug 21 2023, 3:13 AM · gnupg, pinentry

Aug 18 2023

gniibe committed rPa6f63fe37dbf: tty,curses: Upon SIGINT, let pinentry exit gracefully. (authored by gniibe).
tty,curses: Upon SIGINT, let pinentry exit gracefully.
Aug 18 2023, 8:41 AM