Thanks. A few hours too late for 1.9.2.
- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
Advanced Search
Feb 17 2021
Backport was done with commit rC1d312bc65846 (for unknown reasons it did not show up in the list of bugs related to this bug; I added it by hand). Fix will go into 1.8.8.
The mix up of external patches and commits makes it not easy to see what has been fixed. AFAICS rC3d095206c30d fixes the last bug mentioned by @ballapete on Jan 26.
Feb 14 2021
Backward compatibility fixed using the MacPorts legacysupport PortGroup:
https://github.com/macports/macports-ports/commit/74b50424649a7c657521140fcd7f92ba79a3cec5
Feb 13 2021
This approach is too simplistic. See Ryan Schmidt's and Joshua Root's comments in https://trac.macports.org/ticket/62278
Feb 12 2021
Feb 9 2021
We need more information on the why and when of this change. We don't want to maintain different versions of the same algorithm. The I-D expired more than 6 years ago and thus it should not be used as a reference.
Feb 6 2021
Problem with clang and these files was resolved by replacement of assembler macros with C preprocessor macros.
Feb 5 2021
Looks like this has been addressed in af23ab5c5482d625ff52e60606cf044e2b0106c8. A quick test building the current version in master with --disable-asm worked for me.
https://tools.ietf.org/html/draft-shen-sm2-ecdsa-02
Section 5.1.4.4
Feb 3 2021
Feb 2 2021
So, the change against libgcrypt 1.9.1 will be:
I got hit of search by "$ld$weak$os10.11$_getentropy".
So, I guess that it's 10.11 which has _getentropy as weak symbol, and 10.12 or later has implementation.
There is some (partly) good news: The function getentropy() is available in the packet manager MacPorts. It has a legacy support:
Feb 1 2021
Unfortunately, building without "--disable-asm" does not work if building a universal package under MacPorts (e.g. 32bit and 64bit x86 or 64bit x86 and arm64).
In T5268#142714, @gniibe wrote:To do that, I'd like to know, when the symbol getentropy was added.
I think that a backport to 1.8. also makes sense
Here is a patch adding those checks:
diff --git a/cipher/ecc-ecdsa.c b/cipher/ecc-ecdsa.c index d540578e..30103f14 100644 --- a/cipher/ecc-ecdsa.c +++ b/cipher/ecc-ecdsa.c @@ -172,6 +172,9 @@ _gcry_ecc_ecdsa_verify (gcry_mpi_t input, mpi_ec_t ec, mpi_point_struct Q, Q1, Q2; unsigned int nbits;
no, that doesn't change anything.
In T5268#142612, @ballapete wrote:Wouldn't it be better to move these failures as a single one into the configure script that it definitely can tell "This Mac has getentropy()"?
Jan 31 2021
Does it build if configure with parameter 'ac_cv_sys_symbol_underscore=yes'? <path-to-libgcrypt-source>/configure ac_cv_sys_symbol_underscore=yes --host=aarch64-apple-darwin ...
Jan 30 2021
Compiling now works, but I get the following linker errors:
@jukivili Thanks for the reply! We've reverted that commit downstream in Gentoo as a temporary workaround, as due to some complications, our release systems needed to build without asm (for now) to ensure portability. Rest assured, this is not the default, and is discouraged for regular users.
Jan 29 2021
Latext 1.9.1 builds without any unreported workarounds. Done. Close.
Building without "--disable-asm" works without any issues.
Thanks for your report.
FYI, this is not just an MacOS issue. We see that also on Gentoo Linux:
Wouldn't it be better to move these failures as a single one into the configure script that it definitely can tell "This Mac has getentropy()"?
Fix has been released. Keeping this in testing state for easier visibility of this task.
I applied the two patches on Mac OS X 10.5.8, Leopard, to random/rndlinux.c, resulting in this unified diff:
Release done.
I linked all related tasks for the release of 1.9.1, so that making release notes can be easier and recording information here.