Page MenuHome GnuPG
Feed All Stories

Jun 4 2021

dkg added a comment to T5464: Failure to import Curve25519 ECDH secret subkey to the GnupG..

Do we want to encourage multiple cleartext wire-format representations of the same secret key?

Jun 4 2021, 3:56 PM · Support, gnupg, OpenPGP
aheinecke triaged T5473: Libkleo build for Windows broken as High priority.
Jun 4 2021, 2:33 PM · kleopatra, Restricted Project
aheinecke created P13 (An Untitled Masterwork).
Jun 4 2021, 1:12 PM
jarregui created T5472: Kleopatra not storing decrypted files.
Jun 4 2021, 12:52 PM · Support, kleopatra, Bug Report
werner added a comment to T5442: Serial number detection of Yubikey 5 (Yubikey 5 doesn't work after updating to GnuPG 2.3.1).

I need to see how we can pass the check permission notice up to gpg. This is a too common problem and thus serves some special treatment.

Jun 4 2021, 12:22 PM · gnupg (gpg23), yubikey
Suertzz added a comment to T5442: Serial number detection of Yubikey 5 (Yubikey 5 doesn't work after updating to GnuPG 2.3.1).

GPG Version :

Jun 4 2021, 11:58 AM · gnupg (gpg23), yubikey
Alexander Lohnau <alexander.lohnau@gmx.de> committed rKLEOPATRAe12eb5d0a832: Install service menus in ${KDE_INSTALL_KSERVICES5DIR}/ServiceMenus (authored by Alexander Lohnau <alexander.lohnau@gmx.de>).
Install service menus in ${KDE_INSTALL_KSERVICES5DIR}/ServiceMenus
Jun 4 2021, 11:17 AM
onickolay added a comment to T5464: Failure to import Curve25519 ECDH secret subkey to the GnupG..

JFYI: Original curve25519-donna (as well as Botan library, and OpenSSL) tweaks bits inside of the exponentiation function, so secret keys with or without tweaked bits would be equivalent and produce the same public key.

Jun 4 2021, 10:57 AM · Support, gnupg, OpenPGP
ikloecker committed rLIBKLEO405b06ff36db: add Boost::headers to link libraries (authored by ikloecker).
add Boost::headers to link libraries
Jun 4 2021, 10:12 AM
aheinecke closed T5424: GnuPG w32: Expand environment variables when reading registry paths as Resolved.

Works. My initial tests also failed because on Windows 64 the registry value has to be placed in the WOW6432NODE

Jun 4 2021, 10:09 AM · gnupg (gpg22), Restricted Project
aheinecke changed the status of T5424: GnuPG w32: Expand environment variables when reading registry paths from Open to Testing.

Apologies,.. I used ctags on read_w32_registry_string and that jumped me to build-aux/speedo/w32/g4wihelp.c which has a read_w32_registry_string that does not expand....
Now I found the w32-reg.c in common which looks completely fine.

Jun 4 2021, 9:39 AM · gnupg (gpg22), Restricted Project
werner lowered the priority of T5328: On the (in)security of Elgamal in OpenPGP from High to Normal.
Jun 4 2021, 7:52 AM · side-channel, CVE, libgcrypt
werner changed the visibility for T5328: On the (in)security of Elgamal in OpenPGP.
Jun 4 2021, 7:52 AM · side-channel, CVE, libgcrypt
werner committed rG8bd5172539e1: dirmngr: Remove useless code. (authored by werner).
dirmngr: Remove useless code.
Jun 4 2021, 7:49 AM
werner added inline comments to rG2b4cddf9086f: dirmngr: Allow for non-URL specified ldap keyservers..
Jun 4 2021, 7:45 AM
werner added a comment to rGff17aee5d10c: dirmngr: New option --ldapserver.

Alright, we can keep just the colon delimited format for --ldapservers et al. Because we support ldap URLs in CrlDistributionPoints in X.509 certificates we need to handle them internally. But there is indeed no need to support them in the config files.

Jun 4 2021, 7:40 AM
werner added a comment to T5464: Failure to import Curve25519 ECDH secret subkey to the GnupG..

gniibe: Can you explain why an import shall modify the secret key? Form my understanding it is an invalid secret key and thus it can't be used. An import operation is different than the key generation.

Jun 4 2021, 7:33 AM · Support, gnupg, OpenPGP
gniibe added a comment to T5464: Failure to import Curve25519 ECDH secret subkey to the GnupG..

For an implementation of Curve25519 routine, it is needed to tweak those bits.

Jun 4 2021, 6:52 AM · Support, gnupg, OpenPGP
gniibe committed rG21ef425e222d: agent: Appropriate error code for importing key with no passwd. (authored by gniibe).
agent: Appropriate error code for importing key with no passwd.
Jun 4 2021, 6:49 AM
gniibe added a comment to T5464: Failure to import Curve25519 ECDH secret subkey to the GnupG..

Better to have in-line:

diff --git a/agent/cvt-openpgp.c b/agent/cvt-openpgp.c
index 53c88154b..b1d43227a 100644
--- a/agent/cvt-openpgp.c
+++ b/agent/cvt-openpgp.c
@@ -159,7 +159,21 @@ convert_secret_key (gcry_sexp_t *r_key, int pubkey_algo, gcry_mpi_t *skey,
                EdDSA flag.  */
             format = "(private-key(ecc(curve %s)(flags eddsa)(q%m)(d%m)))";
           else if (!strcmp (curve, "Curve25519"))
-            format = "(private-key(ecc(curve %s)(flags djb-tweak)(q%m)(d%m)))";
+            {
+              unsigned int nbits;
+              unsigned char *buffer = gcry_mpi_get_opaque (skey[1], &nbits);
+              unsigned char d[32];
+
+              if (nbits != 256)
+                return gpg_error (GPG_ERR_BAD_SECKEY);
+
+              memcpy (d, buffer, 32);
+              d[0] = (d[0] & 0x7f) | 0x40;
+              d[31] &= 0xf8;
+              gcry_mpi_release (skey[1]);
+              skey[1] = gcry_mpi_set_opaque_copy (NULL, d, 256);
+              format = "(private-key(ecc(curve %s)(flags djb-tweak)(q%m)(d%m)))";
+            }
           else
             format = "(private-key(ecc(curve %s)(q%m)(d%m)))";
Jun 4 2021, 6:00 AM · Support, gnupg, OpenPGP
gniibe added a comment to T5464: Failure to import Curve25519 ECDH secret subkey to the GnupG..

"Curve25519" in libgcrypt was implemented before the standardization of X25519. There are two problems here: endianess and tweaking-bits.

Jun 4 2021, 5:59 AM · Support, gnupg, OpenPGP
Suertzz added a comment to T5442: Serial number detection of Yubikey 5 (Yubikey 5 doesn't work after updating to GnuPG 2.3.1).

I see your situation

Could you please help me to analyze what's going on?
Please add following lines to your scdaemon.conf to see CCID driver's debug output:

debug-ccid-driver
verbose
verbose
verbose

And share the debug output.

Jun 4 2021, 2:08 AM · gnupg (gpg23), yubikey
gniibe added a comment to T5442: Serial number detection of Yubikey 5 (Yubikey 5 doesn't work after updating to GnuPG 2.3.1).

Ah, I think that your problem was fixed in rG53bdc6288f9b: scd: Recover the partial match for PORTSTR for PC/SC. (to be 2.3.2).

Jun 4 2021, 2:02 AM · gnupg (gpg23), yubikey
gniibe triaged T5442: Serial number detection of Yubikey 5 (Yubikey 5 doesn't work after updating to GnuPG 2.3.1) as High priority.
Jun 4 2021, 1:58 AM · gnupg (gpg23), yubikey
gniibe claimed T5442: Serial number detection of Yubikey 5 (Yubikey 5 doesn't work after updating to GnuPG 2.3.1).
Jun 4 2021, 1:57 AM · gnupg (gpg23), yubikey
gniibe reopened T5442: Serial number detection of Yubikey 5 (Yubikey 5 doesn't work after updating to GnuPG 2.3.1) as "Open".

I see your situation

Jun 4 2021, 1:57 AM · gnupg (gpg23), yubikey
Suertzz added a comment to T5442: Serial number detection of Yubikey 5 (Yubikey 5 doesn't work after updating to GnuPG 2.3.1).

If possible, please let us know how you configure the permission to access CCID device with 2.2 (and with 2.3)?

Jun 4 2021, 1:40 AM · gnupg (gpg23), yubikey
gniibe added a comment to T5442: Serial number detection of Yubikey 5 (Yubikey 5 doesn't work after updating to GnuPG 2.3.1).

If possible, please let us know how you configure the permission to access CCID device with 2.2 (and with 2.3)?

Jun 4 2021, 1:32 AM · gnupg (gpg23), yubikey

Jun 3 2021

Suertzz added a comment to T5415: YubiKey no longer recognized in GnuPG 2.3.1 on macOS 10.15.7.

Please excuse my late reply. I was busy with other things over the last few weeks.

Yes, putting disable-ccid into ~/.gnupg/scdaemon.conf works for me with GnuPG 2.3.1 under macOS Catalina (10.15).

I still don't understand what the problem is/was, so I cannot judge whether it's better to recommend this manual configuration for Mac users or to disable CCID by default on macOS.

Jun 3 2021, 11:20 PM · MacOS, yubikey, Bug Report
Allen Winter <winter@kde.org> committed rLIBKLEO522010b01dcd: add Boost::headers to link libraries (authored by Allen Winter <winter@kde.org>).
add Boost::headers to link libraries
Jun 3 2021, 9:44 PM
Saturneric added a comment to T5470: T5454 Continue Gpgme still shows secret flag even when the secret key content is missing.

I tried again after cloning the master branch, and I finally figured it out. Sorry for the trouble caused by this irrelevant question just submitted. thanks again.

Jun 3 2021, 9:36 PM · Bug Report
werner added a comment to T5470: T5454 Continue Gpgme still shows secret flag even when the secret key content is missing.

Please read T5454 again. To get the listing I showed you need to use the latest gpgme from Git master.

Jun 3 2021, 9:24 PM · Bug Report
werner merged T5470: T5454 Continue Gpgme still shows secret flag even when the secret key content is missing into T5454: Failed to sign with subkey with a signature function using gpgme_op_keysign.
Jun 3 2021, 9:23 PM · FAQ, Support, gpgme
werner merged task T5470: T5454 Continue Gpgme still shows secret flag even when the secret key content is missing into T5454: Failed to sign with subkey with a signature function using gpgme_op_keysign.
Jun 3 2021, 9:23 PM · Bug Report
Allen Winter <winter@kde.org> committed rLIBKLEO18331f8ca050: add Boost::headers to link libraries (authored by Allen Winter <winter@kde.org>).
add Boost::headers to link libraries
Jun 3 2021, 8:42 PM
Saturneric created T5470: T5454 Continue Gpgme still shows secret flag even when the secret key content is missing.
Jun 3 2021, 8:19 PM · Bug Report
gniibe committed rC3462280f2e23: cipher: Fix ElGamal encryption for other implementations. (authored by gniibe).
cipher: Fix ElGamal encryption for other implementations.
Jun 3 2021, 7:09 PM
gniibe committed rC7ba5d831d573: build: _DARWIN_C_SOURCE should be 1. (authored by gniibe).
build: _DARWIN_C_SOURCE should be 1.
Jun 3 2021, 7:09 PM
gniibe committed rC71a07704ad98: build: Don't use /dev/srandom on OpenBSD. (authored by Jeremie Courreges-Anglas <jca@wxcvbn.org>).
build: Don't use /dev/srandom on OpenBSD.
Jun 3 2021, 7:09 PM
gniibe committed rC334e1a1cfc8f: tests: Add HAVE_MMAP check for MinGW. (authored by gniibe).
tests: Add HAVE_MMAP check for MinGW.
Jun 3 2021, 7:09 PM
werner committed rC59df8d629542: sexp: Avoid a fatal error in case of ENOMEM in called functions. (authored by werner).
sexp: Avoid a fatal error in case of ENOMEM in called functions.
Jun 3 2021, 7:09 PM
gniibe committed rCda127f7505ff: Fix secmem test for machine with larger page. (authored by gniibe).
Fix secmem test for machine with larger page.
Jun 3 2021, 7:09 PM
werner committed rCf4582f8c429f: api: Add auto expand secmem feature (authored by werner).
api: Add auto expand secmem feature
Jun 3 2021, 7:09 PM
werner committed rC32577d5b91f8: Post release updates (authored by werner).
Post release updates
Jun 3 2021, 7:09 PM
werner committed rCeb84e429950b: Release 1.8.2 (authored by werner).
Release 1.8.2
Jun 3 2021, 7:09 PM
werner committed rC0a391b259adc: Fix incorrect counter overflow handling for GCM (authored by jukivili).
Fix incorrect counter overflow handling for GCM
Jun 3 2021, 7:09 PM
werner committed rCc114ffd6da83: doc: fix double "See" in front of reference (authored by jukivili).
doc: fix double "See" in front of reference
Jun 3 2021, 7:09 PM
werner committed rC4e11e9d98818: Improve constant-time buffer compare (authored by jukivili).
Improve constant-time buffer compare
Jun 3 2021, 7:09 PM
werner committed rC0da4a237661c: random: Protect another use of jent_rng_collector. (authored by gniibe).
random: Protect another use of jent_rng_collector.
Jun 3 2021, 7:09 PM
werner committed rC1900853f2aee: doc: Clarify the value range of the use-rsa-e parameter. (authored by werner).
doc: Clarify the value range of the use-rsa-e parameter.
Jun 3 2021, 7:09 PM
werner committed rCe1695a8f6ca1: random: Don't assume that _WIN64 implies x86_64 (authored by Martin Storsjö <martin@martin.st>).
random: Don't assume that _WIN64 implies x86_64
Jun 3 2021, 7:09 PM
werner committed rC06fdc074eb29: hmac: Use xtrymalloc. (authored by gniibe).
hmac: Use xtrymalloc.
Jun 3 2021, 7:09 PM
werner committed rCa0e016e29409: mpi: Fix for buidling for MIPS64 with Clang (authored by werner).
mpi: Fix for buidling for MIPS64 with Clang
Jun 3 2021, 7:09 PM
werner committed rCbbf88f0e9d48: AES-KW: fix in-place encryption (authored by smueller_chronox.de).
AES-KW: fix in-place encryption
Jun 3 2021, 7:09 PM
werner committed rC22db6237de00: Make BMI2 inline assembly check more robust (authored by jukivili).
Make BMI2 inline assembly check more robust
Jun 3 2021, 7:09 PM
werner committed rC1a0289daa408: build: Convince gcc not to delete NULL ptr checks. (authored by werner).
build: Convince gcc not to delete NULL ptr checks.
Jun 3 2021, 7:09 PM
werner committed rCc5bed9df9633: prime: Avoid rare assertion failure in gcry_prime_check. (authored by werner).
prime: Avoid rare assertion failure in gcry_prime_check.
Jun 3 2021, 7:09 PM
werner committed rC846f8fe8b3be: ecc: Improve gcry_mpi_ec_curve_point (authored by werner).
ecc: Improve gcry_mpi_ec_curve_point
Jun 3 2021, 7:09 PM
werner committed rC5600d2d6b236: Release 1.8.3 (authored by werner).
Release 1.8.3
Jun 3 2021, 7:09 PM
gniibe committed rC20c034865f2d: random: Fix hang of _gcry_rndjent_get_version. (authored by dtzWill).
random: Fix hang of _gcry_rndjent_get_version.
Jun 3 2021, 7:09 PM
werner committed rC6ca6344429e5: Post release updates (authored by werner).
Post release updates
Jun 3 2021, 7:09 PM
werner committed rC54620a27f450: mpi: New internal function _gcry_mpi_cmpabs. (authored by werner).
mpi: New internal function _gcry_mpi_cmpabs.
Jun 3 2021, 7:09 PM
gniibe committed rC9be06c6b2e5c: ecc: Add blinding for ECDSA. (authored by gniibe).
ecc: Add blinding for ECDSA.
Jun 3 2021, 7:09 PM
werner committed rCbe68b3ee4fd1: ecc: Fix potential unintended freeing of an internal param. (authored by werner).
ecc: Fix potential unintended freeing of an internal param.
Jun 3 2021, 7:09 PM
werner committed rC8cc7cac82ec2: sexp: Fix uninitialized use of a var in the error case. (authored by werner).
sexp: Fix uninitialized use of a var in the error case.
Jun 3 2021, 7:09 PM
werner committed rC347987d4cf29: ecc: Fix possible memory leakage in parameter check of eddsa. (authored by werner).
ecc: Fix possible memory leakage in parameter check of eddsa.
Jun 3 2021, 7:08 PM
werner committed rC7f4de8bab991: doc: Fix example for gcry_sexp_extract_param (authored by werner).
doc: Fix example for gcry_sexp_extract_param
Jun 3 2021, 7:08 PM
werner committed rCabd267bf2393: Fix memory leak in secmem in out of core conditions. (authored by werner).
Fix memory leak in secmem in out of core conditions.
Jun 3 2021, 7:08 PM
werner committed rC4e044b80b296: doc: Update yat2m.c from upstream (libgpg-error) (authored by werner).
doc: Update yat2m.c from upstream (libgpg-error)
Jun 3 2021, 7:08 PM
werner committed rC60224352f4de: ecc: Fix memory leak in the error case of ecc_encrypt_raw (authored by werner).
ecc: Fix memory leak in the error case of ecc_encrypt_raw
Jun 3 2021, 7:08 PM
werner committed rC60885655756d: random: Make sure to re-open /dev/random after a fork (authored by werner).
random: Make sure to re-open /dev/random after a fork
Jun 3 2021, 7:08 PM
werner committed rC99a5babfd1e7: build: Add release make target (authored by werner).
build: Add release make target
Jun 3 2021, 7:08 PM
werner committed rC5b1d022293c5: primes: Avoid leaking bits of the prime test to pageable memory. (authored by werner).
primes: Avoid leaking bits of the prime test to pageable memory.
Jun 3 2021, 7:08 PM
gniibe committed rC813b002eaf30: libgrypt.pc: Provide pkg-config file. (authored by gniibe).
libgrypt.pc: Provide pkg-config file.
Jun 3 2021, 7:08 PM
werner committed rC0973c3f9ee7a: random: use getrandom() on Linux where available (authored by dkg).
random: use getrandom() on Linux where available
Jun 3 2021, 7:08 PM
werner committed rCb3f4e39b2a29: Post release updates (authored by werner).
Post release updates
Jun 3 2021, 7:08 PM
werner committed rC93775172713c: Release 1.8.4 (authored by werner).
Release 1.8.4
Jun 3 2021, 7:08 PM
werner committed rC6faeca72b455: doc: Fix library initialization examples (authored by ametzler).
doc: Fix library initialization examples
Jun 3 2021, 7:08 PM
gniibe committed rC0216418ab23a: libgcrypt.m4: Update from master. (authored by gniibe).
libgcrypt.m4: Update from master.
Jun 3 2021, 7:08 PM
werner committed rC35e002d4b842: random: Initialize variable as requested by valgrind (authored by werner).
random: Initialize variable as requested by valgrind
Jun 3 2021, 7:08 PM
gniibe committed rC4141caabe76a: libgcrypt.m4: Update from master. (authored by gniibe).
libgcrypt.m4: Update from master.
Jun 3 2021, 7:08 PM
gniibe committed rC0147a5e69e49: tests: t-mpi-point: Remove implementation dependent checks. (authored by gniibe).
tests: t-mpi-point: Remove implementation dependent checks.
Jun 3 2021, 7:08 PM
werner committed rCbc05e16bb494: doc: Minor typo fix (authored by werner).
doc: Minor typo fix
Jun 3 2021, 7:08 PM
gniibe committed rC5ad654a33085: dsa,ecdsa: Allocate secure memory for RFC6979 generation. (authored by gniibe).
dsa,ecdsa: Allocate secure memory for RFC6979 generation.
Jun 3 2021, 7:08 PM
gniibe committed rC1862f402d363: ecdsa: Fix unblinding too early. (authored by gniibe).
ecdsa: Fix unblinding too early.
Jun 3 2021, 7:08 PM
gniibe committed rCdb4e9976cc31: dsa,ecdsa: Fix use of nonce, use larger one. (authored by gniibe).
dsa,ecdsa: Fix use of nonce, use larger one.
Jun 3 2021, 7:08 PM
gniibe committed rCd5407b78cca9: ecc: Add mitigation against timing attack. (authored by gniibe).
ecc: Add mitigation against timing attack.
Jun 3 2021, 7:08 PM
werner committed rC56606331bc2a: Release 1.8.5 (authored by werner).
Release 1.8.5
Jun 3 2021, 7:08 PM
werner committed rC3de8991c8543: ecc: Add a keygrip testcase for cv25519. (authored by werner).
ecc: Add a keygrip testcase for cv25519.
Jun 3 2021, 7:08 PM
werner committed rC853027569ce3: Post release updates (authored by werner).
Post release updates
Jun 3 2021, 7:08 PM
werner committed rCca121256b146: Prepare NEWS for upcoming release (authored by werner).
Prepare NEWS for upcoming release
Jun 3 2021, 7:08 PM
gniibe committed rC006e51cd83a1: ecc: Fix wrong handling of shorten PK bytes. (authored by gniibe).
ecc: Fix wrong handling of shorten PK bytes.
Jun 3 2021, 7:08 PM
gniibe committed rCa29e058ff114: Fix declaration of internal function _gcry_mpi_get_ui. (authored by gniibe).
Fix declaration of internal function _gcry_mpi_get_ui.
Jun 3 2021, 7:08 PM
jukivili committed rCec7db47e9998: Set vZZ.16b register to zero before use in armv8 gcm implementation (authored by larma).
Set vZZ.16b register to zero before use in armv8 gcm implementation
Jun 3 2021, 7:08 PM
gniibe committed rC03e6d6597198: random: Fix include of config.h. (authored by gniibe).
random: Fix include of config.h.
Jun 3 2021, 7:08 PM
jukivili committed rC761a1a0d30ea: Fix wrong code execution in Poly1305 ARM/NEON implementation (authored by jukivili).
Fix wrong code execution in Poly1305 ARM/NEON implementation
Jun 3 2021, 7:08 PM
werner committed rCffbc5702ab16: mpi: Abort on division by zero also in _gcry_mpi_tdiv_qr. (authored by werner).
mpi: Abort on division by zero also in _gcry_mpi_tdiv_qr.
Jun 3 2021, 7:08 PM
gniibe committed rC3a16c19d4d63: DSA,ECDSA: Fix use of mpi_invm. (authored by gniibe).
DSA,ECDSA: Fix use of mpi_invm.
Jun 3 2021, 7:08 PM
werner committed rCda8623bd6dbf: doc: Fix description of hash algorithms (authored by Sébastien Helleu <flashcode@flashtux.org>).
doc: Fix description of hash algorithms
Jun 3 2021, 7:08 PM
gniibe committed rC90b7339b0654: mpi: Constant time mpi_inv with some conditions. (authored by gniibe).
mpi: Constant time mpi_inv with some conditions.
Jun 3 2021, 7:08 PM