Page MenuHome GnuPG

patchTag
ActivePublic

Members

  • This project does not have any members.
  • View All

Watchers

  • This project does not have any watchers.
  • View All

Recent Activity

Tue, Jun 14

gniibe added a project to T6019: Parsing AEAD preference string parsing causes reads uninitialized memory: Testing.

Thank you. Applied.

Tue, Jun 14, 8:39 AM · Testing, patch, gnupg (gpg23), Bug Report

Mon, Jun 13

gniibe claimed T6019: Parsing AEAD preference string parsing causes reads uninitialized memory.
Mon, Jun 13, 10:24 AM · Testing, patch, gnupg (gpg23), Bug Report

Sun, Jun 12

jukivili closed T6006: Optimize Chacha20 and Poly1305 for PPC P10 LE as Resolved.
Sun, Jun 12, 9:58 PM · patch, ppc, Feature Request, libgcrypt
jukivili added a comment to T6006: Optimize Chacha20 and Poly1305 for PPC P10 LE.

Patch applied to master with small changes.

Sun, Jun 12, 9:58 PM · patch, ppc, Feature Request, libgcrypt

Wed, Jun 8

gniibe added a project to T6018: libassuan: Coverity reports: Testing.

Applied the changes.

Wed, Jun 8, 2:20 PM · Testing, patch, libassuan, Bug Report

Tue, Jun 7

gniibe claimed T6018: libassuan: Coverity reports.
Tue, Jun 7, 1:56 PM · Testing, patch, libassuan, Bug Report
Jakuje created T6019: Parsing AEAD preference string parsing causes reads uninitialized memory.
Tue, Jun 7, 11:58 AM · Testing, patch, gnupg (gpg23), Bug Report
Jakuje created T6018: libassuan: Coverity reports.
Tue, Jun 7, 11:25 AM · Testing, patch, libassuan, Bug Report

Fri, Jun 3

dannytsen added a comment to T6006: Optimize Chacha20 and Poly1305 for PPC P10 LE.

Thanks @jukivili , Here is the changelog,

Fri, Jun 3, 3:59 PM · patch, ppc, Feature Request, libgcrypt
jukivili added a comment to T6006: Optimize Chacha20 and Poly1305 for PPC P10 LE.

Thanks for updated patch. I'm travelling next week and have time to check it closely only after I'm back. On quick glance, it looks good. What is also needed is the changelog for git commit log.

Fri, Jun 3, 10:30 AM · patch, ppc, Feature Request, libgcrypt

Thu, Jun 2

dannytsen added a comment to T6006: Optimize Chacha20 and Poly1305 for PPC P10 LE.

Thanks @jukivili. I have never thought of interleaving with interger poly1305 operation and that's a good suggestion. Will think about that one.

Thu, Jun 2, 12:59 AM · patch, ppc, Feature Request, libgcrypt

Wed, Jun 1

jukivili added a comment to T6006: Optimize Chacha20 and Poly1305 for PPC P10 LE.

I meant interleaving integer register based 1xPoly1305 with 8xChacha20 as is done for 4xChacha20 in cipher/chacha20-ppc.c (interleaved so that for each 4xChaCha20 processed, 4 blocks of 1xPoly1305 is executed). Quite often microarchitectures have separate execution units for integer registers and vector registers and then it makes sense to interleave integer-poly1305 with vector-chacha20 as algorithms do end up not compete for same execution resources. Interleaving vector-poly1305 and vector-chacha20 is not likely to give performance increase (and likely to run problems with running out of vector registers).

Wed, Jun 1, 5:37 PM · patch, ppc, Feature Request, libgcrypt
dannytsen added a comment to T6006: Optimize Chacha20 and Poly1305 for PPC P10 LE.

HI @jukivili , Thanks for the updates. For f14-f31 registers that was my mistake that did not think floating point will be used. Will correct that. For poly1305, it can be used on ARCH_3.0 so checking use_p10 doesn't seem to be necessary but I can include that as well.

Wed, Jun 1, 4:14 PM · patch, ppc, Feature Request, libgcrypt
gniibe claimed T5973: libgcrypt: Minor test issues reported by coverity.
Wed, Jun 1, 5:09 AM · Testing, patch, libgcrypt, Bug Report

Tue, May 31

gniibe moved T5975: Allow signature verification using specific RSA keys <2k in FIPS mode from Next to Done on the FIPS board.
Tue, May 31, 11:16 AM · Testing, patch, libgcrypt, FIPS, Feature Request
gniibe added a comment to T5973: libgcrypt: Minor test issues reported by coverity.

Also applied to 1.10.

Tue, May 31, 8:27 AM · Testing, patch, libgcrypt, Bug Report
gniibe added a project to T5973: libgcrypt: Minor test issues reported by coverity: Testing.
Tue, May 31, 8:25 AM · Testing, patch, libgcrypt, Bug Report
gniibe added a comment to T5973: libgcrypt: Minor test issues reported by coverity.

Applied and pushed.

Tue, May 31, 8:24 AM · Testing, patch, libgcrypt, Bug Report

May 28 2022

jukivili added a comment to T6006: Optimize Chacha20 and Poly1305 for PPC P10 LE.

Problem is that new assembly is using VSX registers vs14-vs31 which overlap with floating-point registers f14-f31. f14-f31 are ABI callee saved, so those need to be stored and restored.

May 28 2022, 9:04 PM · patch, ppc, Feature Request, libgcrypt
jukivili added a comment to T6006: Optimize Chacha20 and Poly1305 for PPC P10 LE.

Tested patch with small change so that HWF_PPC_ARCH_3_00 is used instead of HWF_PPC_ARCH_3_10. Building bench-slope with "-O3 -flto" makes bug in new implementation visible. Without new implementations bench-slope is ok (testing with QEMU):

$ tests/bench-slope --disable-hwf ppc-arch_3_00 cipher chacha20
Cipher:
 CHACHA20       |  nanosecs/byte   mebibytes/sec   cycles/byte
     STREAM enc |      2.35 ns/B     405.0 MiB/s         - c/B
     STREAM dec |      2.32 ns/B     410.7 MiB/s         - c/B
   POLY1305 enc |      2.46 ns/B     388.0 MiB/s         - c/B
   POLY1305 dec |      2.34 ns/B     408.1 MiB/s         - c/B
  POLY1305 auth |     0.238 ns/B      4003 MiB/s         - c/B
May 28 2022, 6:49 PM · patch, ppc, Feature Request, libgcrypt

May 27 2022

jukivili added a comment to T6006: Optimize Chacha20 and Poly1305 for PPC P10 LE.

-O2 problem with bench-slope seems strange. Does problem appear after this patch is applied?

May 27 2022, 7:15 PM · patch, ppc, Feature Request, libgcrypt

May 26 2022

werner triaged T6006: Optimize Chacha20 and Poly1305 for PPC P10 LE as Normal priority.
May 26 2022, 11:44 AM · patch, ppc, Feature Request, libgcrypt

May 25 2022

gniibe added a project to T5702: Display prompt to user when YubiKey is waiting for touch confirmation: Testing.

This feature is implemented in different way, by T5099.

May 25 2022, 1:11 PM · Testing, patch, Feature Request
gniibe added a subtask for T5702: Display prompt to user when YubiKey is waiting for touch confirmation: T5099: Confirmation dialog for remote access (restricted extra socket).
May 25 2022, 1:03 PM · Testing, patch, Feature Request
gniibe added a project to T5702: Display prompt to user when YubiKey is waiting for touch confirmation: patch.
May 25 2022, 4:13 AM · Testing, patch, Feature Request

May 23 2022

DemiMarie added a comment to T5975: Allow signature verification using specific RSA keys <2k in FIPS mode.

I can imagine thar there are use cases for this. Thus I see no problems for the first part.

The second part is imho not a good idea. Libgcrypt is a building block for all kind of software and there are for sure legitimate reasons to use rsa512 (MCUs, short living keys, etc). Thus I think that the decision on the key size should be done by the software using libgcrypt.

May 23 2022, 5:56 PM · Testing, patch, libgcrypt, FIPS, Feature Request

May 19 2022

gniibe claimed T5975: Allow signature verification using specific RSA keys <2k in FIPS mode.

Pushed the change (master and 1.10).

May 19 2022, 3:50 AM · Testing, patch, libgcrypt, FIPS, Feature Request

May 17 2022

werner moved T5975: Allow signature verification using specific RSA keys <2k in FIPS mode from Backlog to Next on the FIPS board.
May 17 2022, 11:12 AM · Testing, patch, libgcrypt, FIPS, Feature Request
gniibe added a project to T5979: SCardListReaders: Conditional jump or move depends on uninitialised value(s): Testing.

To detect these kinds of bugs, possibly, we can use new GCC option: -ftrivial-auto-var-init=0xFEFEFEFE.
https://gcc.gnu.org/gcc-12/changes.html#uninitialized

May 17 2022, 3:34 AM · Testing, backport, gnupg, scd, patch
gniibe claimed T5979: SCardListReaders: Conditional jump or move depends on uninitialised value(s).

The bug was there when it was initially written. It was in 2003, which introduced PC/SC in rG1bcf8ef9dea1: Cleanups, fixes and PC/SC support

May 17 2022, 3:29 AM · Testing, backport, gnupg, scd, patch

May 14 2022

ludovic added a comment to T5979: SCardListReaders: Conditional jump or move depends on uninitialised value(s).

I just wrote a blog article about this problem
https://ludovicrousseau.blogspot.com/2022/05/scardlistreaders-and-non-initialized.html

May 14 2022, 4:13 PM · Testing, backport, gnupg, scd, patch

May 13 2022

werner triaged T5979: SCardListReaders: Conditional jump or move depends on uninitialised value(s) as High priority.

Thanks for opening a ticket.

May 13 2022, 2:36 PM · Testing, backport, gnupg, scd, patch
Jakuje added a comment to T5975: Allow signature verification using specific RSA keys <2k in FIPS mode.

Ok. Thank you for the clarification. I will drop the second part and keep only the FIPS change in the patch. Merge request already updated.

May 13 2022, 11:17 AM · Testing, patch, libgcrypt, FIPS, Feature Request
ludovic created T5979: SCardListReaders: Conditional jump or move depends on uninitialised value(s).
May 13 2022, 11:16 AM · Testing, backport, gnupg, scd, patch
werner triaged T5973: libgcrypt: Minor test issues reported by coverity as Normal priority.

Thanks. Should be applied.

May 13 2022, 8:16 AM · Testing, patch, libgcrypt, Bug Report
werner triaged T5975: Allow signature verification using specific RSA keys <2k in FIPS mode as Normal priority.

I can imagine thar there are use cases for this. Thus I see no problems for the first part.

May 13 2022, 8:00 AM · Testing, patch, libgcrypt, FIPS, Feature Request

May 10 2022

gniibe added a comment to T5899: Fix compilation of dirmngr with mingw.org's MinGW.

Pushed the changes for http.c.

May 10 2022, 7:58 AM · patch, Feature Request, Windows, toolchain

Mar 30 2022

gniibe claimed T5899: Fix compilation of dirmngr with mingw.org's MinGW.

Last part is applied. Let me consider how to solve, for other parts.

Mar 30 2022, 6:07 AM · patch, Feature Request, Windows, toolchain

Mar 22 2022

eliz added a comment to T5897: Fix MinGW compilation error with 'struct _stat32' in common/sysutils.c from gnupg-2.3.4.

I guess I don't understand what you mean by "native building". This build was with MinGW, which is as "native" as MinGW64 is.
The reason for the problem is (AFAIU) that MinGW64 went after Microsoft's change in stat due to the 32-bit vs 64-bit time and off_t values issue.s That change breaks backward compatibility in more than one way: programs compiled on some versions of Windows will not run on other versions. mingw.org's MinGW kept the original semantics and symbols, which is why _stat32 exists in the mingw.org's headers, but is not exposed by default.

Mar 22 2022, 1:52 PM · gnupg (gpg23), toolchain, Feature Request, patch
werner triaged T5897: Fix MinGW compilation error with 'struct _stat32' in common/sysutils.c from gnupg-2.3.4 as Normal priority.

Turned into a feature request because native building on Windows is not supported.

Mar 22 2022, 11:49 AM · gnupg (gpg23), toolchain, Feature Request, patch
werner triaged T5899: Fix compilation of dirmngr with mingw.org's MinGW as Normal priority.
Mar 22 2022, 11:43 AM · patch, Feature Request, Windows, toolchain

Mar 14 2022

werner triaged T5596: Libgcrypt documentation: corrections to obvious misprints as Normal priority.

Thanks for you patches. Most of them applied cleanly despite that I delayed processing them for half a year.

Mar 14 2022, 8:59 AM · libgcrypt, patch, Documentation, Bug Report

Mar 2 2022

jukivili closed T5700: libgcrypt: bulk AES-GCM acceleration for ppc64le as Resolved.
Mar 2 2022, 8:24 PM · patch, ppc, libgcrypt, Feature Request

Feb 14 2022

werner triaged T5825: [gpgme] [python] possible dangling reference to passphrase as High priority.
Feb 14 2022, 12:51 PM · patch, gpgme, Bug Report

Feb 10 2022

jap added projects to T5825: [gpgme] [python] possible dangling reference to passphrase: gpgme, patch.
Feb 10 2022, 2:43 PM · patch, gpgme, Bug Report

Dec 21 2021

jukivili added a comment to T5700: libgcrypt: bulk AES-GCM acceleration for ppc64le.

Ok, I'll add.

Dec 21 2021, 4:03 PM · patch, ppc, libgcrypt, Feature Request
werner added a comment to T5700: libgcrypt: bulk AES-GCM acceleration for ppc64le.

Seen. @jukivili can you please add it to the AUTHORS file?

Dec 21 2021, 10:13 AM · patch, ppc, libgcrypt, Feature Request

Dec 14 2021

dannytsen added a comment to T5700: libgcrypt: bulk AES-GCM acceleration for ppc64le.

Ok, I have subscribed to the mailing list. I have resent the DCO.

Dec 14 2021, 9:09 PM · patch, ppc, libgcrypt, Feature Request
jukivili added a comment to T5700: libgcrypt: bulk AES-GCM acceleration for ppc64le.

DCO has not appeared on mailing-list. You can this from check list archives, https://lists.gnupg.org/pipermail/gcrypt-devel/2021-December/thread.html

Dec 14 2021, 8:58 PM · patch, ppc, libgcrypt, Feature Request
dannytsen added a comment to T5700: libgcrypt: bulk AES-GCM acceleration for ppc64le.

Thanks Jussi, I did not receive the list moderator's email so I am not sure if the it has been posted on gcrypt-devel@gnupg.org. If not, I can resend the DCO. Thanks.

Dec 14 2021, 7:58 PM · patch, ppc, libgcrypt, Feature Request