Page MenuHome GnuPG
Create Task
Maniphest T5916

Kleopatra: Change Add E-Mail to add name and E-Mail and remove advanced mode
Closed, ResolvedPublic
Actions

Description

I think the topic says it all, the reason is that we now use both more file encryption and that it will be more consistent with the file encryption dialog.

Comment should be removed because you can add a comment as part of the name.

Revisions and Commits

rLIBKLEO Libkleo
rLIBKLEOdfe52921c849 Make the comment argument optional
rKLEOPATRA Kleopatra
rKLEOPATRAc13f51907cff Return user ID instead of text of result label
rKLEOPATRA2dff4b9ee25b Use an instruction for the "all inputs are empty" error
rKLEOPATRA7b28b77540fb Change text of error summary and always use error message box
rKLEOPATRAb5e66009907e Prefix the error messages with "Error: "
rKLEOPATRA3d26858fed34 Allow only plain text for label, hint, and error messages
rKLEOPATRAd2df55340080 Use the currently shown error messages for the error summary
rKLEOPATRAfac8b1863000 Ensure that assistive tools use the accessible hint text if available
rKLEOPATRA95ee796e27d8 Mark hint label and error label as related labels
rKLEOPATRA82aa98db34b4 Set label text and optional accessible name with one setter
rKLEOPATRAc2ae61e82c63 Add an optional hint to the input fields
rKLEOPATRAb1ebbec8dd8d Allow alternative error messages for assistive tools
rKLEOPATRA176628375d39 GIT_SILENT Remove superfluous nullptr checks
rKLEOPATRA45344d5df7b7 Make the labels stand out more
rKLEOPATRA68732c3f8459 Put the labels above the input fields
rKLEOPATRA689e2e16c33c Visually indicate required input fields
rKLEOPATRA1c1d7b86165f Select the text of an HTML label when it gets keyboard focus
rKLEOPATRA45e703a5d665 Add helper to give labels keyboard focus if an assistive tool is active
rKLEOPATRAdf9b9fe6c2b3 Make the result label accessible
rKLEOPATRAb2d2d2783417 Omit the colon in the accessible name of the input fields
rKLEOPATRAea6da6586070 Mark name and/or email as required if requested
rKLEOPATRAae0c8ddfeda9 Allow marking a form input as required
rKLEOPATRA0f7c231429a8 Improve tooltips and error messages
rKLEOPATRA3867617878b5 Override default accessible description of name input
rKLEOPATRA7d9c716e7fbf Allow setting an accessible description for a form input
rKLEOPATRA9de08db46382 Change text of button to add a new user ID
rKLEOPATRA762f28274f39 Unify spelling of "user ID"
rKLEOPATRA5c51fa73d33a Modernize and clean up code
rKLEOPATRA301f02e601a0 Impose less strict restrictions on the name component of a new user id
rKLEOPATRAacfab27b0746 Use modern quick-adduid instead of "adduid" edit-key command
rKLEOPATRA69a36d040fcd Do not let the validators be fooled by leading or trailing whitespace
rKLEOPATRAdf5f8bb4b082 Add class wrapping a text input used in a form-like dialog
rKLEOPATRAaedb5797b39e Add input validation to the Add User ID dialog
rKLEOPATRA4e7c53815587 Share duplicated accessibility-related local helpers
rKLEOPATRA93e93df6f081 GnuPG wants at least 5 characters for the name
rKLEOPATRAaddbfad36724 Optionally make the validators accept empty values
rKLEOPATRA29a4359fe359 Simplify the Add User ID dialog
rKLEOPATRA1a2b258b2051 Port validators to QRegularExpression
rKLEOPATRA6bd834193027 Simplify the Add User ID dialog
rKLEOPATRA26fe7b5bf16d Remove the simple Add Email dialog

Event Timeline

• aheinecke triaged this task as Normal priority.Apr 4 2022, 10:33 AM
• aheinecke created this task.
• ikloecker moved this task from Restricted Project Column to Restricted Project Column on the Restricted Project board.Apr 5 2022, 10:51 AM
• ikloecker added a commit: rKLEOPATRA26fe7b5bf16d: Remove the simple Add Email dialog.Apr 5 2022, 7:01 PM
• ikloecker added a commit: rKLEOPATRA6bd834193027: Simplify the Add User ID dialog.
• ikloecker added a commit: rKLEOPATRAaddbfad36724: Optionally make the validators accept empty values.Apr 8 2022, 12:47 PM
• ikloecker added a commit: rKLEOPATRA29a4359fe359: Simplify the Add User ID dialog.
• ikloecker added a commit: rKLEOPATRA1a2b258b2051: Port validators to QRegularExpression.
• ikloecker added a commit: rKLEOPATRA93e93df6f081: GnuPG wants at least 5 characters for the name.
• ikloecker added a commit: rKLEOPATRA4e7c53815587: Share duplicated accessibility-related local helpers.
• ikloecker added a commit: rKLEOPATRAdf5f8bb4b082: Add class wrapping a text input used in a form-like dialog.
• ikloecker added a commit: rKLEOPATRAaedb5797b39e: Add input validation to the Add User ID dialog.
• ikloecker added a commit: rKLEOPATRA69a36d040fcd: Do not let the validators be fooled by leading or trailing whitespace.
• ikloecker added a commit: rLIBKLEOdfe52921c849: Make the comment argument optional.Apr 8 2022, 12:53 PM
• ikloecker added a commit: rKLEOPATRA301f02e601a0: Impose less strict restrictions on the name component of a new user id.Apr 8 2022, 5:16 PM
• ikloecker added a commit: rKLEOPATRAacfab27b0746: Use modern quick-adduid instead of "adduid" edit-key command.
• ikloecker added a commit: rKLEOPATRA5c51fa73d33a: Modernize and clean up code.
• ikloecker added a commit: rKLEOPATRA762f28274f39: Unify spelling of "user ID".
• ikloecker added a commit: rKLEOPATRA9de08db46382: Change text of button to add a new user ID.
• ikloecker added a commit: rKLEOPATRA0f7c231429a8: Improve tooltips and error messages.Apr 11 2022, 11:34 AM
• ikloecker added a commit: rKLEOPATRA7d9c716e7fbf: Allow setting an accessible description for a form input.
• ikloecker added a commit: rKLEOPATRA3867617878b5: Override default accessible description of name input.
• ikloecker added a commit: rKLEOPATRAae0c8ddfeda9: Allow marking a form input as required.Apr 14 2022, 12:26 PM
• ikloecker added a commit: rKLEOPATRAea6da6586070: Mark name and/or email as required if requested.
• ikloecker added a commit: rKLEOPATRAb2d2d2783417: Omit the colon in the accessible name of the input fields.
• ikloecker added a commit: rKLEOPATRA45e703a5d665: Add helper to give labels keyboard focus if an assistive tool is active.
• ikloecker added a commit: rKLEOPATRA1c1d7b86165f: Select the text of an HTML label when it gets keyboard focus.
• ikloecker added a commit: rKLEOPATRAdf9b9fe6c2b3: Make the result label accessible.
• ikloecker added a commit: rKLEOPATRA689e2e16c33c: Visually indicate required input fields.
• ikloecker added a commit: rKLEOPATRA68732c3f8459: Put the labels above the input fields.
• ikloecker added a commit: rKLEOPATRA45344d5df7b7: Make the labels stand out more.
• ikloecker added a commit: rKLEOPATRA176628375d39: GIT_SILENT Remove superfluous nullptr checks.
• ikloecker added a commit: rKLEOPATRAc2ae61e82c63: Add an optional hint to the input fields.
• ikloecker added a commit: rKLEOPATRA82aa98db34b4: Set label text and optional accessible name with one setter.
• ikloecker added a commit: rKLEOPATRAb1ebbec8dd8d: Allow alternative error messages for assistive tools.
• ikloecker added a commit: rKLEOPATRAfac8b1863000: Ensure that assistive tools use the accessible hint text if available.
• ikloecker added a commit: rKLEOPATRA95ee796e27d8: Mark hint label and error label as related labels.
• ikloecker added a commit: rKLEOPATRA3d26858fed34: Allow only plain text for label, hint, and error messages.Apr 14 2022, 3:41 PM
• ikloecker added a commit: rKLEOPATRAb5e66009907e: Prefix the error messages with "Error: ".
• ikloecker added a commit: rKLEOPATRAd2df55340080: Use the currently shown error messages for the error summary.
• ikloecker added a commit: rKLEOPATRA2dff4b9ee25b: Use an instruction for the "all inputs are empty" error.
• ikloecker added a commit: rKLEOPATRA7b28b77540fb: Change text of error summary and always use error message box.
• ikloecker changed the task status from Open to Testing.Apr 14 2022, 3:43 PM
• ikloecker removed • ikloecker as the assignee of this task.
• ikloecker moved this task from Restricted Project Column to Restricted Project Column on the Restricted Project board.
• ikloecker added a project: Restricted Project.
• ikloecker added a subscriber: • ikloecker.

Done. I have also tried to make this dialog as accessible as possible as prototype for other form-like dialogs. The error reporting could still be improved by specifying what exactly is wrong instead of simply saying what could be wrong, but QValidator is too limited for this.

• ikloecker added a commit: rKLEOPATRAc13f51907cff: Return user ID instead of text of result label.Apr 19 2022, 5:22 PM
• werner removed a project: Restricted Project.Sep 22 2022, 11:04 AM
• ebo closed this task as Resolved.Nov 30 2022, 2:30 PM
• ebo claimed this task.
• ebo added a subscriber: • ebo.

very nice

• ebo moved this task from Restricted Project Column to Restricted Project Column on the Restricted Project board.Apr 5 2023, 2:54 PM