Page MenuHome GnuPG
Create Task
Maniphest T6046

Kleopatra: Make certifying certificates accessible
Closed, ResolvedPublic
Actions

Description

Certifying OpenPGP certificates should be possible:

  • with keyboard only
  • for people using a screenreader
  • with 400 % magnification
  • with high contrast color scheme
  • with inverted color scheme

Revisions and Commits

rLIBKLEO Libkleo
rLIBKLEO0386040ed572 Prevent screen readers from reading the tool tip
rKLEOPATRA Kleopatra
rKLEOPATRA3c5248f9d1f6 Store and restore the size of the dialog, not its geometry
rKLEOPATRAcd308b239523 Add a label explaining what the user is expected to do
rKLEOPATRAc7c45ac3a835 Make InfoField available for other parts of Kleopatra
rKLEOPATRA7bfd78296eb4 Add helper for storing/retrieving the accessible name of a QAction
rKLEOPATRA61ba5b0bd91b Use an InfoField for the fingerprint
rKLEOPATRA8a58b87b22f8 Remove <html> tag from the tool tip
rKLEOPATRA22cc7a6f7ff0 Set accessible name for User ID list
rKLEOPATRAa754714a2654 Send state-change event if user ID is checked or unchecked
rKLEOPATRA39564c0f8b01 Announce current item when user ID list gets focus
rKLEOPATRA0618448166fe Close tool tip instead of dialog if Escape is pressed
rKLEOPATRA884142975598 Set a more accessible name for the collapsible Advanced group box
rKLEOPATRA0738ffa1c456 Avoid keyboard focus for UI elements in the collapsed content area
rKLEOPATRA9af5f1eaa2d5 Associate labels with corresponding form inputs
rKLEOPATRA5056be308d9e Make label showing fingerprint of key to certify accessible
rKLEOPATRAdd1784474094 Make the info buttons accessible
rKLEOPATRA433ac7316c7a Create all widgets in the correct tab order
rKLEOPATRA60cb6b231c1d Do not pass the main widget as parent to sub-layouts
rKLEOPATRAf80977214324 Use a simple QWidget instead of a QScrollArea for the animated expander
rW Gpg4win
rW3003d37f3a7d Add upstreamed patch that fixes tab order in KMessageWidget

Related Objects
Search...

Event Timeline

• ikloecker triaged this task as Normal priority.Jun 28 2022, 9:14 AM
• ikloecker created this task.
• ikloecker added a commit: rKLEOPATRA433ac7316c7a: Create all widgets in the correct tab order.Jun 29 2022, 11:33 AM
• ikloecker added a commit: rKLEOPATRAf80977214324: Use a simple QWidget instead of a QScrollArea for the animated expander.
• ikloecker added a commit: rKLEOPATRA60cb6b231c1d: Do not pass the main widget as parent to sub-layouts.
• ikloecker added a commit: rKLEOPATRAdd1784474094: Make the info buttons accessible.
• ikloecker added a comment.Jul 26 2022, 2:46 PM

Issues:

  • Fingerprint is inaccessible (finding [3] in the Prüfbericht Barrierefreiheit GnuPG Kleopatra 3.1.20.3)
  • "Certify with" label not associated with combo box
  • Collapsible "Advanced" section is not accessible (announced as "check box")
  • UI elements in "Advanced" section can receive focus, even if section is collapsed (finding [12] in the Prüfbericht Barrierefreiheit GnuPG Kleopatra 3.1.20.3)
  • "Tags" label not associated with input field
  • Pressing Esc cancels dialog even if explanation tooltip is shown
  • "Domain" input field has no label (finding [4] in the Prüfbericht Barrierefreiheit GnuPG Kleopatra 3.1.20.3)
  • No accessible feedback when checking/unchecking user ID
• ikloecker mentioned this in T6100: Kleopatra: Make revocation of certifications accessible.Jul 26 2022, 2:53 PM
• ikloecker moved this task from Restricted Project Column to Restricted Project Column on the Restricted Project board.Aug 11 2022, 4:04 PM
• ikloecker added a commit: rLIBKLEO0386040ed572: Prevent screen readers from reading the tool tip.Aug 12 2022, 3:59 PM
• ikloecker added a commit: rKLEOPATRA5056be308d9e: Make label showing fingerprint of key to certify accessible.Aug 12 2022, 4:31 PM
• ikloecker added a commit: rKLEOPATRA9af5f1eaa2d5: Associate labels with corresponding form inputs.
• ikloecker added a commit: rKLEOPATRA0738ffa1c456: Avoid keyboard focus for UI elements in the collapsed content area.
• ikloecker added a commit: rKLEOPATRA884142975598: Set a more accessible name for the collapsible Advanced group box.
• ikloecker added a commit: rKLEOPATRA0618448166fe: Close tool tip instead of dialog if Escape is pressed.
• ikloecker added a commit: rKLEOPATRA39564c0f8b01: Announce current item when user ID list gets focus.
• ikloecker added a commit: rKLEOPATRA22cc7a6f7ff0: Set accessible name for User ID list.
• ikloecker added a commit: rKLEOPATRAa754714a2654: Send state-change event if user ID is checked or unchecked.
• ikloecker added a commit: rKLEOPATRA7bfd78296eb4: Add helper for storing/retrieving the accessible name of a QAction.Aug 15 2022, 6:48 PM
• ikloecker added a commit: rKLEOPATRA8a58b87b22f8: Remove <html> tag from the tool tip.
• ikloecker added a commit: rKLEOPATRA61ba5b0bd91b: Use an InfoField for the fingerprint.
• ikloecker added a commit: rKLEOPATRAc7c45ac3a835: Make InfoField available for other parts of Kleopatra.
• ikloecker added a commit: rKLEOPATRAcd308b239523: Add a label explaining what the user is expected to do.
• ikloecker added a commit: rKLEOPATRA3c5248f9d1f6: Store and restore the size of the dialog, not its geometry.
• ikloecker changed the task status from Open to Testing.Aug 16 2022, 9:27 AM
• ikloecker removed • ikloecker as the assignee of this task.
• ikloecker moved this task from Restricted Project Column to Restricted Project Column on the Restricted Project board.
• ikloecker added a project: Restricted Project.

All issues have been addressed except:

  • No accessible feedback when checking/unchecking user ID

This is caused by a bug in Qt which doesn't report the checkable state to AT-SPI.

Another issue is that orca doesn't read the text of the certification key combo box. orca only reads the label of the combo box. Qt has a weird implementation for passing a value-changed event of a combo box to AT-SPI because "Combo Box with AT-SPI likes to be special. It requires a name-change to update caches and then selection-changed". Needs to be checked on Windows.

• ikloecker added a commit: rW3003d37f3a7d: Add upstreamed patch that fixes tab order in KMessageWidget.Aug 16 2022, 4:55 PM
• werner removed a project: Restricted Project.Sep 22 2022, 11:03 AM
• ikloecker merged a task: T5844: Kleopatra: Make certify accessible (certificate import).Dec 5 2022, 9:57 AM
• aheinecke added a project: vsd32.Nov 15 2023, 9:44 AM

This would of course all be also in vsd32

• ebo removed a project: vsd32.Nov 15 2023, 10:40 AM
• ebo added a subscriber: • ebo.

This is already in 3.1.26. I only wasn't sure if I should make another ticket for remaining issues before closing that is the only reason why it is still open

• ebo closed this task as Resolved.Nov 16 2023, 4:28 PM
• ebo claimed this task.
• ebo mentioned this in T6825: Kleopatra: make (un)checking of user IDs in the certification window accessible.
• ebo moved this task from Restricted Project Column to Restricted Project Column on the Restricted Project board.

Another issue is that orca doesn't read the text of the certification key combo box. orca only reads the label of the combo box. Qt has a weird implementation for passing a value-changed event of a combo box to AT-SPI because "Combo Box with AT-SPI likes to be special. It requires a name-change to update caches and then selection-changed". Needs to be checked on Windows.

On Windows with NVDA the combo box is read.

For the rest see T6825